PRs for the Vim 9.1 release milestone
Hi all, Most of the outstanding PRs are now either assigned to the vim-9.1 milestone or to the backlog: https://github.com/vim/vim/milestone/1 https://github.com/vim/vim/milestone/2 If you think a PR should be or should not be part of these milestones, let us know. The criteria for the vim-9.1 milestone PRs are: 1. Fix for a Vim crash. 2. Security vulnerability fix. 3. Coverity analysis fix. 4. Fix for a bug in an existing feature. 5. Runtime file update. 6. Minor new feature. Thanks, Yegappan -- -- You received this message from the "vim_dev" maillist. Do not top-post! Type your reply below the text you are replying to. For more information, visit http://www.vim.org/maillist.php --- You received this message because you are subscribed to the Google Groups "vim_dev" group. To unsubscribe from this group and stop receiving emails from it, send an email to vim_dev+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/vim_dev/CAAW7x7%3DU3AEfLTsEdGA4y1fZz%3DDJekbLQPA6Yg%3DNxppXPOvb-w%40mail.gmail.com.
CI Linux tests are failing
Hi, The CI Linux tests are failing for the past few days due to missing linux-modules-extra-5.15.0-1042-azure package. Should we disable the sound tests temporarily and disable the installation of this package? Regards, Yegappan -- -- You received this message from the "vim_dev" maillist. Do not top-post! Type your reply below the text you are replying to. For more information, visit http://www.vim.org/maillist.php --- You received this message because you are subscribed to the Google Groups "vim_dev" group. To unsubscribe from this group and stop receiving emails from it, send an email to vim_dev+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/vim_dev/CAAW7x7nf37eRxgbDf19G2B6MJWAVOCwq6KPO4d6JqAgoiu4MEQ%40mail.gmail.com.
Re: Surprising test failure after rebasing PR
Hi, On Mon, Aug 14, 2023 at 6:39 PM Ernie Rael wrote: > > Bunch of failures, all of them > > Set up snd-dummy > E: Package 'linux-modules-extra-5.15.0-1042-azure' has no installation > candidate > > I see this after rebasing and pushing two PR's. > > Is there something I need to do? > No. We started seeing these failures for the past few days. Regards, Yegappan -- -- You received this message from the "vim_dev" maillist. Do not top-post! Type your reply below the text you are replying to. For more information, visit http://www.vim.org/maillist.php --- You received this message because you are subscribed to the Google Groups "vim_dev" group. To unsubscribe from this group and stop receiving emails from it, send an email to vim_dev+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/vim_dev/CAAW7x7kyUZUvQW42jDDV%3DT0Q%3D6Vz9kHLGr4-T5K_TvtDgp263A%40mail.gmail.com.
Surprising test failure after rebasing PR
Bunch of failures, all of them Set up snd-dummy E: Package 'linux-modules-extra-5.15.0-1042-azure' has no installation candidate I see this after rebasing and pushing two PR's. Is there something I need to do? -ernie -- -- You received this message from the "vim_dev" maillist. Do not top-post! Type your reply below the text you are replying to. For more information, visit http://www.vim.org/maillist.php --- You received this message because you are subscribed to the Google Groups "vim_dev" group. To unsubscribe from this group and stop receiving emails from it, send an email to vim_dev+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/vim_dev/ca7afb2c-5a0e-ea25-6b19-ce18fe84fb29%40raelity.com.
Re: No more tags for new 9.0 patches?
On Mon, 14 Aug 2023 12:18:50 +0200 Christian Brabandt wrote: > On Mo, 14 Aug 2023, Manfred Rosenboom wrote: > > Don't get each patch a related annotated tag anymore? > > I think we only used lightweight tags? So I only added those: Not that it's super important, but I suggest strictly using annotated tags. Cannot recall the exact reasons, but last year my team and I faced multiple unrelated problems: all of them because of using lightweight tags instead of annotated ones. Here's what "git tag --help" has to say: > Annotated tags are meant for release while lightweight tags are meant > for private or temporary object labels. For this reason, some git > commands for naming objects (like git describe) will ignore > lightweight tags by default. I don't wanna be annoying. Just wanted to leaves a word that weird problems may pop up if using lightweight tags instead of annotated ones. -- Enan > ``` > chrisbra@debian ~/code/vim-upstream (git)-[master]- % git describe v9.0.1676 > fatal: No annotated tags can describe > '16abd997c99b1a40fb0ba54889ce0cf44d7585b4'. > However, there were unannotated tags: try --tags. > chrisbra@debian ~/code/vim-upstream (git)-[master]- % git describe v9.0.1712 > fatal: No annotated tags can describe > '5b0889b8bf25b0793b1949ec965c94b623900aba'. > However, there were unannotated tags: try --tags. > chrisbra@debian ~/code/vim-upstream (git)-[master]- % git cat-file -t > v9.0.1676 > commit > chrisbra@debian ~/code/vim-upstream (git)-[master]- % git cat-file -t > v9.0.1712 > commit > ``` > > > Best, > Christian -- -- You received this message from the "vim_dev" maillist. Do not top-post! Type your reply below the text you are replying to. For more information, visit http://www.vim.org/maillist.php --- You received this message because you are subscribed to the Google Groups "vim_dev" group. To unsubscribe from this group and stop receiving emails from it, send an email to vim_dev+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/vim_dev/20230814202646.4203%40gmail.com.
Re: Farewell to Bram and dedicate upcoming Vim 9.1 to him (#12749)
> Op 13-08-2023 10:45 CEST schreef Christian Brabandt :
[..]
> diff --git a/runtime/doc/intro.txt b/runtime/doc/intro.txt
[..]
> @@ -216,7 +217,7 @@ Vim would never have become what it is now, without the
> help of these people!
> Bill Foster Athena GUI port (later removed)
> Google Lets me work on Vim one day a week
I noticed this: "Lets me work". Bram worked for Google for 15 years, until
September 2021.
Shouldn't this "Lets me" be past tense then, like "Let Bram"? Alternatively:
"Letting Bram".
> diff --git a/LICENSE b/LICENSE
[..]
> @@ -21,8 +21,8 @@ II) It is allowed to distribute a modified (or extended)
> version of Vim,
>maintainer will do with your changes and under what license they
>will be distributed is negotiable. If there has been no
> negotiation
>then this license, or a later version, also applies to your
> changes.
> - The current maintainer is Bram Moolenaar . If this
> - changes it will be announced in appropriate places (most likely
> + The current maintainers are listed here:
> https://github.com/orgs/vim/people.
> + If this changes it will be announced in appropriate places (most
> likely
>vim.sf.net, www.vim.org and/or comp.editors). When it is completely
>impossible to contact the maintainer, the obligation to send him
>your changes ceases. Once the maintainer has confirmed that he has
Above it says: "The current maintainers are listed".
As we can see, that's plural. Let's watch out for the word "maintainer" then.
Let's also have another look at the lines above.
"It is allowed to distribute a modified (or extended) version of Vim",
that's singular ("version of Vim"). Then the next lines: "maintainer will do
with your changes and under what license they will be distributed is
negotiable".
I think this can be split into two parts: the part where the changes are
mentioned
and the part where the license of the version is discussed. 'The changes'
might be plural, but 'the version' is singular. So shouldn't this be "the
maintainers will do with your changes and under what license that version"
(trying to avoid the word 'it' or 'they' after "under what license") then?
Possibly, the following lines:
"impossible to contact the maintainer, the obligation to send him
your changes ceases. Once the maintainer has confirmed that he has"
should then be changed into:
"impossible to contact the maintainers, the obligation to send them
your changes ceases. Once the maintainers have confirmed that they have"
There are more locations where "maintainer" is mentioned. Should I list them?
The same text appears in file uganda.txt:
> diff --git a/runtime/doc/uganda.txt b/runtime/doc/uganda.txt
[..]
> @@ -46,8 +46,8 @@ II) It is allowed to distribute a modified (or extended)
> version of Vim,
> maintainer will do with your changes and under what license they
> will be distributed is negotiable. If there has been no negotiation
> then this license, or a later version, also applies to your changes.
> - The current maintainer is Bram Moolenaar . If this
> - changes it will be announced in appropriate places (most likely
> + The current maintainers are listed here:
> https://github.com/orgs/vim/people.
> + If this changes it will be announced in appropriate places (most
> likely
> vim.sf.net, www.vim.org and/or comp.editors). When it is completely
> impossible to contact the maintainer, the obligation to send him
> your changes ceases. Once the maintainer has confirmed that he has
So the same remarks apply. :-)
This wasn't changed yet:
> diff --git a/runtime/indent/README.txt b/runtime/indent/README.txt
[..]
> If you have remarks about an existing file, send them to the maintainer of
> that file. Only when you get no response send a message to b...@vim.org.
That should possibly be changed into:
"get no response send a message to the vim-dev mailing list ."
The word "me" is also 'suspect':
> diff --git a/runtime/syntax/model.vim b/runtime/syntax/model.vim
[..]
> -" Maintainer:Bram Moolenaar
> -" Last Change: 2005 Jun 20
> +" Maintainer:The Vim Project
> +" Last Change: 2023 Aug 10
> +" Former Maintainer: Bram Moolenaar
>
> " very basic things only (based on the vgrindefs file).
> " If you use this language, please improve it, and send me the patches!
Maybe change "me" into "us"?
> diff --git a/src/po/README.txt b/src/po/README.txt
[..]
> You should include your name and E-mail address instead, for example:
Shouldn't this just be "e-mail" instead of "E-mail"?
The same applies here:
> diff --git a/src/po/README_mingw.txt b/src/po/README_mingw.txt
[..]
> You should include your name and E-mail address instead, for example:
Adri
PS Great that you've taken up the project!
Re: No more tags for new 9.0 patches?
On Mo, 14 Aug 2023, Manfred Rosenboom wrote: > Up to patch 9.0.1677 I see a related annotated tag. But meanwhile I see the > following new patches in the commit log: > > * 5b0889b8b patch 9.0.1712: missing null check in object_clear() > * d3515a1e8 patch 9.0.1711: dead code in charset.c > * 4a8eb6e7a patch 9.0.1710: scrolloff options work slightly different > * e5e4709a6 patch 9.0.1709: dynamic build with python 3.12 breaks > * 8ef1fbc0c patch 9.0.1708: getcompletion() failes for user-defined commands > * badeedd91 patch 9.0.1707: Cannot wrap around in popup_filter_menu() > * 02551c9de patch 9.0.1706: typos in the xxd manpage > * b25dbb3f9 patch 9.0.1705: cursor position wrong when clicking on an > unprintable char > * 0c6181fec patch 9.0.1704: Cannot use positional arguments for printf() > * 74cc13cc4 patch 9.0.1703: Vim9 Calling a method in an extended class fails > * 9c30f4389 patch 9.0.1702: Undo test is flaky > * 57a02ccf4 patch 9.0.1701: vim9 crash when class member overridden > * 32f586eec patch 9.0.1700: Cannot compile with dynamic perl < 5.38 > * 6c313bbb0 patch 9.0.1699: compile warning for xdiff/xutils on MS-Windows > * 7fe108990 patch 9.0.1698: Test_map_restore_sid fails in GUI > * 73b820926 patch 9.0.1697: incsearch test not sufficient > * 8878653a4 patch 9.0.1696: sodium_mlock may still fail in CI > * f1cc4d55b patch 9.0.1695: Crash with overlong textprop above > * bacc83009 patch 9.0.1694: wrong mapping applied when replaying a char search > * 2d63e4b3c patch 9.0.1693: Ctrl-Q not handled like Ctrl-V in replace mode > * db4fd2906 patch 9.0.1692: Android not handling AI_V4MAPPED ai_flag > * 7b7b4cb6f patch 9.0.1691: wrong viewport restored for incsearch and > smoothscroll > * f6cdab370 patch 9.0.1690: popup_create() not aborting on errors > * 288bf26c5 patch 9.0.1689: python 3.12 produces warnings and fails test > * ca6ac9907 patch 9.0.1688: cannot store custom data in quickfix list > * 7e0bae024 patch 9.0.1687: mapset() not properly handling script ID > * 5fee4 patch 9.0.1686: undotree() only works for the current buffer > * 422b9dcbf patch 9.0.1685: silence Python 3.11 depreciations for gcc > * b00df7aa3 patch 9.0.1684: Update libvterm to rev 839 > * 6019fed0c patch 9.0.1682: sodium encryption is not portable > * 1d7caa58e patch 9.0.1681: Build Failure with Perl 5.38 > * 335c58494 patch 9.0.1680: sodium test fails in Github CI > * 84bc00e9b patch 9.0.1679: Cleanup Tests from leftover files > * ad34abee2 patch 9.0.1678: blade files are not recognized > * 4c0089d69 (tag: v9.0.1677) patch 9.0.1677: typo in syntax test input file > > Don't get each patch a related annotated tag anymore? I think we only used lightweight tags? So I only added those: ``` chrisbra@debian ~/code/vim-upstream (git)-[master]- % git describe v9.0.1676 fatal: No annotated tags can describe '16abd997c99b1a40fb0ba54889ce0cf44d7585b4'. However, there were unannotated tags: try --tags. chrisbra@debian ~/code/vim-upstream (git)-[master]- % git describe v9.0.1712 fatal: No annotated tags can describe '5b0889b8bf25b0793b1949ec965c94b623900aba'. However, there were unannotated tags: try --tags. chrisbra@debian ~/code/vim-upstream (git)-[master]- % git cat-file -t v9.0.1676 commit chrisbra@debian ~/code/vim-upstream (git)-[master]- % git cat-file -t v9.0.1712 commit ``` Best, Christian -- "Aww, if you make me cry anymore, you'll fog up my helmet." -- "Visionaries" cartoon -- -- You received this message from the "vim_dev" maillist. Do not top-post! Type your reply below the text you are replying to. For more information, visit http://www.vim.org/maillist.php --- You received this message because you are subscribed to the Google Groups "vim_dev" group. To unsubscribe from this group and stop receiving emails from it, send an email to vim_dev+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/vim_dev/ZNn/ilYmiMsXWtAC%40256bit.org.
No more tags for new 9.0 patches?
Up to patch 9.0.1677 I see a related annotated tag. But meanwhile I see the following new patches in the commit log: * 5b0889b8b patch 9.0.1712: missing null check in object_clear() * d3515a1e8 patch 9.0.1711: dead code in charset.c * 4a8eb6e7a patch 9.0.1710: scrolloff options work slightly different * e5e4709a6 patch 9.0.1709: dynamic build with python 3.12 breaks * 8ef1fbc0c patch 9.0.1708: getcompletion() failes for user-defined commands * badeedd91 patch 9.0.1707: Cannot wrap around in popup_filter_menu() * 02551c9de patch 9.0.1706: typos in the xxd manpage * b25dbb3f9 patch 9.0.1705: cursor position wrong when clicking on an unprintable char * 0c6181fec patch 9.0.1704: Cannot use positional arguments for printf() * 74cc13cc4 patch 9.0.1703: Vim9 Calling a method in an extended class fails * 9c30f4389 patch 9.0.1702: Undo test is flaky * 57a02ccf4 patch 9.0.1701: vim9 crash when class member overridden * 32f586eec patch 9.0.1700: Cannot compile with dynamic perl < 5.38 * 6c313bbb0 patch 9.0.1699: compile warning for xdiff/xutils on MS-Windows * 7fe108990 patch 9.0.1698: Test_map_restore_sid fails in GUI * 73b820926 patch 9.0.1697: incsearch test not sufficient * 8878653a4 patch 9.0.1696: sodium_mlock may still fail in CI * f1cc4d55b patch 9.0.1695: Crash with overlong textprop above * bacc83009 patch 9.0.1694: wrong mapping applied when replaying a char search * 2d63e4b3c patch 9.0.1693: Ctrl-Q not handled like Ctrl-V in replace mode * db4fd2906 patch 9.0.1692: Android not handling AI_V4MAPPED ai_flag * 7b7b4cb6f patch 9.0.1691: wrong viewport restored for incsearch and smoothscroll * f6cdab370 patch 9.0.1690: popup_create() not aborting on errors * 288bf26c5 patch 9.0.1689: python 3.12 produces warnings and fails test * ca6ac9907 patch 9.0.1688: cannot store custom data in quickfix list * 7e0bae024 patch 9.0.1687: mapset() not properly handling script ID * 5fee4 patch 9.0.1686: undotree() only works for the current buffer * 422b9dcbf patch 9.0.1685: silence Python 3.11 depreciations for gcc * b00df7aa3 patch 9.0.1684: Update libvterm to rev 839 * 6019fed0c patch 9.0.1682: sodium encryption is not portable * 1d7caa58e patch 9.0.1681: Build Failure with Perl 5.38 * 335c58494 patch 9.0.1680: sodium test fails in Github CI * 84bc00e9b patch 9.0.1679: Cleanup Tests from leftover files * ad34abee2 patch 9.0.1678: blade files are not recognized * 4c0089d69 (tag: v9.0.1677) patch 9.0.1677: typo in syntax test input file Don't get each patch a related annotated tag anymore? -- -- You received this message from the "vim_dev" maillist. Do not top-post! Type your reply below the text you are replying to. For more information, visit http://www.vim.org/maillist.php --- You received this message because you are subscribed to the Google Groups "vim_dev" group. To unsubscribe from this group and stop receiving emails from it, send an email to vim_dev+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/vim_dev/977cfd1b-41e5-4d6f-9948-2fb881b92215n%40googlegroups.com.
Re: Documentation error
I found this older message; the issue hasn't been resolved because the text has been moved from eval.txt to the file channel.txt (as part of the package vim-common-9.0.1677-2.fc38.x86_64). See issue below. > Op 17-05-2018 20:08 CEST schreef Bram Moolenaar : > > > Adri Verhoef wrote: > > > In eval.txt (vim 8.0.1842), line 5423, job_start() is documented. On > > the 13th > > line underneath it there is this text: > > > > On MS-Windows, job_start() makes a GUI application > > hidden. If > > want to show it, Use :!start instead. > > > > Perhaps it should be "If you want" and "use"? > > Yes, I'll correct it. > > -- > Why is "abbreviation" such a long word? > > /// Bram Moolenaar -- b...@moolenaar.net -- http://www.Moolenaar.net \\\ > ///sponsor Vim, vote for features -- http://www.Vim.org/sponsor/ \\\ > \\\ an exciting new programming language -- http://www.Zimbu.org/// > \\\help me help AIDS victims -- http://ICCF-Holland.org/// "want to show it, Use :!start instead." is now on line 959. Adri -- -- You received this message from the "vim_dev" maillist. Do not top-post! Type your reply below the text you are replying to. For more information, visit http://www.vim.org/maillist.php --- You received this message because you are subscribed to the Google Groups "vim_dev" group. To unsubscribe from this group and stop receiving emails from it, send an email to vim_dev+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/vim_dev/1477030968.479533.1692006412437%40kpc.webmail.kpnmail.nl.
