Re: [vim/vim] doc: Use gender-neutral pronouns in the docs. (#6535)
On 13/08/2020 21:53, Bram Moolenaar (Vim Github Repository) wrote:
> I have been trying to get used to "the user, they..." but it just keeps
> sounding wrong. It's like using Shakespearean English: it may be correct
> English, but that's just not how you would say it in real life.
> I understand some people (and I think it's actually not that many, but
> they are very opinionated) object to using "the user, he...". So we need
> to phrase that differently.
Generally, you can abstract a singular user into plural ("if users click
on this item then they will see..."), and for instructions directed
towards a user then second-person can be useful ("if you click on this
item then you will see...").
J
--
--
You received this message from the "vim_dev" maillist.
Do not top-post! Type your reply below the text you are replying to.
For more information, visit http://www.vim.org/maillist.php
---
You received this message because you are subscribed to the Google Groups
"vim_dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to vim_dev+unsubscr...@googlegroups.com.
To view this discussion on the web visit
https://groups.google.com/d/msgid/vim_dev/90a58860-99ea-090c-2470-232198730360%40york.ac.uk.
signature.asc
Description: OpenPGP digital signature
Re: Patch 8.1.1031
On 22/03/2019 10:33, Bram Moolenaar wrote: > > Elimar Riesebieter wrote: > >> * Bram Moolenaar [2019-03-21 21:16 +0100]: >> >>> >>> Patch 8.1.1031 >>> Problem:Memory usage test may still fail. >>> Solution: Drop the unused min value. (Christian Brabandt) >>> Files: src/testdir/test_memory_usage.vim >> >> Still get on i686: >> >> From test_memory_usage.vim: >> Found errors in Test_memory_func_capture_lvars(): >> function RunTheTest[40]..Test_memory_func_capture_lvars line 33: Expected >> range 10051 - 26967, but got 27516 >> TEST FAILURE > > I added 1% and this goes over the limit by 1.02%. > I guess I'll have to make the tolerance 3%. > Even with 3% tolerance (per 8.1.1033) I'm still seeing this on i686 [1] (and armhf [2]): >From test_memory_usage.vim: Found errors in Test_memory_func_capture_lvars(): function RunTheTest[40]..Test_memory_func_capture_lvars line 33: Expected range 6579 - 22985, but got 23108 TEST FAILURE Is the reported upper range number (in this case 22985) the 100% value, or the 103% value? Another build with larger value difference [2]: >From test_memory_usage.vim: Found errors in Test_memory_func_capture_lvars(): function RunTheTest[40]..Test_memory_func_capture_lvars line 33: Expected range 12780 - 28292, but got 30896 TEST FAILURE The build/packaging process in these logs runs several times with different enabled features/flags. The first run [1] failed while testing "vim-basic", the second run [3] succeeded where [1] failed but failed later while testing "vim-gtk", and a third run [4] succeeded where [1] and [3] failed but failed later still while testing "vim-gtk3". (and a fourth run failed again testing "vim-basic". [5]) The test looks pretty flaky for 32-bit... 64-bit builds (amd64, arm64) don't have the same problem. J [1] https://launchpadlibrarian.net/416114150/buildlog_ubuntu-bionic-i386.vim_2%3A8.1.1017+really.v8.1.1034-0york0~ubuntu18.04.1_BUILDING.txt.gz [2] https://launchpadlibrarian.net/416119282/buildlog_ubuntu-bionic-armhf.vim_2%3A8.1.1017+really.v8.1.1034-0york0~ubuntu18.04.1_BUILDING.txt.gz [3] https://launchpadlibrarian.net/416116391/buildlog_ubuntu-bionic-i386.vim_2%3A8.1.1017+really.v8.1.1034-0york0~ubuntu18.04.1_BUILDING.txt.gz [4] https://launchpadlibrarian.net/416118864/buildlog_ubuntu-bionic-i386.vim_2%3A8.1.1017+really.v8.1.1034-0york0~ubuntu18.04.1_BUILDING.txt.gz [5] https://code.launchpad.net/~jonathonf/+archive/ubuntu/vim-daily/+build/16521748/+files/buildlog_ubuntu-bionic-i386.vim_2%3A8.1.1017+really.v8.1.1034-0york0~ubuntu18.04.1_BUILDING.txt.gz (yes, it +really. is 8.1.1034 ;) -- -- You received this message from the "vim_dev" maillist. Do not top-post! Type your reply below the text you are replying to. For more information, visit http://www.vim.org/maillist.php --- You received this message because you are subscribed to the Google Groups "vim_dev" group. To unsubscribe from this group and stop receiving emails from it, send an email to vim_dev+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout. signature.asc Description: OpenPGP digital signature
Re: 8.1.0350's Test_exit_cb_wipes_buf() causes segfault when building on Launchpad
On 26/11/2018 20:19, Bram Moolenaar wrote: > I'll send out this patch, please verify it fixes the problem. 8.1.0548 builds without issue on Launchpad. Excellent. -- -- You received this message from the "vim_dev" maillist. Do not top-post! Type your reply below the text you are replying to. For more information, visit http://www.vim.org/maillist.php --- You received this message because you are subscribed to the Google Groups "vim_dev" group. To unsubscribe from this group and stop receiving emails from it, send an email to vim_dev+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout. signature.asc Description: OpenPGP digital signature
Re: 8.1.0350's Test_exit_cb_wipes_buf() causes segfault when building on Launchpad
On 26/11/2018 10:54, Christian Brabandt wrote: > On Mo, 26 Nov 2018, Christian Brabandt wrote: >> This looks very similar to the crash posted here: >> https://github.com/vim/vim/pull/2107#issuecomment-418816582 >> >> I guess the redrawing() function is being called again, that triggers >> the win_free() and will make curwin invalid. >> >> Perhaps we do need a patch similar to this one >> https://github.com/vim/vim/pull/2107#issuecomment-418882802 > > How about the following patch: > > diff --git a/src/move.c b/src/move.c > index 68404e3f7..c25d6271f 100644 > --- a/src/move.c > +++ b/src/move.c > @@ -687,6 +687,8 @@ validate_cline_row(void) > /* > * Compute wp->w_cline_row and wp->w_cline_height, based on the current value > * of wp->w_topline. > + * Might cause processing of async messages. > + * If async causes wp to become invalid, uses curwin > */ > static void > curs_rows(win_T *wp) > @@ -699,10 +701,16 @@ curs_rows(win_T *wp) > long fold_count; > #endif > > -/* Check if wp->w_lines[].wl_size is invalid */ > -all_invalid = (!redrawing() > - || wp->w_lines_valid == 0 > - || wp->w_lines[0].wl_lnum > wp->w_topline); > +// Check if wp->w_lines[].wl_size is invalid > +all_invalid = (wp->w_lines_valid == 0 > + || wp->w_lines[0].wl_lnum > wp->w_topline > + || !redrawing()); > + > +// redrawing might have processed async messages, > +// causing wp to become invalid > +if (!win_valid(wp)) > + wp = curwin; > + > i = 0; > wp->w_cline_row = 0; > for (lnum = wp->w_topline; lnum < wp->w_cursor.lnum; ++i) > > > Best, > Christian > That patch fixes building on Launchpad: https://launchpad.net/~jonathonf/+archive/ubuntu/vim-staging/+build/15706279 :D J -- -- You received this message from the "vim_dev" maillist. Do not top-post! Type your reply below the text you are replying to. For more information, visit http://www.vim.org/maillist.php --- You received this message because you are subscribed to the Google Groups "vim_dev" group. To unsubscribe from this group and stop receiving emails from it, send an email to vim_dev+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout. signature.asc Description: OpenPGP digital signature
