Re: [MPF] runtimefiles cpo+=l save

2012-02-08 Fir de Conversatie Bram Moolenaar

Charles Campbell wrote:

> Thilo Six wrote:
> > Hello
> >
>  ,[ :h syn-pattern   ]-
>  Syntax patterns are always interpreted like the 'magic' option is set,
>  no matter what the actual value of 'magic' is.  And the patterns are
>  interpreted like the 'l' flag is not included in 'cpoptions'.  This
>  was done to make syntax files portable and independent of 'compatible'
>  and 'magic' settings.
>  `-
>   
> > --   --
> >
> >
> >>> Test:
> >>>   :new
> >>>   :put = \"abc\tdef\"
> >>>   :set cpo+=l
> >>>   :syn match Test /c[\t]d/
> >>>   :hi link Test StatusLine
> >>>   " I can see highlighted text
> >>>   /c[\t]d
> >>>   E486: Pattern not found: c[\t]d
> >>>
> >>>
> > --   --
> >
> > ,[  src/syntax.c  ]---
> >
> >  /* Make 'cpoptions' empty, to avoid the 'l' flag */
> >  cpo_save = p_cpo;
> >  p_cpo = (char_u *)"";
> >  ci->sp_prog = vim_regcomp(ci->sp_pattern, RE_MAGIC);
> >  p_cpo = cpo_save;
> >
> > `-
> >
> > Bram i do not speak any C but to me it seems that something like this 
> > should be
> > doable without great afford to cover all runtime files, too.
> > IIRC when we have discussed this topic here last year it had been suggested 
> > to
> > use a function to fix it once for all. Can't something like this be used to 
> > a
> > broader scope, too?
> >
> >
> The exceptions for syntax files are (without having tested) likely to 
> apply to the user's syntax files, too ($HOME/.vim/syntax, etc).
> Applying this exception to plugins would, for consistency, also apply to 
> user-written plugins, and so vim would not behave in the manner to which 
> some users are accustomed.  Also, making such a change might break 
> user-written, personal plugins.
> 
> What I'd like to see is something akin to
> 
>vimstatepush()
>vimstdstate()
>(optional plugin author state modifications (settings) here)
>vimstatepop()
> 
> The problem here is when a plugin does something (like return, exit on 
> error, etc) and doesn't do the vimstatepop().  Thus, vimstatepush() and 
> vimstatepop() could be done automatically by vim (instead of explicitly 
> by plugin authors).

There is a big difference between behavior depending on the command and
depdinging on how the command was invoked.  The last one quickly becomes
unpredictable, e.g., when definign autocommands.
 
> And, while I'm at it: I'd like beval to be a local rather than global.

That's an implementation problem.

-- 
Despite the cost of living, have you noticed how it remains so popular?

 /// Bram Moolenaar -- b...@moolenaar.net -- http://www.Moolenaar.net   \\\
///sponsor Vim, vote for features -- http://www.Vim.org/sponsor/ \\\
\\\  an exciting new programming language -- http://www.Zimbu.org///
 \\\help me help AIDS victims -- http://ICCF-Holland.org///

-- 
You received this message from the "vim_dev" maillist.
Do not top-post! Type your reply below the text you are replying to.
For more information, visit http://www.vim.org/maillist.php


Re: [MPF] runtimefiles cpo+=l save

2012-02-08 Fir de Conversatie Charles E Campbell Jr

Thilo Six wrote:

Hello


   

,[ :h syn-pattern   ]-
Syntax patterns are always interpreted like the 'magic' option is set,
no matter what the actual value of 'magic' is.  And the patterns are
interpreted like the 'l' flag is not included in 'cpoptions'.  This
was done to make syntax files portable and independent of 'compatible'
and 'magic' settings.
`-
 

--   --

   

Test:
  :new
  :put = \"abc\tdef\"
  :set cpo+=l
  :syn match Test /c[\t]d/
  :hi link Test StatusLine
  " I can see highlighted text
  /c[\t]d
  E486: Pattern not found: c[\t]d

   

--   --

,[  src/syntax.c  ]---

 /* Make 'cpoptions' empty, to avoid the 'l' flag */
 cpo_save = p_cpo;
 p_cpo = (char_u *)"";
 ci->sp_prog = vim_regcomp(ci->sp_pattern, RE_MAGIC);
 p_cpo = cpo_save;

`-

Bram i do not speak any C but to me it seems that something like this should be
doable without great afford to cover all runtime files, too.
IIRC when we have discussed this topic here last year it had been suggested to
use a function to fix it once for all. Can't something like this be used to a
broader scope, too?

   
The exceptions for syntax files are (without having tested) likely to 
apply to the user's syntax files, too ($HOME/.vim/syntax, etc).
Applying this exception to plugins would, for consistency, also apply to 
user-written plugins, and so vim would not behave in the manner to which 
some users are accustomed.  Also, making such a change might break 
user-written, personal plugins.


What I'd like to see is something akin to

  vimstatepush()
  vimstdstate()
  (optional plugin author state modifications (settings) here)
  vimstatepop()

The problem here is when a plugin does something (like return, exit on 
error, etc) and doesn't do the vimstatepop().  Thus, vimstatepush() and 
vimstatepop() could be done automatically by vim (instead of explicitly 
by plugin authors).


And, while I'm at it: I'd like beval to be a local rather than global.

Regards,
Chip Campbell

--
You received this message from the "vim_dev" maillist.
Do not top-post! Type your reply below the text you are replying to.
For more information, visit http://www.vim.org/maillist.php


Re: [MPF] runtimefiles cpo+=l save

2012-02-08 Fir de Conversatie Thilo Six
Hello


>>> ,[ :h syn-pattern   ]-
>>> Syntax patterns are always interpreted like the 'magic' option is set,
>>> no matter what the actual value of 'magic' is.  And the patterns are
>>> interpreted like the 'l' flag is not included in 'cpoptions'.  This
>>> was done to make syntax files portable and independent of 'compatible'
>>> and 'magic' settings.
>>> `-

--  --

>> Test:
>>  :new
>>  :put = \"abc\tdef\"
>>  :set cpo+=l
>>  :syn match Test /c[\t]d/
>>  :hi link Test StatusLine
>>  " I can see highlighted text
>>  /c[\t]d
>>  E486: Pattern not found: c[\t]d
>>
--  --

,[  src/syntax.c  ]---

/* Make 'cpoptions' empty, to avoid the 'l' flag */
cpo_save = p_cpo;
p_cpo = (char_u *)"";
ci->sp_prog = vim_regcomp(ci->sp_pattern, RE_MAGIC);
p_cpo = cpo_save;

`-

Bram i do not speak any C but to me it seems that something like this should be
doable without great afford to cover all runtime files, too.
IIRC when we have discussed this topic here last year it had been suggested to
use a function to fix it once for all. Can't something like this be used to a
broader scope, too?


-- 
Regards,
Thilo

4096R/0xC70B1A8F
721B 1BA0 095C 1ABA 3FC6  7C18 89A4 A2A0 C70B 1A8F


-- 
You received this message from the "vim_dev" maillist.
Do not top-post! Type your reply below the text you are replying to.
For more information, visit http://www.vim.org/maillist.php


Re: [MPF] runtimefiles cpo+=l save

2012-02-07 Fir de Conversatie Thilo Six
Andy Wokula wrote the following on 07.02.2012 20:40


--  --
>> ,[ :h syn-pattern   ]-
>> Syntax patterns are always interpreted like the 'magic' option is set,
>> no matter what the actual value of 'magic' is.  And the patterns are
>> interpreted like the 'l' flag is not included in 'cpoptions'.  This
>> was done to make syntax files portable and independent of 'compatible'
>> and 'magic' settings.
>> `-
>>
>> To me this sounds like the whole subject is already handled inside of
>> Vim and no additional settings regarding 'set cpo+=l' inside of vim
>> (syntax) scripts is needed. Is this correct?
> 
> I'd say: yes
> 
> Test:
>  :new
>  :put = \"abc\tdef\"
>  :set cpo+=l
>  :syn match Test /c[\t]d/
>  :hi link Test StatusLine
>  " I can see highlighted text
>  /c[\t]d
>  E486: Pattern not found: c[\t]d
> 
> And, btw, that :syn-pattern help section isn't new, it's found even in
> Vim 5.7 (!)

sigh. core dumped.

-- 
Regards,
Thilo

4096R/0xC70B1A8F
721B 1BA0 095C 1ABA 3FC6  7C18 89A4 A2A0 C70B 1A8F


-- 
You received this message from the "vim_dev" maillist.
Do not top-post! Type your reply below the text you are replying to.
For more information, visit http://www.vim.org/maillist.php


Re: [MPF] runtimefiles cpo+=l save

2012-02-07 Fir de Conversatie Andy Wokula

Am 07.02.2012 18:29, schrieb Thilo Six:

I had a rather usefull discussion with Andriy Sokolov offlist. He
pointed out to me:

,[ :h syn-pattern   ]-
Syntax patterns are always interpreted like the 'magic' option is set,
no matter what the actual value of 'magic' is.  And the patterns are
interpreted like the 'l' flag is not included in 'cpoptions'.  This
was done to make syntax files portable and independent of 'compatible'
and 'magic' settings.
`-

To me this sounds like the whole subject is already handled inside of
Vim and no additional settings regarding 'set cpo+=l' inside of vim
(syntax) scripts is needed. Is this correct?


I'd say: yes

Test:
:new
:put = \"abc\tdef\"
:set cpo+=l
:syn match Test /c[\t]d/
:hi link Test StatusLine
" I can see highlighted text
/c[\t]d
E486: Pattern not found: c[\t]d

And, btw, that :syn-pattern help section isn't new, it's found even in
Vim 5.7 (!)

--
Andy

--
You received this message from the "vim_dev" maillist.
Do not top-post! Type your reply below the text you are replying to.
For more information, visit http://www.vim.org/maillist.php


Re: [MPF] runtimefiles cpo+=l save

2012-02-07 Fir de Conversatie Thilo Six
Thilo Six wrote the following on 03.02.2012 17:37

Hello Bram,
hello Maintainers,

> for those who do not know MPF stands for mass patch filling. ;)
> 
> All proposed patches have been sent out to maintainers. The according list is
> attached.
> By the way how long should we wait on maintainers before we consider them MIA?
> Some patches sent out 2 months ago are still without response.

I had a rather usefull discussion with Andriy Sokolov offlist. He pointed out 
to me:

,[ :h syn-pattern   ]-

Syntax patterns are
always interpreted like the 'magic' option is set, no matter what the actual
value of 'magic' is.  And the patterns are interpreted like the 'l' flag is
not included in 'cpoptions'.  This was done to make syntax files portable and
independent of 'compatible' and 'magic' settings.
`-

To me this sounds like the whole subject is already handled inside of Vim and no
additional settings regarding 'set cpo+=l' inside of vim (syntax) scripts is
needed. Is this correct?

-- 
Regards,
Thilo

4096R/0xC70B1A8F
721B 1BA0 095C 1ABA 3FC6  7C18 89A4 A2A0 C70B 1A8F


-- 
You received this message from the "vim_dev" maillist.
Do not top-post! Type your reply below the text you are replying to.
For more information, visit http://www.vim.org/maillist.php


[MPF] runtimefiles cpo+=l save

2012-02-03 Fir de Conversatie Thilo Six
Hello Bram,
hello Maintainers,

for those who do not know MPF stands for mass patch filling. ;)

All proposed patches have been sent out to maintainers. The according list is
attached.
By the way how long should we wait on maintainers before we consider them MIA?
Some patches sent out 2 months ago are still without response.


-- 
Regards,
Thilo

4096R/0xC70B1A8F
721B 1BA0 095C 1ABA 3FC6  7C18 89A4 A2A0 C70B 1A8F

-- 
You received this message from the "vim_dev" maillist.
Do not top-post! Type your reply below the text you are replying to.
For more information, visit http://www.vim.org/maillist.php
patch sent out
FALSE POSITIVES:

~/build/vim/runtime/autoload/gzip.vim   reviewed again, nothing to 
do.
~/build/vim/runtime/autoload/tohtml.vim reviewed again, nothing to 
do.
~/build/vim/runtime/ftplugin/matlab.vim reviewed again, nothing to 
do.
~/build/vim/runtime/ftplugin/vim.vimreviewed again, nothing to 
do.
~/build/vim/runtime/syntax/named.vimreviewed again, nothing to 
do.
~/build/vim/runtime/ftplugin/cobol.vim  reviewed again, nothing to 
do.
~/build/vim/runtime/indent/liquid.vim   reviewed again, nothing to 
do.
~/build/vim/runtime/syntax/antlr.vim\t in currently commented 
line
~/build/vim/runtime/syntax/foxpro.vim   reviewed again, nothing to 
do.
~/build/vim/runtime/syntax/markdown.vim reviewed again, nothing to 
do.
~/build/vim/runtime/syntax/papp.vim reviewed again, nothing to 
do.
~/build/vim/runtime/syntax/pccts.vimreviewed again, nothing to 
do.
~/build/vim/runtime/syntax/sml.vim  reviewed again, nothing to 
do.



FIXED in Mercurial:

~/build/vim/runtime/ftplugin/falcon.vim 2011-12-10does not 
restore user cpo settings
~/build/vim/runtime/ftplugin/lua.vim2011-12-10does not 
restore user cpo settings
~/build/vim/runtime/ftplugin/ocaml.vim  2011-12-10not cpo+=l 
save
~/build/vim/runtime/ftplugin/vhdl.vim   2011-12-10does not 
restore user cpo settings
~/build/vim/runtime/indent/falcon.vim   2011-12-10does not 
restore user cpo settings
~/build/vim/runtime/indent/tcsh.vim 2011-12-10does not 
restore user cpo settings
~/build/vim/runtime/indent/verilog.vim  2011-12-10does not 
restore user cpo settings
~/build/vim/runtime/syntax/lpc.vim  2011-12-10does not 
restore user cpo settings
~/build/vim/runtime/autoload/ccomplete.vim  2011-12-24not cpo+=l 
save
~/build/vim/runtime/compiler/gcc.vim2011-12-10not cpo+=l 
save
~/build/vim/runtime/compiler/rst.vim2011-12-10not cpo+=l 
save
~/build/vim/runtime/ftplugin/fortran.vim2011-12-10not cpo+=l 
save, cpo-=C too late down
~/build/vim/runtime/ftplugin/kwt.vim2011-12-10does not 
restore user cpo settings
~/build/vim/runtime/ftplugin/spec.vim   2011-12-24not cpo+=l 
save
~/build/vim/runtime/indent/fortran.vim  2011-12-10not cpo+=l 
save
~/build/vim/runtime/indent/gitolite.vim 2011-12-24not cpo+=l 
save
~/build/vim/runtime/indent/sdl.vim  2011-12-10does not 
restore user cpo settings
~/build/vim/runtime/indent/tex.vim  2011-12-24not cpo+=C 
save
~/build/vim/runtime/syntax/abel.vim 2011-12-24not cpo+=l 
save
~/build/vim/runtime/syntax/art.vim  2011-12-25not cpo+=l 
save
~/build/vim/runtime/syntax/ayacc.vim2011-12-25not cpo+=l 
save
~/build/vim/runtime/syntax/basic.vim2011-12-25not cpo+=l 
save
~/build/vim/runtime/syntax/bib.vim  2011-12-25not cpo+=l 
save
~/build/vim/runtime/syntax/blank.vim2011-12-25not cpo+=l 
save
~/build/vim/runtime/syntax/c.vim2011-12-25not cpo+=l 
save
~/build/vim/runtime/syntax/clean.vim2011-12-25not cpo+=l 
save
~/build/vim/runtime/syntax/clipper.vim  2011-12-25not cpo+=l 
save
~/build/vim/runtime/syntax/csc.vim  2011-12-25not cpo+=l 
save
~/build/vim/runtime/syntax/cupl.vim 2011-12-25not cpo+=l 
save
~/build/vim/runtime/syntax/cweb.vim 2011-12-25not cpo+=l 
save
~/build/vim/runtime/syntax/fortran.vim  2011-12-25not cpo+=l 
save
~/build/vim/runtime/syntax/asm.vim  2011-12-25not cpo+=l 
save
~/build/vim/runtime/syntax/eiffel.vim   2011-12-25not cpo+=l 
save
~/build/vim/runtime/syntax/forth.vim2011-12-25not cpo+=l 
save
~/build/vim/runtime/syntax/gsp.vim  2012-01-08not cpo+=l 
sav