subject:"\[patch\] test_clientserver.vim and test_quotestar.vim fails in certain circumstances"

Re: [patch] test_clientserver.vim and test_quotestar.vim fails in certain circumstances

2017-03-25 Fir de Conversatie Kazunobu Kuriyama

2017-03-26 2:21 GMT+09:00 h_east :

> Hi,
>
> 2017-3-26(Sun) 2:08:41 UTC+9 Kazunobu Kuriyama:
> > 2017-03-26 1:52 GMT+09:00 h_east :
> >
> >
> > Hi,
> >
> >
> >
> > 2017-3-26(Sun) 1:15:07 UTC+9 Kazunobu Kuriyama:
> >
> >
> >
> > > 2017-03-26 0:49 GMT+09:00 h_east :
> >
> > >
> >
> > >
> >
> > > Hi Bram and list,
> >
> > >
> >
> > >
> >
> > >
> >
> > > 2017-3-24(Fri) 6:24:42 UTC+9 Bram Moolenaar:
> >
> > >
> >
> > >
> >
> > >
> >
> > > > I wrote:
> >
> > >
> >
> > > >
> >
> > >
> >
> > > > > Hirohito Higashi wrote:
> >
> > >
> >
> > > > >
> >
> > >
> >
> > > > > > > > > > My config:
> >
> > >
> >
> > > > > > > > > >   $ ./configure --with-features=huge --enable-gui=gnome2
> --enable-fail-if-missing
> >
> > >
> >
> > > > > > > > > > My env.:
> >
> > >
> >
> > > > > > > > > >   I am connecting to fedora 25 with ssh via PuTTY on
> Windows 7.
> >
> > >
> >
> > > > > > > > > > Vim version:
> >
> > >
> >
> > > > > > > > > >   8.0.502
> >
> > >
> >
> > > > > > > > > >
> >
> > >
> >
> > > > > > > > > > Executed command:
> >
> > >
> >
> > > > > > > > > >   $ cd vim/src
> >
> > >
> >
> > > > > > > > > >   $ make test
> >
> > >
> >
> > > > > > > > > >
> >
> > >
> >
> > > > > > > > > > Execution result:
> >
> > >
> >
> > > > > > > > > > I got the following error.
> >
> > >
> >
> > > > > > > > > > >8
> >
> > >
> >
> > > > > > > > > > Test results:
> >
> > >
> >
> > > > > > > > > >
> >
> > >
> >
> > > > > > > > > >
> >
> > >
> >
> > > > > > > > > > >From test_clientserver.vim:
> >
> > >
> >
> > > > > > > > > > Found errors in Test_client_server():
> >
> > >
> >
> > > > > > > > > > First run:
> >
> > >
> >
> > > > > > > > > > function RunTheTest[24]..Test_client_server line 17:
> Pattern 'XVIMTEST' does not match ''
> >
> > >
> >
> > > > > > > > > > Caught exception in Test_client_server():
> Vim(call):E240: No connection to the X server @ function
> RunTheTest[24]..Test_client_server, line 19
> >
> > >
> >
> > > > > > > > > > Second run:
> >
> > >
> >
> > > > > > > > > > function RunTheTest[24]..Test_client_server line 17:
> Pattern 'XVIMTEST' does not match ''
> >
> > >
> >
> > > > > > > > > > Caught exception in Test_client_server():
> Vim(call):E240: No connection to the X server @ function
> RunTheTest[24]..Test_client_server, line 19
> >
> > >
> >
> > > > > > > > >
> >
> > >
> >
> > > > > > > > > Why is there no connection to the X server?  Anyway, we
> could catch this
> >
> > >
> >
> > > > > > > > > error and give up.
> >
> > >
> >
> > > > > > > >
> >
> > >
> >
> > > > > > > > There might be the case one builds vim on a headless system.
> I.e.
> >
> > >
> >
> > > > > > > > some build servers of distro's?
> >
> > >
> >
> > > > > > >
> >
> > >
> >
> > > > > > > Can you try this patch:
> >
> > >
> >
> > > > > > >
> >
> > >
> >
> > > > > > >
> >
> > >
> >
> > > > > > > --- /home/mool/vim/git/vim80/src/testdir/test_clientserver.vim
> 2017-03-19 21:20:45.909034204 +0100
> >
> > >
> >
> > > > > > > +++ testdir/test_clientserver.vim   2017-03-22
> 22:19:57.761651837 +0100
> >
> > >
> >
> > > > > > > @@ -11,6 +11,12 @@
> >
> > >
> >
> > > > > > >if cmd == ''
> >
> > >
> >
> > > > > > >  return
> >
> > >
> >
> > > > > > >endif
> >
> > >
> >
> > > > > > > +  try
> >
> > >
> >
> > > > > > > +call serverlist()
> >
> > >
> >
> > > > > > > +  catch /E240:/
> >
> > >
> >
> > > > > > > +" No connection to the X server, give up.
> >
> > >
> >
> > > > > > > +finish
> >
> > >
> >
> > > > > > > +  endtry
> >
> > >
> >
> > > > > > >
> >
> > >
> >
> > > > > > >let name = 'XVIMTEST'
> >
> > >
> >
> > > > > > >let cmd .= ' --servername ' . name
> >
> > >
> >
> > > > > >
> >
> > >
> >
> > > > > > In my environment, `:call serverlist()` always succeed and
> returns the empty string.
> >
> > >
> >
> > > > > > So, above patch does not change the situation.
> >
> > >
> >
> > > > >
> >
> > >
> >
> > > > > It appears serverlist() can fail silently.
> >
> > >
> >
> > > > >
> >
> > >
> >
> > > > > Try this check instead:
> >
> > >
> >
> > > > >
> >
> > >
> >
> > > > > func Test_client_server()
> >
> > >
> >
> > > > >   let cmd = GetVimCommand()
> >
> > >
> >
> > > > >   if cmd == ''
> >
> > >
> >
> > > > > return
> >
> > >
> >
> > > > >   endif
> >
> > >
> >
> > > > >   if has('unix')
> >
> > >
> >
> > > > > try
> >
> > >
> >
> > > > >   call remote_send('xxx', '')
> >
> > >
> >
> > > > > catch
> >
> > >
> >
> > > > >   if v:exception =~ 'E240:'
> >
> > >
> >
> > > > > " No connection to the X server, give up.
> >
> > >
> >
> > > > > finish
> >
> > >
> >
> > > >
> >
> > >
> >
> > > > That should be "return".
> >
> > >
> >
> > > >
> >
> > >
> >
> > > > >   endif
> >
> > >
> >
> > > > >   " ignore other errors
> >
> > >
> >
> > > > > endtry
> >
> > >
> >
> > > > >   endif
> >
> > >
> >
> > >
> >
> > >
> >
> > > Thanks for the

Re: [patch] test_clientserver.vim and test_quotestar.vim fails in certain circumstances

2017-03-25 Fir de Conversatie h_east

Hi,

2017-3-26(Sun) 2:08:41 UTC+9 Kazunobu Kuriyama:
> 2017-03-26 1:52 GMT+09:00 h_east :
> 
> 
> Hi,
> 
> 
> 
> 2017-3-26(Sun) 1:15:07 UTC+9 Kazunobu Kuriyama:
> 
> 
> 
> > 2017-03-26 0:49 GMT+09:00 h_east :
> 
> >
> 
> >
> 
> > Hi Bram and list,
> 
> >
> 
> >
> 
> >
> 
> > 2017-3-24(Fri) 6:24:42 UTC+9 Bram Moolenaar:
> 
> >
> 
> >
> 
> >
> 
> > > I wrote:
> 
> >
> 
> > >
> 
> >
> 
> > > > Hirohito Higashi wrote:
> 
> >
> 
> > > >
> 
> >
> 
> > > > > > > > > My config:
> 
> >
> 
> > > > > > > > >   $ ./configure --with-features=huge --enable-gui=gnome2 
> > > > > > > > >--enable-fail-if-missing
> 
> >
> 
> > > > > > > > > My env.:
> 
> >
> 
> > > > > > > > >   I am connecting to fedora 25 with ssh via PuTTY on Windows 
> > > > > > > > >7.
> 
> >
> 
> > > > > > > > > Vim version:
> 
> >
> 
> > > > > > > > >   8.0.502
> 
> >
> 
> > > > > > > > >
> 
> >
> 
> > > > > > > > > Executed command:
> 
> >
> 
> > > > > > > > >   $ cd vim/src
> 
> >
> 
> > > > > > > > >   $ make test
> 
> >
> 
> > > > > > > > >
> 
> >
> 
> > > > > > > > > Execution result:
> 
> >
> 
> > > > > > > > > I got the following error.
> 
> >
> 
> > > > > > > > > >8
> 
> >
> 
> > > > > > > > > Test results:
> 
> >
> 
> > > > > > > > >
> 
> >
> 
> > > > > > > > >
> 
> >
> 
> > > > > > > > > >From test_clientserver.vim:
> 
> >
> 
> > > > > > > > > Found errors in Test_client_server():
> 
> >
> 
> > > > > > > > > First run:
> 
> >
> 
> > > > > > > > > function RunTheTest[24]..Test_client_server line 17: Pattern 
> > > > > > > > > 'XVIMTEST' does not match ''
> 
> >
> 
> > > > > > > > > Caught exception in Test_client_server(): Vim(call):E240: No 
> > > > > > > > > connection to the X server @ function 
> > > > > > > > > RunTheTest[24]..Test_client_server, line 19
> 
> >
> 
> > > > > > > > > Second run:
> 
> >
> 
> > > > > > > > > function RunTheTest[24]..Test_client_server line 17: Pattern 
> > > > > > > > > 'XVIMTEST' does not match ''
> 
> >
> 
> > > > > > > > > Caught exception in Test_client_server(): Vim(call):E240: No 
> > > > > > > > > connection to the X server @ function 
> > > > > > > > > RunTheTest[24]..Test_client_server, line 19
> 
> >
> 
> > > > > > > >
> 
> >
> 
> > > > > > > > Why is there no connection to the X server?  Anyway, we could 
> > > > > > > > catch this
> 
> >
> 
> > > > > > > > error and give up.
> 
> >
> 
> > > > > > >
> 
> >
> 
> > > > > > > There might be the case one builds vim on a headless system. I.e.
> 
> >
> 
> > > > > > > some build servers of distro's?
> 
> >
> 
> > > > > >
> 
> >
> 
> > > > > > Can you try this patch:
> 
> >
> 
> > > > > >
> 
> >
> 
> > > > > >
> 
> >
> 
> > > > > > --- /home/mool/vim/git/vim80/src/testdir/test_clientserver.vim  
> > > > > > 2017-03-19 21:20:45.909034204 +0100
> 
> >
> 
> > > > > > +++ testdir/test_clientserver.vim       2017-03-22 
> > > > > > 22:19:57.761651837 +0100
> 
> >
> 
> > > > > > @@ -11,6 +11,12 @@
> 
> >
> 
> > > > > >    if cmd == ''
> 
> >
> 
> > > > > >      return
> 
> >
> 
> > > > > >    endif
> 
> >
> 
> > > > > > +  try
> 
> >
> 
> > > > > > +    call serverlist()
> 
> >
> 
> > > > > > +  catch /E240:/
> 
> >
> 
> > > > > > +    " No connection to the X server, give up.
> 
> >
> 
> > > > > > +    finish
> 
> >
> 
> > > > > > +  endtry
> 
> >
> 
> > > > > >
> 
> >
> 
> > > > > >    let name = 'XVIMTEST'
> 
> >
> 
> > > > > >    let cmd .= ' --servername ' . name
> 
> >
> 
> > > > >
> 
> >
> 
> > > > > In my environment, `:call serverlist()` always succeed and returns 
> > > > > the empty string.
> 
> >
> 
> > > > > So, above patch does not change the situation.
> 
> >
> 
> > > >
> 
> >
> 
> > > > It appears serverlist() can fail silently.
> 
> >
> 
> > > >
> 
> >
> 
> > > > Try this check instead:
> 
> >
> 
> > > >
> 
> >
> 
> > > >     func Test_client_server()
> 
> >
> 
> > > >       let cmd = GetVimCommand()
> 
> >
> 
> > > >       if cmd == ''
> 
> >
> 
> > > >         return
> 
> >
> 
> > > >       endif
> 
> >
> 
> > > >       if has('unix')
> 
> >
> 
> > > >         try
> 
> >
> 
> > > >           call remote_send('xxx', '')
> 
> >
> 
> > > >         catch
> 
> >
> 
> > > >           if v:exception =~ 'E240:'
> 
> >
> 
> > > >             " No connection to the X server, give up.
> 
> >
> 
> > > >             finish
> 
> >
> 
> > >
> 
> >
> 
> > > That should be "return".
> 
> >
> 
> > >
> 
> >
> 
> > > >           endif
> 
> >
> 
> > > >           " ignore other errors
> 
> >
> 
> > > >         endtry
> 
> >
> 
> > > >       endif
> 
> >
> 
> >
> 
> >
> 
> > Thanks for the fixing this issue at Patch 8.0.0507 
> 
> >
> 
> >
> 
> >
> 
> > Please also fix the following one as reported first. I attached a patch.
> 
> >
> 
> >
> 
> >
> 
> > > Also, the following code is always true, so we should modify it.
> 
> >
> 
> > > src/testdir/test_quotestar.vim : 112
> 
> >
> 
> > >
> 
> >
> 
> > >   elseif !empty("$DISPLAY")
> 
> >
> 
> >
> 
> >
> 
> > Now that a TRY statement which checks whether or

Re: [patch] test_clientserver.vim and test_quotestar.vim fails in certain circumstances

2017-03-25 Fir de Conversatie Bram Moolenaar


Hirohito Higashi wrote:

> > > > > > > > My config:
> > > > > > > >   $ ./configure --with-features=huge --enable-gui=gnome2 
> > > > > > > > --enable-fail-if-missing
> > > > > > > > My env.:
> > > > > > > >   I am connecting to fedora 25 with ssh via PuTTY on Windows 7.
> > > > > > > > Vim version:
> > > > > > > >   8.0.502
> > > > > > > > 
> > > > > > > > Executed command:
> > > > > > > >   $ cd vim/src
> > > > > > > >   $ make test
> > > > > > > > 
> > > > > > > > Execution result:
> > > > > > > > I got the following error.
> > > > > > > > >8
> > > > > > > > Test results:
> > > > > > > > 
> > > > > > > > 
> > > > > > > > >From test_clientserver.vim:
> > > > > > > > Found errors in Test_client_server():
> > > > > > > > First run:
> > > > > > > > function RunTheTest[24]..Test_client_server line 17: Pattern 
> > > > > > > > 'XVIMTEST' does not match ''
> > > > > > > > Caught exception in Test_client_server(): Vim(call):E240: No 
> > > > > > > > connection to the X server @ function 
> > > > > > > > RunTheTest[24]..Test_client_server, line 19
> > > > > > > > Second run:
> > > > > > > > function RunTheTest[24]..Test_client_server line 17: Pattern 
> > > > > > > > 'XVIMTEST' does not match ''
> > > > > > > > Caught exception in Test_client_server(): Vim(call):E240: No 
> > > > > > > > connection to the X server @ function 
> > > > > > > > RunTheTest[24]..Test_client_server, line 19
> > > > > > > 
> > > > > > > Why is there no connection to the X server?  Anyway, we could 
> > > > > > > catch this
> > > > > > > error and give up.
> > > > > > 
> > > > > > There might be the case one builds vim on a headless system. I.e.
> > > > > > some build servers of distro's?
> > > > > 
> > > > > Can you try this patch:
> > > > > 
> > > > > 
> > > > > --- /home/mool/vim/git/vim80/src/testdir/test_clientserver.vim
> > > > > 2017-03-19 21:20:45.909034204 +0100
> > > > > +++ testdir/test_clientserver.vim 2017-03-22 22:19:57.761651837 
> > > > > +0100
> > > > > @@ -11,6 +11,12 @@
> > > > >if cmd == ''
> > > > >  return
> > > > >endif
> > > > > +  try
> > > > > +call serverlist()
> > > > > +  catch /E240:/
> > > > > +" No connection to the X server, give up.
> > > > > +finish
> > > > > +  endtry
> > > > >  
> > > > >let name = 'XVIMTEST'
> > > > >let cmd .= ' --servername ' . name
> > > > 
> > > > In my environment, `:call serverlist()` always succeed and returns the 
> > > > empty string.
> > > > So, above patch does not change the situation.
> > > 
> > > It appears serverlist() can fail silently.
> > > 
> > > Try this check instead:
> > > 
> > >   func Test_client_server()
> > > let cmd = GetVimCommand()
> > > if cmd == ''
> > >   return
> > > endif
> > > if has('unix')
> > >   try
> > > call remote_send('xxx', '')
> > >   catch
> > > if v:exception =~ 'E240:'
> > >   " No connection to the X server, give up.
> > >   finish
> > 
> > That should be "return".
> > 
> > > endif
> > > " ignore other errors
> > >   endtry
> > > endif
> 
> Thanks for the fixing this issue at Patch 8.0.0507 ߑ 
> 
> Please also fix the following one as reported first. I attached a patch.

Thanks.  Let's be a bit more specific with the error message.  On unix
$DISPLAY not set means we can't run the test, even when Vim has the
necessary features.

As Kazunobu suggested, checking for "x11" is the most accurate.

-- 
hundred-and-one symptoms of being an internet addict:
212. Your Internet group window has more icons than your Accessories window.

 /// Bram Moolenaar -- b...@moolenaar.net -- http://www.Moolenaar.net   \\\
///sponsor Vim, vote for features -- http://www.Vim.org/sponsor/ \\\
\\\  an exciting new programming language -- http://www.Zimbu.org///
 \\\help me help AIDS victims -- http://ICCF-Holland.org///

-- 
-- 
You received this message from the "vim_dev" maillist.
Do not top-post! Type your reply below the text you are replying to.
For more information, visit http://www.vim.org/maillist.php

--- 
You received this message because you are subscribed to the Google Groups 
"vim_dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to vim_dev+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

Re: [patch] test_clientserver.vim and test_quotestar.vim fails in certain circumstances

2017-03-25 Fir de Conversatie Kazunobu Kuriyama

2017-03-26 1:52 GMT+09:00 h_east :

> Hi,
>
> 2017-3-26(Sun) 1:15:07 UTC+9 Kazunobu Kuriyama:
> > 2017-03-26 0:49 GMT+09:00 h_east :
> >
> >
> > Hi Bram and list,
> >
> >
> >
> > 2017-3-24(Fri) 6:24:42 UTC+9 Bram Moolenaar:
> >
> >
> >
> > > I wrote:
> >
> > >
> >
> > > > Hirohito Higashi wrote:
> >
> > > >
> >
> > > > > > > > > My config:
> >
> > > > > > > > >   $ ./configure --with-features=huge --enable-gui=gnome2
> --enable-fail-if-missing
> >
> > > > > > > > > My env.:
> >
> > > > > > > > >   I am connecting to fedora 25 with ssh via PuTTY on
> Windows 7.
> >
> > > > > > > > > Vim version:
> >
> > > > > > > > >   8.0.502
> >
> > > > > > > > >
> >
> > > > > > > > > Executed command:
> >
> > > > > > > > >   $ cd vim/src
> >
> > > > > > > > >   $ make test
> >
> > > > > > > > >
> >
> > > > > > > > > Execution result:
> >
> > > > > > > > > I got the following error.
> >
> > > > > > > > > >8
> >
> > > > > > > > > Test results:
> >
> > > > > > > > >
> >
> > > > > > > > >
> >
> > > > > > > > > >From test_clientserver.vim:
> >
> > > > > > > > > Found errors in Test_client_server():
> >
> > > > > > > > > First run:
> >
> > > > > > > > > function RunTheTest[24]..Test_client_server line 17:
> Pattern 'XVIMTEST' does not match ''
> >
> > > > > > > > > Caught exception in Test_client_server(): Vim(call):E240:
> No connection to the X server @ function RunTheTest[24]..Test_client_server,
> line 19
> >
> > > > > > > > > Second run:
> >
> > > > > > > > > function RunTheTest[24]..Test_client_server line 17:
> Pattern 'XVIMTEST' does not match ''
> >
> > > > > > > > > Caught exception in Test_client_server(): Vim(call):E240:
> No connection to the X server @ function RunTheTest[24]..Test_client_server,
> line 19
> >
> > > > > > > >
> >
> > > > > > > > Why is there no connection to the X server?  Anyway, we
> could catch this
> >
> > > > > > > > error and give up.
> >
> > > > > > >
> >
> > > > > > > There might be the case one builds vim on a headless system.
> I.e.
> >
> > > > > > > some build servers of distro's?
> >
> > > > > >
> >
> > > > > > Can you try this patch:
> >
> > > > > >
> >
> > > > > >
> >
> > > > > > --- /home/mool/vim/git/vim80/src/testdir/test_clientserver.vim
> 2017-03-19 21:20:45.909034204 +0100
> >
> > > > > > +++ testdir/test_clientserver.vim   2017-03-22
> 22:19:57.761651837 +0100
> >
> > > > > > @@ -11,6 +11,12 @@
> >
> > > > > >if cmd == ''
> >
> > > > > >  return
> >
> > > > > >endif
> >
> > > > > > +  try
> >
> > > > > > +call serverlist()
> >
> > > > > > +  catch /E240:/
> >
> > > > > > +" No connection to the X server, give up.
> >
> > > > > > +finish
> >
> > > > > > +  endtry
> >
> > > > > >
> >
> > > > > >let name = 'XVIMTEST'
> >
> > > > > >let cmd .= ' --servername ' . name
> >
> > > > >
> >
> > > > > In my environment, `:call serverlist()` always succeed and returns
> the empty string.
> >
> > > > > So, above patch does not change the situation.
> >
> > > >
> >
> > > > It appears serverlist() can fail silently.
> >
> > > >
> >
> > > > Try this check instead:
> >
> > > >
> >
> > > > func Test_client_server()
> >
> > > >   let cmd = GetVimCommand()
> >
> > > >   if cmd == ''
> >
> > > > return
> >
> > > >   endif
> >
> > > >   if has('unix')
> >
> > > > try
> >
> > > >   call remote_send('xxx', '')
> >
> > > > catch
> >
> > > >   if v:exception =~ 'E240:'
> >
> > > > " No connection to the X server, give up.
> >
> > > > finish
> >
> > >
> >
> > > That should be "return".
> >
> > >
> >
> > > >   endif
> >
> > > >   " ignore other errors
> >
> > > > endtry
> >
> > > >   endif
> >
> >
> >
> > Thanks for the fixing this issue at Patch 8.0.0507 
> >
> >
> >
> > Please also fix the following one as reported first. I attached a patch.
> >
> >
> >
> > > Also, the following code is always true, so we should modify it.
> >
> > > src/testdir/test_quotestar.vim : 112
> >
> > >
> >
> > >   elseif !empty("$DISPLAY")
> >
> >
> >
> > Now that a TRY statement which checks whether or not a connection to the
> X server is established at runtime is added, that ELSEIF condition would be
> better replaced with has('x11'); otherwise, it's simply redundant and the
> statement which is to be thrown at the succeeding ELSE statement wouldn't
> make sense.
>
> Since Do_test_quotestar_for_x11() is executed on Windows, right?
>

No.


> If yes then it is better to change the function name.
>
> --
> Best regards,
> Hirohito Higashi (a.k.a. h_east)
>
> --
> --
> You received this message from the "vim_dev" maillist.
> Do not top-post! Type your reply below the text you are replying to.
> For more information, visit http://www.vim.org/maillist.php
>
> ---
> You received this message because you are subscribed to the Google Groups
> "vim_dev" group.
> To unsubscribe from this group and stop receiving emails from it,

Re: [patch] test_clientserver.vim and test_quotestar.vim fails in certain circumstances

2017-03-25 Fir de Conversatie h_east

Hi,

2017-3-26(Sun) 1:15:07 UTC+9 Kazunobu Kuriyama:
> 2017-03-26 0:49 GMT+09:00 h_east :
> 
> 
> Hi Bram and list,
> 
> 
> 
> 2017-3-24(Fri) 6:24:42 UTC+9 Bram Moolenaar:
> 
> 
> 
> > I wrote:
> 
> >
> 
> > > Hirohito Higashi wrote:
> 
> > >
> 
> > > > > > > > My config:
> 
> > > > > > > >   $ ./configure --with-features=huge --enable-gui=gnome2 
> > > > > > > >--enable-fail-if-missing
> 
> > > > > > > > My env.:
> 
> > > > > > > >   I am connecting to fedora 25 with ssh via PuTTY on Windows 7.
> 
> > > > > > > > Vim version:
> 
> > > > > > > >   8.0.502
> 
> > > > > > > >
> 
> > > > > > > > Executed command:
> 
> > > > > > > >   $ cd vim/src
> 
> > > > > > > >   $ make test
> 
> > > > > > > >
> 
> > > > > > > > Execution result:
> 
> > > > > > > > I got the following error.
> 
> > > > > > > > >8
> 
> > > > > > > > Test results:
> 
> > > > > > > >
> 
> > > > > > > >
> 
> > > > > > > > >From test_clientserver.vim:
> 
> > > > > > > > Found errors in Test_client_server():
> 
> > > > > > > > First run:
> 
> > > > > > > > function RunTheTest[24]..Test_client_server line 17: Pattern 
> > > > > > > > 'XVIMTEST' does not match ''
> 
> > > > > > > > Caught exception in Test_client_server(): Vim(call):E240: No 
> > > > > > > > connection to the X server @ function 
> > > > > > > > RunTheTest[24]..Test_client_server, line 19
> 
> > > > > > > > Second run:
> 
> > > > > > > > function RunTheTest[24]..Test_client_server line 17: Pattern 
> > > > > > > > 'XVIMTEST' does not match ''
> 
> > > > > > > > Caught exception in Test_client_server(): Vim(call):E240: No 
> > > > > > > > connection to the X server @ function 
> > > > > > > > RunTheTest[24]..Test_client_server, line 19
> 
> > > > > > >
> 
> > > > > > > Why is there no connection to the X server?  Anyway, we could 
> > > > > > > catch this
> 
> > > > > > > error and give up.
> 
> > > > > >
> 
> > > > > > There might be the case one builds vim on a headless system. I.e.
> 
> > > > > > some build servers of distro's?
> 
> > > > >
> 
> > > > > Can you try this patch:
> 
> > > > >
> 
> > > > >
> 
> > > > > --- /home/mool/vim/git/vim80/src/testdir/test_clientserver.vim  
> > > > > 2017-03-19 21:20:45.909034204 +0100
> 
> > > > > +++ testdir/test_clientserver.vim       2017-03-22 22:19:57.761651837 
> > > > > +0100
> 
> > > > > @@ -11,6 +11,12 @@
> 
> > > > >    if cmd == ''
> 
> > > > >      return
> 
> > > > >    endif
> 
> > > > > +  try
> 
> > > > > +    call serverlist()
> 
> > > > > +  catch /E240:/
> 
> > > > > +    " No connection to the X server, give up.
> 
> > > > > +    finish
> 
> > > > > +  endtry
> 
> > > > >
> 
> > > > >    let name = 'XVIMTEST'
> 
> > > > >    let cmd .= ' --servername ' . name
> 
> > > >
> 
> > > > In my environment, `:call serverlist()` always succeed and returns the 
> > > > empty string.
> 
> > > > So, above patch does not change the situation.
> 
> > >
> 
> > > It appears serverlist() can fail silently.
> 
> > >
> 
> > > Try this check instead:
> 
> > >
> 
> > >     func Test_client_server()
> 
> > >       let cmd = GetVimCommand()
> 
> > >       if cmd == ''
> 
> > >         return
> 
> > >       endif
> 
> > >       if has('unix')
> 
> > >         try
> 
> > >           call remote_send('xxx', '')
> 
> > >         catch
> 
> > >           if v:exception =~ 'E240:'
> 
> > >             " No connection to the X server, give up.
> 
> > >             finish
> 
> >
> 
> > That should be "return".
> 
> >
> 
> > >           endif
> 
> > >           " ignore other errors
> 
> > >         endtry
> 
> > >       endif
> 
> 
> 
> Thanks for the fixing this issue at Patch 8.0.0507 
> 
> 
> 
> Please also fix the following one as reported first. I attached a patch.
> 
> 
> 
> > Also, the following code is always true, so we should modify it.
> 
> > src/testdir/test_quotestar.vim : 112
> 
> >
> 
> >   elseif !empty("$DISPLAY")
> 
> 
> 
> Now that a TRY statement which checks whether or not a connection to the X 
> server is established at runtime is added, that ELSEIF condition would be 
> better replaced with has('x11'); otherwise, it's simply redundant and the 
> statement which is to be thrown at the succeeding ELSE statement wouldn't 
> make sense.

Since Do_test_quotestar_for_x11() is executed on Windows, right?
If yes then it is better to change the function name.

--
Best regards,
Hirohito Higashi (a.k.a. h_east)

-- 
-- 
You received this message from the "vim_dev" maillist.
Do not top-post! Type your reply below the text you are replying to.
For more information, visit http://www.vim.org/maillist.php

--- 
You received this message because you are subscribed to the Google Groups 
"vim_dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to vim_dev+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

Re: [patch] test_clientserver.vim and test_quotestar.vim fails in certain circumstances

2017-03-25 Fir de Conversatie Kazunobu Kuriyama

2017-03-26 0:49 GMT+09:00 h_east :

> Hi Bram and list,
>
> 2017-3-24(Fri) 6:24:42 UTC+9 Bram Moolenaar:
> > I wrote:
> >
> > > Hirohito Higashi wrote:
> > >
> > > > > > > > My config:
> > > > > > > >   $ ./configure --with-features=huge --enable-gui=gnome2
> --enable-fail-if-missing
> > > > > > > > My env.:
> > > > > > > >   I am connecting to fedora 25 with ssh via PuTTY on Windows
> 7.
> > > > > > > > Vim version:
> > > > > > > >   8.0.502
> > > > > > > >
> > > > > > > > Executed command:
> > > > > > > >   $ cd vim/src
> > > > > > > >   $ make test
> > > > > > > >
> > > > > > > > Execution result:
> > > > > > > > I got the following error.
> > > > > > > > >8
> > > > > > > > Test results:
> > > > > > > >
> > > > > > > >
> > > > > > > > >From test_clientserver.vim:
> > > > > > > > Found errors in Test_client_server():
> > > > > > > > First run:
> > > > > > > > function RunTheTest[24]..Test_client_server line 17:
> Pattern 'XVIMTEST' does not match ''
> > > > > > > > Caught exception in Test_client_server(): Vim(call):E240: No
> connection to the X server @ function RunTheTest[24]..Test_client_server,
> line 19
> > > > > > > > Second run:
> > > > > > > > function RunTheTest[24]..Test_client_server line 17:
> Pattern 'XVIMTEST' does not match ''
> > > > > > > > Caught exception in Test_client_server(): Vim(call):E240: No
> connection to the X server @ function RunTheTest[24]..Test_client_server,
> line 19
> > > > > > >
> > > > > > > Why is there no connection to the X server?  Anyway, we could
> catch this
> > > > > > > error and give up.
> > > > > >
> > > > > > There might be the case one builds vim on a headless system. I.e.
> > > > > > some build servers of distro's?
> > > > >
> > > > > Can you try this patch:
> > > > >
> > > > >
> > > > > --- /home/mool/vim/git/vim80/src/testdir/test_clientserver.vim
> 2017-03-19 21:20:45.909034204 +0100
> > > > > +++ testdir/test_clientserver.vim   2017-03-22
> 22:19:57.761651837 +0100
> > > > > @@ -11,6 +11,12 @@
> > > > >if cmd == ''
> > > > >  return
> > > > >endif
> > > > > +  try
> > > > > +call serverlist()
> > > > > +  catch /E240:/
> > > > > +" No connection to the X server, give up.
> > > > > +finish
> > > > > +  endtry
> > > > >
> > > > >let name = 'XVIMTEST'
> > > > >let cmd .= ' --servername ' . name
> > > >
> > > > In my environment, `:call serverlist()` always succeed and returns
> the empty string.
> > > > So, above patch does not change the situation.
> > >
> > > It appears serverlist() can fail silently.
> > >
> > > Try this check instead:
> > >
> > > func Test_client_server()
> > >   let cmd = GetVimCommand()
> > >   if cmd == ''
> > > return
> > >   endif
> > >   if has('unix')
> > > try
> > >   call remote_send('xxx', '')
> > > catch
> > >   if v:exception =~ 'E240:'
> > > " No connection to the X server, give up.
> > > finish
> >
> > That should be "return".
> >
> > >   endif
> > >   " ignore other errors
> > > endtry
> > >   endif
>
> Thanks for the fixing this issue at Patch 8.0.0507 
>
> Please also fix the following one as reported first. I attached a patch.
>
> > Also, the following code is always true, so we should modify it.
> > src/testdir/test_quotestar.vim : 112
> >
> >   elseif !empty("$DISPLAY")
>

Now that a TRY statement which checks whether or not a connection to the X
server is established at runtime is added, that ELSEIF condition would be
better replaced with has('x11'); otherwise, it's simply redundant and the
statement which is to be thrown at the succeeding ELSE statement wouldn't
make sense.


> --
> Best regards,
> Hirohito Higashi (a.k.a. h_east)
>
> --
> --
> You received this message from the "vim_dev" maillist.
> Do not top-post! Type your reply below the text you are replying to.
> For more information, visit http://www.vim.org/maillist.php
>
> ---
> You received this message because you are subscribed to the Google Groups
> "vim_dev" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to vim_dev+unsubscr...@googlegroups.com.
> For more options, visit https://groups.google.com/d/optout.
>

-- 
-- 
You received this message from the "vim_dev" maillist.
Do not top-post! Type your reply below the text you are replying to.
For more information, visit http://www.vim.org/maillist.php

--- 
You received this message because you are subscribed to the Google Groups 
"vim_dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to vim_dev+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

Re: [patch] test_clientserver.vim and test_quotestar.vim fails in certain circumstances

2017-03-25 Fir de Conversatie h_east

Hi Bram and list,

2017-3-24(Fri) 6:24:42 UTC+9 Bram Moolenaar:
> I wrote:
> 
> > Hirohito Higashi wrote:
> > 
> > > > > > > My config:
> > > > > > >   $ ./configure --with-features=huge --enable-gui=gnome2 
> > > > > > > --enable-fail-if-missing
> > > > > > > My env.:
> > > > > > >   I am connecting to fedora 25 with ssh via PuTTY on Windows 7.
> > > > > > > Vim version:
> > > > > > >   8.0.502
> > > > > > > 
> > > > > > > Executed command:
> > > > > > >   $ cd vim/src
> > > > > > >   $ make test
> > > > > > > 
> > > > > > > Execution result:
> > > > > > > I got the following error.
> > > > > > > >8
> > > > > > > Test results:
> > > > > > > 
> > > > > > > 
> > > > > > > >From test_clientserver.vim:
> > > > > > > Found errors in Test_client_server():
> > > > > > > First run:
> > > > > > > function RunTheTest[24]..Test_client_server line 17: Pattern 
> > > > > > > 'XVIMTEST' does not match ''
> > > > > > > Caught exception in Test_client_server(): Vim(call):E240: No 
> > > > > > > connection to the X server @ function 
> > > > > > > RunTheTest[24]..Test_client_server, line 19
> > > > > > > Second run:
> > > > > > > function RunTheTest[24]..Test_client_server line 17: Pattern 
> > > > > > > 'XVIMTEST' does not match ''
> > > > > > > Caught exception in Test_client_server(): Vim(call):E240: No 
> > > > > > > connection to the X server @ function 
> > > > > > > RunTheTest[24]..Test_client_server, line 19
> > > > > > 
> > > > > > Why is there no connection to the X server?  Anyway, we could catch 
> > > > > > this
> > > > > > error and give up.
> > > > > 
> > > > > There might be the case one builds vim on a headless system. I.e.
> > > > > some build servers of distro's?
> > > > 
> > > > Can you try this patch:
> > > > 
> > > > 
> > > > --- /home/mool/vim/git/vim80/src/testdir/test_clientserver.vim  
> > > > 2017-03-19 21:20:45.909034204 +0100
> > > > +++ testdir/test_clientserver.vim   2017-03-22 22:19:57.761651837 
> > > > +0100
> > > > @@ -11,6 +11,12 @@
> > > >if cmd == ''
> > > >  return
> > > >endif
> > > > +  try
> > > > +call serverlist()
> > > > +  catch /E240:/
> > > > +" No connection to the X server, give up.
> > > > +finish
> > > > +  endtry
> > > >  
> > > >let name = 'XVIMTEST'
> > > >let cmd .= ' --servername ' . name
> > > 
> > > In my environment, `:call serverlist()` always succeed and returns the 
> > > empty string.
> > > So, above patch does not change the situation.
> > 
> > It appears serverlist() can fail silently.
> > 
> > Try this check instead:
> > 
> > func Test_client_server()
> >   let cmd = GetVimCommand()
> >   if cmd == ''
> > return
> >   endif
> >   if has('unix')
> > try
> >   call remote_send('xxx', '')
> > catch
> >   if v:exception =~ 'E240:'
> > " No connection to the X server, give up.
> > finish
> 
> That should be "return".
> 
> >   endif
> >   " ignore other errors
> > endtry
> >   endif

Thanks for the fixing this issue at Patch 8.0.0507 

Please also fix the following one as reported first. I attached a patch.

> Also, the following code is always true, so we should modify it.
> src/testdir/test_quotestar.vim : 112
> 
>   elseif !empty("$DISPLAY")

--
Best regards,
Hirohito Higashi (a.k.a. h_east)

-- 
-- 
You received this message from the "vim_dev" maillist.
Do not top-post! Type your reply below the text you are replying to.
For more information, visit http://www.vim.org/maillist.php

--- 
You received this message because you are subscribed to the Google Groups 
"vim_dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to vim_dev+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.
diff --git a/src/testdir/test_quotestar.vim b/src/testdir/test_quotestar.vim
index 6e4e4ca..7eb6d0d 100644
--- a/src/testdir/test_quotestar.vim
+++ b/src/testdir/test_quotestar.vim
@@ -118,7 +118,7 @@ func Test_quotestar()
 
   if has('macunix')
 let skipped = Do_test_quotestar_for_macunix()
-  elseif !empty("$DISPLAY")
+  elseif !empty($DISPLAY)
 let skipped = Do_test_quotestar_for_x11()
   else
 let skipped = "Test is not implemented yet for this platform."

Re: [patch] test_clientserver.vim and test_quotestar.vim fails in certain circumstances

2017-03-23 Fir de Conversatie Bram Moolenaar



I wrote:

> Hirohito Higashi wrote:
> 
> > > > > > My config:
> > > > > >   $ ./configure --with-features=huge --enable-gui=gnome2 
> > > > > > --enable-fail-if-missing
> > > > > > My env.:
> > > > > >   I am connecting to fedora 25 with ssh via PuTTY on Windows 7.
> > > > > > Vim version:
> > > > > >   8.0.502
> > > > > > 
> > > > > > Executed command:
> > > > > >   $ cd vim/src
> > > > > >   $ make test
> > > > > > 
> > > > > > Execution result:
> > > > > > I got the following error.
> > > > > > >8
> > > > > > Test results:
> > > > > > 
> > > > > > 
> > > > > > >From test_clientserver.vim:
> > > > > > Found errors in Test_client_server():
> > > > > > First run:
> > > > > > function RunTheTest[24]..Test_client_server line 17: Pattern 
> > > > > > 'XVIMTEST' does not match ''
> > > > > > Caught exception in Test_client_server(): Vim(call):E240: No 
> > > > > > connection to the X server @ function 
> > > > > > RunTheTest[24]..Test_client_server, line 19
> > > > > > Second run:
> > > > > > function RunTheTest[24]..Test_client_server line 17: Pattern 
> > > > > > 'XVIMTEST' does not match ''
> > > > > > Caught exception in Test_client_server(): Vim(call):E240: No 
> > > > > > connection to the X server @ function 
> > > > > > RunTheTest[24]..Test_client_server, line 19
> > > > > 
> > > > > Why is there no connection to the X server?  Anyway, we could catch 
> > > > > this
> > > > > error and give up.
> > > > 
> > > > There might be the case one builds vim on a headless system. I.e.
> > > > some build servers of distro's?
> > > 
> > > Can you try this patch:
> > > 
> > > 
> > > --- /home/mool/vim/git/vim80/src/testdir/test_clientserver.vim
> > > 2017-03-19 21:20:45.909034204 +0100
> > > +++ testdir/test_clientserver.vim 2017-03-22 22:19:57.761651837 +0100
> > > @@ -11,6 +11,12 @@
> > >if cmd == ''
> > >  return
> > >endif
> > > +  try
> > > +call serverlist()
> > > +  catch /E240:/
> > > +" No connection to the X server, give up.
> > > +finish
> > > +  endtry
> > >  
> > >let name = 'XVIMTEST'
> > >let cmd .= ' --servername ' . name
> > 
> > In my environment, `:call serverlist()` always succeed and returns the 
> > empty string.
> > So, above patch does not change the situation.
> 
> It appears serverlist() can fail silently.
> 
> Try this check instead:
> 
>   func Test_client_server()
> let cmd = GetVimCommand()
> if cmd == ''
>   return
> endif
> if has('unix')
>   try
> call remote_send('xxx', '')
>   catch
> if v:exception =~ 'E240:'
>   " No connection to the X server, give up.
>   finish

That should be "return".

> endif
> " ignore other errors
>   endtry
> endif

-- 
Some of the well known MS-Windows errors:
EHUHUnexpected error
EUSER   User error, not our fault!
EGODHorrible problem, god knows what has happened
EERRErrornous error: nothing wrong

 /// Bram Moolenaar -- b...@moolenaar.net -- http://www.Moolenaar.net   \\\
///sponsor Vim, vote for features -- http://www.Vim.org/sponsor/ \\\
\\\  an exciting new programming language -- http://www.Zimbu.org///
 \\\help me help AIDS victims -- http://ICCF-Holland.org///

-- 
-- 
You received this message from the "vim_dev" maillist.
Do not top-post! Type your reply below the text you are replying to.
For more information, visit http://www.vim.org/maillist.php

--- 
You received this message because you are subscribed to the Google Groups 
"vim_dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to vim_dev+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

Re: [patch] test_clientserver.vim and test_quotestar.vim fails in certain circumstances

2017-03-23 Fir de Conversatie Bram Moolenaar


Hirohito Higashi wrote:

> > > > > My config:
> > > > >   $ ./configure --with-features=huge --enable-gui=gnome2 
> > > > > --enable-fail-if-missing
> > > > > My env.:
> > > > >   I am connecting to fedora 25 with ssh via PuTTY on Windows 7.
> > > > > Vim version:
> > > > >   8.0.502
> > > > > 
> > > > > Executed command:
> > > > >   $ cd vim/src
> > > > >   $ make test
> > > > > 
> > > > > Execution result:
> > > > > I got the following error.
> > > > > >8
> > > > > Test results:
> > > > > 
> > > > > 
> > > > > >From test_clientserver.vim:
> > > > > Found errors in Test_client_server():
> > > > > First run:
> > > > > function RunTheTest[24]..Test_client_server line 17: Pattern 
> > > > > 'XVIMTEST' does not match ''
> > > > > Caught exception in Test_client_server(): Vim(call):E240: No 
> > > > > connection to the X server @ function 
> > > > > RunTheTest[24]..Test_client_server, line 19
> > > > > Second run:
> > > > > function RunTheTest[24]..Test_client_server line 17: Pattern 
> > > > > 'XVIMTEST' does not match ''
> > > > > Caught exception in Test_client_server(): Vim(call):E240: No 
> > > > > connection to the X server @ function 
> > > > > RunTheTest[24]..Test_client_server, line 19
> > > > 
> > > > Why is there no connection to the X server?  Anyway, we could catch this
> > > > error and give up.
> > > 
> > > There might be the case one builds vim on a headless system. I.e.
> > > some build servers of distro's?
> > 
> > Can you try this patch:
> > 
> > 
> > --- /home/mool/vim/git/vim80/src/testdir/test_clientserver.vim  
> > 2017-03-19 21:20:45.909034204 +0100
> > +++ testdir/test_clientserver.vim   2017-03-22 22:19:57.761651837 +0100
> > @@ -11,6 +11,12 @@
> >if cmd == ''
> >  return
> >endif
> > +  try
> > +call serverlist()
> > +  catch /E240:/
> > +" No connection to the X server, give up.
> > +finish
> > +  endtry
> >  
> >let name = 'XVIMTEST'
> >let cmd .= ' --servername ' . name
> 
> In my environment, `:call serverlist()` always succeed and returns the empty 
> string.
> So, above patch does not change the situation.

It appears serverlist() can fail silently.

Try this check instead:

func Test_client_server()
  let cmd = GetVimCommand()
  if cmd == ''
return
  endif
  if has('unix')
try
  call remote_send('xxx', '')
catch
  if v:exception =~ 'E240:'
" No connection to the X server, give up.
finish
  endif
  " ignore other errors
endtry
  endif


-- 
Some of the well known MS-Windows errors:
ESLEEP  Operator fell asleep
ENOERR  No error yet
EDOLLAR OS too expensive
EWINDOWSMS-Windows loaded, system in danger

 /// Bram Moolenaar -- b...@moolenaar.net -- http://www.Moolenaar.net   \\\
///sponsor Vim, vote for features -- http://www.Vim.org/sponsor/ \\\
\\\  an exciting new programming language -- http://www.Zimbu.org///
 \\\help me help AIDS victims -- http://ICCF-Holland.org///

-- 
-- 
You received this message from the "vim_dev" maillist.
Do not top-post! Type your reply below the text you are replying to.
For more information, visit http://www.vim.org/maillist.php

--- 
You received this message because you are subscribed to the Google Groups 
"vim_dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to vim_dev+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

Re: [patch] test_clientserver.vim and test_quotestar.vim fails in certain circumstances

2017-03-23 Fir de Conversatie Kazunobu Kuriyama

2017-03-23 22:41 GMT+09:00 Elimar Riesebieter :

> * Kazunobu Kuriyama  [2017-03-23 21:58
> +0900]:
>
> > 2017-03-23 21:22 GMT+09:00 h_east :
> [...]
> > > > So, the result of test_clientserver looks as if the patch were not
> > > >included.  I'm wondering if the test was done with the patched
> > > >test_clientserver.vim.
>
> The patch is indeed applied. The built was done remote.
>
> > > As in mentoring a few hours ago, in my environment `:echo serverlist()`
> > > will not raise exceptions.
> > > Unfortunately, your guess is out of hand.
> > >
> >
> > I distinguish Elimar Riesebieter's issue from yours; the former is about
> a
> > headless system where X11 can't run; the latter about an environment
> where
> > the test suite tries to run X11 on a remote system (i.e., something
> > unusual) via an ssh connection from Windows and fails for some reason.
> >
> > I thought Bram tried to address the former issue.
>
> Of course yet, but IMHO both cases should be addressed.
>
> Elimar
> --
>

Personally, I don't think it's a good idea to run the test suite on a
system which is incapable of hosting the whole tests, because tests
executed on such a system should not deserve "ALL DONE."


> .~.
> /V\   L   I   N   U   X
>/( )\ >Phear the Penguin<
>^^-^^
>
> --
> --
> You received this message from the "vim_dev" maillist.
> Do not top-post! Type your reply below the text you are replying to.
> For more information, visit http://www.vim.org/maillist.php
>
> ---
> You received this message because you are subscribed to the Google Groups
> "vim_dev" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to vim_dev+unsubscr...@googlegroups.com.
> For more options, visit https://groups.google.com/d/optout.
>

-- 
-- 
You received this message from the "vim_dev" maillist.
Do not top-post! Type your reply below the text you are replying to.
For more information, visit http://www.vim.org/maillist.php

--- 
You received this message because you are subscribed to the Google Groups 
"vim_dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to vim_dev+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

Re: [patch] test_clientserver.vim and test_quotestar.vim fails in certain circumstances

2017-03-23 Fir de Conversatie Elimar Riesebieter

* Kazunobu Kuriyama  [2017-03-23 21:58 +0900]:

> 2017-03-23 21:22 GMT+09:00 h_east :
[...]
> > > So, the result of test_clientserver looks as if the patch were not
> > >included.  I'm wondering if the test was done with the patched
> > >test_clientserver.vim.

The patch is indeed applied. The built was done remote.

> > As in mentoring a few hours ago, in my environment `:echo serverlist()`
> > will not raise exceptions.
> > Unfortunately, your guess is out of hand.
> >
> 
> I distinguish Elimar Riesebieter's issue from yours; the former is about a
> headless system where X11 can't run; the latter about an environment where
> the test suite tries to run X11 on a remote system (i.e., something
> unusual) via an ssh connection from Windows and fails for some reason.
> 
> I thought Bram tried to address the former issue.

Of course yet, but IMHO both cases should be addressed.

Elimar
-- 
.~.
/V\   L   I   N   U   X
   /( )\ >Phear the Penguin<
   ^^-^^

-- 
-- 
You received this message from the "vim_dev" maillist.
Do not top-post! Type your reply below the text you are replying to.
For more information, visit http://www.vim.org/maillist.php

--- 
You received this message because you are subscribed to the Google Groups 
"vim_dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to vim_dev+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

Re: [patch] test_clientserver.vim and test_quotestar.vim fails in certain circumstances

2017-03-23 Fir de Conversatie Kazunobu Kuriyama

2017-03-23 21:22 GMT+09:00 h_east :

> Hi Kazunobu and all,
>
> 2017-3-23(Thu) 21:01:32 UTC+9 Kazunobu Kuriyama:
> > 2017-03-23 18:13 GMT+09:00 Elimar Riesebieter :
> >
> >
> > * Bram Moolenaar  [2017-03-22 22:30 +0100]:
> >
> >
> >
> >
> >
> > >
> >
> > > Elimar Riesebieter wrote:
> >
> > >
> >
> > > > > Hirohito Higashi wrote:
> >
> > > > >
> >
> > > > > > My config:
> >
> > > > > >   $ ./configure --with-features=huge --enable-gui=gnome2
> --enable-fail-if-missing
> >
> > > > > > My env.:
> >
> > > > > >   I am connecting to fedora 25 with ssh via PuTTY on Windows 7.
> >
> > > > > > Vim version:
> >
> > > > > >   8.0.502
> >
> > > > > >
> >
> > > > > > Executed command:
> >
> > > > > >   $ cd vim/src
> >
> > > > > >   $ make test
> >
> > > > > >
> >
> > > > > > Execution result:
> >
> > > > > > I got the following error.
> >
> > > > > > >8
> >
> > > > > > Test results:
> >
> > > > > >
> >
> > > > > >
> >
> > > > > > >From test_clientserver.vim:
> >
> > > > > > Found errors in Test_client_server():
> >
> > > > > > First run:
> >
> > > > > > function RunTheTest[24]..Test_client_server line 17: Pattern
> 'XVIMTEST' does not match ''
> >
> > > > > > Caught exception in Test_client_server(): Vim(call):E240: No
> connection to the X server @ function RunTheTest[24]..Test_client_server,
> line 19
> >
> > > > > > Second run:
> >
> > > > > > function RunTheTest[24]..Test_client_server line 17: Pattern
> 'XVIMTEST' does not match ''
> >
> > > > > > Caught exception in Test_client_server(): Vim(call):E240: No
> connection to the X server @ function RunTheTest[24]..Test_client_server,
> line 19
> >
> > > > >
> >
> > > > > Why is there no connection to the X server?  Anyway, we could
> catch this
> >
> > > > > error and give up.
> >
> > > >
> >
> > > > There might be the case one builds vim on a headless system. I.e.
> >
> > > > some build servers of distro's?
> >
> > >
> >
> > > Can you try this patch:
> >
> > >
> >
> > >
> >
> > > --- /home/mool/vim/git/vim80/src/testdir/test_clientserver.vim
> 2017-03-19 21:20:45.909034204 +0100
> >
> > > +++ testdir/test_clientserver.vim 2017-03-22 22:19:57.761651837
> +0100
> >
> > > @@ -11,6 +11,12 @@
> >
> > >if cmd == ''
> >
> > >  return
> >
> > >endif
> >
> > > +  try
> >
> > > +call serverlist()
> >
> > > +  catch /E240:/
> >
> > > +" No connection to the X server, give up.
> >
> > > +finish
> >
> > > +  endtry
> >
> > >
> >
> > >let name = 'XVIMTEST'
> >
> > >let cmd .= ' --servername ' . name
> >
> >
> >
> > From test_quotestar.vim:
> >
> >   Found errors in Test_quotestar():
> >
> >   First run:
> >
> >   function RunTheTest[24]..Test_quotestar[8]..Do_test_quotestar_for_x11
> line 21: Pattern 'XVIMCLIPBOARD' does not match ''
> >
> >   Caught exception in Test_quotestar(): Vim(call):E240: No connection to
> the X server @ function 
> RunTheTest[24]..Test_quotestar[8]..Do_test_quotestar_for_x11,
> line 31
> >
> >   Second run:
> >
> >   function RunTheTest[24]..Test_quotestar[8]..Do_test_quotestar_for_x11
> line 21: Pattern 'XVIMCLIPBOARD' does not match ''
> >
> >   Caught exception in Test_quotestar(): Vim(call):E240: No connection to
> the X server @ function 
> RunTheTest[24]..Test_quotestar[8]..Do_test_quotestar_for_x11,
> line 31
> >
> >
> >
> > From test_clientserver.vim:
> >
> >   Found errors in Test_client_server():
> >
> >   First run:
> >
> >   function RunTheTest[24]..Test_client_server line 23: Pattern
> 'XVIMTEST' does not match ''
> >
> >   Caught exception in Test_client_server(): Vim(call):E240: No
> connection to the X server @ function RunTheTest[24]..Test_client_server,
> line 25
> >
> >   Second run:
> >
> >   function RunTheTest[24]..Test_client_server line 23: Pattern
> 'XVIMTEST' does not match ''
> >
> >   Caught exception in Test_client_server(): Vim(call):E240: No
> connection to the X server @ function RunTheTest[24]..Test_client_server,
> line 25
> >
> >
> >
> > Elimar
> >
> >
> >
> > Since test_quotestar hasn't been given any handling for E240 yet, the
> result is just what we are expecting.
> >
> >
> >
> > As for test_clientserver, however, the E240 exception should be caught
> and hence the test would be skipped gracefully if Bram's patch were
> included in test_clientserver.vim.
> >
> >
> > So, the result of test_clientserver looks as if the patch were not
> included.  I'm wondering if the test was done with the patched
> test_clientserver.vim.
>
> As in mentoring a few hours ago, in my environment `:echo serverlist()`
> will not raise exceptions.
> Unfortunately, your guess is out of hand.
>

I distinguish Elimar Riesebieter's issue from yours; the former is about a
headless system where X11 can't run; the latter about an environment where
the test suite tries to run X11 on a remote system (i.e., something
unusual) via an ssh connection from Windows and fails for some reason.

I thought Bram tried to address the former

Re: [patch] test_clientserver.vim and test_quotestar.vim fails in certain circumstances

2017-03-23 Fir de Conversatie h_east

Hi Kazunobu and all,

2017-3-23(Thu) 21:01:32 UTC+9 Kazunobu Kuriyama:
> 2017-03-23 18:13 GMT+09:00 Elimar Riesebieter :
> 
> 
> * Bram Moolenaar  [2017-03-22 22:30 +0100]:
> 
> 
> 
> 
> 
> >
> 
> > Elimar Riesebieter wrote:
> 
> >
> 
> > > > Hirohito Higashi wrote:
> 
> > > >
> 
> > > > > My config:
> 
> > > > >   $ ./configure --with-features=huge --enable-gui=gnome2 
> > > > >--enable-fail-if-missing
> 
> > > > > My env.:
> 
> > > > >   I am connecting to fedora 25 with ssh via PuTTY on Windows 7.
> 
> > > > > Vim version:
> 
> > > > >   8.0.502
> 
> > > > >
> 
> > > > > Executed command:
> 
> > > > >   $ cd vim/src
> 
> > > > >   $ make test
> 
> > > > >
> 
> > > > > Execution result:
> 
> > > > > I got the following error.
> 
> > > > > >8
> 
> > > > > Test results:
> 
> > > > >
> 
> > > > >
> 
> > > > > >From test_clientserver.vim:
> 
> > > > > Found errors in Test_client_server():
> 
> > > > > First run:
> 
> > > > > function RunTheTest[24]..Test_client_server line 17: Pattern 
> > > > > 'XVIMTEST' does not match ''
> 
> > > > > Caught exception in Test_client_server(): Vim(call):E240: No 
> > > > > connection to the X server @ function 
> > > > > RunTheTest[24]..Test_client_server, line 19
> 
> > > > > Second run:
> 
> > > > > function RunTheTest[24]..Test_client_server line 17: Pattern 
> > > > > 'XVIMTEST' does not match ''
> 
> > > > > Caught exception in Test_client_server(): Vim(call):E240: No 
> > > > > connection to the X server @ function 
> > > > > RunTheTest[24]..Test_client_server, line 19
> 
> > > >
> 
> > > > Why is there no connection to the X server?  Anyway, we could catch this
> 
> > > > error and give up.
> 
> > >
> 
> > > There might be the case one builds vim on a headless system. I.e.
> 
> > > some build servers of distro's?
> 
> >
> 
> > Can you try this patch:
> 
> >
> 
> >
> 
> > --- /home/mool/vim/git/vim80/src/testdir/test_clientserver.vim        
> > 2017-03-19 21:20:45.909034204 +0100
> 
> > +++ testdir/test_clientserver.vim     2017-03-22 22:19:57.761651837 +0100
> 
> > @@ -11,6 +11,12 @@
> 
> >    if cmd == ''
> 
> >      return
> 
> >    endif
> 
> > +  try
> 
> > +    call serverlist()
> 
> > +  catch /E240:/
> 
> > +    " No connection to the X server, give up.
> 
> > +    finish
> 
> > +  endtry
> 
> >
> 
> >    let name = 'XVIMTEST'
> 
> >    let cmd .= ' --servername ' . name
> 
> 
> 
> From test_quotestar.vim:
> 
>   Found errors in Test_quotestar():
> 
>   First run:
> 
>   function RunTheTest[24]..Test_quotestar[8]..Do_test_quotestar_for_x11 line 
> 21: Pattern 'XVIMCLIPBOARD' does not match ''
> 
>   Caught exception in Test_quotestar(): Vim(call):E240: No connection to the 
> X server @ function 
> RunTheTest[24]..Test_quotestar[8]..Do_test_quotestar_for_x11, line 31
> 
>   Second run:
> 
>   function RunTheTest[24]..Test_quotestar[8]..Do_test_quotestar_for_x11 line 
> 21: Pattern 'XVIMCLIPBOARD' does not match ''
> 
>   Caught exception in Test_quotestar(): Vim(call):E240: No connection to the 
> X server @ function 
> RunTheTest[24]..Test_quotestar[8]..Do_test_quotestar_for_x11, line 31
> 
> 
> 
> From test_clientserver.vim:
> 
>   Found errors in Test_client_server():
> 
>   First run:
> 
>   function RunTheTest[24]..Test_client_server line 23: Pattern 'XVIMTEST' 
> does not match ''
> 
>   Caught exception in Test_client_server(): Vim(call):E240: No connection to 
> the X server @ function RunTheTest[24]..Test_client_server, line 25
> 
>   Second run:
> 
>   function RunTheTest[24]..Test_client_server line 23: Pattern 'XVIMTEST' 
> does not match ''
> 
>   Caught exception in Test_client_server(): Vim(call):E240: No connection to 
> the X server @ function RunTheTest[24]..Test_client_server, line 25
> 
> 
> 
> Elimar
> 
> 
> 
> Since test_quotestar hasn't been given any handling for E240 yet, the result 
> is just what we are expecting.
> 
> 
> 
> As for test_clientserver, however, the E240 exception should be caught and 
> hence the test would be skipped gracefully if Bram's patch were included in 
> test_clientserver.vim.
> 
> 
> So, the result of test_clientserver looks as if the patch were not included.  
> I'm wondering if the test was done with the patched test_clientserver.vim. 

As in mentoring a few hours ago, in my environment `:echo serverlist()` will 
not raise exceptions.
Unfortunately, your guess is out of hand.

--
Best regards,
Hirohito Higashi (a.k.a. h_east)

-- 
-- 
You received this message from the "vim_dev" maillist.
Do not top-post! Type your reply below the text you are replying to.
For more information, visit http://www.vim.org/maillist.php

--- 
You received this message because you are subscribed to the Google Groups 
"vim_dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to vim_dev+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

Re: [patch] test_clientserver.vim and test_quotestar.vim fails in certain circumstances

2017-03-23 Fir de Conversatie Kazunobu Kuriyama

2017-03-23 18:13 GMT+09:00 Elimar Riesebieter :

> * Bram Moolenaar  [2017-03-22 22:30 +0100]:
>
> >
> > Elimar Riesebieter wrote:
> >
> > > > Hirohito Higashi wrote:
> > > >
> > > > > My config:
> > > > >   $ ./configure --with-features=huge --enable-gui=gnome2
> --enable-fail-if-missing
> > > > > My env.:
> > > > >   I am connecting to fedora 25 with ssh via PuTTY on Windows 7.
> > > > > Vim version:
> > > > >   8.0.502
> > > > >
> > > > > Executed command:
> > > > >   $ cd vim/src
> > > > >   $ make test
> > > > >
> > > > > Execution result:
> > > > > I got the following error.
> > > > > >8
> > > > > Test results:
> > > > >
> > > > >
> > > > > >From test_clientserver.vim:
> > > > > Found errors in Test_client_server():
> > > > > First run:
> > > > > function RunTheTest[24]..Test_client_server line 17: Pattern
> 'XVIMTEST' does not match ''
> > > > > Caught exception in Test_client_server(): Vim(call):E240: No
> connection to the X server @ function RunTheTest[24]..Test_client_server,
> line 19
> > > > > Second run:
> > > > > function RunTheTest[24]..Test_client_server line 17: Pattern
> 'XVIMTEST' does not match ''
> > > > > Caught exception in Test_client_server(): Vim(call):E240: No
> connection to the X server @ function RunTheTest[24]..Test_client_server,
> line 19
> > > >
> > > > Why is there no connection to the X server?  Anyway, we could catch
> this
> > > > error and give up.
> > >
> > > There might be the case one builds vim on a headless system. I.e.
> > > some build servers of distro's?
> >
> > Can you try this patch:
> >
> >
> > --- /home/mool/vim/git/vim80/src/testdir/test_clientserver.vim
> 2017-03-19 21:20:45.909034204 +0100
> > +++ testdir/test_clientserver.vim 2017-03-22 22:19:57.761651837 +0100
> > @@ -11,6 +11,12 @@
> >if cmd == ''
> >  return
> >endif
> > +  try
> > +call serverlist()
> > +  catch /E240:/
> > +" No connection to the X server, give up.
> > +finish
> > +  endtry
> >
> >let name = 'XVIMTEST'
> >let cmd .= ' --servername ' . name
>
> From test_quotestar.vim:
>   Found errors in Test_quotestar():
>   First run:
>   function RunTheTest[24]..Test_quotestar[8]..Do_test_quotestar_for_x11
> line 21: Pattern 'XVIMCLIPBOARD' does not match ''
>   Caught exception in Test_quotestar(): Vim(call):E240: No connection to
> the X server @ function 
> RunTheTest[24]..Test_quotestar[8]..Do_test_quotestar_for_x11,
> line 31
>   Second run:
>   function RunTheTest[24]..Test_quotestar[8]..Do_test_quotestar_for_x11
> line 21: Pattern 'XVIMCLIPBOARD' does not match ''
>   Caught exception in Test_quotestar(): Vim(call):E240: No connection to
> the X server @ function 
> RunTheTest[24]..Test_quotestar[8]..Do_test_quotestar_for_x11,
> line 31
>
> From test_clientserver.vim:
>   Found errors in Test_client_server():
>   First run:
>   function RunTheTest[24]..Test_client_server line 23: Pattern 'XVIMTEST'
> does not match ''
>   Caught exception in Test_client_server(): Vim(call):E240: No connection
> to the X server @ function RunTheTest[24]..Test_client_server, line 25
>   Second run:
>   function RunTheTest[24]..Test_client_server line 23: Pattern 'XVIMTEST'
> does not match ''
>   Caught exception in Test_client_server(): Vim(call):E240: No connection
> to the X server @ function RunTheTest[24]..Test_client_server, line 25
>
> Elimar
>

Since test_quotestar hasn't been given any handling for E240 yet, the
result is just what we are expecting.

As for test_clientserver, however, the E240 exception should be caught and
hence the test would be skipped gracefully if Bram's patch were included in
test_clientserver.vim.

So, the result of test_clientserver looks as if the patch were not
included.  I'm wondering if the test was done with the patched
test_clientserver.vim.

> --
>   We all know Linux is great... it does infinite loops in 5 seconds.
> -Linus Torvalds
>
> --
> --
> You received this message from the "vim_dev" maillist.
> Do not top-post! Type your reply below the text you are replying to.
> For more information, visit http://www.vim.org/maillist.php
>
> ---
> You received this message because you are subscribed to the Google Groups
> "vim_dev" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to vim_dev+unsubscr...@googlegroups.com.
> For more options, visit https://groups.google.com/d/optout.
>

-- 
-- 
You received this message from the "vim_dev" maillist.
Do not top-post! Type your reply below the text you are replying to.
For more information, visit http://www.vim.org/maillist.php

--- 
You received this message because you are subscribed to the Google Groups 
"vim_dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to vim_dev+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

Re: [patch] test_clientserver.vim and test_quotestar.vim fails in certain circumstances

2017-03-23 Fir de Conversatie Elimar Riesebieter

* Bram Moolenaar  [2017-03-22 22:30 +0100]:

> 
> Elimar Riesebieter wrote:
> 
> > > Hirohito Higashi wrote:
> > > 
> > > > My config:
> > > >   $ ./configure --with-features=huge --enable-gui=gnome2 
> > > > --enable-fail-if-missing
> > > > My env.:
> > > >   I am connecting to fedora 25 with ssh via PuTTY on Windows 7.
> > > > Vim version:
> > > >   8.0.502
> > > > 
> > > > Executed command:
> > > >   $ cd vim/src
> > > >   $ make test
> > > > 
> > > > Execution result:
> > > > I got the following error.
> > > > >8
> > > > Test results:
> > > > 
> > > > 
> > > > >From test_clientserver.vim:
> > > > Found errors in Test_client_server():
> > > > First run:
> > > > function RunTheTest[24]..Test_client_server line 17: Pattern 'XVIMTEST' 
> > > > does not match ''
> > > > Caught exception in Test_client_server(): Vim(call):E240: No connection 
> > > > to the X server @ function RunTheTest[24]..Test_client_server, line 19
> > > > Second run:
> > > > function RunTheTest[24]..Test_client_server line 17: Pattern 'XVIMTEST' 
> > > > does not match ''
> > > > Caught exception in Test_client_server(): Vim(call):E240: No connection 
> > > > to the X server @ function RunTheTest[24]..Test_client_server, line 19
> > > 
> > > Why is there no connection to the X server?  Anyway, we could catch this
> > > error and give up.
> > 
> > There might be the case one builds vim on a headless system. I.e.
> > some build servers of distro's?
> 
> Can you try this patch:
> 
> 
> --- /home/mool/vim/git/vim80/src/testdir/test_clientserver.vim
> 2017-03-19 21:20:45.909034204 +0100
> +++ testdir/test_clientserver.vim 2017-03-22 22:19:57.761651837 +0100
> @@ -11,6 +11,12 @@
>if cmd == ''
>  return
>endif
> +  try
> +call serverlist()
> +  catch /E240:/
> +" No connection to the X server, give up.
> +finish
> +  endtry
>  
>let name = 'XVIMTEST'
>let cmd .= ' --servername ' . name

>From test_quotestar.vim:
  Found errors in Test_quotestar():
  First run:
  function RunTheTest[24]..Test_quotestar[8]..Do_test_quotestar_for_x11 line 
21: Pattern 'XVIMCLIPBOARD' does not match ''
  Caught exception in Test_quotestar(): Vim(call):E240: No connection to the X 
server @ function RunTheTest[24]..Test_quotestar[8]..Do_test_quotestar_for_x11, 
line 31
  Second run:
  function RunTheTest[24]..Test_quotestar[8]..Do_test_quotestar_for_x11 line 
21: Pattern 'XVIMCLIPBOARD' does not match ''
  Caught exception in Test_quotestar(): Vim(call):E240: No connection to the X 
server @ function RunTheTest[24]..Test_quotestar[8]..Do_test_quotestar_for_x11, 
line 31

>From test_clientserver.vim:
  Found errors in Test_client_server():
  First run:
  function RunTheTest[24]..Test_client_server line 23: Pattern 'XVIMTEST' does 
not match ''
  Caught exception in Test_client_server(): Vim(call):E240: No connection to 
the X server @ function RunTheTest[24]..Test_client_server, line 25
  Second run:
  function RunTheTest[24]..Test_client_server line 23: Pattern 'XVIMTEST' does 
not match ''
  Caught exception in Test_client_server(): Vim(call):E240: No connection to 
the X server @ function RunTheTest[24]..Test_client_server, line 25

Elimar
-- 
  We all know Linux is great... it does infinite loops in 5 seconds.
-Linus Torvalds

-- 
-- 
You received this message from the "vim_dev" maillist.
Do not top-post! Type your reply below the text you are replying to.
For more information, visit http://www.vim.org/maillist.php

--- 
You received this message because you are subscribed to the Google Groups 
"vim_dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to vim_dev+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

Re: [patch] test_clientserver.vim and test_quotestar.vim fails in certain circumstances

2017-03-23 Fir de Conversatie h_east

Hi Bram,

2017-3-23(Thu) 6:31:02 UTC+9 Bram Moolenaar:
> Elimar Riesebieter wrote:
> 
> > > Hirohito Higashi wrote:
> > > 
> > > > My config:
> > > >   $ ./configure --with-features=huge --enable-gui=gnome2 
> > > > --enable-fail-if-missing
> > > > My env.:
> > > >   I am connecting to fedora 25 with ssh via PuTTY on Windows 7.
> > > > Vim version:
> > > >   8.0.502
> > > > 
> > > > Executed command:
> > > >   $ cd vim/src
> > > >   $ make test
> > > > 
> > > > Execution result:
> > > > I got the following error.
> > > > >8
> > > > Test results:
> > > > 
> > > > 
> > > > >From test_clientserver.vim:
> > > > Found errors in Test_client_server():
> > > > First run:
> > > > function RunTheTest[24]..Test_client_server line 17: Pattern 'XVIMTEST' 
> > > > does not match ''
> > > > Caught exception in Test_client_server(): Vim(call):E240: No connection 
> > > > to the X server @ function RunTheTest[24]..Test_client_server, line 19
> > > > Second run:
> > > > function RunTheTest[24]..Test_client_server line 17: Pattern 'XVIMTEST' 
> > > > does not match ''
> > > > Caught exception in Test_client_server(): Vim(call):E240: No connection 
> > > > to the X server @ function RunTheTest[24]..Test_client_server, line 19
> > > 
> > > Why is there no connection to the X server?  Anyway, we could catch this
> > > error and give up.
> > 
> > There might be the case one builds vim on a headless system. I.e.
> > some build servers of distro's?
> 
> Can you try this patch:
> 
> 
> --- /home/mool/vim/git/vim80/src/testdir/test_clientserver.vim
> 2017-03-19 21:20:45.909034204 +0100
> +++ testdir/test_clientserver.vim 2017-03-22 22:19:57.761651837 +0100
> @@ -11,6 +11,12 @@
>if cmd == ''
>  return
>endif
> +  try
> +call serverlist()
> +  catch /E240:/
> +" No connection to the X server, give up.
> +finish
> +  endtry
>  
>let name = 'XVIMTEST'
>let cmd .= ' --servername ' . name

In my environment, `:call serverlist()` always succeed and returns the empty 
string.
So, above patch does not change the situation.

thanks.
--
Best regards,
Hirohito Higashi (a.k.a. h_east)

-- 
-- 
You received this message from the "vim_dev" maillist.
Do not top-post! Type your reply below the text you are replying to.
For more information, visit http://www.vim.org/maillist.php

--- 
You received this message because you are subscribed to the Google Groups 
"vim_dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to vim_dev+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

Re: [patch] test_clientserver.vim and test_quotestar.vim fails in certain circumstances

2017-03-22 Fir de Conversatie Bram Moolenaar


Elimar Riesebieter wrote:

> > Hirohito Higashi wrote:
> > 
> > > My config:
> > >   $ ./configure --with-features=huge --enable-gui=gnome2 
> > > --enable-fail-if-missing
> > > My env.:
> > >   I am connecting to fedora 25 with ssh via PuTTY on Windows 7.
> > > Vim version:
> > >   8.0.502
> > > 
> > > Executed command:
> > >   $ cd vim/src
> > >   $ make test
> > > 
> > > Execution result:
> > > I got the following error.
> > > >8
> > > Test results:
> > > 
> > > 
> > > >From test_clientserver.vim:
> > > Found errors in Test_client_server():
> > > First run:
> > > function RunTheTest[24]..Test_client_server line 17: Pattern 'XVIMTEST' 
> > > does not match ''
> > > Caught exception in Test_client_server(): Vim(call):E240: No connection 
> > > to the X server @ function RunTheTest[24]..Test_client_server, line 19
> > > Second run:
> > > function RunTheTest[24]..Test_client_server line 17: Pattern 'XVIMTEST' 
> > > does not match ''
> > > Caught exception in Test_client_server(): Vim(call):E240: No connection 
> > > to the X server @ function RunTheTest[24]..Test_client_server, line 19
> > 
> > Why is there no connection to the X server?  Anyway, we could catch this
> > error and give up.
> 
> There might be the case one builds vim on a headless system. I.e.
> some build servers of distro's?

Can you try this patch:


--- /home/mool/vim/git/vim80/src/testdir/test_clientserver.vim  2017-03-19 
21:20:45.909034204 +0100
+++ testdir/test_clientserver.vim   2017-03-22 22:19:57.761651837 +0100
@@ -11,6 +11,12 @@
   if cmd == ''
 return
   endif
+  try
+call serverlist()
+  catch /E240:/
+" No connection to the X server, give up.
+finish
+  endtry
 
   let name = 'XVIMTEST'
   let cmd .= ' --servername ' . name

-- 
What is the difference between a professional and an amateur?
The ark was built by an amateur; professionals gave us the Titanic.

 /// Bram Moolenaar -- b...@moolenaar.net -- http://www.Moolenaar.net   \\\
///sponsor Vim, vote for features -- http://www.Vim.org/sponsor/ \\\
\\\  an exciting new programming language -- http://www.Zimbu.org///
 \\\help me help AIDS victims -- http://ICCF-Holland.org///

-- 
-- 
You received this message from the "vim_dev" maillist.
Do not top-post! Type your reply below the text you are replying to.
For more information, visit http://www.vim.org/maillist.php

--- 
You received this message because you are subscribed to the Google Groups 
"vim_dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to vim_dev+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

Re: [patch] test_clientserver.vim and test_quotestar.vim fails in certain circumstances

2017-03-22 Fir de Conversatie Elimar Riesebieter

* Bram Moolenaar  [2017-03-22 12:19 +0100]:

> 
> Hirohito Higashi wrote:
> 
> > My config:
> >   $ ./configure --with-features=huge --enable-gui=gnome2 
> > --enable-fail-if-missing
> > My env.:
> >   I am connecting to fedora 25 with ssh via PuTTY on Windows 7.
> > Vim version:
> >   8.0.502
> > 
> > Executed command:
> >   $ cd vim/src
> >   $ make test
> > 
> > Execution result:
> > I got the following error.
> > >8
> > Test results:
> > 
> > 
> > >From test_clientserver.vim:
> > Found errors in Test_client_server():
> > First run:
> > function RunTheTest[24]..Test_client_server line 17: Pattern 'XVIMTEST' 
> > does not match ''
> > Caught exception in Test_client_server(): Vim(call):E240: No connection to 
> > the X server @ function RunTheTest[24]..Test_client_server, line 19
> > Second run:
> > function RunTheTest[24]..Test_client_server line 17: Pattern 'XVIMTEST' 
> > does not match ''
> > Caught exception in Test_client_server(): Vim(call):E240: No connection to 
> > the X server @ function RunTheTest[24]..Test_client_server, line 19
> 
> Why is there no connection to the X server?  Anyway, we could catch this
> error and give up.

There might be the case one builds vim on a headless system. I.e.
some build servers of distro's?

Elimar
-- 
  "Talking much about oneself can also
   be a means to conceal oneself."
 -Friedrich Nietzsche

-- 
-- 
You received this message from the "vim_dev" maillist.
Do not top-post! Type your reply below the text you are replying to.
For more information, visit http://www.vim.org/maillist.php

--- 
You received this message because you are subscribed to the Google Groups 
"vim_dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to vim_dev+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

Re: [patch] test_clientserver.vim and test_quotestar.vim fails in certain circumstances

2017-03-22 Fir de Conversatie Bram Moolenaar


Hirohito Higashi wrote:

> My config:
>   $ ./configure --with-features=huge --enable-gui=gnome2 
> --enable-fail-if-missing
> My env.:
>   I am connecting to fedora 25 with ssh via PuTTY on Windows 7.
> Vim version:
>   8.0.502
> 
> Executed command:
>   $ cd vim/src
>   $ make test
> 
> Execution result:
> I got the following error.
> >8
> Test results:
> 
> 
> >From test_clientserver.vim:
> Found errors in Test_client_server():
> First run:
> function RunTheTest[24]..Test_client_server line 17: Pattern 'XVIMTEST' does 
> not match ''
> Caught exception in Test_client_server(): Vim(call):E240: No connection to 
> the X server @ function RunTheTest[24]..Test_client_server, line 19
> Second run:
> function RunTheTest[24]..Test_client_server line 17: Pattern 'XVIMTEST' does 
> not match ''
> Caught exception in Test_client_server(): Vim(call):E240: No connection to 
> the X server @ function RunTheTest[24]..Test_client_server, line 19

Why is there no connection to the X server?  Anyway, we could catch this
error and give up.

> >From test_quotestar.vim:
> Found errors in Test_quotestar():
> First run:
> function RunTheTest[24]..Test_quotestar[8]..Do_test_quotestar_for_x11 line 
> 21: Pattern 'XVIMCLIPBOARD' does not match ''
> Caught exception in Test_quotestar(): Vim(call):E240: No connection to the X 
> server @ function 
> RunTheTest[24]..Test_quotestar[8]..Do_test_quotestar_for_x11, line 31
> Second run:
> function RunTheTest[24]..Test_quotestar[8]..Do_test_quotestar_for_x11 line 
> 21: Pattern 'XVIMCLIPBOARD' does not match ''
> Caught exception in Test_quotestar(): Vim(call):E240: No connection to the X 
> server @ function 
> RunTheTest[24]..Test_quotestar[8]..Do_test_quotestar_for_x11, line 31
> TEST FAILURE
> Makefile:41: recipe for target 'report' failed
> make[1]: *** [report] Error 1
> make[1]: Leaving directory '/home/h_east/samba/github/vim/src/testdir'
> Makefile:2027: recipe for target 'scripttests' failed
> make: *** [scripttests] Error 2
> >8
> 
> I think that it is not necessary to carry out test at the following 
> conditions.
> 
> if !has('gui') || ($DISPLAY == "" && !has('gui_running'))
>   finish
> endif

That would mean the test doesn't run in non-GUI, while it should work
there.

> Also, the following code is always true, so we should modify it.
> src/testdir/test_quotestar.vim : 112
> 
>   elseif !empty("$DISPLAY")
> 
> 
> I attached a patch.
> Check it please.

-- 
hundred-and-one symptoms of being an internet addict:
185. You order fast food over the Internet

 /// Bram Moolenaar -- b...@moolenaar.net -- http://www.Moolenaar.net   \\\
///sponsor Vim, vote for features -- http://www.Vim.org/sponsor/ \\\
\\\  an exciting new programming language -- http://www.Zimbu.org///
 \\\help me help AIDS victims -- http://ICCF-Holland.org///

-- 
-- 
You received this message from the "vim_dev" maillist.
Do not top-post! Type your reply below the text you are replying to.
For more information, visit http://www.vim.org/maillist.php

--- 
You received this message because you are subscribed to the Google Groups 
"vim_dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to vim_dev+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

[patch] test_clientserver.vim and test_quotestar.vim fails in certain circumstances

2017-03-22 Fir de Conversatie h_east

Hi Bram and list,

My config:
  $ ./configure --with-features=huge --enable-gui=gnome2 
--enable-fail-if-missing
My env.:
  I am connecting to fedora 25 with ssh via PuTTY on Windows 7.
Vim version:
  8.0.502

Executed command:
  $ cd vim/src
  $ make test

Execution result:
I got the following error.
>8
Test results:


>From test_clientserver.vim:
Found errors in Test_client_server():
First run:
function RunTheTest[24]..Test_client_server line 17: Pattern 'XVIMTEST' does 
not match ''
Caught exception in Test_client_server(): Vim(call):E240: No connection to the 
X server @ function RunTheTest[24]..Test_client_server, line 19
Second run:
function RunTheTest[24]..Test_client_server line 17: Pattern 'XVIMTEST' does 
not match ''
Caught exception in Test_client_server(): Vim(call):E240: No connection to the 
X server @ function RunTheTest[24]..Test_client_server, line 19

>From test_quotestar.vim:
Found errors in Test_quotestar():
First run:
function RunTheTest[24]..Test_quotestar[8]..Do_test_quotestar_for_x11 line 21: 
Pattern 'XVIMCLIPBOARD' does not match ''
Caught exception in Test_quotestar(): Vim(call):E240: No connection to the X 
server @ function RunTheTest[24]..Test_quotestar[8]..Do_test_quotestar_for_x11, 
line 31
Second run:
function RunTheTest[24]..Test_quotestar[8]..Do_test_quotestar_for_x11 line 21: 
Pattern 'XVIMCLIPBOARD' does not match ''
Caught exception in Test_quotestar(): Vim(call):E240: No connection to the X 
server @ function RunTheTest[24]..Test_quotestar[8]..Do_test_quotestar_for_x11, 
line 31
TEST FAILURE
Makefile:41: recipe for target 'report' failed
make[1]: *** [report] Error 1
make[1]: Leaving directory '/home/h_east/samba/github/vim/src/testdir'
Makefile:2027: recipe for target 'scripttests' failed
make: *** [scripttests] Error 2
>8

I think that it is not necessary to carry out test at the following conditions.

if !has('gui') || ($DISPLAY == "" && !has('gui_running'))
  finish
endif


Also, the following code is always true, so we should modify it.
src/testdir/test_quotestar.vim : 112

  elseif !empty("$DISPLAY")


I attached a patch.
Check it please.
--
Best regards,
Hirohito Higashi (a.k.a. h_east)

-- 
-- 
You received this message from the "vim_dev" maillist.
Do not top-post! Type your reply below the text you are replying to.
For more information, visit http://www.vim.org/maillist.php

--- 
You received this message because you are subscribed to the Google Groups 
"vim_dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to vim_dev+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.
diff --git a/src/testdir/test_clientserver.vim b/src/testdir/test_clientserver.vim
index c98fc02..ce6d247 100644
--- a/src/testdir/test_clientserver.vim
+++ b/src/testdir/test_clientserver.vim
@@ -1,5 +1,8 @@
 " Tests for the +clientserver feature.
 
+if !has('gui') || ($DISPLAY == "" && !has('gui_running'))
+  finish
+endif
 if !has('job') || !has('clientserver')
   finish
 endif
diff --git a/src/testdir/test_quotestar.vim b/src/testdir/test_quotestar.vim
index d0dd04f..e67bef8 100644
--- a/src/testdir/test_quotestar.vim
+++ b/src/testdir/test_quotestar.vim
@@ -1,5 +1,8 @@
 " *-register (quotestar) tests
 
+if !has('gui') || ($DISPLAY == "" && !has('gui_running'))
+  finish
+endif
 if !has('clipboard')
   finish
 endif
@@ -109,7 +112,7 @@ func Test_quotestar()
 
   if has('macunix')
 let skipped = Do_test_quotestar_for_macunix()
-  elseif !empty("$DISPLAY")
+  elseif !empty($DISPLAY)
 let skipped = Do_test_quotestar_for_x11()
   else
 let skipped = "Test is not implemented yet for this platform."

Re: [patch] test_clientserver.vim and test_quotestar.vim fails in certain circumstances

Re: [patch] test_clientserver.vim and test_quotestar.vim fails in certain circumstances

Re: [patch] test_clientserver.vim and test_quotestar.vim fails in certain circumstances

Re: [patch] test_clientserver.vim and test_quotestar.vim fails in certain circumstances

Re: [patch] test_clientserver.vim and test_quotestar.vim fails in certain circumstances

Re: [patch] test_clientserver.vim and test_quotestar.vim fails in certain circumstances

Re: [patch] test_clientserver.vim and test_quotestar.vim fails in certain circumstances

Re: [patch] test_clientserver.vim and test_quotestar.vim fails in certain circumstances

Re: [patch] test_clientserver.vim and test_quotestar.vim fails in certain circumstances

Re: [patch] test_clientserver.vim and test_quotestar.vim fails in certain circumstances

Re: [patch] test_clientserver.vim and test_quotestar.vim fails in certain circumstances

Re: [patch] test_clientserver.vim and test_quotestar.vim fails in certain circumstances

Re: [patch] test_clientserver.vim and test_quotestar.vim fails in certain circumstances

Re: [patch] test_clientserver.vim and test_quotestar.vim fails in certain circumstances

Re: [patch] test_clientserver.vim and test_quotestar.vim fails in certain circumstances

Re: [patch] test_clientserver.vim and test_quotestar.vim fails in certain circumstances

Re: [patch] test_clientserver.vim and test_quotestar.vim fails in certain circumstances

Re: [patch] test_clientserver.vim and test_quotestar.vim fails in certain circumstances

Re: [patch] test_clientserver.vim and test_quotestar.vim fails in certain circumstances

[patch] test_clientserver.vim and test_quotestar.vim fails in certain circumstances

20 matches

Site Navigation

Mail list logo

Footer information