Re: [vim/vim] netrw: Fix gx command (#7188)

[Ingo Karkat]

-BEGIN PGP SIGNED MESSAGE-
Hash: SHA256

On 24/10/2020 20:52, Charles Campbell wrote:
> Charles Campbell wrote:
>> James McCoy wrote:
>>> On Thu, Oct 22, 2020, 21:39 Charles Campbell
>>> mailto:campb...@drchip.org>> wrote:
>>>
>>> I confess that I'm not a git master.  It'd be a help if you
>>> could send me a patch instead of a commit which I don't use
>>>
>>>
>>> If you append ".diff" to a pull request URL, you get a diff you
>>> can download.  For example,
>>> https://github.com/vim/vim/pull/7188.diff
>>>
>>> Cheers, James
>>>
>>>
>>
>> Hello:
>>
>> Unfortunately:
>>
>> sphinx?   https://github.com/vim/vim/pull/7188.diff ksh:
>> https://github.com/vim/vim/pull/7188.diff: not found [No such
>> file or directory] sphinx?
>> https://github.com/vim/vim/pull/7188.patch ksh:
>> https://github.com/vim/vim/pull/7188.patch: not found [No such
>> file or directory]
>>
>> Regards, Chip Campbell
>>
> Well, that was dumb on my part.  Here's a new and updated problem:
>
> git pull  https://github.com/vim/vim/pull/7188.diff fatal: Not a
> git repository (or any parent up to mount point /home) Stopping at
> filesystem boundary (GIT_DISCOVERY_ACROSS_FILESYSTEM not set).
>
> Again, I want to pull the diff/patch and not have it bother what
> I've got. I need to check it over, run it through my test suite,
> merge it with the latest netrw (at v171b at the moment).

Charles, that URL gives you a plain diff; download it via

$ curl -L https://github.com/vim/vim/pull/7188.diff

or simply open the URL in the browser and save the page as a text file.

You can also stay within Git, but then would have to set up Vim's
GitHub repository as a remote, pull it (Vim's GitHub page has all the
details behind the "Clone or download" button), and then you can diff
it there, but it would be way more complex, and not so useful, anyway,
as you maintain your plugin separately from what gets included by
Bram. (So sooner or later you'd still need to produce a diff to move
the changes over to your copy.)

Like Vim, Git has a steep initial learning curve (I've been there as
well); take your time!

- -- regards, ingo
-BEGIN PGP SIGNATURE-
Version: GnuPG v2

iQEcBAEBCAAGBQJflIlmAAoJEA7ziXlAzQ/vIWwH/Az1SjjjNbVwbp8+W7JE+t2J
tmEESsMPId38bO2qBe7jSXKXPZdvn/4twaW8JZuid35XxKVRUpC0RH44XiBYHlKB
XKe/3/h8HBPJuqUwPrnh7LiQzM3erkiDt0qo8QEovU3SueG5BGwAzWThcHamxoOn
DK2eTtz/f3ED91EU8RuZ5g6BvEYVVpLlSx5JQ42SyuuHi8HS4GoXIwE1CA2C0hUD
AMN+XBx8rVOQLKR+1rvfWb0UwgMgh4x7LEwf7Glonp0B3cvusoX05s0cT2xHtcrv
c7qCzjNB/99KgbRpsNahmre1JqUZ4b9Dd13ENhB9d9Dvmb6BpF8PzLU71jxqmt4=
=smqM
-END PGP SIGNATURE-

-- 
-- 
You received this message from the "vim_dev" maillist.
Do not top-post! Type your reply below the text you are replying to.
For more information, visit http://www.vim.org/maillist.php

--- 
You received this message because you are subscribed to the Google Groups 
"vim_dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to vim_dev+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/vim_dev/a024c195-767b-df85-cbb2-0efcd8f1a92a%40ingo-karkat.de.

Re: [vim/vim] netrw: Fix gx command (#7188)

[Charles Campbell]

Charles Campbell wrote:

James McCoy wrote:
On Thu, Oct 22, 2020, 21:39 Charles Campbell > wrote:


    I confess that I'm not a git master.  It'd be a help if you could
    send
    me a patch instead of a commit which I don't use


If you append ".diff" to a pull request URL, you get a diff you can 
download.  For example, https://github.com/vim/vim/pull/7188.diff


Cheers,
James




Hello:

Unfortunately:

   sphinx?   https://github.com/vim/vim/pull/7188.diff
   ksh: https://github.com/vim/vim/pull/7188.diff: not found [No such
   file or directory]
   sphinx?   https://github.com/vim/vim/pull/7188.patch
   ksh: https://github.com/vim/vim/pull/7188.patch: not found [No such
   file or directory]

Regards,
Chip Campbell


Well, that was dumb on my part.  Here's a new and updated problem:

git pull  https://github.com/vim/vim/pull/7188.diff
fatal: Not a git repository (or any parent up to mount point /home)
Stopping at filesystem boundary (GIT_DISCOVERY_ACROSS_FILESYSTEM not set).

Again, I want to pull the diff/patch and not have it bother what I've 
got. I need to check it over, run it through my test suite, merge it 
with the latest netrw (at v171b at the moment).


Regards,
Chip Campbell

--
--
You received this message from the "vim_dev" maillist.
Do not top-post! Type your reply below the text you are replying to.
For more information, visit http://www.vim.org/maillist.php

--- 
You received this message because you are subscribed to the Google Groups "vim_dev" group.

To unsubscribe from this group and stop receiving emails from it, send an email 
to vim_dev+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/vim_dev/a6f119b3-420f-11b3-44b6-ed72675c0f3a%40drchip.org.

Re: [vim/vim] netrw: Fix gx command (#7188)

[Charles Campbell]

James McCoy wrote:
On Thu, Oct 22, 2020, 21:39 Charles Campbell > wrote:


I confess that I'm not a git master.  It'd be a help if you could
send
me a patch instead of a commit which I don't use


If you append ".diff" to a pull request URL, you get a diff you can 
download.  For example, https://github.com/vim/vim/pull/7188.diff


Cheers,
James




Hello:

Unfortunately:

   sphinx?   https://github.com/vim/vim/pull/7188.diff
   ksh: https://github.com/vim/vim/pull/7188.diff: not found [No such
   file or directory]
   sphinx?   https://github.com/vim/vim/pull/7188.patch
   ksh: https://github.com/vim/vim/pull/7188.patch: not found [No such
   file or directory]

Regards,
Chip Campbell

--
--
You received this message from the "vim_dev" maillist.
Do not top-post! Type your reply below the text you are replying to.
For more information, visit http://www.vim.org/maillist.php

--- 
You received this message because you are subscribed to the Google Groups "vim_dev" group.

To unsubscribe from this group and stop receiving emails from it, send an email 
to vim_dev+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/vim_dev/29368858-9bf7-80c0-5f4d-218f6702%40drchip.org.

Re: [vim/vim] netrw: Fix gx command (#7188)

[Bram Moolenaar]

Nick Jensen wrote:

> The 2020-10-22 21:39, Charles Campbell wrote:
> >I confess that I'm not a git master.  It'd be a help if you could send 
> >me a patch instead of a commit which I don't use, or inform me of the 
> >git command to download the file separately so I can diff and study 
> >it. I can see a nice pretty set of changes which is almost a diff, but 
> >I hate applying these things manually.  Iffy process, that.
> 
> There's a hint ("Pro Tip!") at the bottom of the github pull request 
> page indicating that you can add ".patch" or ".diff" to the end of the 
> URL:
> 
>  https://github.com/vim/vim/pull/7188.patch
>  https://github.com/vim/vim/pull/7188.diff

It is SO annoying that there is no link for this at the top.
Even if you go to "files changed", which shows a nicely highlighted
version of the diff, the "raw diff" button is missing.  Pretty bad UI.

-- 
hundred-and-one symptoms of being an internet addict:
114. You are counting items, you go "0,1,2,3,4,5,6,7,8,9,A,B,C,D...".

 /// Bram Moolenaar -- b...@moolenaar.net -- http://www.Moolenaar.net   \\\
///sponsor Vim, vote for features -- http://www.Vim.org/sponsor/ \\\
\\\  an exciting new programming language -- http://www.Zimbu.org///
 \\\help me help AIDS victims -- http://ICCF-Holland.org///

-- 
-- 
You received this message from the "vim_dev" maillist.
Do not top-post! Type your reply below the text you are replying to.
For more information, visit http://www.vim.org/maillist.php

--- 
You received this message because you are subscribed to the Google Groups 
"vim_dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to vim_dev+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/vim_dev/202010231307.09ND7Yos688139%40masaka.moolenaar.net.

Re: [vim/vim] netrw: Fix gx command (#7188)

[Nick Jensen]

The 2020-10-22 21:39, Charles Campbell wrote:
I confess that I'm not a git master.  It'd be a help if you could send 
me a patch instead of a commit which I don't use, or inform me of the 
git command to download the file separately so I can diff and study 
it. I can see a nice pretty set of changes which is almost a diff, but 
I hate applying these things manually.  Iffy process, that.


There's a hint ("Pro Tip!") at the bottom of the github pull request 
page indicating that you can add ".patch" or ".diff" to the end of the 
URL:


https://github.com/vim/vim/pull/7188.patch
https://github.com/vim/vim/pull/7188.diff

Regards,
Nick Jensen

--
--
You received this message from the "vim_dev" maillist.
Do not top-post! Type your reply below the text you are replying to.
For more information, visit http://www.vim.org/maillist.php

--- 
You received this message because you are subscribed to the Google Groups "vim_dev" group.

To unsubscribe from this group and stop receiving emails from it, send an email 
to vim_dev+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/vim_dev/20201023015826.GC31442%40KERERU.localdomain.

Re: [vim/vim] netrw: Fix gx command (#7188)

[James McCoy]

On Thu, Oct 22, 2020, 21:39 Charles Campbell  wrote:

> I confess that I'm not a git master.  It'd be a help if you could send
> me a patch instead of a commit which I don't use
>

If you append ".diff" to a pull request URL, you get a diff you can
download.  For example, https://github.com/vim/vim/pull/7188.diff

Cheers,
James

>

-- 
-- 
You received this message from the "vim_dev" maillist.
Do not top-post! Type your reply below the text you are replying to.
For more information, visit http://www.vim.org/maillist.php

--- 
You received this message because you are subscribed to the Google Groups 
"vim_dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to vim_dev+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/vim_dev/CAFeRdpf4aCzJOpx%2B%2BYrETN7rA35Nmz%3D7URF9YfT5nha-tNiDJw%40mail.gmail.com.

Re: [vim/vim] netrw: Fix gx command (#7188)

[Charles Campbell]

K.Takata (Vim Github Repository) wrote:


Fix #4738 .
Since Netrw v165, the gx command had been broken at least on macOS and
MS-Windows. The platform-specific open commands support to handle a
remote URL directly, however, Netrw downloaded a file first.

Stop downloading a remote file when the viewer supports to handle a
remote URL.


Hello, K Takata:

I confess that I'm not a git master.  It'd be a help if you could send 
me a patch instead of a commit which I don't use, or inform me of the 
git command to download the file separately so I can diff and study it. 
I can see a nice pretty set of changes which is almost a diff, but I 
hate applying these things manually.  Iffy process, that.


Thanks,
Chip Campbell

--
--
You received this message from the "vim_dev" maillist.
Do not top-post! Type your reply below the text you are replying to.
For more information, visit http://www.vim.org/maillist.php

--- 
You received this message because you are subscribed to the Google Groups "vim_dev" group.

To unsubscribe from this group and stop receiving emails from it, send an email 
to vim_dev+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/vim_dev/e3b5584b-ce15-8af7-e646-816305b17545%40drchip.org.