Re: [vim] sh.vim incorrectly highlighting if/fi (#636)

[Christian Brabandt]

Hi Charles!

On Di, 01 Mär 2016, Charles E Campbell wrote:

> Has this been a vim bugtracker issue? 

Yes, basically all mails from vim-dev-git...@256bit.org are redirects 
from github and are mirrored to vim-dev. You can see it also in the 
subject which contains the repository in brackets ([vim]) and the issue 
number in parenthesis (#636).

You should be able to use reply-to-all in your mailer or group-reply and 
reply back to the github tracker. The reply address looks like 
reply+\w\+@reply.github.com

It appears in the github tracker as from the user vim-ml. However, I 
think that message won't be redirected back to vim-dev. You would need 
to add vim-dev in that case.

> The prior setup had some text that made that prominent in the message.  I 
> just looked at the original
> message; it says "Reply to this email directly or view it on GitHub". 

Well, we could add a github template file¹ which is prefilled with some 
information. Is there anything you would request to be shown there?
I can prepare a patch for that.

> Well, I don't see it on the bugtracker -- so I presume there is
> yet-another-mailing-list?  Should I be responding via that "view it on
> GitHub" link somehow, as obviously "replay to this email directly" does
> not work.

What bugtracker have you been using? The current bugtracker is:
https://github.com/vim/vim/issues/ and I always thought, the email 
notifications message make this pretty clear.

¹https://github.com/blog/2111-issue-and-pull-request-templates

Mit freundlichen Grüßen
Christian
-- 
Es ist sinnlos zu sagen: Wir tun unser Bestes. Es muß dir gelingen,
das zu tun, was erforderlich ist.
-- Winston Spencer Churchill

-- 
-- 
You received this message from the "vim_dev" maillist.
Do not top-post! Type your reply below the text you are replying to.
For more information, visit http://www.vim.org/maillist.php

--- 
You received this message because you are subscribed to the Google Groups 
"vim_dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to vim_dev+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

Re: [vim] sh.vim incorrectly highlighting if/fi (#636)

[Charles E Campbell]

Christian Brabandt wrote:
> Hi Charles!
>
> On Di, 01 Mär 2016, Charles E Campbell wrote:
>
>> This is a solution, but inadequate, I'm afraid.  The right solution
>> (now, for the 3rd time): use a vim with patch 1141, along with
>> syntax/sh.vim v145.
> I am afraid, your message does not make it to the github issue, so the 
> OP did probably not notice. I'll leave an info there then and close.
>
Hello, Christian:

Has this been a vim bugtracker issue?  The prior setup had some text
that made that prominent in the message.  I just looked at the original
message; it says "Reply to this email directly or view it on GitHub". 
Well, I don't see it on the bugtracker -- so I presume there is
yet-another-mailing-list?  Should I be responding via that "view it on
GitHub" link somehow, as obviously "replay to this email directly" does
not work.

Regards,
Chip Campbell

-- 
-- 
You received this message from the "vim_dev" maillist.
Do not top-post! Type your reply below the text you are replying to.
For more information, visit http://www.vim.org/maillist.php

--- 
You received this message because you are subscribed to the Google Groups 
"vim_dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to vim_dev+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

Re: [vim] sh.vim incorrectly highlighting if/fi (#636)

[Christian Brabandt]

Hi Charles!

On Di, 01 Mär 2016, Charles E Campbell wrote:

> Christian Brabandt wrote:
> >
> > I think, the problem is this line from sh.vim (distributed with vim):
> >
> > |syn region shCaseEsac matchgroup=shConditional start="\ > matchgroup=shConditional end="\" end="\" contains=@shLoopList |
> >
> > which matches the xcode-select command. Something like this might work:
> >
> > diff --git a/runtime/syntax/sh.vim b/runtime/syntax/sh.vim
> > index 15a00eb..cbf10fb 100644
> > --- a/runtime/syntax/sh.vim
> > +++ b/runtime/syntax/sh.vim
> > @@ -240,7 +240,7 @@ if exists("b:is_kornshell") || exists("b:is_bash")
> >   syn cluster shFunctionListadd=shRepeat
> >   syn region shRepeat   matchgroup=shLoop   start="\ > end="\ >   syn region shRepeat   matchgroup=shLoop   start="\ > end="\ > - syn region shCaseEsac matchgroup=shConditional start="\ > matchgroup=shConditional end="\" end="\" contains=@shLoopList
> > + syn region shCaseEsac matchgroup=shConditional
> > start="-\@"
> > end="\" contains=@shLoopList
> >  else
> >   syn region shRepeat   matchgroup=shLoop   start="\ > end="\"me=e-2   contains=@shLoopList
> >   syn region shRepeat   matchgroup=shLoop   start="\ > end="\"me=e-2   contains=@shLoopList
> >
> This is a solution, but inadequate, I'm afraid.  The right solution
> (now, for the 3rd time): use a vim with patch 1141, along with
> syntax/sh.vim v145.

I am afraid, your message does not make it to the github issue, so the 
OP did probably not notice. I'll leave an info there then and close.

Best,
Christian
-- 
Wie man sein Kind nicht nennen sollte: 
  Caspar Puppe 

-- 
-- 
You received this message from the "vim_dev" maillist.
Do not top-post! Type your reply below the text you are replying to.
For more information, visit http://www.vim.org/maillist.php

--- 
You received this message because you are subscribed to the Google Groups 
"vim_dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to vim_dev+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

Re: [vim] sh.vim incorrectly highlighting if/fi (#636)

[Charles E Campbell]

Christian Brabandt wrote:
>
> I think, the problem is this line from sh.vim (distributed with vim):
>
> |syn region shCaseEsac matchgroup=shConditional start="\ matchgroup=shConditional end="\" end="\" contains=@shLoopList |
>
> which matches the xcode-select command. Something like this might work:
>
> diff --git a/runtime/syntax/sh.vim b/runtime/syntax/sh.vim
> index 15a00eb..cbf10fb 100644
> --- a/runtime/syntax/sh.vim
> +++ b/runtime/syntax/sh.vim
> @@ -240,7 +240,7 @@ if exists("b:is_kornshell") || exists("b:is_bash")
>   syn cluster shFunctionListadd=shRepeat
>   syn region shRepeat   matchgroup=shLoop   start="\ end="\"me=e-2 contains=@shLoopList,shDblParen,shDblBrace
>   syn region shRepeat   matchgroup=shLoop   start="\ end="\"me=e-2 contains=@shLoopList,shDblParen,shDblBrace
> - syn region shCaseEsac matchgroup=shConditional start="\ matchgroup=shConditional end="\" end="\" contains=@shLoopList
> + syn region shCaseEsac matchgroup=shConditional
> start="-\@"
> end="\" contains=@shLoopList
>  else
>   syn region shRepeat   matchgroup=shLoop   start="\ end="\"me=e-2   contains=@shLoopList
>   syn region shRepeat   matchgroup=shLoop   start="\ end="\"me=e-2   contains=@shLoopList
>
This is a solution, but inadequate, I'm afraid.  The right solution
(now, for the 3rd time): use a vim with patch 1141, along with
syntax/sh.vim v145.

Regards,
Chip Campbell

-- 
-- 
You received this message from the "vim_dev" maillist.
Do not top-post! Type your reply below the text you are replying to.
For more information, visit http://www.vim.org/maillist.php

--- 
You received this message because you are subscribed to the Google Groups 
"vim_dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to vim_dev+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

Re: [vim] sh.vim incorrectly highlighting if/fi (#636)

[Charles Campbell]

mattn wrote:
>
> Could you please try below?
>
> |$ vim -u NONE -N your.sh :syntax on ... move cursor into `--install`
> above ... :echo synIDattr(synID(line("."), col("."), 1), "name") |
>
> I get shOption.
>
>
I get shOption.  That's what --install is supposed to be highlighted as.
More fully:

SynStack:  shIf->shOption
HltTrace: shOption->shCommandSub->Special
fg<5> bg<-1>

Regards,
Chip Campbell

-- 
-- 
You received this message from the "vim_dev" maillist.
Do not top-post! Type your reply below the text you are replying to.
For more information, visit http://www.vim.org/maillist.php

--- 
You received this message because you are subscribed to the Google Groups 
"vim_dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to vim_dev+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

Re: [vim] sh.vim incorrectly highlighting if/fi (#636)

[Charles E Campbell]

Josh Reichardt wrote:
>
> With no plugins installed:
>
> With the cursor before the |--install| flag I get |shConditional|.
> With the cursor after the |--install| flag I get |shCaseEsac|.
>
>
shCaseEsac should only be in effect when one is using a case construct. 
Your example doesn't have a case construct.  I still see no problems,
though, even when I embed your example into a case.
shConditional is used for if, fi, then, elif, else, do, done, select,
in, case, and esac.

* I suggest using hilinks.vim (it'll translate what's under the cursor
into the  applicable syntax and highlighting groups; using :HLT! will
track your cursor as you move it).  See
http://www.drchip.org/astronaut/vim/index.html#HILINKS

* What does :version show?

* Try  usinjg
   vim -u NONE
   :set nocp
   :syn on
   :so [path]/.vim/plugin/hilinks.vim(assuming you've gotten
hilinks.vim)

Regards,
Chip Campbell

-- 
-- 
You received this message from the "vim_dev" maillist.
Do not top-post! Type your reply below the text you are replying to.
For more information, visit http://www.vim.org/maillist.php

--- 
You received this message because you are subscribed to the Google Groups 
"vim_dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to vim_dev+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

Re: [vim] sh.vim incorrectly highlighting if/fi (#636)

[Charles E Campbell]

Christian Brabandt wrote:
>
> Well, what is the output of the synID command given above? It does not
> seem reproducible.
>
>
Version questions:

 * what version of syntax/sh.vim are you using?  The latest release: v145
 * what version of vim are you using?  You need 7.4.1141 or later.

Charles Campbell

-- 
-- 
You received this message from the "vim_dev" maillist.
Do not top-post! Type your reply below the text you are replying to.
For more information, visit http://www.vim.org/maillist.php

--- 
You received this message because you are subscribed to the Google Groups 
"vim_dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to vim_dev+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

Re: [vim] sh.vim incorrectly highlighting if/fi (#636)

[Charles Campbell]

mattn wrote:
>
> try following on cursor at |--install|.
>
> |echo synIDattr(synID(line("."), col("."), 1), "name") |
>
> what do you get?
>
>
Using hilinks.vim, which gives rather more information, and with the
cursor on --install:

SynStack:  shOption   HltTrace:
shOption->shCommandSub->Specialfg bg

which is what its supposed to be.

Chip Campbell

-- 
-- 
You received this message from the "vim_dev" maillist.
Do not top-post! Type your reply below the text you are replying to.
For more information, visit http://www.vim.org/maillist.php

--- 
You received this message because you are subscribed to the Google Groups 
"vim_dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to vim_dev+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

Re: [vim] sh.vim incorrectly highlighting if/fi (#636)

[Charles Campbell]

Josh Reichardt wrote:
>
> OS: |OS X 10.11.3|
> vim version: |7.4 (2013 Aug 10, compiled Feb 11 2016 11:34:55)|
> Info for filetype: |sh|
>
> To reproduce:
>
> |#!/usr/bin/env bash if ! which "xcode-select" > /dev/null; then echo
> "No xcode" else xcode-select --install fi |
>
> The select in xcode-select seems to be causing the problem? If I
> remove the --install flag the highlight error goes away.
>
>
Hello:

Please try v144 of syntax/sh.vim which you can get from my website:
http://www.drchip.org/astronaut/vim/index.html#SYNTAX_SH .

You'll need a vim v7.4 with patch#1141 for this update to affect the
highlighting, however.

Regards,
Chip Campbell

-- 
-- 
You received this message from the "vim_dev" maillist.
Do not top-post! Type your reply below the text you are replying to.
For more information, visit http://www.vim.org/maillist.php

--- 
You received this message because you are subscribed to the Google Groups 
"vim_dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to vim_dev+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.