Re: A small patch for gui_mac.c to let ATSUI support NON-antialias.
Just tested on macbook pro with 10.4.11, works fine. I tried set anti, set noanti, worked as expected.The binary was built on 10.5 with 10.4u sdks. LC On Mon, Aug 25, 2008 at 8:11 PM, Bram Moolenaar [EMAIL PROTECTED] wrote: LC Mi wrote: I tested it on 10.5, but it should work for 10.4 as well, since ATSUI is some traditional thing. :-)Just use LC Mi is fine. Before including this code we should make sure it also works on 10.4. Can someone please verify? btw, I noticed MacVim already has similar code to handle this as well. Thus I used the same variable name useAntialias to remind other developers about this fact. Yeah, MacVim doesn't have this bug and MacVim folks can just ignore this patch. :-) Similar code is not the same code. So it still needs to be tested. -- A)bort, R)etry, B)ang it with a large hammer /// Bram Moolenaar -- [EMAIL PROTECTED] -- http://www.Moolenaar.net \\\ ///sponsor Vim, vote for features -- http://www.Vim.org/sponsor/\\\ \\\download, build and distribute -- http://www.A-A-P.org /// \\\help me help AIDS victims -- http://ICCF-Holland.org /// --~--~-~--~~~---~--~~ You received this message from the vim_dev maillist. For more information, visit http://www.vim.org/maillist.php -~--~~~~--~~--~--~---
Re: A small patch for gui_mac.c to let ATSUI support NON-antialias.
I tested it on 10.5, but it should work for 10.4 as well, since ATSUI is some traditional thing. :-)Just use LC Mi is fine. btw, I noticed MacVim already has similar code to handle this as well. Thus I used the same variable name useAntialias to remind other developers about this fact. Yeah, MacVim doesn't have this bug and MacVim folks can just ignore this patch. :-) On Sun, Aug 24, 2008 at 12:47 PM, Bram Moolenaar [EMAIL PROTECTED] wrote: LC Mi wrote: New to submitting a patch. Please let me know how to submit if folks agree with this patch. :-) Thanks! Attach the diff: Thanks. What version of Mac OS/X does this work with? What have you tested it on? Is LC Mi your full name? I need to know where code comes from. -- Imagine a world without hypothetical situations. /// Bram Moolenaar -- [EMAIL PROTECTED] -- http://www.Moolenaar.net \\\ ///sponsor Vim, vote for features -- http://www.Vim.org/sponsor/\\\ \\\download, build and distribute -- http://www.A-A-P.org /// \\\help me help AIDS victims -- http://ICCF-Holland.org /// --~--~-~--~~~---~--~~ You received this message from the vim_dev maillist. For more information, visit http://www.vim.org/maillist.php -~--~~~~--~~--~--~---
Re: A small patch for gui_mac.c to let ATSUI support NON-antialias.
LC Mi wrote: I tested it on 10.5, but it should work for 10.4 as well, since ATSUI is some traditional thing. :-)Just use LC Mi is fine. Before including this code we should make sure it also works on 10.4. Can someone please verify? btw, I noticed MacVim already has similar code to handle this as well. Thus I used the same variable name useAntialias to remind other developers about this fact. Yeah, MacVim doesn't have this bug and MacVim folks can just ignore this patch. :-) Similar code is not the same code. So it still needs to be tested. -- A)bort, R)etry, B)ang it with a large hammer /// Bram Moolenaar -- [EMAIL PROTECTED] -- http://www.Moolenaar.net \\\ ///sponsor Vim, vote for features -- http://www.Vim.org/sponsor/ \\\ \\\download, build and distribute -- http://www.A-A-P.org/// \\\help me help AIDS victims -- http://ICCF-Holland.org/// --~--~-~--~~~---~--~~ You received this message from the vim_dev maillist. For more information, visit http://www.vim.org/maillist.php -~--~~~~--~~--~--~---
Re: A small patch for gui_mac.c to let ATSUI support NON-antialias.
Thank you! How to submit the patch though? I tried mac vim, looks great, but I didn't feel I had to do the switching for now... :-) LC On Sat, Aug 23, 2008 at 6:50 PM, Jjgod Jiang [EMAIL PROTECTED] wrote: Hi, On Sun, Aug 24, 2008 at 12:24 AM, LC Mi [EMAIL PROTECTED] wrote: New to submitting a patch. Please let me know how to submit if folks agree with this patch. :-) Thanks! As the last one touching the Carbon vim GUI code, I'd say this patch looks fine for me. However you may want to check out [EMAIL PROTECTED] since most Mac vim users have move on to use Cocoa based vim GUI. Just in case you haven't noticed that. - Jiang --~--~-~--~~~---~--~~ You received this message from the vim_dev maillist. For more information, visit http://www.vim.org/maillist.php -~--~~~~--~~--~--~---
Re: A small patch for gui_mac.c to let ATSUI support NON-antialias.
Hi, On 24.08.2008, at 20:09, LC Mi wrote: Thank you! How to submit the patch though? You've submitted it now. In my experience, Bram will add it to his TODO list and, if there are no reports about any problems, will merge it in a few months. I tried mac vim, looks great, but I didn't feel I had to do the switching for now... :-) Fair enough. If you submit a patch to MacVim, it's usually merged in a few days instead of a few months, though. Nico --~--~-~--~~~---~--~~ You received this message from the vim_dev maillist. For more information, visit http://www.vim.org/maillist.php -~--~~~~--~~--~--~---
A small patch for gui_mac.c to let ATSUI support NON-antialias.
New to submitting a patch. Please let me know how to submit if folks agree
with this patch. :-) Thanks!
Attach the diff:
Index: src/gui_mac.c
===
--- src/gui_mac.c (revision 1164)
+++ src/gui_mac.c (working copy)
@@ -173,6 +173,7 @@
ATSUStyle gWideFontStyle;
# endif
BooleangIsFontFallbackSet;
+UInt32 useAntialias_cache = 0x0;
#endif
/* Colors Macros */
@@ -4123,6 +4124,24 @@
ATSUSetAttributes(gFontStyle, 1, attribTags, attribSizes, attribValues);
}
+UInt32 useAntialias = p_antialias ? kATSStyleApplyAntiAliasing
+ : kATSStyleNoAntiAliasing;
+if (useAntialias != useAntialias_cache)
+{
+
+ATSUAttributeTag attribTags[] = { kATSUStyleRenderingOptionsTag
};
+ByteCount attribSizes[] = { sizeof(UInt32) };
+ATSUAttributeValuePtr attribValues[] = { useAntialias };
+
+if (gFontStyle)
+ATSUSetAttributes(gFontStyle, 1, attribTags, attribSizes,
attribValues);
+
+if (gWideFontStyle)
+ATSUSetAttributes(gWideFontStyle, 1, attribTags,
attribSizes, attribValues);
+
+useAntialias_cache = useAntialias;
+}
+
#ifdef FEAT_MBYTE
if (has_mbyte)
{
--
cicicici
--~--~-~--~~~---~--~~
You received this message from the vim_dev maillist.
For more information, visit http://www.vim.org/maillist.php
-~--~~~~--~~--~--~---
Re: A small patch for gui_mac.c to let ATSUI support NON-antialias.
Hi, On Sun, Aug 24, 2008 at 12:24 AM, LC Mi [EMAIL PROTECTED] wrote: New to submitting a patch. Please let me know how to submit if folks agree with this patch. :-) Thanks! As the last one touching the Carbon vim GUI code, I'd say this patch looks fine for me. However you may want to check out [EMAIL PROTECTED] since most Mac vim users have move on to use Cocoa based vim GUI. Just in case you haven't noticed that. - Jiang --~--~-~--~~~---~--~~ You received this message from the vim_dev maillist. For more information, visit http://www.vim.org/maillist.php -~--~~~~--~~--~--~---
