Re: Patch 8.1.1031
* Bram Moolenaar [2019-03-22 11:33 +0100]: [...] > I added 1% and this goes over the limit by 1.02%. > I guess I'll have to make the tolerance 3%. With 8.1.1034 the build runs just fine on my i686. Thanks Elimar -- We all know Linux is great... it does infinite loops in 5 seconds. -Linus Torvalds -- -- You received this message from the "vim_dev" maillist. Do not top-post! Type your reply below the text you are replying to. For more information, visit http://www.vim.org/maillist.php --- You received this message because you are subscribed to the Google Groups "vim_dev" group. To unsubscribe from this group and stop receiving emails from it, send an email to vim_dev+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
Re: Patch 8.1.1031
> > I added 1% and this goes over the limit by 1.02%. > > I guess I'll have to make the tolerance 3%. > > Even with 3% tolerance (per 8.1.1033) I'm still seeing this on i686 [1] > (and armhf [2]): > > From test_memory_usage.vim: > Found errors in Test_memory_func_capture_lvars(): > function RunTheTest[40]..Test_memory_func_capture_lvars line 33: > Expected range 6579 - 22985, but got 23108 > TEST FAILURE > > Is the reported upper range number (in this case 22985) the 100% value, > or the 103% value? It is the 103% value. We could increase it to 105%. > Another build with larger value difference [2]: > > >From test_memory_usage.vim: > Found errors in Test_memory_func_capture_lvars(): > function RunTheTest[40]..Test_memory_func_capture_lvars line 33: > Expected range 12780 - 28292, but got 30896 > TEST FAILURE That is a lot more, about 10%. We could use a tolerance of 20%. I suppose that when the memory use problem would come back it would still be caught. > The build/packaging process in these logs runs several times with > different enabled features/flags. The first run [1] failed while testing > "vim-basic", the second run [3] succeeded where [1] failed but failed > later while testing "vim-gtk", and a third run [4] succeeded where [1] > and [3] failed but failed later still while testing "vim-gtk3". (and a > fourth run failed again testing "vim-basic". [5]) > > The test looks pretty flaky for 32-bit... 64-bit builds (amd64, arm64) > don't have the same problem. I suspect that these machines are quite busy, causing more fluctuation in memory use. -- >From "know your smileys": :-| :-| Deja' vu! /// Bram Moolenaar -- b...@moolenaar.net -- http://www.Moolenaar.net \\\ ///sponsor Vim, vote for features -- http://www.Vim.org/sponsor/ \\\ \\\ an exciting new programming language -- http://www.Zimbu.org/// \\\help me help AIDS victims -- http://ICCF-Holland.org/// -- -- You received this message from the "vim_dev" maillist. Do not top-post! Type your reply below the text you are replying to. For more information, visit http://www.vim.org/maillist.php --- You received this message because you are subscribed to the Google Groups "vim_dev" group. To unsubscribe from this group and stop receiving emails from it, send an email to vim_dev+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
Re: Patch 8.1.1031
On 22/03/2019 10:33, Bram Moolenaar wrote: > > Elimar Riesebieter wrote: > >> * Bram Moolenaar [2019-03-21 21:16 +0100]: >> >>> >>> Patch 8.1.1031 >>> Problem:Memory usage test may still fail. >>> Solution: Drop the unused min value. (Christian Brabandt) >>> Files: src/testdir/test_memory_usage.vim >> >> Still get on i686: >> >> From test_memory_usage.vim: >> Found errors in Test_memory_func_capture_lvars(): >> function RunTheTest[40]..Test_memory_func_capture_lvars line 33: Expected >> range 10051 - 26967, but got 27516 >> TEST FAILURE > > I added 1% and this goes over the limit by 1.02%. > I guess I'll have to make the tolerance 3%. > Even with 3% tolerance (per 8.1.1033) I'm still seeing this on i686 [1] (and armhf [2]): >From test_memory_usage.vim: Found errors in Test_memory_func_capture_lvars(): function RunTheTest[40]..Test_memory_func_capture_lvars line 33: Expected range 6579 - 22985, but got 23108 TEST FAILURE Is the reported upper range number (in this case 22985) the 100% value, or the 103% value? Another build with larger value difference [2]: >From test_memory_usage.vim: Found errors in Test_memory_func_capture_lvars(): function RunTheTest[40]..Test_memory_func_capture_lvars line 33: Expected range 12780 - 28292, but got 30896 TEST FAILURE The build/packaging process in these logs runs several times with different enabled features/flags. The first run [1] failed while testing "vim-basic", the second run [3] succeeded where [1] failed but failed later while testing "vim-gtk", and a third run [4] succeeded where [1] and [3] failed but failed later still while testing "vim-gtk3". (and a fourth run failed again testing "vim-basic". [5]) The test looks pretty flaky for 32-bit... 64-bit builds (amd64, arm64) don't have the same problem. J [1] https://launchpadlibrarian.net/416114150/buildlog_ubuntu-bionic-i386.vim_2%3A8.1.1017+really.v8.1.1034-0york0~ubuntu18.04.1_BUILDING.txt.gz [2] https://launchpadlibrarian.net/416119282/buildlog_ubuntu-bionic-armhf.vim_2%3A8.1.1017+really.v8.1.1034-0york0~ubuntu18.04.1_BUILDING.txt.gz [3] https://launchpadlibrarian.net/416116391/buildlog_ubuntu-bionic-i386.vim_2%3A8.1.1017+really.v8.1.1034-0york0~ubuntu18.04.1_BUILDING.txt.gz [4] https://launchpadlibrarian.net/416118864/buildlog_ubuntu-bionic-i386.vim_2%3A8.1.1017+really.v8.1.1034-0york0~ubuntu18.04.1_BUILDING.txt.gz [5] https://code.launchpad.net/~jonathonf/+archive/ubuntu/vim-daily/+build/16521748/+files/buildlog_ubuntu-bionic-i386.vim_2%3A8.1.1017+really.v8.1.1034-0york0~ubuntu18.04.1_BUILDING.txt.gz (yes, it +really. is 8.1.1034 ;) -- -- You received this message from the "vim_dev" maillist. Do not top-post! Type your reply below the text you are replying to. For more information, visit http://www.vim.org/maillist.php --- You received this message because you are subscribed to the Google Groups "vim_dev" group. To unsubscribe from this group and stop receiving emails from it, send an email to vim_dev+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout. signature.asc Description: OpenPGP digital signature
Re: Patch 8.1.1031
Elimar Riesebieter wrote: > * Bram Moolenaar [2019-03-21 21:16 +0100]: > > > > > Patch 8.1.1031 > > Problem:Memory usage test may still fail. > > Solution: Drop the unused min value. (Christian Brabandt) > > Files: src/testdir/test_memory_usage.vim > > Still get on i686: > > From test_memory_usage.vim: > Found errors in Test_memory_func_capture_lvars(): > function RunTheTest[40]..Test_memory_func_capture_lvars line 33: Expected > range 10051 - 26967, but got 27516 > TEST FAILURE I added 1% and this goes over the limit by 1.02%. I guess I'll have to make the tolerance 3%. -- I AM THANKFUL... ...for a lawn that needs mowing, windows that need cleaning and gutters that need fixing because it means I have a home. /// Bram Moolenaar -- b...@moolenaar.net -- http://www.Moolenaar.net \\\ ///sponsor Vim, vote for features -- http://www.Vim.org/sponsor/ \\\ \\\ an exciting new programming language -- http://www.Zimbu.org/// \\\help me help AIDS victims -- http://ICCF-Holland.org/// -- -- You received this message from the "vim_dev" maillist. Do not top-post! Type your reply below the text you are replying to. For more information, visit http://www.vim.org/maillist.php --- You received this message because you are subscribed to the Google Groups "vim_dev" group. To unsubscribe from this group and stop receiving emails from it, send an email to vim_dev+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
Re: Patch 8.1.1031
* Bram Moolenaar [2019-03-21 21:16 +0100]: > > Patch 8.1.1031 > Problem:Memory usage test may still fail. > Solution: Drop the unused min value. (Christian Brabandt) > Files:src/testdir/test_memory_usage.vim Still get on i686: >From test_memory_usage.vim: Found errors in Test_memory_func_capture_lvars(): function RunTheTest[40]..Test_memory_func_capture_lvars line 33: Expected range 10051 - 26967, but got 27516 TEST FAILURE Elimar -- Never make anything simple and efficient when a way can be found to make it complex and wonderful ;-) -- -- You received this message from the "vim_dev" maillist. Do not top-post! Type your reply below the text you are replying to. For more information, visit http://www.vim.org/maillist.php --- You received this message because you are subscribed to the Google Groups "vim_dev" group. To unsubscribe from this group and stop receiving emails from it, send an email to vim_dev+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
Patch 8.1.1031
Patch 8.1.1031
Problem:Memory usage test may still fail.
Solution: Drop the unused min value. (Christian Brabandt)
Files: src/testdir/test_memory_usage.vim
*** ../vim-8.1.1030/src/testdir/test_memory_usage.vim 2019-03-20
22:44:58.439933744 +0100
--- src/testdir/test_memory_usage.vim 2019-03-21 21:15:30.477266842 +0100
***
*** 36,50
let proc = {}
let proc.pid = a:pid
let proc.hist = []
- let proc.min = 0
let proc.max = 0
func proc.op() abort
" Check the last 200ms.
let val = s:memory_usage(self.pid)
! if self.min > val
! let self.min = val
! elseif self.max < val
let self.max = val
endif
call add(self.hist, val)
--- 36,47
let proc = {}
let proc.pid = a:pid
let proc.hist = []
let proc.max = 0
func proc.op() abort
" Check the last 200ms.
let val = s:memory_usage(self.pid)
! if self.max < val
let self.max = val
endif
call add(self.hist, val)
***
*** 56,62
endfunc
call WaitFor({-> proc.op()}, 1)
! return {'last': get(proc.hist, -1), 'min': proc.min, 'max': proc.max}
endfunc
let s:term_vim = {}
--- 53,59
endfunc
call WaitFor({-> proc.op()}, 1)
! return {'last': get(proc.hist, -1), 'max': proc.max}
endfunc
let s:term_vim = {}
***
*** 101,108
" Estimate the limit of max usage as 2x initial usage.
call assert_inrange(before, 2 * before, after.max)
! " In this case, garbase collecting is not needed.
! call assert_equal(after.last, after.max)
call vim.stop()
call delete(testfile)
--- 98,108
" Estimate the limit of max usage as 2x initial usage.
call assert_inrange(before, 2 * before, after.max)
! " In this case, garbage collecting is not needed. The value might fluctuate
! " a bit, allow for 3% tolerance.
! let lower = after.last * 97 / 100
! let upper = after.last * 103 / 100
! call assert_inrange(lower, upper, after.max)
call vim.stop()
call delete(testfile)
***
*** 137,145
let last = s:monitor_memory_usage(vim.pid).last
endfor
! " The usage may be a bit less than the last value
let lower = before * 8 / 10
! call assert_inrange(lower, after.max + (after.last - before), last)
call vim.stop()
call delete(testfile)
--- 137,147
let last = s:monitor_memory_usage(vim.pid).last
endfor
! " The usage may be a bit less than the last value, use 80%.
! " Allow for 1% tolerance at the upper limit.
let lower = before * 8 / 10
! let upper = (after.max + (after.last - before)) * 101 / 100
! call assert_inrange(lower, upper, last)
call vim.stop()
call delete(testfile)
*** ../vim-8.1.1030/src/version.c 2019-03-21 21:12:46.282715864 +0100
--- src/version.c 2019-03-21 21:14:25.381831859 +0100
***
*** 781,782
--- 781,784
{ /* Add new patch number below this line */
+ /**/
+ 1031,
/**/
--
I AM THANKFUL...
...for the mess to clean after a party because it means I have
been surrounded by friends.
/// Bram Moolenaar -- b...@moolenaar.net -- http://www.Moolenaar.net \\\
///sponsor Vim, vote for features -- http://www.Vim.org/sponsor/ \\\
\\\ an exciting new programming language -- http://www.Zimbu.org///
\\\help me help AIDS victims -- http://ICCF-Holland.org///
--
--
You received this message from the "vim_dev" maillist.
Do not top-post! Type your reply below the text you are replying to.
For more information, visit http://www.vim.org/maillist.php
---
You received this message because you are subscribed to the Google Groups
"vim_dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to vim_dev+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.
