Re: Patch 8.1.2320
Hi, 2019/11/19 Tue 18:04:35 UTC+9 Elimar Riesebieter wrote: > > * Elimar Riesebieter > [2019-11-19 09:44 > +0100]: > > > * Bram Moolenaar > [2019-11-18 22:02 > +0100]: > > > > > > > > Patch 8.1.2320 > > > Problem:Insufficient test coverage for quickfix. > > > Solution: Add more tests. Fix uncovered problem. (Yegappan > Lakshmanan, > > > closes #5238) > > > Files:src/quickfix.c, src/testdir/test_quickfix.vim > > > > Building on amd64 I get: > > > > Failures: > > From test_quickfix.vim: > > Found errors in Test_helpgrep(): > > function RunTheTest[40]..Test_helpgrep[1]..5_test_xhelpgrep > line 42: Expected ['col', [['leaf', 1067], ['row', [['leaf', 1066], > ['leaf', 1065] but got ['row', [['col', [['leaf', 1067], ['leaf > > ', 1066]]], ['leaf', 1065]]] > > function RunTheTest[40]..Test_helpgrep[3]..5_test_xhelpgrep > line 42: Expected ['col', [['leaf', 1075], ['row', [['leaf', 1074], > ['leaf', 1073] but got ['row', [['col', [['leaf', 1075], ['leaf > > ', 1074]]], ['leaf', 1073]] > > This is on i386 and powerps as well. > > Looks like the same with https://github.com/vim/vim/pull/5244. Regards, Ken Takata -- -- You received this message from the "vim_dev" maillist. Do not top-post! Type your reply below the text you are replying to. For more information, visit http://www.vim.org/maillist.php --- You received this message because you are subscribed to the Google Groups "vim_dev" group. To unsubscribe from this group and stop receiving emails from it, send an email to vim_dev+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/vim_dev/8a812f84-b45d-485e-8183-5cc6b0041344%40googlegroups.com.
Re: Patch 8.1.2320
* Elimar Riesebieter [2019-11-19 09:44 +0100]: > * Bram Moolenaar [2019-11-18 22:02 +0100]: > > > > > Patch 8.1.2320 > > Problem:Insufficient test coverage for quickfix. > > Solution: Add more tests. Fix uncovered problem. (Yegappan Lakshmanan, > > closes #5238) > > Files: src/quickfix.c, src/testdir/test_quickfix.vim > > Building on amd64 I get: > > Failures: > From test_quickfix.vim: > Found errors in Test_helpgrep(): > function RunTheTest[40]..Test_helpgrep[1]..5_test_xhelpgrep line > 42: Expected ['col', [['leaf', 1067], ['row', [['leaf', 1066], ['leaf', > 1065] but got ['row', [['col', [['leaf', 1067], ['leaf > ', 1066]]], ['leaf', 1065]]] > function RunTheTest[40]..Test_helpgrep[3]..5_test_xhelpgrep line > 42: Expected ['col', [['leaf', 1075], ['row', [['leaf', 1074], ['leaf', > 1073] but got ['row', [['col', [['leaf', 1075], ['leaf > ', 1074]]], ['leaf', 1073]] This is on i386 and powerps as well. Elimar -- .~. /V\ L I N U X /( )\ >Phear the Penguin< ^^-^^ -- -- You received this message from the "vim_dev" maillist. Do not top-post! Type your reply below the text you are replying to. For more information, visit http://www.vim.org/maillist.php --- You received this message because you are subscribed to the Google Groups "vim_dev" group. To unsubscribe from this group and stop receiving emails from it, send an email to vim_dev+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/vim_dev/20191119090431.44jche76mf6bgylf%40toy.home.lxtec.de.
Re: Patch 8.1.2320
* Bram Moolenaar [2019-11-18 22:02 +0100]: > > Patch 8.1.2320 > Problem:Insufficient test coverage for quickfix. > Solution: Add more tests. Fix uncovered problem. (Yegappan Lakshmanan, > closes #5238) > Files:src/quickfix.c, src/testdir/test_quickfix.vim Building on amd64 I get: Failures: From test_quickfix.vim: Found errors in Test_helpgrep(): function RunTheTest[40]..Test_helpgrep[1]..5_test_xhelpgrep line 42: Expected ['col', [['leaf', 1067], ['row', [['leaf', 1066], ['leaf', 1065] but got ['row', [['col', [['leaf', 1067], ['leaf ', 1066]]], ['leaf', 1065]]] function RunTheTest[40]..Test_helpgrep[3]..5_test_xhelpgrep line 42: Expected ['col', [['leaf', 1075], ['row', [['leaf', 1074], ['leaf', 1073] but got ['row', [['col', [['leaf', 1075], ['leaf ', 1074]]], ['leaf', 1073]] Elimar -- 355/113: Not the famous irrational number pi, but an incredible simulation! -unknown -- -- You received this message from the "vim_dev" maillist. Do not top-post! Type your reply below the text you are replying to. For more information, visit http://www.vim.org/maillist.php --- You received this message because you are subscribed to the Google Groups "vim_dev" group. To unsubscribe from this group and stop receiving emails from it, send an email to vim_dev+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/vim_dev/20191119084427.q5acjvh35ygeiypv%40toy.home.lxtec.de.
Patch 8.1.2320
Patch 8.1.2320
Problem:Insufficient test coverage for quickfix.
Solution: Add more tests. Fix uncovered problem. (Yegappan Lakshmanan,
closes #5238)
Files: src/quickfix.c, src/testdir/test_quickfix.vim
*** ../vim-8.1.2319/src/quickfix.c 2019-11-17 18:09:33.609491591 +0100
--- src/quickfix.c 2019-11-18 22:00:26.261437036 +0100
***
*** 3044,3055
static int
qf_jump_to_usable_window(int qf_fnum, int newwin, int *opened_window)
{
! win_T *usable_win_ptr = NULL;
! int usable_win;
qf_info_T *ll_ref = NULL;
- win_T *win;
-
- usable_win = 0;
// If opening a new window, then don't use the location list referred by
// the current window. Otherwise two windows will refer to the same
--- 3044,3052
static int
qf_jump_to_usable_window(int qf_fnum, int newwin, int *opened_window)
{
! win_T *usable_wp = NULL;
! int usable_win = FALSE;
qf_info_T *ll_ref = NULL;
// If opening a new window, then don't use the location list referred by
// the current window. Otherwise two windows will refer to the same
***
*** 3060,3076
if (ll_ref != NULL)
{
// Find a non-quickfix window with this location list
! usable_win_ptr = qf_find_win_with_loclist(ll_ref);
! if (usable_win_ptr != NULL)
! usable_win = 1;
}
if (!usable_win)
{
// Locate a window showing a normal buffer
! win = qf_find_win_with_normal_buf();
if (win != NULL)
! usable_win = 1;
}
// If no usable window is found and 'switchbuf' contains "usetab"
--- 3057,3073
if (ll_ref != NULL)
{
// Find a non-quickfix window with this location list
! usable_wp = qf_find_win_with_loclist(ll_ref);
! if (usable_wp != NULL)
! usable_win = TRUE;
}
if (!usable_win)
{
// Locate a window showing a normal buffer
! win_T *win = qf_find_win_with_normal_buf();
if (win != NULL)
! usable_win = TRUE;
}
// If no usable window is found and 'switchbuf' contains "usetab"
***
*** 3089,3095
else
{
if (curwin->w_llist_ref != NULL)// In a location window
! qf_goto_win_with_ll_file(usable_win_ptr, qf_fnum, ll_ref);
else// In a quickfix window
qf_goto_win_with_qfl_file(qf_fnum);
}
--- 3086,3092
else
{
if (curwin->w_llist_ref != NULL)// In a location window
! qf_goto_win_with_ll_file(usable_wp, qf_fnum, ll_ref);
else// In a quickfix window
qf_goto_win_with_qfl_file(qf_fnum);
}
***
*** 3454,3470
qfl->qf_ptr = qf_ptr;
qfl->qf_index = qf_index;
}
! if (p_swb != old_swb)
{
// Restore old 'switchbuf' value, but not when an autocommand or
// modeline has changed the value.
! if (p_swb == empty_option)
! {
! p_swb = old_swb;
! swb_flags = old_swb_flags;
! }
! else
! free_string_option(old_swb);
}
decr_quickfix_busy();
}
--- 3451,3462
qfl->qf_ptr = qf_ptr;
qfl->qf_index = qf_index;
}
! if (p_swb != old_swb && p_swb == empty_option)
{
// Restore old 'switchbuf' value, but not when an autocommand or
// modeline has changed the value.
! p_swb = old_swb;
! swb_flags = old_swb_flags;
}
decr_quickfix_busy();
}
*** ../vim-8.1.2319/src/testdir/test_quickfix.vim 2019-11-17
18:09:33.613491551 +0100
--- src/testdir/test_quickfix.vim 2019-11-18 22:00:26.261437036 +0100
***
*** 14,20
command! -nargs=* Xaddexpr caddexpr
command! -nargs=* -count Xolder colder
command! -nargs=* Xnewer cnewer
! command! -nargs=* Xopen copen
command! -nargs=* Xwindow cwindow
command! -nargs=* Xbottom cbottom
command! -nargs=* Xclose cclose
--- 14,20
command! -nargs=* Xaddexpr caddexpr
command! -nargs=* -count Xolder colder
command! -nargs=* Xnewer cnewer
! command! -nargs=* Xopen copen
command! -nargs=* Xwindow cwindow
command! -nargs=* Xbottom cbottom
command! -nargs=* Xclose cclose
***
*** 32,39
command! -count -nargs=* -bang Xnfile cnfile
command! -nargs=* -bang Xpfile cpfile
command! -nargs=* Xexpr cexpr
! command! -range -nargs=* Xvimgrep vimgrep
! command! -nargs=* Xvimgrepadd vimgrepadd
command! -nargs=* Xgrep grep
command! -nargs=* Xgrepadd grepadd
command! -nargs=* Xhelpgrep helpgrep
--- 32,39
command! -count -nargs=* -bang Xnfile cnfil
