Re: Patch 7.4.855
Charles Campbell wrote:
> Bram Moolenaar wrote:
>> Patch 7.4.855
>> Problem:GTK: font glitches for combining characters
>> Solution: Use pango_shape_full() instead of pango_shape(). (luchr, PR #393)
>> Files: src/gui_gtk_x11.c
>>
>>
>> *** ../vim-7.4.854/src/gui_gtk_x11.c 2015-06-09 19:14:18.773373964 +0200
>> --- src/gui_gtk_x11.c2015-09-08 16:18:51.944711934 +0200
>> ***
>> *** 5063,5070
>> * done, because drawing the cursor would change the display. */
>> item->analysis.shape_engine = default_shape_engine;
>>
>> !pango_shape((const char *)s + item->offset, item->length,
>> !>analysis, glyphs);
>> /*
>> * Fixed-width hack: iterate over the array and assign a fixed
>> * width to each glyph, thus overriding the choice made by the
>> --- 5063,5070
>> * done, because drawing the cursor would change the display. */
>> item->analysis.shape_engine = default_shape_engine;
>>
>> !pango_shape_full((const char *)s + item->offset, item->length,
>> !(const char *)s, len, >analysis, glyphs);
>> /*
>> * Fixed-width hack: iterate over the array and assign a fixed
>> * width to each glyph, thus overriding the choice made by the
>> *** ../vim-7.4.854/src/version.c 2015-09-01 21:25:38.845874761 +0200
>> --- src/version.c2015-09-08 16:28:14.186863672 +0200
>> ***
>> *** 743,744
>> --- 743,746
>> { /* Add new patch number below this line */
>> + /**/
>> + 855,
>> /**/
> Hello,
>
> After (attempting to) apply 855 (and 861):
> /home/cec/.SW/VIM/vim74/src/gui_gtk_x11.c:5067: undefined reference to
> `pango_shape_full'
>
> I did run configure, btw. I'm using Scientific Linux release 6.7.
>
I'll further mention that I can no longer compile vim on my linux
workstation because of the undefined reference. I see where use of it
is protected by a #ifdef HAVE_PANGO_SHAPE_FULL test, so presumably the
problem lies with the configure step.
So I slipped a
#undef HAVE_PANGO_SHAPE_FULL
just before the #ifdef and vim compiles again.
Regards,
Chip Campbell
--
--
You received this message from the "vim_dev" maillist.
Do not top-post! Type your reply below the text you are replying to.
For more information, visit http://www.vim.org/maillist.php
---
You received this message because you are subscribed to the Google Groups
"vim_dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to vim_dev+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.
Re: Patch 7.4.855
Hi Charles! On Mi, 09 Sep 2015, Charles Campbell wrote: > I'll further mention that I can no longer compile vim on my linux > workstation because of the undefined reference. I see where use of it > is protected by a #ifdef HAVE_PANGO_SHAPE_FULL test, so presumably the > problem lies with the configure step. > > So I slipped a > > #undef HAVE_PANGO_SHAPE_FULL > > just before the #ifdef and vim compiles again. Did you update your source? Bram just committed a change. Best, Christian -- Wie man sein Kind nicht nennen sollte: Al Tersheim -- -- You received this message from the "vim_dev" maillist. Do not top-post! Type your reply below the text you are replying to. For more information, visit http://www.vim.org/maillist.php --- You received this message because you are subscribed to the Google Groups "vim_dev" group. To unsubscribe from this group and stop receiving emails from it, send an email to vim_dev+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
Re: Patch 7.4.855
Christian Brabandt wrote: > Hi Charles! > > On Mi, 09 Sep 2015, Charles Campbell wrote: > >> I'll further mention that I can no longer compile vim on my linux >> workstation because of the undefined reference. I see where use of it >> is protected by a #ifdef HAVE_PANGO_SHAPE_FULL test, so presumably the >> problem lies with the configure step. >> >> So I slipped a >> >> #undef HAVE_PANGO_SHAPE_FULL >> >> just before the #ifdef and vim compiles again. > Did you update your source? Bram just committed a change. > > Thank you! Vim now compiles without my hack. Regards, Chip Campbell -- -- You received this message from the "vim_dev" maillist. Do not top-post! Type your reply below the text you are replying to. For more information, visit http://www.vim.org/maillist.php --- You received this message because you are subscribed to the Google Groups "vim_dev" group. To unsubscribe from this group and stop receiving emails from it, send an email to vim_dev+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
Re: Patch 7.4.855
Bram Moolenaar wrote:
> Patch 7.4.855
> Problem:GTK: font glitches for combining characters
> Solution: Use pango_shape_full() instead of pango_shape(). (luchr, PR #393)
> Files: src/gui_gtk_x11.c
>
>
> *** ../vim-7.4.854/src/gui_gtk_x11.c 2015-06-09 19:14:18.773373964 +0200
> --- src/gui_gtk_x11.c 2015-09-08 16:18:51.944711934 +0200
> ***
> *** 5063,5070
>* done, because drawing the cursor would change the display. */
> item->analysis.shape_engine = default_shape_engine;
>
> ! pango_shape((const char *)s + item->offset, item->length,
> ! >analysis, glyphs);
> /*
>* Fixed-width hack: iterate over the array and assign a fixed
>* width to each glyph, thus overriding the choice made by the
> --- 5063,5070
>* done, because drawing the cursor would change the display. */
> item->analysis.shape_engine = default_shape_engine;
>
> ! pango_shape_full((const char *)s + item->offset, item->length,
> ! (const char *)s, len, >analysis, glyphs);
> /*
>* Fixed-width hack: iterate over the array and assign a fixed
>* width to each glyph, thus overriding the choice made by the
> *** ../vim-7.4.854/src/version.c 2015-09-01 21:25:38.845874761 +0200
> --- src/version.c 2015-09-08 16:28:14.186863672 +0200
> ***
> *** 743,744
> --- 743,746
> { /* Add new patch number below this line */
> + /**/
> + 855,
> /**/
Hello,
After (attempting to) apply 855 (and 861):
/home/cec/.SW/VIM/vim74/src/gui_gtk_x11.c:5067: undefined reference to
`pango_shape_full'
I did run configure, btw. I'm using Scientific Linux release 6.7.
Regards,
Chip Campbell
--
--
You received this message from the "vim_dev" maillist.
Do not top-post! Type your reply below the text you are replying to.
For more information, visit http://www.vim.org/maillist.php
---
You received this message because you are subscribed to the Google Groups
"vim_dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to vim_dev+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.
