Re: Patch 8.2.0807

2020-05-22 Fir de Conversatie Bram Moolenaar


Marius Gedminas wrote:

> On Fri, May 22, 2020 at 01:11:18PM +0200, Bram Moolenaar wrote:
> > Patch 8.2.0807
> > Problem:Cannot easily restore a mapping.
> > Solution:   Add mapset().
> > Files:  runtime/doc/eval.txt, src/map.c, src/proto/map.pro, 
> > src/evalfunc.c
> > src/testdir/test_maparg.vim
> 
> > *** ../vim-8.2.0806/runtime/doc/eval.txt2020-05-13 16:34:10.397723799 
> > +0200
> > --- runtime/doc/eval.txt2020-05-22 12:52:07.920142788 +0200
> > ***
> > *** 2582,2587 
> > --- 2586,2593 
> > rhs of mapping {name} in mode {mode}
> >   mapcheck({name} [, {mode} [, {abbr}]])
> > String  check for mappings matching {name}
> > + mapset({name}, {mode}, {abbr}, {dict}
> 
> This line is missing a closing )

Right, and {name} should not be there.


-- 
hundred-and-one symptoms of being an internet addict:
164. You got out to buy software, instead of going out for a beer.

 /// Bram Moolenaar -- b...@moolenaar.net -- http://www.Moolenaar.net   \\\
///sponsor Vim, vote for features -- http://www.Vim.org/sponsor/ \\\
\\\  an exciting new programming language -- http://www.Zimbu.org///
 \\\help me help AIDS victims -- http://ICCF-Holland.org///

-- 
-- 
You received this message from the "vim_dev" maillist.
Do not top-post! Type your reply below the text you are replying to.
For more information, visit http://www.vim.org/maillist.php

--- 
You received this message because you are subscribed to the Google Groups 
"vim_dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to vim_dev+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/vim_dev/202005221841.04MIfN8m024111%40masaka.moolenaar.net.


Re: Patch 8.2.0807

2020-05-22 Fir de Conversatie Marius Gedminas
On Fri, May 22, 2020 at 01:11:18PM +0200, Bram Moolenaar wrote:
> Patch 8.2.0807
> Problem:Cannot easily restore a mapping.
> Solution:   Add mapset().
> Files:  runtime/doc/eval.txt, src/map.c, src/proto/map.pro, src/evalfunc.c
> src/testdir/test_maparg.vim

> *** ../vim-8.2.0806/runtime/doc/eval.txt  2020-05-13 16:34:10.397723799 
> +0200
> --- runtime/doc/eval.txt  2020-05-22 12:52:07.920142788 +0200
> ***
> *** 2582,2587 
> --- 2586,2593 
>   rhs of mapping {name} in mode {mode}
>   mapcheck({name} [, {mode} [, {abbr}]])
>   String  check for mappings matching {name}
> + mapset({name}, {mode}, {abbr}, {dict}

This line is missing a closing )

> + nonerestore mapping from |maparg()| result
>   match({expr}, {pat} [, {start} [, {count}]])
>   Number  position where {pat} matches in {expr}
>   matchadd({group}, {pattern} [, {priority} [, {id} [, {dict}]]])

Marius Gedminas
-- 
Isn't air travel wonderful?  Breakfast in London, dinner in New York,
luggage in Brazil.

-- 
-- 
You received this message from the "vim_dev" maillist.
Do not top-post! Type your reply below the text you are replying to.
For more information, visit http://www.vim.org/maillist.php

--- 
You received this message because you are subscribed to the Google Groups 
"vim_dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to vim_dev+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/vim_dev/20200522175003.apohgnrymvqnl72u%40blynas.


signature.asc
Description: PGP signature


Re: Patch 8.2.0807

2020-05-22 Fir de Conversatie Bram Moolenaar


Tony wrote:

> On Fri, May 22, 2020 at 1:11 PM Bram Moolenaar  wrote:
> >
> >
> > Patch 8.2.0807
> > Problem:Cannot easily restore a mapping.
> > Solution:   Add mapset().
> > Files:  runtime/doc/eval.txt, src/map.c, src/proto/map.pro, 
> > src/evalfunc.c
> > src/testdir/test_maparg.vim
> 
> Missing #ifdef ? I get a fatal error in Small and Tiny, as follows:
> 
> linux-2iyu:~/.build/vim/vim-hg/src/shadow-tiny # (make || echo 'exit
> status' $? ; date) 2>&1 |tee -a make.log
> gcc -c -I. -Iproto -DHAVE_CONFIG_H -O2 -fno-strength-reduce -Wall
> -U_FORTIFY_SOURCE -D_FORTIFY_SOURCE=1-o objects/evalfunc.o
> evalfunc.c
> gcc -c -I. -Iproto -DHAVE_CONFIG_H -O2 -fno-strength-reduce -Wall
> -U_FORTIFY_SOURCE -D_FORTIFY_SOURCE=1-o objects/map.o map.c
> map.c: In function ‘do_map’:
> map.c:842:58: error: ‘expr’ undeclared (first use in this function);
> did you mean ‘ex_z’?
>   if (map_add(map_table, abbr_table, keys, rhs, orig_rhs, expr,
>   ^~~~
>   ex_z

Ah, "expr" also depends on FEAT_EVAL, I'll fix that.

Note that it's not easy to restore a mapping exactly how it was done
before.  Watch out for anything that's not restored properly.

-- 
hundred-and-one symptoms of being an internet addict:
158. You get a tuner card so you can watch TV while surfing.

 /// Bram Moolenaar -- b...@moolenaar.net -- http://www.Moolenaar.net   \\\
///sponsor Vim, vote for features -- http://www.Vim.org/sponsor/ \\\
\\\  an exciting new programming language -- http://www.Zimbu.org///
 \\\help me help AIDS victims -- http://ICCF-Holland.org///

-- 
-- 
You received this message from the "vim_dev" maillist.
Do not top-post! Type your reply below the text you are replying to.
For more information, visit http://www.vim.org/maillist.php

--- 
You received this message because you are subscribed to the Google Groups 
"vim_dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to vim_dev+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/vim_dev/202005221140.04MBe1jE022915%40masaka.moolenaar.net.


Re: Patch 8.2.0807

2020-05-22 Fir de Conversatie Tony Mechelynck
On Fri, May 22, 2020 at 1:11 PM Bram Moolenaar  wrote:
>
>
> Patch 8.2.0807
> Problem:Cannot easily restore a mapping.
> Solution:   Add mapset().
> Files:  runtime/doc/eval.txt, src/map.c, src/proto/map.pro, src/evalfunc.c
> src/testdir/test_maparg.vim

Missing #ifdef ? I get a fatal error in Small and Tiny, as follows:

linux-2iyu:~/.build/vim/vim-hg/src/shadow-tiny # (make || echo 'exit
status' $? ; date) 2>&1 |tee -a make.log
gcc -c -I. -Iproto -DHAVE_CONFIG_H -O2 -fno-strength-reduce -Wall
-U_FORTIFY_SOURCE -D_FORTIFY_SOURCE=1-o objects/evalfunc.o
evalfunc.c
gcc -c -I. -Iproto -DHAVE_CONFIG_H -O2 -fno-strength-reduce -Wall
-U_FORTIFY_SOURCE -D_FORTIFY_SOURCE=1-o objects/map.o map.c
map.c: In function ‘do_map’:
map.c:842:58: error: ‘expr’ undeclared (first use in this function);
did you mean ‘ex_z’?
  if (map_add(map_table, abbr_table, keys, rhs, orig_rhs, expr,
  ^~~~
  ex_z
map.c:842:58: note: each undeclared identifier is reported only once
for each function it appears in
make: *** [Makefile:3344: objects/map.o] Error 1
exit status 2
Fri 22 May 13:16:17 CEST 2020
linux-2iyu:~/.build/vim/vim-hg/src/shadow-tiny #



Best regards,
Tony.

-- 
-- 
You received this message from the "vim_dev" maillist.
Do not top-post! Type your reply below the text you are replying to.
For more information, visit http://www.vim.org/maillist.php

--- 
You received this message because you are subscribed to the Google Groups 
"vim_dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to vim_dev+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/vim_dev/CAJkCKXsT0KzT2t-yT7P%2BwEKvsakR%2BeNTqFF1ZYP2b%2BttKkOHiw%40mail.gmail.com.