Re: cpo-=l full list

2011-12-27 Fir de Conversatie Charles E Campbell Jr

Thilo Six wrote:

Taylor Hedberg wrote the following on 25.12.2011 05:20

Hello Charles,

   

Charles E Campbell Jr, Sat 2011-12-24 @ 22:11:31-0500:
 

If I may repeat myself, what advantage does
   set cpo-=a cpo-=A
have over
   set cpo-=aA
???
   

 From `:help :set-=`:

When the option is a list of flags, {value} must be
exactly as they appear in the option.  Remove flags
one by one to avoid problems.

Removing the flags individually is guaranteed to work regardless of the
order and position in which the flags appear in the option string. This
is not true if you remove them in combination.
 

Thank you Taylor that i exactly what i thought of.

Charles here is a example:
:set cpo?
cpoptions=aABceFs
:set cpo-=aA
cpoptions=BceFs

so far so good. Now lets have a crazy user shuffling things around:
:set cpo?
cpoptions=ABFacespretty much default, just different order
:set cpo-=aA
:set cpo?
cpoptions=ABFaces
:set cpo-=a
:set cpo-=A
:set cpo?
cpoptions=BFces
   

OK, I'll include the change.

Thank you,
Chip Campbell

--
You received this message from the vim_dev maillist.
Do not top-post! Type your reply below the text you are replying to.
For more information, visit http://www.vim.org/maillist.php


Re: cpo-=l full list

2011-12-25 Fir de Conversatie Thilo Six
Taylor Hedberg wrote the following on 25.12.2011 05:20

Hello Charles,

 Charles E Campbell Jr, Sat 2011-12-24 @ 22:11:31-0500:
 If I may repeat myself, what advantage does
   set cpo-=a cpo-=A
 have over
   set cpo-=aA
 ???
 
 From `:help :set-=`:
 
   When the option is a list of flags, {value} must be
   exactly as they appear in the option.  Remove flags
   one by one to avoid problems.
 
 Removing the flags individually is guaranteed to work regardless of the
 order and position in which the flags appear in the option string. This
 is not true if you remove them in combination.

Thank you Taylor that i exactly what i thought of.

Charles here is a example:
:set cpo?
cpoptions=aABceFs
:set cpo-=aA
cpoptions=BceFs

so far so good. Now lets have a crazy user shuffling things around:
:set cpo?
cpoptions=ABFacespretty much default, just different order
:set cpo-=aA
:set cpo?
cpoptions=ABFaces
:set cpo-=a
:set cpo-=A
:set cpo?
cpoptions=BFces

HTH
-- 
Regards,
Thilo

4096R/0xC70B1A8F
721B 1BA0 095C 1ABA 3FC6  7C18 89A4 A2A0 C70B 1A8F


-- 
You received this message from the vim_dev maillist.
Do not top-post! Type your reply below the text you are replying to.
For more information, visit http://www.vim.org/maillist.php


Re: cpo-=l full list

2011-12-24 Fir de Conversatie Thilo Six
just an status update.


-- 
Regards,
Thilo

4096R/0xC70B1A8F
721B 1BA0 095C 1ABA 3FC6  7C18 89A4 A2A0 C70B 1A8F

-- 
You received this message from the vim_dev maillist.
Do not top-post! Type your reply below the text you are replying to.
For more information, visit http://www.vim.org/maillist.php
patch sent out
FALSE POSITIVES:

~/build/vim/runtime/autoload/gzip.vim   2011-12-04reviewed 
again, nothing to do.
~/build/vim/runtime/autoload/tohtml.vim 2011-12-04reviewed 
again, nothing to do.
~/build/vim/runtime/ftplugin/matlab.vim 2011-12-04reviewed 
again, nothing to do.
~/build/vim/runtime/ftplugin/vim.vim2011-12-04reviewed 
again, nothing to do.
~/build/vim/runtime/syntax/named.vim2011-12-04reviewed 
again, nothing to do.
~/build/vim/runtime/ftplugin/cobol.vim  2011-12-10reviewed 
again, nothing to do.



FIXED in Mercurial:

~/build/vim/runtime/ftplugin/falcon.vim 2011-12-10does not 
restore user cpo settings
~/build/vim/runtime/ftplugin/lua.vim2011-12-10does not 
restore user cpo settings
~/build/vim/runtime/ftplugin/ocaml.vim  2011-12-10not cpo+=l 
save
~/build/vim/runtime/ftplugin/vhdl.vim   2011-12-10does not 
restore user cpo settings
~/build/vim/runtime/indent/falcon.vim   2011-12-10does not 
restore user cpo settings
~/build/vim/runtime/indent/tcsh.vim 2011-12-10does not 
restore user cpo settings
~/build/vim/runtime/indent/verilog.vim  2011-12-10does not 
restore user cpo settings
~/build/vim/runtime/syntax/lpc.vim  2011-12-10does not 
restore user cpo settings



PATCHES have been sent out:

~/build/vim/runtime/autoload/netrw.vim  2011-12-10
s:cpo-=aA:cpo-=a cpo-=A:
~/build/vim/runtime/autoload/vimball.vim2011-12-10does not 
restore user cpo settings
~/build/vim/runtime/compiler/fortran_g77.vim2011-12-10not cpo+=l 
save
~/build/vim/runtime/compiler/gcc.vim2011-12-10not cpo+=l 
save
~/build/vim/runtime/compiler/mcs.vim2011-12-10not cpo+=l 
save
~/build/vim/runtime/compiler/rst.vim2011-12-10not cpo+=l 
save
~/build/vim/runtime/compiler/splint.vim 2011-12-10not cpo+=l 
save
~/build/vim/runtime/compiler/tex.vim2011-12-10not cpo+=l 
save
~/build/vim/runtime/ftplugin/fortran.vim2011-12-10not cpo+=l 
save, cpo-=C too late down
~/build/vim/runtime/ftplugin/hamster.vim2011-12-10NEEDS REVIEW! 
restores cpo, after that then sets 'cpo+=M', make cpo_save scriptlocal, script 
sets global ingnorecase
~/build/vim/runtime/ftplugin/html.vim   2011-12-10not cpo+=l 
save
~/build/vim/runtime/ftplugin/ishd.vim   2011-12-10does not 
restore user cpo settings
~/build/vim/runtime/ftplugin/kwt.vim2011-12-10does not 
restore user cpo settings
~/build/vim/runtime/ftplugin/postscr.vim2011-12-10does not 
restore user cpo settings
~/build/vim/runtime/ftplugin/sql.vim2011-12-10'set cpo=' 
!??, not cpo+=l save
~/build/vim/runtime/ftplugin/xml.vim2011-12-10not cpo+=l 
save
~/build/vim/runtime/indent/fortran.vim  2011-12-10not cpo+=l 
save
~/build/vim/runtime/indent/sdl.vim  2011-12-10does not 
restore user cpo settings
~/build/vim/runtime/indent/xml.vim  2011-12-10does not 
restore user cpo settings
~/build/vim/runtime/ftplugin/ruby.vim   2011-12-24not cpo+=l 
save NEEDS REVIEW! uses \[\]   cpo-=C
~/build/vim/runtime/indent/html.vim 2011-12-24not cpo+=l 
save NEEDS REVIEW! uses [^\1]  cpo-=C
~/build/vim/runtime/indent/perl.vim 2011-12-24not cpo+=l 
save NEEDS REVIEW! uses [(){}\[\]] cpo-=C
~/build/vim/runtime/indent/perl6.vim2011-12-24not cpo+=l 
save NEEDS REVIEW! uses [^)}\]ยป]  cpo-=C
~/build/vim/runtime/syntax/2html.vim2011-12-24not cpo+=l 
save NEEDS REVIEW! uses [\\']   cpo-=C
~/build/vim/runtime/autoload/ccomplete.vim  2011-12-24not cpo+=l 
save
~/build/vim/runtime/autoload/javascriptcomplete.vim 2011-12-24not cpo+=l 
save
~/build/vim/runtime/autoload/phpcomplete.vim2011-12-24not cpo+=l 
save
~/build/vim/runtime/autoload/rubycomplete.vim   2011-12-24not cpo+=l 
save
~/build/vim/runtime/ftplugin/spec.vim   2011-12-24not cpo+=l 
save
~/build/vim/runtime/indent/cucumber.vim 2011-12-24not cpo+=l 
save
~/build/vim/runtime/indent/liquid.vim  

Re: cpo-=l full list

2011-12-24 Fir de Conversatie Charles E Campbell Jr

Thilo Six wrote:

just an status update.


   


~/build/vim/runtime/autoload/netrw.vim  2011-12-10
s:cpo-=aA:cpo-=a cpo-=A:

If I may repeat myself, what advantage does
  set cpo-=a cpo-=A
have over
  set cpo-=aA
???

Regards,
Chip Campbell


--
You received this message from the vim_dev maillist.
Do not top-post! Type your reply below the text you are replying to.
For more information, visit http://www.vim.org/maillist.php


Re: cpo-=l full list

2011-12-24 Fir de Conversatie Taylor Hedberg
Charles E Campbell Jr, Sat 2011-12-24 @ 22:11:31-0500:
 If I may repeat myself, what advantage does
   set cpo-=a cpo-=A
 have over
   set cpo-=aA
 ???

From `:help :set-=`:

When the option is a list of flags, {value} must be
exactly as they appear in the option.  Remove flags
one by one to avoid problems.

Removing the flags individually is guaranteed to work regardless of the
order and position in which the flags appear in the option string. This
is not true if you remove them in combination.


pgp2yN2XOEXSC.pgp
Description: PGP signature


Re: cpo-=l full list

2011-12-09 Fir de Conversatie Thilo Six
Thilo Six wrote the following on 23.10.2011 21:37

 
 -- snip --
 
 Full list now attached. Danek please tell me which of those are already has 
 been
 handled by you. Thanks.
 
 I did a QA rescan of runtimefiles and revealed some more with a faulty 
 handling
 of cpo settings. I consider this list now complete.

Upon review i found some false positives. These i will not bother:
runtime/autoload/gzip.vim   
runtime/autoload/tohtml.vim 
runtime/ftplugin/matlab.vim 
runtime/ftplugin/vim.vim
runtime/indent/html.vim 
runtime/indent/perl.vim 
runtime/indent/perl6.vim
runtime/syntax/2html.vim
runtime/syntax/named.vim



Patches for these have been send out:
runtime/autoload/netrw.vim  
runtime/autoload/vimball.vim
runtime/compiler/fortran_g77.vim
runtime/compiler/gcc.vim
runtime/compiler/mcs.vim
runtime/compiler/rst.vim
runtime/compiler/splint.vim 
runtime/compiler/tex.vim
runtime/ftplugin/falcon.vim 
runtime/ftplugin/fortran.vim
runtime/ftplugin/html.vim   
runtime/ftplugin/ishd.vim   
runtime/ftplugin/kwt.vim
runtime/ftplugin/lua.vim
runtime/ftplugin/ocaml.vim  
runtime/ftplugin/postscr.vim
runtime/ftplugin/sql.vim
runtime/ftplugin/vhdl.vim   
runtime/ftplugin/xml.vim
runtime/indent/falcon.vim   
runtime/indent/fortran.vim  
runtime/indent/sdl.vim  
runtime/indent/tcsh.vim 
runtime/indent/verilog.vim  
runtime/indent/xml.vim  
runtime/syntax/lpc.vim  


These are not strictly necessary but imho could still be improved. Therefor
patches send for these, too:
runtime/ftplugin/cobol.vim  
runtime/ftplugin/hamster.vim
runtime/ftplugin/ruby.vim

-- 
Regards,
Thilo

4096R/0xC70B1A8F
721B 1BA0 095C 1ABA 3FC6  7C18 89A4 A2A0 C70B 1A8F


-- 
You received this message from the vim_dev maillist.
Do not top-post! Type your reply below the text you are replying to.
For more information, visit http://www.vim.org/maillist.php


Re: cpo-=l full list

2011-10-23 Fir de Conversatie Thilo Six
Thilo Six wrote the following on 23.10.2011 00:12

-- snip --

 Additionally to already identified bogus files, where 'cpo-=C' is expected 
 there
 are ones which actually expect an environment which has 'cpo-=l' set!

 IMHO those need to be fixed, too.

 Actually those 'cpo-=l' bugs are not as obvious. I'll try to generate a list 
 and
 then would like to coordinate with you Danek again.
 
 Here we are. List part one attached. This list consists of those runtimefiles
 which already handle 'cpo' in some way but could be improved. Some actually 
 have
 real bugs. Most of them can be fixed simply by 's:cpo-=C:cpo\vim:'. See
 comments for details.

Full list now attached. Danek please tell me which of those are already has been
handled by you. Thanks.


-- 
Regards,
Thilo

4096R/0xC70B1A8F
721B 1BA0 095C 1ABA 3FC6  7C18 89A4 A2A0 C70B 1A8F

-- 
You received this message from the vim_dev maillist.
Do not top-post! Type your reply below the text you are replying to.
For more information, visit http://www.vim.org/maillist.php
./autoload/vimball.vimdoes not restore user cpo settings
./autoload/netrw.vim  s:cpo-=aA:cpo-=a cpo-=A:
./indent/xml.vim  not cpo+=l save + does not restore user cpo 
settings
./indent/verilog.vim  not cpo+=l save + does not restore user cpo 
settings
./indent/html.vim not cpo+=l save
./indent/perl6.vimnot cpo+=l save
./indent/fortran.vim  not cpo+=l save
./indent/falcon.vim   not cpo+=l save + does not restore user cpo 
settings
./indent/perl.vim not cpo+=l save
./compiler/gcc.vimnot cpo+=l save
./compiler/rst.vimnot cpo+=l save
./compiler/mcs.vimnot cpo+=l save
./compiler/splint.vim not cpo+=l save
./compiler/tex.vimnot cpo+=l save
./compiler/fortran_g77.vimnot cpo+=l save
./syntax/lpc.vim  not cpo+=l save + does not restore user cpo 
settings
./syntax/2html.vimnot cpo+=l save
./syntax/named.vimnot cpo+=l save
./ftplugin/ocaml.vim  not cpo+=l save
./ftplugin/vim.vimnot cpo+=l save, but does currently not use \ 
inside []
./ftplugin/cobol.vim  not cpo+=l save, restores cpo to early, but does 
currently not use \ inside []
./ftplugin/xml.vimnot cpo+=l save
./ftplugin/html.vim   not cpo+=l save
./ftplugin/fortran.vimnot cpo+=l save, cpo-=C too late down
./ftplugin/falcon.vim does not restore user cpo settings
./ftplugin/matlab.vim not cpo+=l save, but does currently not use \ 
inside []
./ftplugin/sql.vim'set cpo=' !??
./ftplugin/ruby.vim   not cpo+=l save, restores cpo to early





./autoload/ccomplete.vimnot cpo+=l save
./autoload/javascriptcomplete.vim   not cpo+=l save
./autoload/phpcomplete.vim  not cpo+=l save
./autoload/rubycomplete.vim not cpo+=l save
./ftplugin/spec.vim not cpo+=l save
./indent/cucumber.vim   not cpo+=l save
./indent/liquid.vim not cpo+=l save
./indent/make.vim   not cpo+=l save
./syntax/abel.vim   not cpo+=l save
./syntax/aml.vimnot cpo+=l save
./syntax/antlr.vim  \t in currently commented line
./syntax/apachestyle.vimnot cpo+=l save
./syntax/art.vimnot cpo+=l save
./syntax/asm.vimnot cpo+=l save
./syntax/asn.vimnot cpo+=l save
./syntax/awk.vimnot cpo+=l save
./syntax/ayacc.vim  not cpo+=l save
./syntax/basic.vim  not cpo+=l save
./syntax/bib.vimnot cpo+=l save
./syntax/blank.vim  not cpo+=l save
./syntax/c.vim  not cpo+=l save
./syntax/cf.vim not cpo+=l save
./syntax/chaiscript.vim not cpo+=l save
./syntax/clean.vim  not cpo+=l save
./syntax/clipper.vimnot cpo+=l save
./syntax/csc.vimnot cpo+=l save
./syntax/cupl.vim   not cpo+=l save
./syntax/cweb.vim   not cpo+=l save
./syntax/d.vim  not cpo+=l save
./syntax/dcl.vimnot cpo+=l save
./syntax/eiffel.vim not cpo+=l save
./syntax/fasm.vim   not cpo+=l save
./syntax/flexwiki.vim   not cpo+=l save
./syntax/forth.vim  not cpo+=l save
./syntax/fortran.vimnot cpo+=l save
./syntax/foxpro.vim not cpo+=l save
./syntax/fstab.vim  not cpo+=l save
./syntax/gdmo.vim   not cpo+=l save
./syntax/gitcommit.vim  not cpo+=l save
./syntax/gitolite.vim   not cpo+=l save
./syntax/gp.vim not cpo+=l save
./syntax/groovy.vim not cpo+=l save
./syntax/gsp.vimnot cpo+=l save
./syntax/haskell.vim