Re: Test failure in Test_diffmode.vim building 8.1.1735 on Linux powerpc

2019-07-25 Fir de Conversatie Bram Moolenaar


Elimar Riesebieter wrote:

> * Christian Brabandt  [2019-07-24 19:33 +0200]:
> 
> > Can you share the actual failed screendump file?
> > 
> > > Am 24.07.2019 um 15:27 schrieb Elimar Riesebieter :
> > > 
> > > * Bram Moolenaar  [2019-07-24 15:00 +0200]:
> > > 
> > >> 
> > >> Elimar Riesebieter wrote:
> > >> 
> > >>> I get test failures as follows:
> > >>> 
> > >>> Failures: 
> > >>>From test_diffmode.vim:
> > >>>Found errors in Test_diff_screen():
> > >>>Run 1:
> > >>>function 
> > >>> RunTheTest[40]..Test_diff_screen[95]..VerifyBoth[4]..VerifyScreenDump 
> > >>> line 55: external: See dump file difference: call 
> > >>> term_dumpdiff("testdir/failed/Test_diff_13.dump", 
> > >>> "testdir/dumps/Test_diff_13.dump"); difference in line 1: 
> > >>> "|-+0#e05#a8a8a8255| > 
> > >>> +0#000#ff0@34||+1&&|-+0#e05#a8a8a8255| | 
> > >>> +0#000#ff0@34"; difference in line 20: "|"+0&&|X|f|i|l|e|2|"| 
> > >>> |0|L|,| |0|C| @59"
> > >> 
> > >> [...]
> > >> 
> > >>>Flaky test failed too often, giving up
> > >>> :r
> > >>> 
> > >>> The failures are different in different attempts. Building on i386
> > >>> and amd64 runs fine, 
> > >> 
> > >> Any idea why it fails?  Could it be an actual failure in the diff code?
> > >> Might be related to byte order perhaps.
> > >> I can't reproduce, thus it's hard for me to try fixing it.
> > > 
> > > Well 8.1.1714 built fine. But there was no change in
> > > test_diffmode.vim... I don't have an overview which files in runtime
> > > changed since 8.1.1714.
> 
> It seems that v8.1.1724 is the first tag where test_diffmode.vim
> fails.

That didn't change functionality, only timing.

> Please find attached screendumps.

> Thanks for investigation

The first screendump is wrong.  But from the others I can see that
there is something different about how commands are interpreted.
E.g. for Test_diff_15.dump it did not get the "set" command to change
the diff options.  In Test_diff_16.dump it did get the next command,
thus it looks like it completely dropped the set command.

Is this build without the GUI feature?  Then the value for
BREAKCHECK_SKIP jumped from 32 to 1000.  You can try if using a lower
value indeed makes it work again.  That's not a solution, but good to
check if this changes the results.

For me it still works even when I set BREAKCHECK_SKIP to 1.

-- 
"The future's already arrived - it's just not evenly distributed yet."
-- William Gibson

 /// Bram Moolenaar -- b...@moolenaar.net -- http://www.Moolenaar.net   \\\
///sponsor Vim, vote for features -- http://www.Vim.org/sponsor/ \\\
\\\  an exciting new programming language -- http://www.Zimbu.org///
 \\\help me help AIDS victims -- http://ICCF-Holland.org///

-- 
-- 
You received this message from the "vim_dev" maillist.
Do not top-post! Type your reply below the text you are replying to.
For more information, visit http://www.vim.org/maillist.php

--- 
You received this message because you are subscribed to the Google Groups 
"vim_dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to vim_dev+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/vim_dev/201907252104.x6PL4ReU021386%40masaka.moolenaar.net.


Re: Test failure in Test_diffmode.vim building 8.1.1735 on Linux powerpc

2019-07-24 Fir de Conversatie Christian Brabandt


On Mi, 24 Jul 2019, Elimar Riesebieter wrote:

> * Christian Brabandt  [2019-07-24 19:33 +0200]:
> 
> > Can you share the actual failed screendump file?
> > 
> > > Am 24.07.2019 um 15:27 schrieb Elimar Riesebieter :
> > > 
> > > * Bram Moolenaar  [2019-07-24 15:00 +0200]:
> > > 
> > >> 
> > >> Elimar Riesebieter wrote:
> > >> 
> > >>> I get test failures as follows:
> > >>> 
> > >>> Failures: 
> > >>>From test_diffmode.vim:
> > >>>Found errors in Test_diff_screen():
> > >>>Run 1:
> > >>>function 
> > >>> RunTheTest[40]..Test_diff_screen[95]..VerifyBoth[4]..VerifyScreenDump 
> > >>> line 55: external: See dump file difference: call 
> > >>> term_dumpdiff("testdir/failed/Test_diff_13.dump", 
> > >>> "testdir/dumps/Test_diff_13.dump"); difference in line 1: 
> > >>> "|-+0#e05#a8a8a8255| > 
> > >>> +0#000#ff0@34||+1&&|-+0#e05#a8a8a8255| | 
> > >>> +0#000#ff0@34"; difference in line 20: "|"+0&&|X|f|i|l|e|2|"| 
> > >>> |0|L|,| |0|C| @59"
> > >> 
> > >> [...]
> > >> 
> > >>>Flaky test failed too often, giving up
> > >>> :r
> > >>> 
> > >>> The failures are different in different attempts. Building on i386
> > >>> and amd64 runs fine, 
> > >> 
> > >> Any idea why it fails?  Could it be an actual failure in the diff code?
> > >> Might be related to byte order perhaps.
> > >> I can't reproduce, thus it's hard for me to try fixing it.
> > > 
> > > Well 8.1.1714 built fine. But there was no change in
> > > test_diffmode.vim... I don't have an overview which files in runtime
> > > changed since 8.1.1714.
> 
> It seems that v8.1.1724 is the first tag where test_diffmode.vim
> fails. Please find attached screendumps.
> 
> Thanks for investigation

Well, the dump for 05 seems to be corrupted, it prints corrupted all 
over the place...

The dump for file 16 looks like it did not really update the diff? Not 
sure how this can happen.

The other is just the commandline displaying the filename instead of the 
:

To prevent this, the test always adds a "\n:" so that the commandline 
always displays as ':', apparently this did not work...

Can you manually run through the test Test_diff_screen() and see what 
happens?


Best,
Christian
-- 
Die Fähigkeit, seine Muße klug auszufüllen, ist die letzte Stufe der
persönlichen Kultur.
-- Bertrand A. W. Russell

-- 
-- 
You received this message from the "vim_dev" maillist.
Do not top-post! Type your reply below the text you are replying to.
For more information, visit http://www.vim.org/maillist.php

--- 
You received this message because you are subscribed to the Google Groups 
"vim_dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to vim_dev+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/vim_dev/20190724211634.GC9808%40256bit.org.


Re: Test failure in Test_diffmode.vim building 8.1.1735 on Linux powerpc

2019-07-24 Fir de Conversatie Elimar Riesebieter
* Christian Brabandt  [2019-07-24 19:33 +0200]:

> Can you share the actual failed screendump file?
> 
> > Am 24.07.2019 um 15:27 schrieb Elimar Riesebieter :
> > 
> > * Bram Moolenaar  [2019-07-24 15:00 +0200]:
> > 
> >> 
> >> Elimar Riesebieter wrote:
> >> 
> >>> I get test failures as follows:
> >>> 
> >>> Failures: 
> >>>From test_diffmode.vim:
> >>>Found errors in Test_diff_screen():
> >>>Run 1:
> >>>function 
> >>> RunTheTest[40]..Test_diff_screen[95]..VerifyBoth[4]..VerifyScreenDump 
> >>> line 55: external: See dump file difference: call 
> >>> term_dumpdiff("testdir/failed/Test_diff_13.dump", 
> >>> "testdir/dumps/Test_diff_13.dump"); difference in line 1: 
> >>> "|-+0#e05#a8a8a8255| > 
> >>> +0#000#ff0@34||+1&&|-+0#e05#a8a8a8255| | 
> >>> +0#000#ff0@34"; difference in line 20: "|"+0&&|X|f|i|l|e|2|"| 
> >>> |0|L|,| |0|C| @59"
> >> 
> >> [...]
> >> 
> >>>Flaky test failed too often, giving up
> >>> :r
> >>> 
> >>> The failures are different in different attempts. Building on i386
> >>> and amd64 runs fine, 
> >> 
> >> Any idea why it fails?  Could it be an actual failure in the diff code?
> >> Might be related to byte order perhaps.
> >> I can't reproduce, thus it's hard for me to try fixing it.
> > 
> > Well 8.1.1714 built fine. But there was no change in
> > test_diffmode.vim... I don't have an overview which files in runtime
> > changed since 8.1.1714.

It seems that v8.1.1724 is the first tag where test_diffmode.vim
fails. Please find attached screendumps.

Thanks for investigation

Elimar
-- 
  Excellent day for drinking heavily.
  Spike the office water cooler;-)

-- 
-- 
You received this message from the "vim_dev" maillist.
Do not top-post! Type your reply below the text you are replying to.
For more information, visit http://www.vim.org/maillist.php

--- 
You received this message because you are subscribed to the Google Groups 
"vim_dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to vim_dev+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/vim_dev/20190724203438.gthapw4whsrqw3db%40toy.home.lxtec.de.


vim-8.1.1724_Test_diffs_dumps.tar.xz
Description: application/xz


Re: Test failure in Test_diffmode.vim building 8.1.1735 on Linux powerpc

2019-07-24 Fir de Conversatie Christian Brabandt
Can you share the actual failed screendump file?

> Am 24.07.2019 um 15:27 schrieb Elimar Riesebieter :
> 
> * Bram Moolenaar  [2019-07-24 15:00 +0200]:
> 
>> 
>> Elimar Riesebieter wrote:
>> 
>>> I get test failures as follows:
>>> 
>>> Failures: 
>>>From test_diffmode.vim:
>>>Found errors in Test_diff_screen():
>>>Run 1:
>>>function 
>>> RunTheTest[40]..Test_diff_screen[95]..VerifyBoth[4]..VerifyScreenDump line 
>>> 55: external: See dump file difference: call 
>>> term_dumpdiff("testdir/failed/Test_diff_13.dump", 
>>> "testdir/dumps/Test_diff_13.dump"); difference in line 1: 
>>> "|-+0#e05#a8a8a8255| > 
>>> +0#000#ff0@34||+1&&|-+0#e05#a8a8a8255| | 
>>> +0#000#ff0@34"; difference in line 20: "|"+0&&|X|f|i|l|e|2|"| 
>>> |0|L|,| |0|C| @59"
>> 
>> [...]
>> 
>>>Flaky test failed too often, giving up
>>> :r
>>> 
>>> The failures are different in different attempts. Building on i386
>>> and amd64 runs fine, 
>> 
>> Any idea why it fails?  Could it be an actual failure in the diff code?
>> Might be related to byte order perhaps.
>> I can't reproduce, thus it's hard for me to try fixing it.
> 
> Well 8.1.1714 built fine. But there was no change in
> test_diffmode.vim... I don't have an overview which files in runtime
> changed since 8.1.1714.
> 
> Elimar
> -- 
>  The path to source is always uphill!
>-unknown-
> 
> -- 
> -- 
> You received this message from the "vim_dev" maillist.
> Do not top-post! Type your reply below the text you are replying to.
> For more information, visit http://www.vim.org/maillist.php
> 
> --- 
> You received this message because you are subscribed to the Google Groups 
> "vim_dev" group.
> To unsubscribe from this group and stop receiving emails from it, send an 
> email to vim_dev+unsubscr...@googlegroups.com.
> To view this discussion on the web visit 
> https://groups.google.com/d/msgid/vim_dev/20190724132744.bs7lftdbju5yz6wy%40toy.home.lxtec.de.

-- 
-- 
You received this message from the "vim_dev" maillist.
Do not top-post! Type your reply below the text you are replying to.
For more information, visit http://www.vim.org/maillist.php

--- 
You received this message because you are subscribed to the Google Groups 
"vim_dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to vim_dev+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/vim_dev/492933A3-04A8-4D6C-BE1D-33462BA12E84%40256bit.org.


Re: Test failure in Test_diffmode.vim building 8.1.1735 on Linux powerpc

2019-07-24 Fir de Conversatie Elimar Riesebieter
* Bram Moolenaar  [2019-07-24 15:00 +0200]:

> 
> Elimar Riesebieter wrote:
> 
> > I get test failures as follows:
> > 
> > Failures: 
> > From test_diffmode.vim:
> > Found errors in Test_diff_screen():
> > Run 1:
> > function 
> > RunTheTest[40]..Test_diff_screen[95]..VerifyBoth[4]..VerifyScreenDump line 
> > 55: external: See dump file difference: call 
> > term_dumpdiff("testdir/failed/Test_diff_13.dump", 
> > "testdir/dumps/Test_diff_13.dump"); difference in line 1: 
> > "|-+0#e05#a8a8a8255| > 
> > +0#000#ff0@34||+1&&|-+0#e05#a8a8a8255| | 
> > +0#000#ff0@34"; difference in line 20: "|"+0&&|X|f|i|l|e|2|"| 
> > |0|L|,| |0|C| @59"
> 
> [...]
> 
> > Flaky test failed too often, giving up
> > :r
> > 
> > The failures are different in different attempts. Building on i386
> > and amd64 runs fine, 
> 
> Any idea why it fails?  Could it be an actual failure in the diff code?
> Might be related to byte order perhaps.
> I can't reproduce, thus it's hard for me to try fixing it.

Well 8.1.1714 built fine. But there was no change in
test_diffmode.vim... I don't have an overview which files in runtime
changed since 8.1.1714.

Elimar
-- 
  The path to source is always uphill!
-unknown-

-- 
-- 
You received this message from the "vim_dev" maillist.
Do not top-post! Type your reply below the text you are replying to.
For more information, visit http://www.vim.org/maillist.php

--- 
You received this message because you are subscribed to the Google Groups 
"vim_dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to vim_dev+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/vim_dev/20190724132744.bs7lftdbju5yz6wy%40toy.home.lxtec.de.


Re: Test failure in Test_diffmode.vim building 8.1.1735 on Linux powerpc

2019-07-24 Fir de Conversatie Bram Moolenaar


Elimar Riesebieter wrote:

> I get test failures as follows:
> 
> Failures: 
>   From test_diffmode.vim:
>   Found errors in Test_diff_screen():
>   Run 1:
>   function 
> RunTheTest[40]..Test_diff_screen[95]..VerifyBoth[4]..VerifyScreenDump line 
> 55: external: See dump file difference: call 
> term_dumpdiff("testdir/failed/Test_diff_13.dump", 
> "testdir/dumps/Test_diff_13.dump"); difference in line 1: 
> "|-+0#e05#a8a8a8255| > +0#000#ff0@34||+1&&|-+0#e05#a8a8a8255| 
> | +0#000#ff0@34"; difference in line 20: "|"+0&&|X|f|i|l|e|2|"| 
> |0|L|,| |0|C| @59"

[...]

>   Flaky test failed too often, giving up
> :r
> 
> The failures are different in different attempts. Building on i386
> and amd64 runs fine, 

Any idea why it fails?  Could it be an actual failure in the diff code?
Might be related to byte order perhaps.
I can't reproduce, thus it's hard for me to try fixing it.

-- 
THEOREM: VI is perfect.
PROOF: VI in roman numerals is 6.  The natural numbers < 6 which divide 6 are
1, 2, and 3. 1+2+3 = 6.  So 6 is a perfect number.  Therefore, VI is perfect.
QED
-- Arthur Tateishi

 /// Bram Moolenaar -- b...@moolenaar.net -- http://www.Moolenaar.net   \\\
///sponsor Vim, vote for features -- http://www.Vim.org/sponsor/ \\\
\\\  an exciting new programming language -- http://www.Zimbu.org///
 \\\help me help AIDS victims -- http://ICCF-Holland.org///

-- 
-- 
You received this message from the "vim_dev" maillist.
Do not top-post! Type your reply below the text you are replying to.
For more information, visit http://www.vim.org/maillist.php

--- 
You received this message because you are subscribed to the Google Groups 
"vim_dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to vim_dev+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/vim_dev/201907241300.x6OD03nZ029884%40masaka.moolenaar.net.


Test failure in Test_diffmode.vim building 8.1.1735 on Linux powerpc

2019-07-24 Fir de Conversatie Elimar Riesebieter
I get test failures as follows:

Failures: 
From test_diffmode.vim:
Found errors in Test_diff_screen():
Run 1:
function 
RunTheTest[40]..Test_diff_screen[95]..VerifyBoth[4]..VerifyScreenDump line 55: 
external: See dump file difference: call 
term_dumpdiff("testdir/failed/Test_diff_13.dump", 
"testdir/dumps/Test_diff_13.dump"); difference in line 1: 
"|-+0#e05#a8a8a8255| > +0#000#ff0@34||+1&&|-+0#e05#a8a8a8255| | 
+0#000#ff0@34"; difference in line 20: "|"+0&&|X|f|i|l|e|2|"| |0|L|,| 
|0|C| @59"
function 
RunTheTest[40]..Test_diff_screen[112]..VerifyInternal[5]..VerifyScreenDump line 
55: See dump file difference: call 
term_dumpdiff("testdir/failed/Test_diff_17.dump", 
"testdir/dumps/Test_diff_17.dump"); difference in line 1: "| 
+0#e05#a8a8a8255@1>a+0#000#ff0| @33||+1&&| 
+0#e05#a8a8a8255@1|a+0#000#ff0| @33"; difference in line 4: "| 
+0#e05#a8a8a8255@1|-+0#4040ff13#af255@34||+1#000#ff0| 
+0#e05#a8a8a8255@1| +0#000#5fd7ff255@34"; difference in line 5: "| 
+0#e05#a8a8a8255@1|e+0#000#ff0|f| @32||+1&&| 
+0#e05#a8a8a8255@1|e+0#000#ff0|f| @32"; difference in line 6: "| 
+0#e05#a8a8a8255@1|x+2#000#ff404010@2|