Re: Test failures on amd64

2020-03-27 Fir de Conversatie Bram Moolenaar


Dominique wrote:

> Elimar Riesebieter wrote:
> 
> > Hi,
> >
> > building v8.2.0460 gives the following test failures an amd64:
> >
> > Failures:
> >   From test_excmd.vim:
> >   Found errors in Test_confirm_cmd_cancel():
> >   Run 1:
> >   function RunTheTest[40]..Test_confirm_cmd_cancel[18]..StopVimIn=
> Terminal[10]..WaitForAssert[2]..7_WaitForCommon[11]..16 line 1=
> : Expected 'finished' but got 'running'
> >   Run 2:
> >   function RunTheTest[40]..Test_confirm_cmd_cancel[18]..StopVimIn=
> Terminal[10]..WaitForAssert[2]..7_WaitForCommon[11]..20 line 1=
> : Expected 'finished' but got 'running'
> >   Run 3:
> >   function RunTheTest[40]..Test_confirm_cmd_cancel[18]..StopVimIn=
> Terminal[10]..WaitForAssert[2]..7_WaitForCommon[11]..24 line 1=
> : Expected 'finished' but got 'running'
> >   Run 4:
> >   function RunTheTest[40]..Test_confirm_cmd_cancel[18]..StopVimIn=
> Terminal[10]..WaitForAssert[2]..7_WaitForCommon[11]..28 line 1=
> : Expected 'finished' but got 'running'
> >   Run 5:
> >   function RunTheTest[40]..Test_confirm_cmd_cancel[18]..StopVimIn=
> Terminal[10]..WaitForAssert[2]..7_WaitForCommon[11]..32 line 1=
> : Expected 'finished' but got 'running'
> >   Flaky test failed too often, giving up
> >   From test_alot.vim:
> >   Found errors in Test_compiler():
> >   function RunTheTest[40]..Test_compiler line 23: command did not=
>  fail: clist
> >   function RunTheTest[40]..Test_compiler line 29: Pattern '\\n \\=
> d\\+ Xfoo.pl:3: Global symbol "$foo" requires explicit package name' does n=
> ot match '\n21 Xfoo.pl:3: Global symbol "$foo" requires expl:3: Global symb=
> ol "$foo" requires explicit package name (did you forget to declare "my $fo=
> o"?)'
> 
> I see the same failure in Test_confirm_cmd_cancel()
> on one of my 2 machines. The attached patch fixes
> it for me.  Can you also check?

Thanks!  Such a WaitFor is nicer than a simple delay.  But it's hard to
do without being able to reproduce.
 
> All other test pass for me. I don't see the failure
> in Test_compiler().  What does "/usr/bin/perl --version"
> say on your machine? Mine says:
> 
> $ /usr/bin/perl --version
> 
> This is perl 5, version 26, subversion 1 (v5.26.1) built for
> x86_64-linux-gnu-thread-multi
> (with 67 registered patches, see perl -V for more detail)
> ...snip...

Strangely, the "does not match" text seems to have part of the error
repeated. Would work to add a ".*" around "explicit", but that would be
weird.

-- 
No letters of the alphabet were harmed in the creation of this message.

 /// Bram Moolenaar -- b...@moolenaar.net -- http://www.Moolenaar.net   \\\
///sponsor Vim, vote for features -- http://www.Vim.org/sponsor/ \\\
\\\  an exciting new programming language -- http://www.Zimbu.org///
 \\\help me help AIDS victims -- http://ICCF-Holland.org///

-- 
-- 
You received this message from the "vim_dev" maillist.
Do not top-post! Type your reply below the text you are replying to.
For more information, visit http://www.vim.org/maillist.php

--- 
You received this message because you are subscribed to the Google Groups 
"vim_dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to vim_dev+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/vim_dev/202003271841.02RIfZEf014954%40masaka.moolenaar.net.


Re: Test failures on amd64

2020-03-27 Fir de Conversatie Elimar Riesebieter
* Dominique Pellé  [2020-03-27 14:07 +0100]:

> Elimar Riesebieter wrote:
> 
> > Hi,
> >
> > building v8.2.0460 gives the following test failures an amd64:
> >
> > Failures:
> >   From test_excmd.vim:
> >   Found errors in Test_confirm_cmd_cancel():
> >   Run 1:
> >   function 
> > RunTheTest[40]..Test_confirm_cmd_cancel[18]..StopVimInTerminal[10]..WaitForAssert[2]..7_WaitForCommon[11]..16
> >  line 1: Expected 'finished' but got 'running'
> >   Run 2:
> >   function 
> > RunTheTest[40]..Test_confirm_cmd_cancel[18]..StopVimInTerminal[10]..WaitForAssert[2]..7_WaitForCommon[11]..20
> >  line 1: Expected 'finished' but got 'running'
> >   Run 3:
> >   function 
> > RunTheTest[40]..Test_confirm_cmd_cancel[18]..StopVimInTerminal[10]..WaitForAssert[2]..7_WaitForCommon[11]..24
> >  line 1: Expected 'finished' but got 'running'
> >   Run 4:
> >   function 
> > RunTheTest[40]..Test_confirm_cmd_cancel[18]..StopVimInTerminal[10]..WaitForAssert[2]..7_WaitForCommon[11]..28
> >  line 1: Expected 'finished' but got 'running'
> >   Run 5:
> >   function 
> > RunTheTest[40]..Test_confirm_cmd_cancel[18]..StopVimInTerminal[10]..WaitForAssert[2]..7_WaitForCommon[11]..32
> >  line 1: Expected 'finished' but got 'running'
> >   Flaky test failed too often, giving up
> >   From test_alot.vim:
> >   Found errors in Test_compiler():
> >   function RunTheTest[40]..Test_compiler line 23: command did not 
> > fail: clist
> >   function RunTheTest[40]..Test_compiler line 29: Pattern '\\n 
> > \\d\\+ Xfoo.pl:3: Global symbol "$foo" requires explicit package name' does 
> > not match '\n21 Xfoo.pl:3: Global symbol "$foo" requires expl:3: Global 
> > symbol "$foo" requires explicit package name (did you forget to declare "my 
> > $foo"?)'
> 
> I see the same failure in Test_confirm_cmd_cancel()
> on one of my 2 machines. The attached patch fixes
> it for me.  Can you also check?

Appying your patch mede the built successful :-)

> 
> All other test pass for me. I don't see the failure
> in Test_compiler().  What does "/usr/bin/perl --version"
> say on your machine? Mine says:

Mine says:

This is perl 5, version 30, subversion 0 (v5.30.0) built for 
x86_64-linux-gnu-thread-multi
(with 46 registered patches, see perl -V for more detail)

Thanks for cooperation
Elimar
-- 
  Alles, was viel bedacht wird, wird bedenklich!;-)
 Friedrich Nietzsche

-- 
-- 
You received this message from the "vim_dev" maillist.
Do not top-post! Type your reply below the text you are replying to.
For more information, visit http://www.vim.org/maillist.php

--- 
You received this message because you are subscribed to the Google Groups 
"vim_dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to vim_dev+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/vim_dev/20200327134850.ukqp4gozxhgtwb57%40toy.home.lxtec.de.


Re: Test failures on amd64

2020-03-27 Fir de Conversatie Dominique Pellé
Elimar Riesebieter wrote:

> Hi,
>
> building v8.2.0460 gives the following test failures an amd64:
>
> Failures:
>   From test_excmd.vim:
>   Found errors in Test_confirm_cmd_cancel():
>   Run 1:
>   function 
> RunTheTest[40]..Test_confirm_cmd_cancel[18]..StopVimInTerminal[10]..WaitForAssert[2]..7_WaitForCommon[11]..16
>  line 1: Expected 'finished' but got 'running'
>   Run 2:
>   function 
> RunTheTest[40]..Test_confirm_cmd_cancel[18]..StopVimInTerminal[10]..WaitForAssert[2]..7_WaitForCommon[11]..20
>  line 1: Expected 'finished' but got 'running'
>   Run 3:
>   function 
> RunTheTest[40]..Test_confirm_cmd_cancel[18]..StopVimInTerminal[10]..WaitForAssert[2]..7_WaitForCommon[11]..24
>  line 1: Expected 'finished' but got 'running'
>   Run 4:
>   function 
> RunTheTest[40]..Test_confirm_cmd_cancel[18]..StopVimInTerminal[10]..WaitForAssert[2]..7_WaitForCommon[11]..28
>  line 1: Expected 'finished' but got 'running'
>   Run 5:
>   function 
> RunTheTest[40]..Test_confirm_cmd_cancel[18]..StopVimInTerminal[10]..WaitForAssert[2]..7_WaitForCommon[11]..32
>  line 1: Expected 'finished' but got 'running'
>   Flaky test failed too often, giving up
>   From test_alot.vim:
>   Found errors in Test_compiler():
>   function RunTheTest[40]..Test_compiler line 23: command did not 
> fail: clist
>   function RunTheTest[40]..Test_compiler line 29: Pattern '\\n \\d\\+ 
> Xfoo.pl:3: Global symbol "$foo" requires explicit package name' does not 
> match '\n21 Xfoo.pl:3: Global symbol "$foo" requires expl:3: Global symbol 
> "$foo" requires explicit package name (did you forget to declare "my $foo"?)'

I see the same failure in Test_confirm_cmd_cancel()
on one of my 2 machines. The attached patch fixes
it for me.  Can you also check?

All other test pass for me. I don't see the failure
in Test_compiler().  What does "/usr/bin/perl --version"
say on your machine? Mine says:

$ /usr/bin/perl --version

This is perl 5, version 26, subversion 1 (v5.26.1) built for
x86_64-linux-gnu-thread-multi
(with 67 registered patches, see perl -V for more detail)
...snip...

Regards
Dominique

-- 
-- 
You received this message from the "vim_dev" maillist.
Do not top-post! Type your reply below the text you are replying to.
For more information, visit http://www.vim.org/maillist.php

--- 
You received this message because you are subscribed to the Google Groups 
"vim_dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to vim_dev+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/vim_dev/CAON-T_gZCumyJsOiZ3y1qLRUSrcyCXsZ1O1F5toqeeoLfPFF5w%40mail.gmail.com.
diff --git a/src/testdir/test_excmd.vim b/src/testdir/test_excmd.vim
index ec252a660..d5588d670 100644
--- a/src/testdir/test_excmd.vim
+++ b/src/testdir/test_excmd.vim
@@ -264,6 +264,8 @@ func Test_confirm_cmd_cancel()
   call WaitForAssert({-> assert_match('^\[Y\]es, (N)o, (C)ancel: *$',
 \ term_getline(buf, 20))}, 1000)
   call term_sendkeys(buf, "N")
+  call WaitForAssert({-> assert_match('^ *0,0-1 All$',
+\ term_getline(buf, 20))}, 1000)
   call StopVimInTerminal(buf)
 endfunc
 


Test failures on amd64

2020-03-27 Fir de Conversatie Elimar Riesebieter
Hi,

building v8.2.0460 gives the following test failures an amd64:

Failures:
  From test_excmd.vim:
  Found errors in Test_confirm_cmd_cancel():
  Run 1:
  function 
RunTheTest[40]..Test_confirm_cmd_cancel[18]..StopVimInTerminal[10]..WaitForAssert[2]..7_WaitForCommon[11]..16
 line 1: Expected 'finished' but got 'running'
  Run 2:
  function 
RunTheTest[40]..Test_confirm_cmd_cancel[18]..StopVimInTerminal[10]..WaitForAssert[2]..7_WaitForCommon[11]..20
 line 1: Expected 'finished' but got 'running'
  Run 3:
  function 
RunTheTest[40]..Test_confirm_cmd_cancel[18]..StopVimInTerminal[10]..WaitForAssert[2]..7_WaitForCommon[11]..24
 line 1: Expected 'finished' but got 'running'
  Run 4:
  function 
RunTheTest[40]..Test_confirm_cmd_cancel[18]..StopVimInTerminal[10]..WaitForAssert[2]..7_WaitForCommon[11]..28
 line 1: Expected 'finished' but got 'running'
  Run 5:
  function 
RunTheTest[40]..Test_confirm_cmd_cancel[18]..StopVimInTerminal[10]..WaitForAssert[2]..7_WaitForCommon[11]..32
 line 1: Expected 'finished' but got 'running'
  Flaky test failed too often, giving up
  From test_alot.vim:
  Found errors in Test_compiler():
  function RunTheTest[40]..Test_compiler line 23: command did not fail: 
clist
  function RunTheTest[40]..Test_compiler line 29: Pattern '\\n \\d\\+ 
Xfoo.pl:3: Global symbol "$foo" requires explicit package name' does not match 
'\n21 Xfoo.pl:3: Global symbol "$foo" requires expl:3: Global symbol "$foo" 
requires explicit package name (did you forget to declare "my $foo"?)'


Thanks
-- 
   Elimar

-- 
-- 
You received this message from the "vim_dev" maillist.
Do not top-post! Type your reply below the text you are replying to.
For more information, visit http://www.vim.org/maillist.php

--- 
You received this message because you are subscribed to the Google Groups 
"vim_dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to vim_dev+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/vim_dev/20200327124028.noqrzd3mn7luxwbm%40toy.home.lxtec.de.