Re: [virt-tools-list] [PATCH 5/5] Remove useless {get, set}_property functions
On Thu, Oct 29, 2015 at 9:40 PM, Eduardo Lima (Etrunko)
wrote:
> Signed-off-by: Eduardo Lima (Etrunko)
> ---
> src/virt-viewer.c | 22 --
> 1 file changed, 22 deletions(-)
>
> diff --git a/src/virt-viewer.c b/src/virt-viewer.c
> index dd8dbba..10f624d 100644
> --- a/src/virt-viewer.c
> +++ b/src/virt-viewer.c
> @@ -74,26 +74,6 @@ static void virt_viewer_dispose (GObject *object);
> static int virt_viewer_connect(VirtViewerApp *app, GError **error);
>
> static void
> -virt_viewer_get_property (GObject *object, guint property_id,
> - GValue *value G_GNUC_UNUSED, GParamSpec *pspec)
> -{
> -switch (property_id) {
> -default:
> -G_OBJECT_WARN_INVALID_PROPERTY_ID (object, property_id, pspec);
> -}
> -}
> -
> -static void
> -virt_viewer_set_property (GObject *object, guint property_id,
> - const GValue *value G_GNUC_UNUSED, GParamSpec
> *pspec)
> -{
> -switch (property_id) {
> -default:
> -G_OBJECT_WARN_INVALID_PROPERTY_ID (object, property_id, pspec);
> -}
> -}
> -
> -static void
> virt_viewer_class_init (VirtViewerClass *klass)
> {
> GObjectClass *object_class = G_OBJECT_CLASS (klass);
> @@ -101,8 +81,6 @@ virt_viewer_class_init (VirtViewerClass *klass)
>
> g_type_class_add_private (klass, sizeof (VirtViewerPrivate));
>
> -object_class->get_property = virt_viewer_get_property;
> -object_class->set_property = virt_viewer_set_property;
> object_class->dispose = virt_viewer_dispose;
>
> app_class->initial_connect = virt_viewer_initial_connect;
> --
> 2.4.3
>
> ___
> virt-tools-list mailing list
> virt-tools-list@redhat.com
> https://www.redhat.com/mailman/listinfo/virt-tools-list
ack!
___
virt-tools-list mailing list
virt-tools-list@redhat.com
https://www.redhat.com/mailman/listinfo/virt-tools-list
[virt-tools-list] [virt-viewer][PATCH v2] window: Standardize "Leave Fullscreen" behaviour
Historically fullscreen mode used to be an app-level option (you could
only have *all* windows fullscreen or *all* windows non-fullscreen). At
some point per-window fullscreen was introduced, but the startup
fullscreen remained with the old (app-level) behaviour.
According to the multimonitor requirements[0], item D5, the --fullscreen
behaviour needs to be changed to match the per-window fullscreen
behaviour, what is done by this patch.
[0]:
https://www.redhat.com/archives/virt-tools-list/2015-June/msg00074.html
Resolves: rhbz#1275248
---
Changes since v1:
- Set both the app and the window to non-fullscreen mode
---
src/virt-viewer-app.c| 7 ++-
src/virt-viewer-window.c | 5 +
2 files changed, 7 insertions(+), 5 deletions(-)
diff --git a/src/virt-viewer-app.c b/src/virt-viewer-app.c
index 0670358..835fced 100644
--- a/src/virt-viewer-app.c
+++ b/src/virt-viewer-app.c
@@ -2187,7 +2187,12 @@ virt_viewer_app_set_fullscreen(VirtViewerApp *self,
gboolean fullscreen)
/* we iterate unconditionnaly, even if it was set before to update new
windows */
priv->fullscreen = fullscreen;
-g_list_foreach(priv->windows, fullscreen_cb, &options);
+
+/* For "leaving fullscreen", do not iterate over the windows, keeping the
same
+ * behavior as the normal (non-fullscreen) mode. So, developer, take it as
+ * reminder that you must set both the app the window to non-fullscreen
mode. */
+if (fullscreen)
+g_list_foreach(priv->windows, fullscreen_cb, &options);
g_object_notify(G_OBJECT(self), "fullscreen");
}
diff --git a/src/virt-viewer-window.c b/src/virt-viewer-window.c
index a1b9940..31c0c46 100644
--- a/src/virt-viewer-window.c
+++ b/src/virt-viewer-window.c
@@ -784,12 +784,9 @@ virt_viewer_window_set_fullscreen(VirtViewerWindow *self,
if (fullscreen) {
virt_viewer_window_enter_fullscreen(self, -1);
} else {
-/* leave all windows fullscreen state */
if (virt_viewer_app_get_fullscreen(self->priv->app))
g_object_set(self->priv->app, "fullscreen", FALSE, NULL);
-/* or just this window */
-else
-virt_viewer_window_leave_fullscreen(self);
+virt_viewer_window_leave_fullscreen(self);
}
}
--
2.5.0
___
virt-tools-list mailing list
virt-tools-list@redhat.com
https://www.redhat.com/mailman/listinfo/virt-tools-list
Re: [virt-tools-list] Some cosmetic fixes
Hey, On Thu, Oct 29, 2015 at 9:40 PM, Eduardo Lima (Etrunko) wrote: > While working on adding support to GtkApplication for virt-viewer and > remote-viewer, I fixed some small things. I figured it was time to > flush them to avoid those to pile up. The patch series seems good apart from the first patch and a question raised in the 3rd one. Also, I know it's not a rule here, but would be nice if you could add a prefix to the commit shortlog. > > Regards, Eduardo > > -- > Eduardo de Barros Lima (Etrunko) > Software Engineer - RedHat > etru...@redhat.com > > ___ > virt-tools-list mailing list > virt-tools-list@redhat.com > https://www.redhat.com/mailman/listinfo/virt-tools-list Best Regards, -- Fabiano Fidêncio ___ virt-tools-list mailing list virt-tools-list@redhat.com https://www.redhat.com/mailman/listinfo/virt-tools-list
Re: [virt-tools-list] [PATCH 3/5] Update gitignore
On Thu, Oct 29, 2015 at 9:40 PM, Eduardo Lima (Etrunko) wrote: > Signed-off-by: Eduardo Lima (Etrunko) > --- > Makefile.am | 5 + > git.mk | 2 +- > m4/.gitignore | 0 > src/Makefile.am | 8 > 4 files changed, 14 insertions(+), 1 deletion(-) > delete mode 100644 m4/.gitignore > > diff --git a/Makefile.am b/Makefile.am > index d0e9ab4..9646119 100644 > --- a/Makefile.am > +++ b/Makefile.am > @@ -48,6 +48,11 @@ MAINTAINERCLEANFILES = \ > $(srcdir)/m4/lt~obsolete.m4 \ > $(NULL) > > +GITIGNOREFILES = \ > + AUTHORS \ > + build-aux/test-driver \ > + $(NULL) > + > dist-hook: gen-ChangeLog gen-AUTHORS > > # Generate the ChangeLog file (with all entries since the switch to git) > diff --git a/git.mk b/git.mk > index 0b26b23..277e6e3 100644 > --- a/git.mk > +++ b/git.mk > @@ -123,7 +123,7 @@ $(srcdir)/.gitignore: Makefile.am $(top_srcdir)/git.mk > $(gsettings__enum_file) \ > ; do echo /$$x; done; \ > fi; \ > - if test -f $(srcdir)/po/Makefile.in.in; then \ > + if test -f $(top_srcdir)/po/Makefile.in.in; then \ I didn't get why you had to change $(srcdir) to $(top_srcdir) here. > for x in \ > po/Makefile.in.in \ > po/Makefile.in \ > diff --git a/m4/.gitignore b/m4/.gitignore > deleted file mode 100644 > index e69de29..000 > diff --git a/src/Makefile.am b/src/Makefile.am > index 1ebc24e..5ce08bc 100644 > --- a/src/Makefile.am > +++ b/src/Makefile.am > @@ -218,4 +218,12 @@ debug_helper_LDFLAGS = $(GLIB2_LIBS) > -Wl,--subsystem,windows > debug_helper_CFLAGS = $(GLIB2_CFLAGS) > endif > > +GITIGNOREFILES = \ > + view/.deps \ > + view/.dirstamp \ > + view/.libs \ > + view/*.lo \ > + view/*.o\ > + $(NULL) > + > -include $(top_srcdir)/git.mk > -- > 2.4.3 > > ___ > virt-tools-list mailing list > virt-tools-list@redhat.com > https://www.redhat.com/mailman/listinfo/virt-tools-list Looks good, ack! ___ virt-tools-list mailing list virt-tools-list@redhat.com https://www.redhat.com/mailman/listinfo/virt-tools-list
Re: [virt-tools-list] [PATCH 4/5] Move declaration to the beginning of the file
On Thu, Oct 29, 2015 at 9:40 PM, Eduardo Lima (Etrunko)
wrote:
> Signed-off-by: Eduardo Lima (Etrunko)
> ---
> src/virt-viewer.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/src/virt-viewer.c b/src/virt-viewer.c
> index ca264c8..dd8dbba 100644
> --- a/src/virt-viewer.c
> +++ b/src/virt-viewer.c
> @@ -71,6 +71,7 @@ static gboolean virt_viewer_open_connection(VirtViewerApp
> *self, int *fd);
> static void virt_viewer_deactivated(VirtViewerApp *self, gboolean
> connect_error);
> static gboolean virt_viewer_start(VirtViewerApp *self, GError **error);
> static void virt_viewer_dispose (GObject *object);
> +static int virt_viewer_connect(VirtViewerApp *app, GError **error);
>
> static void
> virt_viewer_get_property (GObject *object, guint property_id,
> @@ -723,8 +724,6 @@ choose_vm(GtkWindow *main_window,
> return dom;
> }
>
> -static int virt_viewer_connect(VirtViewerApp *app, GError **error);
> -
> static gboolean
> virt_viewer_initial_connect(VirtViewerApp *app, GError **error)
> {
> --
> 2.4.3
>
> ___
> virt-tools-list mailing list
> virt-tools-list@redhat.com
> https://www.redhat.com/mailman/listinfo/virt-tools-list
ack!
___
virt-tools-list mailing list
virt-tools-list@redhat.com
https://www.redhat.com/mailman/listinfo/virt-tools-list
Re: [virt-tools-list] [PATCH 2/5] Fix MAINTAINERCLEANFILES variable
On Thu, Oct 29, 2015 at 9:40 PM, Eduardo Lima (Etrunko) wrote: > Signed-off-by: Eduardo Lima (Etrunko) > --- > man/Makefile.am | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/man/Makefile.am b/man/Makefile.am > index 6ee3116..39b6019 100644 > --- a/man/Makefile.am > +++ b/man/Makefile.am > @@ -10,7 +10,7 @@ EXTRA_DIST = \ > virt-viewer.pod \ > $(NULL) > > -MAINTAINERCLEANFILES = $(man_MANS) > +MAINTAINERCLEANFILES = $(dist_man_MANS) > > %.1: %.pod > $(AM_V_GEN)pod2man -c "Virtualization Support" $< > $@ > -- > 2.4.3 > > ___ > virt-tools-list mailing list > virt-tools-list@redhat.com > https://www.redhat.com/mailman/listinfo/virt-tools-list ack! ___ virt-tools-list mailing list virt-tools-list@redhat.com https://www.redhat.com/mailman/listinfo/virt-tools-list
Re: [virt-tools-list] [PATCH 1/5] Call intltoolize after autoreconf
Hey! On Thu, Oct 29, 2015 at 9:40 PM, Eduardo Lima (Etrunko) wrote: > After a calling 'git clean -d -x -f' I got this error: > > ln: failed to create symbolic link ‘m4/intltool.m4’: No such file or directory > cp: cannot create regular file ‘m4/intltool.m4’: No such file or directory > intltoolize: cannot copy '/usr/share/aclocal/intltool.m4' to 'm4/intltool.m4' I've never seen this error before and I am not able to reproduce it here. > > With this patch, the error is gone. This patch introduces this warning: aclocal: warning: couldn't open directory 'm4': No such file or directory > > Signed-off-by: Eduardo Lima (Etrunko) > --- > autogen.sh | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/autogen.sh b/autogen.sh > index b8d3c4d..a688ad4 100755 > --- a/autogen.sh > +++ b/autogen.sh > @@ -27,8 +27,8 @@ fi > # exists at all times :-( > touch ChangeLog AUTHORS > > -intltoolize --force > autoreconf -vfi > +intltoolize --force > > cd $THEDIR > > -- > 2.4.3 > > ___ > virt-tools-list mailing list > virt-tools-list@redhat.com > https://www.redhat.com/mailman/listinfo/virt-tools-list Best Regards, -- Fabiano Fidêncio ___ virt-tools-list mailing list virt-tools-list@redhat.com https://www.redhat.com/mailman/listinfo/virt-tools-list
