Re: [virt-tools-list] virtinst: Support paths to SUSE OVMF firmwares
On 01/27/2016 05:37 PM, Jim Fehlig wrote: > FYI, I added the attached patch to SUSE's virt-manager package. I thought it > one > of those distro-specific patches to maintain forever, but in the end decided > it > was worth a shot to upstream since the existing regex includes "gerd's > firmware > repo" :-). Proper patch sent via git now that github is back https://www.redhat.com/archives/virt-tools-list/2016-January/msg00110.html Regards, Jim ___ virt-tools-list mailing list virt-tools-list@redhat.com https://www.redhat.com/mailman/listinfo/virt-tools-list
[virt-tools-list] [PATCH] virtinst: Support paths to SUSE OVMF firmwares
Extend the domcapabilities regex to include SUSE's OVMF file naming convention. Signed-off-by: Jim Fehlig --- virtinst/domcapabilities.py | 1 + 1 file changed, 1 insertion(+) diff --git a/virtinst/domcapabilities.py b/virtinst/domcapabilities.py index 86bdfe8..f074b4e 100644 --- a/virtinst/domcapabilities.py +++ b/virtinst/domcapabilities.py @@ -101,6 +101,7 @@ class DomainCapabilities(XMLBuilder): "x86_64": [ ".*OVMF_CODE\.fd", # RHEL ".*ovmf-x64/OVMF.*\.fd", # gerd's firmware repo +".*ovmf-x86_64-.*", # SUSE ], "aarch64": [ ".*AAVMF_CODE\.fd", # RHEL -- 2.1.4 ___ virt-tools-list mailing list virt-tools-list@redhat.com https://www.redhat.com/mailman/listinfo/virt-tools-list
[virt-tools-list] virtinst: Support paths to SUSE OVMF firmwares
FYI, I added the attached patch to SUSE's virt-manager package. I thought it one of those distro-specific patches to maintain forever, but in the end decided it was worth a shot to upstream since the existing regex includes "gerd's firmware repo" :-). Regards, Jim Support paths to SUSE OVMF firmwares Extend the domcapabilities regex to include SUSE's OVMF file naming convention. Index: virt-manager-1.3.2/virtinst/domcapabilities.py === --- virt-manager-1.3.2.orig/virtinst/domcapabilities.py +++ virt-manager-1.3.2/virtinst/domcapabilities.py @@ -101,6 +101,8 @@ class DomainCapabilities(XMLBuilder): "x86_64": [ ".*OVMF_CODE\.fd", # RHEL ".*ovmf-x64/OVMF.*\.fd", # gerd's firmware repo +".*ovmf-x86_64-.*", # SUSE + ], "aarch64": [ ".*AAVMF_CODE\.fd", # RHEL ___ virt-tools-list mailing list virt-tools-list@redhat.com https://www.redhat.com/mailman/listinfo/virt-tools-list
Re: [virt-tools-list] Delayed Deletion or Creation
On Mon, Jan 25, 2016 at 11:10:16AM -0500, Cole Robinson wrote: > On 01/24/2016 08:15 AM, Michael A Cooper wrote: > > Hey Guys, > > > > How is everyone? I am not sure how to word this question but here > > goes. I have a 3 server setup and I created a nfs share so that I could do > > Live Migration across the servers. So when I create the vm with qcow2 > > everything goes smooth and quick, but when I try to create with .img (Raw) > > it > > takes forever to create the file. Also when I try and delete an .img file > > (20 > > gb) it has been over 20 minutes to delete it, any ideas? > > > > qcow2 files are sparse/not-fully-allocated, so while you request 20GB it's > probably only writing a few MB. The rest is filled in as the VM writes to it. > > raw can do sparse as well, but 1) virt-manager doesn't default to it if you > choose raw which means it is allocating the full 20GB, and 2) even if you do > choose sparse the semantics are a bit different for NFS, not sure if it > affects your use case though: > https://serverfault.com/questions/731632/does-nfs-and-smb-support-sparse-files I suspect in this case, the shortcoming of NFS is that it doesn't support posix_fallocate, so it has to be emulated by glibc (although NFS 4.2 does support it, finally). This bug is also relevant if you're using RHEL 7.2: https://bugzilla.redhat.com/show_bug.cgi?id=1265196 Rich. -- Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones Read my programming and virtualization blog: http://rwmj.wordpress.com virt-top is 'top' for virtual machines. Tiny program with many powerful monitoring features, net stats, disk stats, logging, etc. http://people.redhat.com/~rjones/virt-top ___ virt-tools-list mailing list virt-tools-list@redhat.com https://www.redhat.com/mailman/listinfo/virt-tools-list
Re: [virt-tools-list] VMWare guestId to libvirt os-variant
On 01/27/2016 12:45 PM, Richard W.M. Jones wrote: > On Tue, Jan 26, 2016 at 11:00:49AM -0500, Cole Robinson wrote: >> In that case, use whatever the latest fedora version is. > > I always thought it would be nice if virt-install substituted (eg) > fedora22 instead of fedora23 whenever it encounters a version that it > doesn't yet know about. > It tries to with fedora. URL detection works well, and libosinfo should return fedora-unknown which we map to latest fedora version. - Cole ___ virt-tools-list mailing list virt-tools-list@redhat.com https://www.redhat.com/mailman/listinfo/virt-tools-list
Re: [virt-tools-list] VMWare guestId to libvirt os-variant
On Tue, Jan 26, 2016 at 11:00:49AM -0500, Cole Robinson wrote: > In that case, use whatever the latest fedora version is. I always thought it would be nice if virt-install substituted (eg) fedora22 instead of fedora23 whenever it encounters a version that it doesn't yet know about. > If you have a disk image and you need to do this generically, virt-inspector > is really your only option. virt-inspector of course has its own naming scheme for operating systems (invented before libosinfo came along). So it goes :-( > However if you are trying to do this generically and not as a one off, check > out virt-v2v, it might be what you are looking for Right - for converting a guest from VMware to KVM, virt-v2v can help, both in installing virtio drivers into the guest [probably not needed in this instance] and for the practical aspects of fetching the disk data and copying it into KVM/oVirt/Glance. More info here: http://libguestfs.org/virt-v2v.1.html Rich. -- Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones Read my programming and virtualization blog: http://rwmj.wordpress.com virt-top is 'top' for virtual machines. Tiny program with many powerful monitoring features, net stats, disk stats, logging, etc. http://people.redhat.com/~rjones/virt-top ___ virt-tools-list mailing list virt-tools-list@redhat.com https://www.redhat.com/mailman/listinfo/virt-tools-list
[virt-tools-list] [PATCH virt-viewer] display: Set value of desktop width and height property directly
Avoid calling gtk_widget_queue_resize() and emitting
the "display-desktop-resize" signal.
---
src/virt-viewer-display.c | 8 ++--
1 file changed, 2 insertions(+), 6 deletions(-)
diff --git a/src/virt-viewer-display.c b/src/virt-viewer-display.c
index d1b088e..af1fe01 100644
--- a/src/virt-viewer-display.c
+++ b/src/virt-viewer-display.c
@@ -301,14 +301,10 @@ virt_viewer_display_set_property(GObject *object,
switch (prop_id) {
case PROP_DESKTOP_WIDTH:
-virt_viewer_display_set_desktop_size(display,
- g_value_get_int(value),
- priv->desktopHeight);
+priv->desktopWidth = g_value_get_int(value);
break;
case PROP_DESKTOP_HEIGHT:
-virt_viewer_display_set_desktop_size(display,
- priv->desktopWidth,
- g_value_get_int(value));
+priv->desktopHeight = g_value_get_int(value);
break;
case PROP_NTH_DISPLAY:
priv->nth_display = g_value_get_int(value);
--
2.5.0
___
virt-tools-list mailing list
virt-tools-list@redhat.com
https://www.redhat.com/mailman/listinfo/virt-tools-list
[virt-tools-list] [PATCH virt-viewer 1/2] display: Remove unnecessary VIRT_VIEWER_DISPLAY cast
---
src/virt-viewer-display.c | 12 ++--
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/src/virt-viewer-display.c b/src/virt-viewer-display.c
index a16181f..72ec56a 100644
--- a/src/virt-viewer-display.c
+++ b/src/virt-viewer-display.c
@@ -545,7 +545,7 @@ virt_viewer_display_size_allocate(GtkWidget *widget,
#if !GTK_CHECK_VERSION(3, 0, 0)
end:
-virt_viewer_display_make_resizable(VIRT_VIEWER_DISPLAY(widget));
+virt_viewer_display_make_resizable(display);
#endif
}
@@ -819,7 +819,7 @@ void
virt_viewer_display_get_preferred_monitor_geometry(VirtViewerDisplay* self,
g_return_if_fail(preferred != NULL);
-if (!virt_viewer_display_get_enabled(VIRT_VIEWER_DISPLAY(self))) {
+if (!virt_viewer_display_get_enabled(self)) {
preferred->width = 0;
preferred->height = 0;
preferred->x = 0;
@@ -832,10 +832,10 @@ void
virt_viewer_display_get_preferred_monitor_geometry(VirtViewerDisplay* self,
topx = MAX(topx, 0);
topy = MAX(topy, 0);
-if (virt_viewer_display_get_fullscreen(VIRT_VIEWER_DISPLAY(self))) {
+if (virt_viewer_display_get_fullscreen(self)) {
GdkRectangle physical_monitor;
GdkScreen *screen = gtk_widget_get_screen(GTK_WIDGET(self));
-int n = virt_viewer_display_get_monitor(VIRT_VIEWER_DISPLAY(self));
+int n = virt_viewer_display_get_monitor(self);
if (n == -1)
n = gdk_screen_get_monitor_at_window(screen,
gtk_widget_get_window(GTK_WIDGET(self)));
@@ -850,8 +850,8 @@ void
virt_viewer_display_get_preferred_monitor_geometry(VirtViewerDisplay* self,
preferred->y = topy;
}
-if (virt_viewer_display_get_zoom(VIRT_VIEWER_DISPLAY(self))) {
-guint zoom =
virt_viewer_display_get_zoom_level(VIRT_VIEWER_DISPLAY(self));
+if (virt_viewer_display_get_zoom(self)) {
+guint zoom = virt_viewer_display_get_zoom_level(self);
preferred->width = round(preferred->width * NORMAL_ZOOM_LEVEL /
(double) zoom);
preferred->height = round(preferred->height * NORMAL_ZOOM_LEVEL /
(double) zoom);
--
2.5.0
___
virt-tools-list mailing list
virt-tools-list@redhat.com
https://www.redhat.com/mailman/listinfo/virt-tools-list
[virt-tools-list] [PATCH virt-viewer 2/2] display: Move variable definitions to block where are used
---
src/virt-viewer-display.c | 18 +++---
1 file changed, 7 insertions(+), 11 deletions(-)
diff --git a/src/virt-viewer-display.c b/src/virt-viewer-display.c
index 72ec56a..d1b088e 100644
--- a/src/virt-viewer-display.c
+++ b/src/virt-viewer-display.c
@@ -501,11 +501,6 @@ virt_viewer_display_size_allocate(GtkWidget *widget,
GtkBin *bin = GTK_BIN(widget);
VirtViewerDisplay *display = VIRT_VIEWER_DISPLAY(widget);
VirtViewerDisplayPrivate *priv = display->priv;
-GtkAllocation child_allocation;
-gint width, height;
-gint border_width;
-double desktopAspect;
-double actualAspect;
GtkWidget *child = gtk_bin_get_child(bin);
g_debug("Allocated %dx%d", allocation->width, allocation->height);
@@ -519,14 +514,15 @@ virt_viewer_display_size_allocate(GtkWidget *widget,
return;
#endif
-desktopAspect = (double)priv->desktopWidth / (double)priv->desktopHeight;
-
if (child && gtk_widget_get_visible(child)) {
-border_width = gtk_container_get_border_width(GTK_CONTAINER(display));
+GtkAllocation child_allocation;
+gint border_width =
gtk_container_get_border_width(GTK_CONTAINER(display));
+
+gint width = MAX(1, allocation->width - 2 * border_width);
+gint height = MAX(1, allocation->height - 2 * border_width);
-width = MAX(1, allocation->width - 2 * border_width);
-height = MAX(1, allocation->height - 2 * border_width);
-actualAspect = (double)width / (double)height;
+double desktopAspect = (double) priv->desktopWidth / (double)
priv->desktopHeight;
+double actualAspect = (double) width / (double) height;
if (actualAspect > desktopAspect) {
child_allocation.width = round(height * desktopAspect);
--
2.5.0
___
virt-tools-list mailing list
virt-tools-list@redhat.com
https://www.redhat.com/mailman/listinfo/virt-tools-list
