Re: [virt-tools-list] [PATCH] Adjust timer to refresh ovirt foreign menu

[Fabiano Fidêncio]

On Thu, Jun 30, 2016 at 2:01 PM, Eduardo Lima (Etrunko)
 wrote:
> This is a temporary solution, as discussed in the bug. We will adjust
> the timer to refresh the ISO list from 15 seconds to 5 minutes (300
> seconds), while reworking in the UI to replace the menu with a dialog,
> which seems a saner way to display the list.
>
> Resolves: rhbz#1347726
>
> Signed-off-by: Eduardo Lima (Etrunko) 
> ---
>  src/ovirt-foreign-menu.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/src/ovirt-foreign-menu.c b/src/ovirt-foreign-menu.c
> index 2d286fb..33ff4f1 100644
> --- a/src/ovirt-foreign-menu.c
> +++ b/src/ovirt-foreign-menu.c
> @@ -797,7 +797,7 @@ static void iso_list_fetched_cb(GObject *source_object,
>  ovirt_foreign_menu_set_files(OVIRT_FOREIGN_MENU(user_data), files);
>  g_list_free(files);
>
> -g_timeout_add_seconds(15, ovirt_foreign_menu_refresh_iso_list, 
> user_data);
> +g_timeout_add_seconds(300, ovirt_foreign_menu_refresh_iso_list, 
> user_data);
>  }
>
>
> --
> 2.5.5
>
> ___
> virt-tools-list mailing list
> virt-tools-list@redhat.com
> https://www.redhat.com/mailman/listinfo/virt-tools-list


Acked-by: Fabiano Fidêncio 
-- 
Fabiano Fidêncio

___
virt-tools-list mailing list
virt-tools-list@redhat.com
https://www.redhat.com/mailman/listinfo/virt-tools-list

Re: [virt-tools-list] [PATCH] Adjust timer to refresh ovirt foreign menu

[Christophe Fergeau]

Hey,

I'd add a sentence describing what the bug is about (flooding oVirt
log), apart from this

Acked-by: Christophe Fergeau 

Christophe

On Thu, Jun 30, 2016 at 09:01:17AM -0300, Eduardo Lima (Etrunko) wrote:
> This is a temporary solution, as discussed in the bug. We will adjust
> the timer to refresh the ISO list from 15 seconds to 5 minutes (300
> seconds), while reworking in the UI to replace the menu with a dialog,
> which seems a saner way to display the list.
> 
> Resolves: rhbz#1347726
> 
> Signed-off-by: Eduardo Lima (Etrunko) 
> ---
>  src/ovirt-foreign-menu.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/src/ovirt-foreign-menu.c b/src/ovirt-foreign-menu.c
> index 2d286fb..33ff4f1 100644
> --- a/src/ovirt-foreign-menu.c
> +++ b/src/ovirt-foreign-menu.c
> @@ -797,7 +797,7 @@ static void iso_list_fetched_cb(GObject *source_object,
>  ovirt_foreign_menu_set_files(OVIRT_FOREIGN_MENU(user_data), files);
>  g_list_free(files);
>  
> -g_timeout_add_seconds(15, ovirt_foreign_menu_refresh_iso_list, 
> user_data);
> +g_timeout_add_seconds(300, ovirt_foreign_menu_refresh_iso_list, 
> user_data);
>  }
>  
>  
> -- 
> 2.5.5
> 
> ___
> virt-tools-list mailing list
> virt-tools-list@redhat.com
> https://www.redhat.com/mailman/listinfo/virt-tools-list


signature.asc
Description: PGP signature
___
virt-tools-list mailing list
virt-tools-list@redhat.com
https://www.redhat.com/mailman/listinfo/virt-tools-list

Re: [virt-tools-list] [PATCH] Adjust timer to refresh ovirt foreign menu

[Eduardo Lima (Etrunko)]

On 06/30/2016 09:03 AM, Fabiano Fidêncio wrote:
> On Thu, Jun 30, 2016 at 2:01 PM, Eduardo Lima (Etrunko)
>  wrote:
>> This is a temporary solution, as discussed in the bug. We will adjust
>> the timer to refresh the ISO list from 15 seconds to 5 minutes (300
>> seconds), while reworking in the UI to replace the menu with a dialog,
>> which seems a saner way to display the list.
>>
>> Resolves: rhbz#1347726
>>
>> Signed-off-by: Eduardo Lima (Etrunko) 
>> ---
>>  src/ovirt-foreign-menu.c | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/src/ovirt-foreign-menu.c b/src/ovirt-foreign-menu.c
>> index 2d286fb..33ff4f1 100644
>> --- a/src/ovirt-foreign-menu.c
>> +++ b/src/ovirt-foreign-menu.c
>> @@ -797,7 +797,7 @@ static void iso_list_fetched_cb(GObject *source_object,
>>  ovirt_foreign_menu_set_files(OVIRT_FOREIGN_MENU(user_data), files);
>>  g_list_free(files);
>>
>> -g_timeout_add_seconds(15, ovirt_foreign_menu_refresh_iso_list, 
>> user_data);
>> +g_timeout_add_seconds(300, ovirt_foreign_menu_refresh_iso_list, 
>> user_data);
>>  }
>>
>>
>> --
>> 2.5.5
>>
>> ___
>> virt-tools-list mailing list
>> virt-tools-list@redhat.com
>> https://www.redhat.com/mailman/listinfo/virt-tools-list
> 
> 
> Acked-by: Fabiano Fidêncio 

Thanks, pushed.

-- 
Eduardo de Barros Lima (Etrunko)
Software Engineer - RedHat
etru...@redhat.com

___
virt-tools-list mailing list
virt-tools-list@redhat.com
https://www.redhat.com/mailman/listinfo/virt-tools-list

[virt-tools-list] [PATCH] Adjust timer to refresh ovirt foreign menu

[Eduardo Lima (Etrunko)]

This is a temporary solution, as discussed in the bug. We will adjust
the timer to refresh the ISO list from 15 seconds to 5 minutes (300
seconds), while reworking in the UI to replace the menu with a dialog,
which seems a saner way to display the list.

Resolves: rhbz#1347726

Signed-off-by: Eduardo Lima (Etrunko) 
---
 src/ovirt-foreign-menu.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/ovirt-foreign-menu.c b/src/ovirt-foreign-menu.c
index 2d286fb..33ff4f1 100644
--- a/src/ovirt-foreign-menu.c
+++ b/src/ovirt-foreign-menu.c
@@ -797,7 +797,7 @@ static void iso_list_fetched_cb(GObject *source_object,
 ovirt_foreign_menu_set_files(OVIRT_FOREIGN_MENU(user_data), files);
 g_list_free(files);
 
-g_timeout_add_seconds(15, ovirt_foreign_menu_refresh_iso_list, user_data);
+g_timeout_add_seconds(300, ovirt_foreign_menu_refresh_iso_list, user_data);
 }
 
 
-- 
2.5.5

___
virt-tools-list mailing list
virt-tools-list@redhat.com
https://www.redhat.com/mailman/listinfo/virt-tools-list