Re: [virt-tools-list] [PATCH 2/2] configure: cleanup {GLIB2, GTK}_CFLAGS
On 03/22/2016 10:42 AM, Eduardo Lima (Etrunko) wrote: > On 03/22/2016 08:02 AM, Pavel Grunt wrote: >> Hi, >> >> imo with the change the line is too long >> >> About the AC_SUBST calls - iirc they are defined automatically when >> pkg-config is >= 0.24 (not the case of rhel6). >> Or is it about something else (why just _LIBS and not _CFLAGS) ? >> > > About line being to long it is easily fixed by breaking the line. This > patch is only here because when I reviewed the original patch, it wal > already merged. > > About calling AC_SUBST for _LIBS, only _CFLAGS varible is touched, so it > is only required for the latter. I will provide more details in the > commit message. > Forgot to add that about RHEL6, it does not matter anyway, as virt-viewer dropped Gtk+ 2.0 support recently. -- Eduardo de Barros Lima (Etrunko) Software Engineer - RedHat etru...@redhat.com ___ virt-tools-list mailing list virt-tools-list@redhat.com https://www.redhat.com/mailman/listinfo/virt-tools-list
Re: [virt-tools-list] [PATCH 2/2] configure: cleanup {GLIB2, GTK}_CFLAGS
On 03/22/2016 08:02 AM, Pavel Grunt wrote: > Hi, > > imo with the change the line is too long > > About the AC_SUBST calls - iirc they are defined automatically when > pkg-config is >= 0.24 (not the case of rhel6). > Or is it about something else (why just _LIBS and not _CFLAGS) ? > About line being to long it is easily fixed by breaking the line. This patch is only here because when I reviewed the original patch, it wal already merged. About calling AC_SUBST for _LIBS, only _CFLAGS varible is touched, so it is only required for the latter. I will provide more details in the commit message. -- Eduardo de Barros Lima (Etrunko) Software Engineer - RedHat etru...@redhat.com ___ virt-tools-list mailing list virt-tools-list@redhat.com https://www.redhat.com/mailman/listinfo/virt-tools-list
Re: [virt-tools-list] [PATCH 2/2] configure: cleanup {GLIB2, GTK}_CFLAGS
Hi, imo with the change the line is too long About the AC_SUBST calls - iirc they are defined automatically when pkg-config is >= 0.24 (not the case of rhel6). Or is it about something else (why just _LIBS and not _CFLAGS) ? Thanks, Pavel On Tue, 2016-03-15 at 11:48 -0300, Eduardo Lima (Etrunko) wrote: > Also, remove unecessary AC_SUBST calls > > Signed-off-by: Eduardo Lima (Etrunko) > --- > configure.ac | 8 ++-- > 1 file changed, 2 insertions(+), 6 deletions(-) > > diff --git a/configure.ac b/configure.ac > index 6d8475b..ee9dc73 100644 > --- a/configure.ac > +++ b/configure.ac > @@ -102,10 +102,8 @@ GLIB_MKENUMS=`$PKG_CONFIG -- > variable=glib_mkenums glib-2.0` > AC_SUBST(GLIB_MKENUMS) > > PKG_CHECK_MODULES(GLIB2, glib-2.0 >= $GLIB2_REQUIRED gio-2.0 > gthread-2.0 gmodule-export-2.0) > -GLIB2_CFLAGS="$GLIB2_CFLAGS > -DGLIB_VERSION_MIN_REQUIRED=$GLIB2_ENCODED_VERSION" > -GLIB2_CFLAGS="$GLIB2_CFLAGS > -DGLIB_VERSION_MAX_ALLOWED=$GLIB2_ENCODED_VERSION" > +GLIB2_CFLAGS="$GLIB2_CFLAGS > -DGLIB_VERSION_MIN_REQUIRED=$GLIB2_ENCODED_VERSION > -DGLIB_VERSION_MAX_ALLOWED=$GLIB2_ENCODED_VERSION" > AC_SUBST(GLIB2_CFLAGS) > -AC_SUBST(GLIB2_LIBS) > > AC_ARG_VAR([GLIB_COMPILE_RESOURCES],[the glib-compile-resources > program]) > AC_PATH_PROG([GLIB_COMPILE_RESOURCES],[glib-compile-resources],[]) > @@ -137,10 +135,8 @@ AC_CHECK_LIB([virt], > LIBS=$old_LIBS > > PKG_CHECK_MODULES(GTK, gtk+-3.0 >= $GTK_REQUIRED) > -GTK_CFLAGS="$GTK_CFLAGS > -DGDK_VERSION_MIN_REQUIRED=$GTK_ENCODED_VERSION" > -GTK_CFLAGS="$GTK_CFLAGS > -DGDK_VERSION_MAX_ALLOWED=$GTK_ENCODED_VERSION" > +GTK_CFLAGS="$GTK_CFLAGS > -DGDK_VERSION_MIN_REQUIRED=$GTK_ENCODED_VERSION > -DGDK_VERSION_MAX_ALLOWED=$GTK_ENCODED_VERSION" > AC_SUBST(GTK_CFLAGS) > -AC_SUBST(GTK_LIBS) > > AC_ARG_WITH([gtk-vnc], > AS_HELP_STRING([--without-gtk-vnc], [Ignore presence of gtk-vnc > and disable it])) ___ virt-tools-list mailing list virt-tools-list@redhat.com https://www.redhat.com/mailman/listinfo/virt-tools-list
[virt-tools-list] [PATCH 2/2] configure: cleanup {GLIB2, GTK}_CFLAGS
Also, remove unecessary AC_SUBST calls Signed-off-by: Eduardo Lima (Etrunko) --- configure.ac | 8 ++-- 1 file changed, 2 insertions(+), 6 deletions(-) diff --git a/configure.ac b/configure.ac index 6d8475b..ee9dc73 100644 --- a/configure.ac +++ b/configure.ac @@ -102,10 +102,8 @@ GLIB_MKENUMS=`$PKG_CONFIG --variable=glib_mkenums glib-2.0` AC_SUBST(GLIB_MKENUMS) PKG_CHECK_MODULES(GLIB2, glib-2.0 >= $GLIB2_REQUIRED gio-2.0 gthread-2.0 gmodule-export-2.0) -GLIB2_CFLAGS="$GLIB2_CFLAGS -DGLIB_VERSION_MIN_REQUIRED=$GLIB2_ENCODED_VERSION" -GLIB2_CFLAGS="$GLIB2_CFLAGS -DGLIB_VERSION_MAX_ALLOWED=$GLIB2_ENCODED_VERSION" +GLIB2_CFLAGS="$GLIB2_CFLAGS -DGLIB_VERSION_MIN_REQUIRED=$GLIB2_ENCODED_VERSION -DGLIB_VERSION_MAX_ALLOWED=$GLIB2_ENCODED_VERSION" AC_SUBST(GLIB2_CFLAGS) -AC_SUBST(GLIB2_LIBS) AC_ARG_VAR([GLIB_COMPILE_RESOURCES],[the glib-compile-resources program]) AC_PATH_PROG([GLIB_COMPILE_RESOURCES],[glib-compile-resources],[]) @@ -137,10 +135,8 @@ AC_CHECK_LIB([virt], LIBS=$old_LIBS PKG_CHECK_MODULES(GTK, gtk+-3.0 >= $GTK_REQUIRED) -GTK_CFLAGS="$GTK_CFLAGS -DGDK_VERSION_MIN_REQUIRED=$GTK_ENCODED_VERSION" -GTK_CFLAGS="$GTK_CFLAGS -DGDK_VERSION_MAX_ALLOWED=$GTK_ENCODED_VERSION" +GTK_CFLAGS="$GTK_CFLAGS -DGDK_VERSION_MIN_REQUIRED=$GTK_ENCODED_VERSION -DGDK_VERSION_MAX_ALLOWED=$GTK_ENCODED_VERSION" AC_SUBST(GTK_CFLAGS) -AC_SUBST(GTK_LIBS) AC_ARG_WITH([gtk-vnc], AS_HELP_STRING([--without-gtk-vnc], [Ignore presence of gtk-vnc and disable it])) -- 2.5.0 ___ virt-tools-list mailing list virt-tools-list@redhat.com https://www.redhat.com/mailman/listinfo/virt-tools-list
