On Wed, 2016-02-17 at 11:01 -0200, Eduardo Lima (Etrunko) wrote:
> In this version I addressed the comments made from review of v5.
> - Rename virt_viewer_app_startup() to
> virt_viewer_app_on_application_startup()
> - Remove VIRT_VIEWER_VERSION error code and move --version option
> handler to VirtViewerApp.
> - Removed {remote,virt}_viewer_new() functions and call g_object_new()
> directly.
I actually disagree with this last change. I know that remote_viewer_new() is
just a wrapper around g_object new, but it's a standard convention in glib
libraries to privide a constructor function like this, especially when there are
properties that need to be set. In this situation, there's not much benefit
since they're only called from one location, but I still like the convention.
>
>
> Eduardo Lima (Etrunko) (3):
> Port to GtkApplication API's
> remote-viewer: Remove unused properties
> Drop old compatibility code
>
> configure.ac| 6 +-
> src/Makefile.am | 2 -
> src/ovirt-foreign-menu.c| 1 -
> src/remote-viewer-main.c| 173 ++-
> src/remote-viewer.c | 256 +--
> -
> src/remote-viewer.h | 3 -
> src/virt-glib-compat.c | 34 --
> src/virt-glib-compat.h | 83 -
> src/virt-viewer-app.c | 158 -
> src/virt-viewer-app.h | 11 +-
> src/virt-viewer-events.c| 1 -
> src/virt-viewer-file.h | 1 -
> src/virt-viewer-main.c | 113 ++
> src/virt-viewer-session-spice.c | 1 -
> src/virt-viewer-util.h | 2 +-
> src/virt-viewer.c | 120 ++-
> src/virt-viewer.h | 8 --
> src/virt-viewer.xml | 2 +-
> 18 files changed, 353 insertions(+), 622 deletions(-)
> delete mode 100644 src/virt-glib-compat.c
> delete mode 100644 src/virt-glib-compat.h
>
___
virt-tools-list mailing list
virt-tools-list@redhat.com
https://www.redhat.com/mailman/listinfo/virt-tools-list
