Re: [virt-tools-list] [PATCH virt-viewer] iso-dialog: Do not use string directly

2017-02-06 Thread Eduardo Lima (Etrunko) 
Acked-by: Eduardo Lima (Etrunko) 

On 06/02/17 10:02, Pavel Grunt wrote:
> Fixes -Werror=format-security used when creating the rpm
> ---
> see: 
> https://copr-be.cloud.fedoraproject.org/results/pgrunt/spice-upstream/fedora-25-x86_64/00507878-virt-viewer/build.log.gz
> ---
>  src/remote-viewer-iso-list-dialog.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/src/remote-viewer-iso-list-dialog.c 
> b/src/remote-viewer-iso-list-dialog.c
> index f23ddb2..2ab5435 100644
> --- a/src/remote-viewer-iso-list-dialog.c
> +++ b/src/remote-viewer-iso-list-dialog.c
> @@ -286,7 +286,7 @@ 
> remote_viewer_iso_list_dialog_show_error(RemoteViewerISOListDialog *self,
>  GTK_DIALOG_DESTROY_WITH_PARENT,
>  GTK_MESSAGE_ERROR,
>  GTK_BUTTONS_CLOSE,
> -message ? message : _("Unspecified 
> error"));
> +"%s", message ? message : _("Unspecified 
> error"));
>  gtk_dialog_run(GTK_DIALOG(dialog));
>  gtk_widget_destroy(dialog);
>  }
> 


-- 
Eduardo de Barros Lima (Etrunko)
Software Engineer - RedHat
etru...@redhat.com

___
virt-tools-list mailing list
virt-tools-list@redhat.com
https://www.redhat.com/mailman/listinfo/virt-tools-list

[virt-tools-list] [PATCH virt-viewer] iso-dialog: Do not use string directly

2017-02-06 Thread Pavel Grunt 
Fixes -Werror=format-security used when creating the rpm
---
see: 
https://copr-be.cloud.fedoraproject.org/results/pgrunt/spice-upstream/fedora-25-x86_64/00507878-virt-viewer/build.log.gz
---
 src/remote-viewer-iso-list-dialog.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/remote-viewer-iso-list-dialog.c 
b/src/remote-viewer-iso-list-dialog.c
index f23ddb2..2ab5435 100644
--- a/src/remote-viewer-iso-list-dialog.c
+++ b/src/remote-viewer-iso-list-dialog.c
@@ -286,7 +286,7 @@ 
remote_viewer_iso_list_dialog_show_error(RemoteViewerISOListDialog *self,
 GTK_DIALOG_DESTROY_WITH_PARENT,
 GTK_MESSAGE_ERROR,
 GTK_BUTTONS_CLOSE,
-message ? message : _("Unspecified 
error"));
+"%s", message ? message : _("Unspecified 
error"));
 gtk_dialog_run(GTK_DIALOG(dialog));
 gtk_widget_destroy(dialog);
 }
-- 
2.11.0

___
virt-tools-list mailing list
virt-tools-list@redhat.com
https://www.redhat.com/mailman/listinfo/virt-tools-list