Re: [virt-tools-list] [PATCH virt-viewer 07/11] UI: Make 'Change CD' menu item a submenu under 'File' toplevel menu

2016-07-19 Thread Eduardo Lima (Etrunko) 
On 07/19/2016 12:46 PM, Christophe Fergeau wrote:
> Your glade seems to have added unrelated changes to that commit. If
> newer versions of glade are always going to make these changes, we can
> commit them separately.
> 

Dunno why all those changes got in, most likely because of different
versions of glade. I will remove the unrelated changes and keep only
what the commit is meant to do.

-- 
Eduardo de Barros Lima (Etrunko)
Software Engineer - RedHat
etru...@redhat.com

___
virt-tools-list mailing list
virt-tools-list@redhat.com
https://www.redhat.com/mailman/listinfo/virt-tools-list

Re: [virt-tools-list] [PATCH virt-viewer 07/11] UI: Make 'Change CD' menu item a submenu under 'File' toplevel menu

2016-07-19 Thread Christophe Fergeau 
Your glade seems to have added unrelated changes to that commit. If
newer versions of glade are always going to make these changes, we can
commit them separately.

Christophe

On Sun, Jul 17, 2016 at 11:13:07PM -0300, Eduardo Lima (Etrunko) wrote:
> Signed-off-by: Eduardo Lima (Etrunko) 
> ---
>  src/resources/ui/virt-viewer.ui | 57 
> +++--
>  1 file changed, 21 insertions(+), 36 deletions(-)
> 
> diff --git a/src/resources/ui/virt-viewer.ui b/src/resources/ui/virt-viewer.ui
> index 6e3c5ad..ee23ba5 100644
> --- a/src/resources/ui/virt-viewer.ui
> +++ b/src/resources/ui/virt-viewer.ui
> @@ -1,6 +1,7 @@
>  
> +
>  
> -  
> +  
>
>
>  False
> @@ -23,7 +24,6 @@
>
>  True
>  False
> -False
>   translatable="yes">_File
>  True
>  
> @@ -35,7 +35,6 @@
> id="menu-file-screenshot">
>  True
>  False
> - name="use_action_appearance">False
>   translatable="yes">_Screenshot
>  True
>   handler="virt_viewer_window_menu_file_screenshot" swapped="no"/>
> @@ -46,7 +45,6 @@
>  True
>  False
>  False
> - name="use_action_appearance">False
>  _USB 
> device selection
>  True
>   handler="virt_viewer_window_menu_file_usb_device_selection" swapped="no"/>
> @@ -55,7 +53,6 @@
>  
> id="menu-file-smartcard-insert">
>  False
> - name="use_action_appearance">False
>   name="accel_path">virt-viewer/file/smartcard-insert
>   translatable="yes">Smartcard insertion
>  True
> @@ -65,7 +62,6 @@
>  
> id="menu-file-smartcard-remove">
>  False
> - name="use_action_appearance">False
>   name="accel_path">virt-viewer/file/smartcard-remove
>   translatable="yes">Smartcard removal
>  True
> @@ -73,6 +69,13 @@
>
>  
>  
> +  
> +False
> + translatable="yes">_Change CD
> +True
> +  
> +
> +
>
>  True
>  False
> @@ -89,13 +92,12 @@
>  
>  
>
> - translatable="yes">_Quit
>  True
>  False
> - name="use_action_appearance">False
> + translatable="yes">_Quit
>  True
> - modifiers="GDK_SHIFT_MASK | GDK_CONTROL_MASK"/>
>   handler="virt_viewer_window_menu_file_quit" swapped="no"/>
> + modifiers="GDK_SHIFT_MASK | GDK_CONTROL_MASK"/>
>
>  
>
> @@ -106,7 +108,6 @@
>
>  True
>  False
> -False
>   translatable="yes">_View
>  True
>  
> @@ -118,7 +119,6 @@
> id="menu-view-fullscreen">
>  True
>  False
> - name="use_action_appearance">False
>   name="accel_path">virt-viewer/view/toggle-fullscreen
>  _Full 
> screen
>  True
> @@ -129,7 +129,6 @@
>
>  True
>  False
> - name="use_action_appearance">False
>   translatable="yes">_Zoom
>  True
>  
> @@ -139,22 +138,22 @@
>   name="accel_group">accelgroup
>  
> id="menu-view-zoom-in">
> - name="accel_path">virt-viewer/view/zoom-in
> -

[virt-tools-list] [PATCH virt-viewer 07/11] UI: Make 'Change CD' menu item a submenu under 'File' toplevel menu

2016-07-17 Thread Eduardo Lima (Etrunko) 
Signed-off-by: Eduardo Lima (Etrunko) 
---
 src/resources/ui/virt-viewer.ui | 57 +++--
 1 file changed, 21 insertions(+), 36 deletions(-)

diff --git a/src/resources/ui/virt-viewer.ui b/src/resources/ui/virt-viewer.ui
index 6e3c5ad..ee23ba5 100644
--- a/src/resources/ui/virt-viewer.ui
+++ b/src/resources/ui/virt-viewer.ui
@@ -1,6 +1,7 @@
 
+
 
-  
+  
   
   
 False
@@ -23,7 +24,6 @@
   
 True
 False
-False
 _File
 True
 
@@ -35,7 +35,6 @@
   
 True
 False
-False
 _Screenshot
 True
 
@@ -46,7 +45,6 @@
 True
 False
 False
-False
 _USB 
device selection
 True
 
@@ -55,7 +53,6 @@
 
   
 False
-False
 virt-viewer/file/smartcard-insert
 Smartcard insertion
 True
@@ -65,7 +62,6 @@
 
   
 False
-False
 virt-viewer/file/smartcard-remove
 Smartcard removal
 True
@@ -73,6 +69,13 @@
   
 
 
+  
+False
+_Change 
CD
+True
+  
+
+
   
 True
 False
@@ -89,13 +92,12 @@
 
 
   
-_Quit
 True
 False
-False
+_Quit
 True
-
 
+
   
 
   
@@ -106,7 +108,6 @@
   
 True
 False
-False
 _View
 True
 
@@ -118,7 +119,6 @@
   
 True
 False
-False
 virt-viewer/view/toggle-fullscreen
 _Full 
screen
 True
@@ -129,7 +129,6 @@
   
 True
 False
-False
 _Zoom
 True
 
@@ -139,22 +138,22 @@
 accelgroup
 
   
-virt-viewer/view/zoom-in
-Zoom _In
+False
 True
 False
-False
+virt-viewer/view/zoom-in
+Zoom _In
 True
 
   
 
 
   
-virt-viewer/view/zoom-out
-Zoom _Out
+False
 True
 False
-False
+virt-viewer/view/zoom-out
+Zoom _Out
 True
 
   
@@ -167,11 +166,11 @@
 
 
   
-virt-viewer/view/zoom-reset
-_Normal Size
+False
 True
 False
-