Re: [virt-tools-list] [virt-manager PATCH] virt-xml: add qemu commandline passthrough example

2017-03-29 Thread Chen Hanxiao

At 2017-03-29 19:33:11, "Cole Robinson"  wrote:
>On 03/28/2017 06:42 AM, Chen Hanxiao wrote:
>> From: Chen Hanxiao 
>> 
>> We forgot to mention --qemu-commandline in virt-xml.pod.
>> Also added an example copied from Cole's blog.
>> 
>> Signed-off-by: Chen Hanxiao 
>> ---
>>  man/virt-xml.pod | 6 ++
>>  1 file changed, 6 insertions(+)
>> 
>> diff --git a/man/virt-xml.pod b/man/virt-xml.pod
>> index 675288d..fa75cb3 100644
>> --- a/man/virt-xml.pod
>> +++ b/man/virt-xml.pod
>> @@ -222,6 +222,8 @@ Before defining or updating the domain, show the 
>> generated XML diff and interact
>>  
>>  =item B<--panic>
>>  
>> +=item B<--qemu-commandline>
>> +
>>  These options alter the XML for a single class of XML elements. More 
>> complete documentation is found in L.
>>  
>>  Generally these options map pretty straightforwardly to the libvirt XML, 
>> documented at L
>> @@ -337,6 +339,10 @@ Generate XML for a virtio console device and print it 
>> to stdout:
>>  
>># virt-xml --build-xml --console pty,target_type=virtio
>>  
>> +Add qemu command line passthrough:
>> +
>> +  # virt-xml f25 --edit --confirm --qemu-commandline="-device FOO"
>> +
>>  
>>  =head1 CAVEATS
>>  
>> 
>
>ACK
>

Pushed

Regards,
- Chen

___
virt-tools-list mailing list
virt-tools-list@redhat.com
https://www.redhat.com/mailman/listinfo/virt-tools-list


Re: [virt-tools-list] [virt-manager PATCH] virt-xml: add qemu commandline passthrough example

2017-03-29 Thread Cole Robinson
On 03/28/2017 06:42 AM, Chen Hanxiao wrote:
> From: Chen Hanxiao 
> 
> We forgot to mention --qemu-commandline in virt-xml.pod.
> Also added an example copied from Cole's blog.
> 
> Signed-off-by: Chen Hanxiao 
> ---
>  man/virt-xml.pod | 6 ++
>  1 file changed, 6 insertions(+)
> 
> diff --git a/man/virt-xml.pod b/man/virt-xml.pod
> index 675288d..fa75cb3 100644
> --- a/man/virt-xml.pod
> +++ b/man/virt-xml.pod
> @@ -222,6 +222,8 @@ Before defining or updating the domain, show the 
> generated XML diff and interact
>  
>  =item B<--panic>
>  
> +=item B<--qemu-commandline>
> +
>  These options alter the XML for a single class of XML elements. More 
> complete documentation is found in L.
>  
>  Generally these options map pretty straightforwardly to the libvirt XML, 
> documented at L
> @@ -337,6 +339,10 @@ Generate XML for a virtio console device and print it to 
> stdout:
>  
># virt-xml --build-xml --console pty,target_type=virtio
>  
> +Add qemu command line passthrough:
> +
> +  # virt-xml f25 --edit --confirm --qemu-commandline="-device FOO"
> +
>  
>  =head1 CAVEATS
>  
> 

ACK

Thanks,
Cole

___
virt-tools-list mailing list
virt-tools-list@redhat.com
https://www.redhat.com/mailman/listinfo/virt-tools-list