[virtio-dev] RE: [PATCH v1 01/20] virtio-network: Maintain network device spec in separate directory

2023-01-09 Thread Parav Pandit


> From: Michael S. Tsirkin 
> Sent: Monday, January 9, 2023 2:15 PM
> 
> > > So my preference is \\input for now.
> > \\input doesn't support reading from the directory.
> 
> I just tested this and it seems to work fine:
> 
> \input{sub/file.tex}
> 
> what is the issue that you see?

I was running with file_conformance.tex name and it doesn't like underscore 
based named.
And I lost track when I moved away from understore and missed to revert to 
input again.

> 
> I think I prefer \\input as it's easier to understand.

Yes. I will respin with \input and directories.

> 
> --
> MST


-
To unsubscribe, e-mail: virtio-dev-unsubscr...@lists.oasis-open.org
For additional commands, e-mail: virtio-dev-h...@lists.oasis-open.org



[virtio-dev] Re: [PATCH v1 01/20] virtio-network: Maintain network device spec in separate directory

2023-01-09 Thread Michael S. Tsirkin
On Mon, Jan 09, 2023 at 02:12:36PM +, Parav Pandit wrote:
> 
> > From: Michael S. Tsirkin 
> > Sent: Monday, January 9, 2023 8:43 AM
> > 
> > I found another issue with this. Currently for redline diff generation
> > we use latexpand. Using a flat expanded file has lots of benefits, in
> > particular latexdiff is sometimes fragile as it is, with a flat file
> > one can at least see the input it gets.
> > 
> > We should either stick with \\input or more work is needed on
> > these scripts. Besides, we are already using \\input and I like
> > consistency.
> > 
> > So my preference is \\input for now.
> \\input doesn't support reading from the directory.

I just tested this and it seems to work fine:

\input{sub/file.tex}

what is the issue that you see?

I think I prefer \\input as it's easier to understand.

-- 
MST


-
To unsubscribe, e-mail: virtio-dev-unsubscr...@lists.oasis-open.org
For additional commands, e-mail: virtio-dev-h...@lists.oasis-open.org



[virtio-dev] Re: [PATCH v1 01/20] virtio-network: Maintain network device spec in separate directory

2023-01-09 Thread Michael S. Tsirkin
On Mon, Jan 09, 2023 at 02:12:36PM +, Parav Pandit wrote:
> 
> > From: Michael S. Tsirkin 
> > Sent: Monday, January 9, 2023 8:43 AM
> > 
> > I found another issue with this. Currently for redline diff generation
> > we use latexpand. Using a flat expanded file has lots of benefits, in
> > particular latexdiff is sometimes fragile as it is, with a flat file
> > one can at least see the input it gets.
> > 
> > We should either stick with \\input or more work is needed on
> > these scripts. Besides, we are already using \\input and I like
> > consistency.
> > 
> > So my preference is \\input for now.
> \\input doesn't support reading from the directory.

In that case let's put everything in the same directory.
The argument for splitting things was weak anyway.

-- 
MST


-
To unsubscribe, e-mail: virtio-dev-unsubscr...@lists.oasis-open.org
For additional commands, e-mail: virtio-dev-h...@lists.oasis-open.org



[virtio-dev] RE: [PATCH v1 01/20] virtio-network: Maintain network device spec in separate directory

2023-01-09 Thread Parav Pandit


> From: Michael S. Tsirkin 
> Sent: Monday, January 9, 2023 8:43 AM
> 
> I found another issue with this. Currently for redline diff generation
> we use latexpand. Using a flat expanded file has lots of benefits, in
> particular latexdiff is sometimes fragile as it is, with a flat file
> one can at least see the input it gets.
> 
> We should either stick with \\input or more work is needed on
> these scripts. Besides, we are already using \\input and I like
> consistency.
> 
> So my preference is \\input for now.
\\input doesn't support reading from the directory.

-
To unsubscribe, e-mail: virtio-dev-unsubscr...@lists.oasis-open.org
For additional commands, e-mail: virtio-dev-h...@lists.oasis-open.org