Re: [PATCH 0/2] virtio net improvements

2010-02-02 Thread Rusty Russell
On Fri, 29 Jan 2010 11:46:43 pm Rusty Russell wrote:
 Hi Dave,
 
Nice driver optimization from Shirley, but requires a new virtio hook.
 Do you want to take both?  I have nothing else overlapping it.

Dave, any news on this?  Shirley, I note that your final commit message did
not contain this information from your original version:

Tests have been done for small packets, big packets and
mergeable buffers.

The single netperf TCP_STREAM performance improved for host to guest. 
It also reduces UDP packets drop rate.

The netperf laptop results were:

mtu=1500
netperf -H xxx -l 120

w/o patch   w/i patch (two runs)
guest to host:  3336.84Mb/s   3730.14Mb/s ~ 3582.88Mb/s

host to guest:  3165.10Mb/s   3370.39Mb/s ~ 3407.96Mb/s

Thanks,
Rusty.
___
Virtualization mailing list
Virtualization@lists.linux-foundation.org
https://lists.linux-foundation.org/mailman/listinfo/virtualization


Re: [PATCH 0/2] virtio net improvements

2010-02-02 Thread David Miller
From: Rusty Russell ru...@rustcorp.com.au
Date: Wed, 3 Feb 2010 09:57:06 +1030

 On Fri, 29 Jan 2010 11:46:43 pm Rusty Russell wrote:
 Hi Dave,
 
Nice driver optimization from Shirley, but requires a new virtio hook.
 Do you want to take both?  I have nothing else overlapping it.
 
 Dave, any news on this?

Just slowly creeping up the backlog :-)

___
Virtualization mailing list
Virtualization@lists.linux-foundation.org
https://lists.linux-foundation.org/mailman/listinfo/virtualization


Re: [PATCH 1/2] virtio: Add ability to detach unused buffers from vrings

2010-02-02 Thread David Miller
From: Rusty Russell ru...@rustcorp.com.au
Date: Fri, 29 Jan 2010 23:49:05 +1030

 From: Shirley Ma mashi...@us.ibm.com
 
 There's currently no way for a virtio driver to ask for unused
 buffers, so it has to keep a list itself to reclaim them at shutdown.
 This is redundant, since virtio_ring stores that information.  So
 add a new hook to do this.
 
 Signed-off-by: Shirley Ma x...@us.ibm.com
 Signed-off-by: Amit Shah amit.s...@redhat.com
 Signed-off-by: Rusty Russell ru...@rustcorp.com.au

Applied.
___
Virtualization mailing list
Virtualization@lists.linux-foundation.org
https://lists.linux-foundation.org/mailman/listinfo/virtualization


Re: [PATCH 2/2] virtio_net: Defer skb allocation in receive path Date: Wed, 13 Jan 2010 12:53:38 -0800

2010-02-02 Thread David Miller
From: Rusty Russell ru...@rustcorp.com.au
Date: Fri, 29 Jan 2010 23:50:04 +1030

 From: Shirley Ma mashi...@us.ibm.com
 
 virtio_net receives packets from its pre-allocated vring buffers, then it 
 delivers these packets to upper layer protocols as skb buffs. So it's not
 necessary to pre-allocate skb for each mergable buffer, then frees extra 
 skbs when buffers are merged into a large packet. This patch has deferred 
 skb allocation in receiving packets for both big packets and mergeable buffers
 to reduce skb pre-allocations and skb frees. It frees unused buffers by 
 calling 
 detach_unused_buf in vring, so recv skb queue is not needed.
 
 Signed-off-by: Shirley Ma x...@us.ibm.com
 Signed-off-by: Rusty Russell ru...@rustcorp.com.au

Applied.
___
Virtualization mailing list
Virtualization@lists.linux-foundation.org
https://lists.linux-foundation.org/mailman/listinfo/virtualization