Re: [Qemu-devel] Re: [PATCH] Implement a virtio GPU transport
On Wed, Nov 03, 2010 at 06:03:50PM +, Ian Molton wrote: On 01/11/10 13:28, Anthony Liguori wrote: On 11/01/2010 06:53 AM, Alon Levy wrote: While we (speaking as part of the SPICE developers) want to have the same support in our virtual GPU for 3d as we have for 2d, we just don't at this point of time. Would it be helpful to you to have /something/ that works in the interim? I'm happy to work with you guys so that we dont need to reinvent the wheel ;-) In case it wasn't clear, I think putting virtio-gl is a good idea, exactly because it works right now. [Snip] ___ Virtualization mailing list Virtualization@lists.linux-foundation.org https://lists.linux-foundation.org/mailman/listinfo/virtualization
[PATCH v2 3/5] VIDEO: xen-fb, switch to for_each_console
Use newly added for_each_console for iterating consoles.
Signed-off-by: Jiri Slaby jsl...@suse.cz
Cc: Jeremy Fitzhardinge jer...@xensource.com
Cc: Chris Wright chr...@sous-sol.org
Cc: virtualizat...@lists.osdl.org
Cc: xen-de...@lists.xensource.com
Cc: linux-fb...@vger.kernel.org
---
drivers/video/xen-fbfront.c |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/video/xen-fbfront.c b/drivers/video/xen-fbfront.c
index 428d273..4abb0b9 100644
--- a/drivers/video/xen-fbfront.c
+++ b/drivers/video/xen-fbfront.c
@@ -492,7 +492,7 @@ xenfb_make_preferred_console(void)
return;
acquire_console_sem();
- for (c = console_drivers; c; c = c-next) {
+ for_each_console(c) {
if (!strcmp(c-name, tty) c-index == 0)
break;
}
--
1.7.3.1
___
Virtualization mailing list
Virtualization@lists.linux-foundation.org
https://lists.linux-foundation.org/mailman/listinfo/virtualization
Re: [PATCH 3/3] VIDEO: xen-fb, switch to for_each_console
On 11/03/2010 11:28 AM, Jiri Slaby wrote:
Use newly added for_each_console for iterating consoles.
Signed-off-by: Jiri Slaby jsl...@suse.cz
Cc: Jeremy Fitzhardinge jer...@xensource.com
Sure, if that's what all the kids are doing these days.
Acked-by: Jeremy Fitzhardinge jeremy.fitzhardi...@citrix.com
J
Cc: Chris Wright chr...@sous-sol.org
Cc: virtualizat...@lists.osdl.org
Cc: xen-de...@lists.xensource.com
Cc: linux-fb...@vger.kernel.org
---
drivers/video/xen-fbfront.c |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/video/xen-fbfront.c b/drivers/video/xen-fbfront.c
index 428d273..4abb0b9 100644
--- a/drivers/video/xen-fbfront.c
+++ b/drivers/video/xen-fbfront.c
@@ -492,7 +492,7 @@ xenfb_make_preferred_console(void)
return;
acquire_console_sem();
- for (c = console_drivers; c; c = c-next) {
+ for_each_console(c) {
if (!strcmp(c-name, tty) c-index == 0)
break;
}
___
Virtualization mailing list
Virtualization@lists.linux-foundation.org
https://lists.linux-foundation.org/mailman/listinfo/virtualization
[PATCH 00/49] Use vzalloc not vmalloc/kmemset
Converted vmalloc/memset and vmalloc_node/memset to vzalloc or vzalloc_node using a cocci script and some editing Reduces text a little bit. Compiled x86 only. There are still vmalloc_32 with memset calls still around. Broken out to multiple patches to cc appropriate maintainers. Joe Perches (49): arch/ia64: Use vzalloc arch/mips: Use vzalloc arch/powerpc: Use vzalloc arch/s390: Use vzalloc arch/x86: Use vzalloc crypto: Use vzalloc drivers/atm: Use vzalloc drivers/block: Use vzalloc drivers/char: Use vzalloc drivers/gpu: Use vzalloc drivers/hid: Use vzalloc drivers/infiniband: Use vzalloc drivers/isdn: Use vzalloc drivers/md: Use vzalloc drivers/media: Use vzalloc drivers/mtd: Use vzalloc drivers/net/cxgb3: Use vzalloc drivers/net/cxgb4: Use vzalloc drivers/net/e1000: Use vzalloc drivers/net/e1000e: Use vzalloc drivers/net/ehea: Use vzalloc drivers/net/igb: Use vzalloc drivers/net/igbvf: Use vzalloc drivers/net/ixgb: Use vzalloc drivers/net/ixgbe: Use vzalloc drivers/net/ixgbevf: Use vzalloc drivers/net/netxen: Use vzalloc drivers/net/pch_gbe: Use vzalloc drivers/net/qlcnic: Use vzalloc drivers/net/sfc: Use vzalloc drivers/net/vxge: Use vzalloc drivers/net/bnx2.c: Use vzalloc drivers/s390: Use vzalloc drivers/scsi: Use vzalloc drivers/staging: Use vzalloc drivers/video: Use vzalloc fs/ext4: Use vzalloc fs/jffs2: Use vzalloc fs/reiserfs: Use vzalloc fs/udf: Use vzalloc fs/xfs: Use vzalloc include/linux/coda_linux.h: Use vzalloc kernel: Use vzalloc mm: Use vzalloc net/core/pktgen.c: Use vzalloc net/netfilter: Use vzalloc net/rds: Use vzalloc sound/oss/dev_table.c: Use vzalloc virt/kvm/kvm_main.c: Use vzalloc arch/ia64/kernel/perfmon.c |3 +- arch/mips/sibyte/common/sb_tbprof.c |3 +- arch/powerpc/kvm/book3s.c |6 +-- arch/powerpc/platforms/cell/spufs/lscsa_alloc.c |3 +- arch/s390/hypfs/hypfs_diag.c|3 +- arch/x86/kernel/microcode_amd.c |3 +- arch/x86/kvm/x86.c |3 +- arch/x86/mm/pageattr-test.c |3 +- crypto/deflate.c|3 +- crypto/zlib.c |3 +- drivers/atm/idt77252.c | 11 --- drivers/atm/lanai.c |3 +- drivers/block/drbd/drbd_bitmap.c|5 +-- drivers/char/agp/backend.c |3 +- drivers/char/mspec.c|5 +-- drivers/gpu/drm/via/via_dmablit.c |4 +- drivers/hid/hid-core.c |3 +- drivers/infiniband/hw/amso1100/c2_rnic.c|5 +-- drivers/infiniband/hw/ehca/ipz_pt_fn.c |5 +-- drivers/infiniband/hw/ipath/ipath_driver.c |3 +- drivers/infiniband/hw/ipath/ipath_file_ops.c| 11 ++- drivers/infiniband/hw/ipath/ipath_init_chip.c |5 +-- drivers/infiniband/hw/qib/qib_init.c|7 +--- drivers/infiniband/ulp/ipoib/ipoib_cm.c | 10 ++ drivers/infiniband/ulp/ipoib/ipoib_main.c |3 +- drivers/isdn/i4l/isdn_common.c |4 +- drivers/isdn/mISDN/dsp_core.c |3 +- drivers/isdn/mISDN/l1oip_codec.c|6 +-- drivers/md/dm-log.c |3 +- drivers/md/dm-snap-persistent.c |3 +- drivers/md/dm-table.c |4 +-- drivers/media/dvb/ngene/ngene-core.c|3 +- drivers/media/video/mx3_camera.c|3 +- drivers/media/video/pwc/pwc-if.c|3 +- drivers/media/video/videobuf-dma-sg.c |3 +- drivers/mtd/nand/nandsim.c |3 +- drivers/mtd/ubi/vtbl.c |6 +-- drivers/net/bnx2.c | 10 +- drivers/net/cxgb3/cxgb3_offload.c |7 ++-- drivers/net/cxgb4/cxgb4_main.c |7 ++-- drivers/net/e1000/e1000_main.c |6 +-- drivers/net/e1000e/netdev.c |6 +-- drivers/net/ehea/ehea_main.c|4 +-- drivers/net/igb/igb_main.c |6 +-- drivers/net/igbvf/netdev.c |6 +-- drivers/net/ixgb/ixgb_main.c|6 +-- drivers/net/ixgbe/ixgbe_main.c | 10 ++ drivers/net/ixgbevf/ixgbevf_main.c |6 +-- drivers/net/netxen/netxen_nic_init.c|7 +--- drivers/net/pch_gbe/pch_gbe_main.c |6 +-- drivers/net/qlcnic/qlcnic_init.c|7 +--- drivers/net/sfc/filter.c|3 +- drivers/net/vxge/vxge-config.c | 37 +- drivers/s390/cio/blacklist.c|3 +-
[PATCH 36/49] drivers/video: Use vzalloc
Signed-off-by: Joe Perches j...@perches.com --- drivers/video/arcfb.c|5 ++--- drivers/video/broadsheetfb.c |4 +--- drivers/video/hecubafb.c |5 ++--- drivers/video/metronomefb.c |4 +--- drivers/video/xen-fbfront.c |3 +-- 5 files changed, 7 insertions(+), 14 deletions(-) diff --git a/drivers/video/arcfb.c b/drivers/video/arcfb.c index 3ec4923..86573e2 100644 --- a/drivers/video/arcfb.c +++ b/drivers/video/arcfb.c @@ -515,11 +515,10 @@ static int __devinit arcfb_probe(struct platform_device *dev) /* We need a flat backing store for the Arc's less-flat actual paged framebuffer */ - if (!(videomemory = vmalloc(videomemorysize))) + videomemory = vmalloc(videomemorysize); + if (!videomemory) return retval; - memset(videomemory, 0, videomemorysize); - info = framebuffer_alloc(sizeof(struct arcfb_par), dev-dev); if (!info) goto err; diff --git a/drivers/video/broadsheetfb.c b/drivers/video/broadsheetfb.c index ebda687..377dde3 100644 --- a/drivers/video/broadsheetfb.c +++ b/drivers/video/broadsheetfb.c @@ -1101,12 +1101,10 @@ static int __devinit broadsheetfb_probe(struct platform_device *dev) videomemorysize = roundup((dpyw*dpyh), PAGE_SIZE); - videomemory = vmalloc(videomemorysize); + videomemory = vzalloc(videomemorysize); if (!videomemory) goto err_fb_rel; - memset(videomemory, 0, videomemorysize); - info-screen_base = (char *)videomemory; info-fbops = broadsheetfb_ops; diff --git a/drivers/video/hecubafb.c b/drivers/video/hecubafb.c index c77bcc6..a941e6f 100644 --- a/drivers/video/hecubafb.c +++ b/drivers/video/hecubafb.c @@ -231,11 +231,10 @@ static int __devinit hecubafb_probe(struct platform_device *dev) videomemorysize = (DPY_W*DPY_H)/8; - if (!(videomemory = vmalloc(videomemorysize))) + videomemory = vzalloc(videomemorysize); + if (!videomemory) return retval; - memset(videomemory, 0, videomemorysize); - info = framebuffer_alloc(sizeof(struct hecubafb_par), dev-dev); if (!info) goto err_fballoc; diff --git a/drivers/video/metronomefb.c b/drivers/video/metronomefb.c index 63ed3b7..c0c358c 100644 --- a/drivers/video/metronomefb.c +++ b/drivers/video/metronomefb.c @@ -628,12 +628,10 @@ static int __devinit metronomefb_probe(struct platform_device *dev) /* we need to add a spare page because our csum caching scheme walks * to the end of the page */ videomemorysize = PAGE_SIZE + (fw * fh); - videomemory = vmalloc(videomemorysize); + videomemory = vzalloc(videomemorysize); if (!videomemory) goto err_fb_rel; - memset(videomemory, 0, videomemorysize); - info-screen_base = (char __force __iomem *)videomemory; info-fbops = metronomefb_ops; diff --git a/drivers/video/xen-fbfront.c b/drivers/video/xen-fbfront.c index 428d273..81fcaea 100644 --- a/drivers/video/xen-fbfront.c +++ b/drivers/video/xen-fbfront.c @@ -395,10 +395,9 @@ static int __devinit xenfb_probe(struct xenbus_device *dev, spin_lock_init(info-dirty_lock); spin_lock_init(info-resize_lock); - info-fb = vmalloc(fb_size); + info-fb = vzalloc(fb_size); if (info-fb == NULL) goto error_nomem; - memset(info-fb, 0, fb_size); info-nr_pages = (fb_size + PAGE_SIZE - 1) PAGE_SHIFT; -- 1.7.3.1.g432b3.dirty ___ Virtualization mailing list Virtualization@lists.linux-foundation.org https://lists.linux-foundation.org/mailman/listinfo/virtualization
[PATCH V2 36/49] drivers/video: Use vzalloc
Signed-off-by: Joe Perches j...@perches.com --- V2 - Fixed vmalloc/vzalloc typo Thanks to Dave Young for noticing. drivers/video/arcfb.c|5 ++--- drivers/video/broadsheetfb.c |4 +--- drivers/video/hecubafb.c |5 ++--- drivers/video/metronomefb.c |4 +--- drivers/video/xen-fbfront.c |3 +-- 5 files changed, 7 insertions(+), 14 deletions(-) diff --git a/drivers/video/arcfb.c b/drivers/video/arcfb.c index 3ec4923..86573e2 100644 --- a/drivers/video/arcfb.c +++ b/drivers/video/arcfb.c @@ -515,11 +515,10 @@ static int __devinit arcfb_probe(struct platform_device *dev) /* We need a flat backing store for the Arc's less-flat actual paged framebuffer */ - if (!(videomemory = vmalloc(videomemorysize))) + videomemory = vzalloc(videomemorysize); + if (!videomemory) return retval; - memset(videomemory, 0, videomemorysize); - info = framebuffer_alloc(sizeof(struct arcfb_par), dev-dev); if (!info) goto err; diff --git a/drivers/video/broadsheetfb.c b/drivers/video/broadsheetfb.c index ebda687..377dde3 100644 --- a/drivers/video/broadsheetfb.c +++ b/drivers/video/broadsheetfb.c @@ -1101,12 +1101,10 @@ static int __devinit broadsheetfb_probe(struct platform_device *dev) videomemorysize = roundup((dpyw*dpyh), PAGE_SIZE); - videomemory = vmalloc(videomemorysize); + videomemory = vzalloc(videomemorysize); if (!videomemory) goto err_fb_rel; - memset(videomemory, 0, videomemorysize); - info-screen_base = (char *)videomemory; info-fbops = broadsheetfb_ops; diff --git a/drivers/video/hecubafb.c b/drivers/video/hecubafb.c index c77bcc6..a941e6f 100644 --- a/drivers/video/hecubafb.c +++ b/drivers/video/hecubafb.c @@ -231,11 +231,10 @@ static int __devinit hecubafb_probe(struct platform_device *dev) videomemorysize = (DPY_W*DPY_H)/8; - if (!(videomemory = vmalloc(videomemorysize))) + videomemory = vzalloc(videomemorysize); + if (!videomemory) return retval; - memset(videomemory, 0, videomemorysize); - info = framebuffer_alloc(sizeof(struct hecubafb_par), dev-dev); if (!info) goto err_fballoc; diff --git a/drivers/video/metronomefb.c b/drivers/video/metronomefb.c index 63ed3b7..c0c358c 100644 --- a/drivers/video/metronomefb.c +++ b/drivers/video/metronomefb.c @@ -628,12 +628,10 @@ static int __devinit metronomefb_probe(struct platform_device *dev) /* we need to add a spare page because our csum caching scheme walks * to the end of the page */ videomemorysize = PAGE_SIZE + (fw * fh); - videomemory = vmalloc(videomemorysize); + videomemory = vzalloc(videomemorysize); if (!videomemory) goto err_fb_rel; - memset(videomemory, 0, videomemorysize); - info-screen_base = (char __force __iomem *)videomemory; info-fbops = metronomefb_ops; diff --git a/drivers/video/xen-fbfront.c b/drivers/video/xen-fbfront.c index 428d273..81fcaea 100644 --- a/drivers/video/xen-fbfront.c +++ b/drivers/video/xen-fbfront.c @@ -395,10 +395,9 @@ static int __devinit xenfb_probe(struct xenbus_device *dev, spin_lock_init(info-dirty_lock); spin_lock_init(info-resize_lock); - info-fb = vmalloc(fb_size); + info-fb = vzalloc(fb_size); if (info-fb == NULL) goto error_nomem; - memset(info-fb, 0, fb_size); info-nr_pages = (fb_size + PAGE_SIZE - 1) PAGE_SHIFT; -- 1.7.3.1.g432b3.dirty ___ Virtualization mailing list Virtualization@lists.linux-foundation.org https://lists.linux-foundation.org/mailman/listinfo/virtualization
Re: [PATCH 36/49] drivers/video: Use vzalloc
On Fri, 2010-11-05 at 13:27 +0800, Dave Young wrote: On Fri, Nov 5, 2010 at 11:08 AM, Joe Perches j...@perches.com wrote: diff --git a/drivers/video/arcfb.c b/drivers/video/arcfb.c @@ -515,11 +515,10 @@ static int __devinit arcfb_probe(struct platform_device *dev) /* We need a flat backing store for the Arc's less-flat actual paged framebuffer */ - if (!(videomemory = vmalloc(videomemorysize))) + videomemory = vmalloc(videomemorysize); typo? Yes. Thanks for catching that. ___ Virtualization mailing list Virtualization@lists.linux-foundation.org https://lists.linux-foundation.org/mailman/listinfo/virtualization
