Re: [rfc net-next v6 2/3] virtio_net: multiqueue support
On Tue, 2012-11-13 at 08:40 +0200, Michael S. Tsirkin wrote:
> On Mon, Nov 05, 2012 at 11:38:39AM +1030, Rusty Russell wrote:
> > > @@ -924,11 +1032,10 @@ static void virtnet_get_ringparam(struct
> > > net_device *dev,
> > > {
> > > struct virtnet_info *vi = netdev_priv(dev);
> > >
> > > - ring->rx_max_pending = virtqueue_get_vring_size(vi->rvq);
> > > - ring->tx_max_pending = virtqueue_get_vring_size(vi->svq);
> > > + ring->rx_max_pending = virtqueue_get_vring_size(vi->rq[0].vq);
> > > + ring->tx_max_pending = virtqueue_get_vring_size(vi->sq[0].vq);
> > > ring->rx_pending = ring->rx_max_pending;
> > > ring->tx_pending = ring->tx_max_pending;
> > > -
> > > }
> >
> > This assumes all vqs are the same size. I think this should probably
> > check: for mq mode, use the first vq, otherewise use the 0th.
>
> For rx_pending/tx_pending I think what is required here is the
> actual number of outstanding buffers.
> Dave, Eric - right?
>
> So this should be the total over all rings and to be useful,
> rx_max_pending/tx_max_pending should be the total too.
So far as I know, all current implementations use the number of
descriptors per ring here. virtio_net should be consistent with this.
Ben.
> > For bonus points, check this assertion at probe time.
>
> Looks like we can easily support different queues too.
>
--
Ben Hutchings, Staff Engineer, Solarflare
Not speaking for my employer; that's the marketing department's job.
They asked us to note that Solarflare product names are trademarked.
___
Virtualization mailing list
Virtualization@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/virtualization
Re: [PATCH v4] x86/xen: Use __pa_symbol instead of __pa on C visible symbols
On Fri, Nov 16, 2012 at 01:45:25PM -0800, Alexander Duyck wrote:
> This change updates a few of the functions to use __pa_symbol when
> translating C visible symbols instead of __pa. By using __pa_symbol we are
> able to drop a few extra lines of code as don't have to test to see if the
> virtual pointer is a part of the kernel text or just standard virtual memory.
>
> Cc: Konrad Rzeszutek Wilk
> Signed-off-by: Alexander Duyck
> ---
>
> v4: I have spun this patch off as a separate patch for v4 due to the fact
> that
> this patch doesn't apply cleanly to Linus's tree. As such I am
> submitting it based off of the linux-next tree to be accepted in the Xen
> tree since this patch can actually exist on its own without the need
> for the other patches in the original __phys_addr performance series.
OK, let me stick it in my tree then.
>
> arch/x86/xen/mmu.c | 21 +++--
> 1 files changed, 11 insertions(+), 10 deletions(-)
>
> diff --git a/arch/x86/xen/mmu.c b/arch/x86/xen/mmu.c
> index 4a05b39..a63e5f9 100644
> --- a/arch/x86/xen/mmu.c
> +++ b/arch/x86/xen/mmu.c
> @@ -1486,7 +1486,8 @@ static int xen_pgd_alloc(struct mm_struct *mm)
>
> if (user_pgd != NULL) {
> user_pgd[pgd_index(VSYSCALL_START)] =
> - __pgd(__pa(level3_user_vsyscall) | _PAGE_TABLE);
> + __pgd(__pa_symbol(level3_user_vsyscall) |
> + _PAGE_TABLE);
> ret = 0;
> }
>
> @@ -1958,10 +1959,10 @@ void __init xen_setup_kernel_pagetable(pgd_t *pgd,
> unsigned long max_pfn)
>* pgd.
>*/
> if (xen_feature(XENFEAT_writable_page_tables)) {
> - native_write_cr3(__pa(init_level4_pgt));
> + native_write_cr3(__pa_symbol(init_level4_pgt));
> } else {
> xen_mc_batch();
> - __xen_write_cr3(true, __pa(init_level4_pgt));
> + __xen_write_cr3(true, __pa_symbol(init_level4_pgt));
> xen_mc_issue(PARAVIRT_LAZY_CPU);
> }
> /* We can't that easily rip out L3 and L2, as the Xen pagetables are
> @@ -1984,10 +1985,10 @@ static RESERVE_BRK_ARRAY(pmd_t, swapper_kernel_pmd,
> PTRS_PER_PMD);
>
> static void __init xen_write_cr3_init(unsigned long cr3)
> {
> - unsigned long pfn = PFN_DOWN(__pa(swapper_pg_dir));
> + unsigned long pfn = PFN_DOWN(__pa_symbol(swapper_pg_dir));
>
> - BUG_ON(read_cr3() != __pa(initial_page_table));
> - BUG_ON(cr3 != __pa(swapper_pg_dir));
> + BUG_ON(read_cr3() != __pa_symbol(initial_page_table));
> + BUG_ON(cr3 != __pa_symbol(swapper_pg_dir));
>
> /*
>* We are switching to swapper_pg_dir for the first time (from
> @@ -2011,7 +2012,7 @@ static void __init xen_write_cr3_init(unsigned long cr3)
> pin_pagetable_pfn(MMUEXT_PIN_L3_TABLE, pfn);
>
> pin_pagetable_pfn(MMUEXT_UNPIN_TABLE,
> - PFN_DOWN(__pa(initial_page_table)));
> + PFN_DOWN(__pa_symbol(initial_page_table)));
> set_page_prot(initial_page_table, PAGE_KERNEL);
> set_page_prot(initial_kernel_pmd, PAGE_KERNEL);
>
> @@ -2036,7 +2037,7 @@ void __init xen_setup_kernel_pagetable(pgd_t *pgd,
> unsigned long max_pfn)
>
> copy_page(initial_page_table, pgd);
> initial_page_table[KERNEL_PGD_BOUNDARY] =
> - __pgd(__pa(initial_kernel_pmd) | _PAGE_PRESENT);
> + __pgd(__pa_symbol(initial_kernel_pmd) | _PAGE_PRESENT);
>
> set_page_prot(initial_kernel_pmd, PAGE_KERNEL_RO);
> set_page_prot(initial_page_table, PAGE_KERNEL_RO);
> @@ -2045,8 +2046,8 @@ void __init xen_setup_kernel_pagetable(pgd_t *pgd,
> unsigned long max_pfn)
> pin_pagetable_pfn(MMUEXT_UNPIN_TABLE, PFN_DOWN(__pa(pgd)));
>
> pin_pagetable_pfn(MMUEXT_PIN_L3_TABLE,
> - PFN_DOWN(__pa(initial_page_table)));
> - xen_write_cr3(__pa(initial_page_table));
> + PFN_DOWN(__pa_symbol(initial_page_table)));
> + xen_write_cr3(__pa_symbol(initial_page_table));
>
> memblock_reserve(__pa(xen_start_info->pt_base),
>xen_start_info->nr_pt_frames * PAGE_SIZE);
___
Virtualization mailing list
Virtualization@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/virtualization
Virtualization DevRoom at FOSDEM 2013
Following on the heels of a successful KVM Forum and oVirt Workshop, FOSDEM will be hosting a Virtualization DevRoom in February. If you've been to FOSDEM before, you know this is about developers and code, not products. Presentation proposals are due by December 16th 2012. The full details are here: http://osvc.v2.cs.unibo.it/index.php/Main_Page With the relevant topics being: "Topics covered will include, but not limited to: - machine virtualization (e.g. KVM, Xen, VirtualBox,...) - network virtualization (e.g. openvstack, vale, vde, Open vSwitch,...) - process level virtualization, flexible kernels (e.g. rump anykernel, view-os, ...) - virt management (e.g. ganeti, libvirt, ovirt, XCP, ...)" thanks, -chris ___ Virtualization mailing list Virtualization@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/virtualization
[PATCH 09/14] xen: events: Remove redundant check on unsigned variable
No need to check whether unsigned variable is less than 0.
CC: Konrad Rzeszutek Wilk
CC: Jeremy Fitzhardinge
CC: xen-de...@lists.xensource.com
CC: virtualization@lists.linux-foundation.org
Signed-off-by: Tushar Behera
---
drivers/xen/events.c |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/xen/events.c b/drivers/xen/events.c
index 4293c57..cadd7d1 100644
--- a/drivers/xen/events.c
+++ b/drivers/xen/events.c
@@ -216,7 +216,7 @@ static void xen_irq_info_pirq_init(unsigned irq,
*/
static unsigned int evtchn_from_irq(unsigned irq)
{
- if (unlikely(WARN(irq < 0 || irq >= nr_irqs, "Invalid irq %d!\n", irq)))
+ if (unlikely(WARN(irq >= nr_irqs, "Invalid irq %d!\n", irq)))
return 0;
return info_for_irq(irq)->evtchn;
--
1.7.4.1
___
Virtualization mailing list
Virtualization@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/virtualization
[PATCH 00/14] Modify signed comparisons of unsigned variables
The occurrences were identified through the coccinelle script at following location. http://www.emn.fr/z-info/coccinelle/rules/find_unsigned.cocci Signed checks for unsigned variables are removed if it is also checked for upper error limit. For error checks, IS_ERR_VALUE() macros is used. Tushar Behera (14): [media] ivtv: Remove redundant check on unsigned variable [media] meye: Remove redundant check on unsigned variable [media] saa7134: Remove redundant check on unsigned variable [media] tlg2300: Remove redundant check on unsigned variable [media] atmel-isi: Update error check for unsigned variables pinctrl: samsung: Update error check for unsigned variables pinctrl: SPEAr: Update error check for unsigned variables xen: netback: Remove redundant check on unsigned variable xen: events: Remove redundant check on unsigned variable atm: Removed redundant check on unsigned variable HID: hiddev: Remove redundant check on unsigned variable gru: Remove redundant check on unsigned variable misc: tsl2550: Remove redundant check on unsigned variable wlcore: Remove redundant check on unsigned variable drivers/atm/fore200e.c|2 +- drivers/hid/usbhid/hiddev.c |2 +- drivers/media/pci/ivtv/ivtv-ioctl.c |2 +- drivers/media/pci/meye/meye.c |2 +- drivers/media/pci/saa7134/saa7134-video.c |2 +- drivers/media/platform/soc_camera/atmel-isi.c |2 +- drivers/media/usb/tlg2300/pd-video.c |2 +- drivers/misc/sgi-gru/grukdump.c |2 +- drivers/misc/tsl2550.c|4 ++-- drivers/net/wireless/ti/wlcore/debugfs.c |2 +- drivers/net/xen-netback/netback.c |4 ++-- drivers/pinctrl/pinctrl-samsung.c |2 +- drivers/pinctrl/spear/pinctrl-plgpio.c|2 +- drivers/xen/events.c |2 +- 14 files changed, 16 insertions(+), 16 deletions(-) -- 1.7.4.1 CC: Mauro Carvalho Chehab CC: Linus Walleij CC: Ian Campbell CC: Konrad Rzeszutek Wilk CC: Jeremy Fitzhardinge CC: Chas Williams CC: Jack Steiner CC: Arnd Bergmann CC: Luciano Coelho CC: Jiri Kosina CC: ivtv-de...@ivtvdriver.org CC: linux-me...@vger.kernel.org CC: xen-de...@lists.xensource.com CC: net...@vger.kernel.org CC: virtualization@lists.linux-foundation.org CC: linux-atm-gene...@lists.sourceforge.net CC: linux-...@vger.kernel.org CC: linux-in...@vger.kernel.org CC: linux-wirel...@vger.kernel.org ___ Virtualization mailing list Virtualization@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/virtualization
Best papers published in JCR/ISI JOURNALS - Deadline: November 25
Apologies if you are receiving this mail more than once... Please disseminate by colleagues, researchers, students, etc. Thanks a lot! ** WorldCIST'13 The 2013 World Conference on Information Systems and Technologies March 27 - 30, Algarve, Portugal http://www.aisti.eu/worldcist13/ ** SCOPE The 2013 World Conference on Information Systems and Technologies (WorldCIST'13: http://www.aisti.eu/worldcist13/) is a global forum for researchers and practitioners to present and discuss the most recent innovations, trends, results, experiences and concerns in the several perspectives of Information Systems and Technologies. We are pleased to invite you to submit your papers to WorldCISTI'13. All submissions will be reviewed on the basis of relevance, originality, importance and clarity. THEMES Submitted papers should be related with one or more of the main themes proposed for the Conference: A) Information and Knowledge Management (IKM); B) Organizational Models and Information Systems (OMIS); C) Intelligent and Decision Support Systems (IDSS); D) Software Systems, Architectures, Applications and Tools (SSAAT); E) Computer Networks, Mobility and Pervasive Systems (CNMPS); F) Human-Computer Interaction (HCI). TYPES OF SUBMISSIONS AND DECISIONS Four types of papers can be submitted: Full paper: Finished or consolidated R&D works, to be included in one of the Conference themes. These papers are assigned a 10-page limit. Short paper: Ongoing works with relevant preliminary results, open to discussion. These papers are assigned a 7-page limit. Poster paper: Initial work with relevant ideas, open to discussion. These papers are assigned to a 4-page limit. Company paper: Companies' papers that show practical experience, R & D, tools, etc., focused on some topics of the conference. These papers are assigned to a 4-page limit. Submitted papers must comply with the format of Advances in Intelligent Systems and Computing Series (see http://www.aisti.eu/worldcist13/springerformat.doc) be written in English, must not have been published before, not be under review for any other conference or publication and not include any information leading to the authors identification. Therefore, the authors names, affiliations and bibliographic references should not be included in the version for evaluation by the Program Committee. This information should only be included in the camera-ready version. All papers will be subjected to a double-blind review by at least two members of the Program Committee. Based on Program Committee evaluation, a paper can be rejected or accepted by the Conference Chairs. In the later case, it can be accepted as the type originally submitted or as another type. Thus, full papers can be accepted as short papers or poster papers only. Similarly, short papers can be accepted as poster papers only. In these cases, the authors will be allowed to maintain the original number of pages in the camera-ready version. The authors of accepted poster papers must also build and print a poster to be exhibited during the Conference. This poster must follow an A1 or A2 vertical format. The Conference includes Work Sessions where these posters are presented and orally discussed, with a 5 minute limit per poster. The authors of accepted full papers will have 15 minutes to present their work in a Conference Work Session; approximately 5 minutes of discussion will follow each presentation. The authors of accepted short papers and company papers will have 11 minutes to present their work in a Conference Work Session; approximately 4 minutes of discussion will follow each presentation. PUBLICATION AND INDEXING To ensure that a full paper, short paper, poster paper or company paper is published in the Proceedings, at least one of the authors must be fully registered by the 11th of January 2013, and the paper must comply with the suggested layout and page-limit. Additionally, all recommended changes must be addressed by the authors before they submit the camera-ready version. No more than one paper per registration will be published in the Conference Proceedings. An extra fee must be paid for publication of additional papers, with a maximum of two additional papers per registration. Full and short papers will be published in Proceedings by Springer, in Advances in Intelligent Systems and Computing Series. Poster and company papers will be published in Proceedings by AISTI. Published full and short papers will be indexed by ISI, EI-Compendex, SCOPUS, DBLP and EBSCO, among others, and will be available in the SpringerLink Digital Library. Published poster and company papers will be indexed in EI-Compendex and EBSCO. The authors of the b
Re: [PATCH 09/14] xen: events: Remove redundant check on unsigned variable
To be honest I'd nack this kind of patch. The test is only redundant in the
most trivial sense that the compiler can easily optimise away. The point of the
test is to make sure that the range is OK even if the type subsequently becomes
signed (to hold a -ve error, for example).
J
Konrad Rzeszutek Wilk wrote:
>On Fri, Nov 16, 2012 at 12:20:41PM +0530, Tushar Behera wrote:
>> No need to check whether unsigned variable is less than 0.
>>
>> CC: Konrad Rzeszutek Wilk
>
>Acked-by: Konrad Rzeszutek Wilk
>
>> CC: Jeremy Fitzhardinge
>> CC: xen-de...@lists.xensource.com
>> CC: virtualization@lists.linux-foundation.org
>> Signed-off-by: Tushar Behera
>> ---
>> drivers/xen/events.c |2 +-
>> 1 files changed, 1 insertions(+), 1 deletions(-)
>>
>> diff --git a/drivers/xen/events.c b/drivers/xen/events.c
>> index 4293c57..cadd7d1 100644
>> --- a/drivers/xen/events.c
>> +++ b/drivers/xen/events.c
>> @@ -216,7 +216,7 @@ static void xen_irq_info_pirq_init(unsigned irq,
>> */
>> static unsigned int evtchn_from_irq(unsigned irq)
>> {
>> -if (unlikely(WARN(irq < 0 || irq >= nr_irqs, "Invalid irq %d!\n",
>irq)))
>> +if (unlikely(WARN(irq >= nr_irqs, "Invalid irq %d!\n", irq)))
>> return 0;
>>
>> return info_for_irq(irq)->evtchn;
>> --
>> 1.7.4.1
--
Sent from my Android phone with K-9 Mail. Please excuse my brevity.___
Virtualization mailing list
Virtualization@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/virtualization
Re: [PATCH 09/14] xen: events: Remove redundant check on unsigned variable
On Fri, Nov 16, 2012 at 12:20:41PM +0530, Tushar Behera wrote:
> No need to check whether unsigned variable is less than 0.
>
> CC: Konrad Rzeszutek Wilk
Acked-by: Konrad Rzeszutek Wilk
> CC: Jeremy Fitzhardinge
> CC: xen-de...@lists.xensource.com
> CC: virtualization@lists.linux-foundation.org
> Signed-off-by: Tushar Behera
> ---
> drivers/xen/events.c |2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/xen/events.c b/drivers/xen/events.c
> index 4293c57..cadd7d1 100644
> --- a/drivers/xen/events.c
> +++ b/drivers/xen/events.c
> @@ -216,7 +216,7 @@ static void xen_irq_info_pirq_init(unsigned irq,
> */
> static unsigned int evtchn_from_irq(unsigned irq)
> {
> - if (unlikely(WARN(irq < 0 || irq >= nr_irqs, "Invalid irq %d!\n", irq)))
> + if (unlikely(WARN(irq >= nr_irqs, "Invalid irq %d!\n", irq)))
> return 0;
>
> return info_for_irq(irq)->evtchn;
> --
> 1.7.4.1
___
Virtualization mailing list
Virtualization@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/virtualization
