Re: [PATCH V7 0/5] virtio-scsi multiqueue
On 03/28/2013 10:22 AM, Wanlong Gao wrote: > On 03/23/2013 07:28 PM, Wanlong Gao wrote: >> This series implements virtio-scsi queue steering, which gives >> performance improvements of up to 50% (measured both with QEMU and >> tcm_vhost backends). >> >> This version rebased on Rusty's virtio ring rework patches, which >> has already gone into virtio-next today. >> We hope this can go into virtio-next together with the virtio ring >> rework pathes. >> >> V7: respin to fix the patch apply error >> >> V6: rework "redo allocation of target data" (James) >> fix comments (Venkatesh) >> rebase to virtio-next >> >> V5: improving the grammar of 1/5 (Paolo) >> move the dropping of sg_elems to 'virtio-scsi: use virtqueue_add_sgs for >> command buffers'. (Asias) >> >> V4: rebase on virtio ring rework patches (rusty's pending-rebases branch) >> >> V3 and be found >> http://marc.info/?l=linux-virtualization&m=136067440717154&w=2 >> >> >> It would probably be easier to get it in via Rusty's tree >> because of the prerequisites. James, can we get your Acked-by? > > James, any thoughts for this version? Ping James > > Thanks, > Wanlong Gao > >> >> Paolo Bonzini (3): >> virtio-scsi: pass struct virtio_scsi to virtqueue completion function >> virtio-scsi: push vq lock/unlock into virtscsi_vq_done >> virtio-scsi: introduce multiqueue support >> >> Wanlong Gao (2): >> virtio-scsi: redo allocation of target data >> virtio-scsi: reset virtqueue affinity when doing cpu hotplug >> >> drivers/scsi/virtio_scsi.c | 387 >> - >> 1 file changed, 309 insertions(+), 78 deletions(-) >> > > ___ Virtualization mailing list Virtualization@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/virtualization
Re: [PATCH 4/7] virtio_config: make transports implement accessors.
On Fri, 2013-04-05 at 04:37 +0100, Rusty Russell wrote:
> diff --git a/drivers/virtio/virtio_mmio.c b/drivers/virtio/virtio_mmio.c
> index 1ba0d68..4c2c6be 100644
> --- a/drivers/virtio/virtio_mmio.c
> +++ b/drivers/virtio/virtio_mmio.c
> @@ -167,26 +167,18 @@ static void vm_finalize_features(struct virtio_device
> *vdev)
> }
> }
>
> -static void vm_get(struct virtio_device *vdev, unsigned offset,
> - void *buf, unsigned len)
> +static u8 vm_get8(struct virtio_device *vdev, unsigned offset)
> {
> struct virtio_mmio_device *vm_dev = to_virtio_mmio_device(vdev);
> - u8 *ptr = buf;
> - int i;
>
> - for (i = 0; i < len; i++)
> - ptr[i] = readb(vm_dev->base + VIRTIO_MMIO_CONFIG + offset +
> i);
> + return readb(vm_dev->base + VIRTIO_MMIO_CONFIG + offset);
> }
>
> -static void vm_set(struct virtio_device *vdev, unsigned offset,
> - const void *buf, unsigned len)
> +static void vm_set8(struct virtio_device *vdev, unsigned offset, u8 v)
> {
> struct virtio_mmio_device *vm_dev = to_virtio_mmio_device(vdev);
> - const u8 *ptr = buf;
> - int i;
>
> - for (i = 0; i < len; i++)
> - writeb(ptr[i], vm_dev->base + VIRTIO_MMIO_CONFIG + offset +
> i);
> + writeb(v, vm_dev->base + VIRTIO_MMIO_CONFIG + offset);
> }
>
> static u8 vm_get_status(struct virtio_device *vdev)
> @@ -424,8 +416,9 @@ static const char *vm_bus_name(struct virtio_device *vdev)
> }
>
> static const struct virtio_config_ops virtio_mmio_config_ops = {
> - .get= vm_get,
> - .set= vm_set,
> + .get8 = vm_get8,
> + .set8 = vm_set8,
> + VIRTIO_CONFIG_OPS_NOCONV,
> .get_status = vm_get_status,
> .set_status = vm_set_status,
> .reset = vm_reset,
Acked-by: Pawel Moll
Thanks!
Pawel
___
Virtualization mailing list
Virtualization@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/virtualization
[PATCH -next] virtio_console: make local symbols static
From: Wei Yongjun
Those symbols only used within this file, and should be static.
Signed-off-by: Wei Yongjun
---
drivers/char/virtio_console.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/char/virtio_console.c b/drivers/char/virtio_console.c
index 13ad9b1..f73ad64 100644
--- a/drivers/char/virtio_console.c
+++ b/drivers/char/virtio_console.c
@@ -78,8 +78,8 @@ struct ports_driver_data {
};
static struct ports_driver_data pdrvdata;
-DEFINE_SPINLOCK(pdrvdata_lock);
-DECLARE_COMPLETION(early_console_added);
+static DEFINE_SPINLOCK(pdrvdata_lock);
+static DECLARE_COMPLETION(early_console_added);
/* This struct holds information that's relevant only for console ports */
struct console {
@@ -1202,7 +1202,7 @@ int __init virtio_cons_early_init(int (*put_chars)(u32,
const char *, int))
return hvc_instantiate(0, 0, &hv_ops);
}
-int init_port_console(struct port *port)
+static int init_port_console(struct port *port)
{
int ret;
___
Virtualization mailing list
Virtualization@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/virtualization
Re: [PATCH 6/7] virtio: add support for 64 bit features.
Ohad Ben-Cohen writes: > On Fri, Apr 5, 2013 at 6:37 AM, Rusty Russell wrote: >> @@ -220,6 +223,7 @@ static void rproc_virtio_finalize_features(struct >> virtio_device *vdev) >> * extension of the virtio resource entries. >> */ >> rvdev->gfeatures = vdev->features; >> + >> } > > Seems like an extra newline has sneaked in - we should probably leave it out. It did... eliminated. Thanks! Rusty. ___ Virtualization mailing list Virtualization@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/virtualization
