RE: [PATCH v3 [resend] 14/18] smp, x86, xen: kill SMP single function call interrupt

[Liu, Jinsong]

Konrad Rzeszutek Wilk wrote:
 On Mon, Dec 16, 2013 at 12:36:36AM +0800, Jiang Liu wrote:
 Commit 9a46ad6d6df3b54 smp: make smp_call_function_many() use logic
 similar to smp_call_function_single() has unified the way to handle
 single and multiple cross-CPU function calls. Now only one interrupt
 is needed for architecture specific code to support generic SMP
 function 
 call interfaces, so kill the redundant single function call
 interrupt. 
 
 Cc: Andrew Morton a...@linux-foundation.org
 Cc: Shaohua Li s...@kernel.org
 Cc: Peter Zijlstra a.p.zijls...@chello.nl
 Cc: Ingo Molnar mi...@elte.hu
 Cc: Steven Rostedt rost...@goodmis.org
 Cc: Jiri Kosina triv...@kernel.org
 Cc: Thomas Gleixner t...@linutronix.de
 Cc: H. Peter Anvin h...@zytor.com
 Cc: Konrad Rzeszutek Wilk konrad.w...@oracle.com
 
 I presume this has been tested?
 

I have just test Jiang's patch, it works fine for dom0 booting.

Thanks,
Jinsong


___
Virtualization mailing list
Virtualization@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/virtualization

RE: xen/acpi: ACPI memory hotplug

[Liu, Jinsong]

Dan Carpenter wrote:
 Hello Liu Jinsong,
 
 This is a semi-automatic email about new static checker warnings.
 
 The patch 259f201cb7ea: xen/acpi: ACPI memory hotplug from Jan 24,
 2013, leads to the following Smatch complaint:
 
 drivers/xen/xen-acpi-memhotplug.c:198 acpi_memory_get_device()
error: we previously assumed 'device' could be null (see line 171)
 
 drivers/xen/xen-acpi-memhotplug.c
170
171if (!acpi_bus_get_device(handle, device)  device)
  ^^
 New check.
 
 Btw, checking device is unnecessary.
 
   if (acpi_bus_get_device(handle, device) == 0)
   goto end;
 
 A successful Get Device means that device is non-NULL; that's
 built into the name.  Anyway, if acpi_bus_get_device() fails either
 something else will fail or we will Oops in the call to
 acpi_driver_data(). 
 
172goto end;
173
174status = acpi_get_parent(handle, phandle);
175if (ACPI_FAILURE(status)) {
176pr_warn(PREFIX Cannot find acpi parent\n);
177return -EINVAL;
178}
179
180/* Get the parent device */
181result = acpi_bus_get_device(phandle, pdevice);
182if (result) {
183pr_warn(PREFIX Cannot get acpi bus device\n);
184return -EINVAL;
185}
186
187/*
188 * Now add the notified device.  This creates the 
 acpi_device
189 * and invokes .add function
190 */
191result = acpi_bus_scan(handle);
192if (result) {
193pr_warn(PREFIX Cannot add acpi bus\n);
194return -EINVAL;
195}
196
197end:
198*mem_device = acpi_driver_data(device);
^^
 Dereference.
 
199if (!(*mem_device)) {
200pr_err(PREFIX Driver data not found\n);
 
 regards,
 dan carpenter

Thanks Dan, updated, will send out minutes later.

Regards,
Jinsong
___
Virtualization mailing list
Virtualization@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/virtualization