On Wed, Apr 10, 2013 at 11:23:08AM +0800, Asias He wrote:
Asias He (3):
tcm_vhost: Fix tv_cmd leak in vhost_scsi_handle_vq
tcm_vhost: Add vhost_scsi_send_bad_target() helper
tcm_vhost: Send bad target to guest when cmd fails
drivers/vhost/tcm_vhost.c | 44
1 file changed, 28 insertions(+), 16 deletions(-)
Forgot to send this out. This series is on top of this one.
From a0b5d53d057a34330c811f5cd4264182f392b374 Mon Sep 17 00:00:00 2001
From: Asias He as...@redhat.com
Date: Wed, 10 Apr 2013 10:39:43 +0800
Subject: [PATCH] tcm_vhost: Remove double check of response
We did the length of response check twice.
Signed-off-by: Asias He as...@redhat.com
---
drivers/vhost/tcm_vhost.c | 9 -
1 file changed, 9 deletions(-)
diff --git a/drivers/vhost/tcm_vhost.c b/drivers/vhost/tcm_vhost.c
index c127731..28c112f 100644
--- a/drivers/vhost/tcm_vhost.c
+++ b/drivers/vhost/tcm_vhost.c
@@ -705,15 +705,6 @@ static void vhost_scsi_handle_vq(struct vhost_scsi *vs,
tv_cmd-tvc_vhost = vs;
tv_cmd-tvc_vq = vq;
-
- if (unlikely(vq-iov[out].iov_len !=
- sizeof(struct virtio_scsi_cmd_resp))) {
- vq_err(vq, Expecting virtio_scsi_cmd_resp, got %zu
-bytes, out: %d, in: %d\n,
- vq-iov[out].iov_len, out, in);
- break;
- }
-
tv_cmd-tvc_resp = vq-iov[out].iov_base;
/*
--
1.8.1.4
--
Asias
___
Virtualization mailing list
Virtualization@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/virtualization
