Re: [PATCH 4/6] virtio_mmio: support non-legacy balloon devices

2015-03-31 Thread Michael S. Tsirkin 
On Tue, Mar 31, 2015 at 01:31:35PM +0100, Pawel Moll wrote:
> On Mon, 2015-03-30 at 18:37 +0100, Michael S. Tsirkin wrote:
> > virtio_device_is_legacy_only is always false now,
> > drop the test from virtio mmio.
> > 
> > Signed-off-by: Michael S. Tsirkin 
> 
> Slightly ironic ack ;-) after all the battle you fought for this:

In hindsight, the time might have been better spent working on this
patchset instead, that's true.

> Acked-by: Pawel Moll 
> 
> Thanks!
> 
> Pawel
___
Virtualization mailing list
Virtualization@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/virtualization

Re: [PATCH 4/6] virtio_mmio: support non-legacy balloon devices

2015-03-31 Thread Pawel Moll 
On Mon, 2015-03-30 at 18:37 +0100, Michael S. Tsirkin wrote:
> virtio_device_is_legacy_only is always false now,
> drop the test from virtio mmio.
> 
> Signed-off-by: Michael S. Tsirkin 

Slightly ironic ack ;-) after all the battle you fought for this:

Acked-by: Pawel Moll 

Thanks!

Pawel

___
Virtualization mailing list
Virtualization@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/virtualization

[PATCH 4/6] virtio_mmio: support non-legacy balloon devices

2015-03-30 Thread Michael S. Tsirkin 
virtio_device_is_legacy_only is always false now,
drop the test from virtio mmio.

Signed-off-by: Michael S. Tsirkin 
---
 drivers/virtio/virtio_mmio.c | 8 
 1 file changed, 8 deletions(-)

diff --git a/drivers/virtio/virtio_mmio.c b/drivers/virtio/virtio_mmio.c
index 6010d7e..7a5e60d 100644
--- a/drivers/virtio/virtio_mmio.c
+++ b/drivers/virtio/virtio_mmio.c
@@ -581,14 +581,6 @@ static int virtio_mmio_probe(struct platform_device *pdev)
}
vm_dev->vdev.id.vendor = readl(vm_dev->base + VIRTIO_MMIO_VENDOR_ID);
 
-   /* Reject legacy-only IDs for version 2 devices */
-   if (vm_dev->version == 2 &&
-   virtio_device_is_legacy_only(vm_dev->vdev.id)) {
-   dev_err(&pdev->dev, "Version 2 not supported for devices %u!\n",
-   vm_dev->vdev.id.device);
-   return -ENODEV;
-   }
-
if (vm_dev->version == 1)
writel(PAGE_SIZE, vm_dev->base + VIRTIO_MMIO_GUEST_PAGE_SIZE);
 
-- 
MST

___
Virtualization mailing list
Virtualization@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/virtualization