Re: [PATCH RFC 4/4] virtio_net: bigger header when VERSION_1 is set

2014-10-27 Thread Rusty Russell
Michael S. Tsirkin m...@redhat.com writes:
 With VERSION_1 virtio_net uses same header size
 whether mergeable buffers are enabled or not.

 Signed-off-by: Michael S. Tsirkin m...@redhat.com

These two are great too, thanks:

Acked-by: Rusty Russell ru...@rustcorp.com.au

Cheers,
Rusty.

 ---
  drivers/net/virtio_net.c | 3 ++-
  1 file changed, 2 insertions(+), 1 deletion(-)

 diff --git a/drivers/net/virtio_net.c b/drivers/net/virtio_net.c
 index 9c6d50f..a2fe340 100644
 --- a/drivers/net/virtio_net.c
 +++ b/drivers/net/virtio_net.c
 @@ -1764,7 +1764,8 @@ static int virtnet_probe(struct virtio_device *vdev)
   if (virtio_has_feature(vdev, VIRTIO_NET_F_MRG_RXBUF))
   vi-mergeable_rx_bufs = true;
  
 - if (virtio_has_feature(vdev, VIRTIO_NET_F_MRG_RXBUF))
 + if (virtio_has_feature(vdev, VIRTIO_NET_F_MRG_RXBUF) ||
 + virtio_has_feature(vdev, VIRTIO_F_VERSION_1))
   vi-hdr_len = sizeof(struct virtio_net_hdr_mrg_rxbuf);
   else
   vi-hdr_len = sizeof(struct virtio_net_hdr);
 -- 
 MST
___
Virtualization mailing list
Virtualization@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/virtualization


[PATCH RFC 4/4] virtio_net: bigger header when VERSION_1 is set

2014-10-23 Thread Michael S. Tsirkin
With VERSION_1 virtio_net uses same header size
whether mergeable buffers are enabled or not.

Signed-off-by: Michael S. Tsirkin m...@redhat.com
---
 drivers/net/virtio_net.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/net/virtio_net.c b/drivers/net/virtio_net.c
index 9c6d50f..a2fe340 100644
--- a/drivers/net/virtio_net.c
+++ b/drivers/net/virtio_net.c
@@ -1764,7 +1764,8 @@ static int virtnet_probe(struct virtio_device *vdev)
if (virtio_has_feature(vdev, VIRTIO_NET_F_MRG_RXBUF))
vi-mergeable_rx_bufs = true;
 
-   if (virtio_has_feature(vdev, VIRTIO_NET_F_MRG_RXBUF))
+   if (virtio_has_feature(vdev, VIRTIO_NET_F_MRG_RXBUF) ||
+   virtio_has_feature(vdev, VIRTIO_F_VERSION_1))
vi-hdr_len = sizeof(struct virtio_net_hdr_mrg_rxbuf);
else
vi-hdr_len = sizeof(struct virtio_net_hdr);
-- 
MST

___
Virtualization mailing list
Virtualization@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/virtualization