Re: [PATCH net-next] virtio_net: bulk free tx skbs
On Wed, Jan 16, 2019 at 03:31:58PM -0800, David Miller wrote: > From: "Michael S. Tsirkin" > Date: Mon, 14 Jan 2019 20:34:26 -0500 > > > Use napi_consume_skb() to get bulk free. Note that napi_consume_skb is > > safe to call in a non-napi context as long as the napi_budget flag is > > correct. > > > > Signed-off-by: Michael S. Tsirkin > > --- > > > > My perf testing setup is down but it works fine on my devel box and > > should be fairly uncontroversial. > > It would be uncontroversial if it compiled. > > drivers/net/virtio_net.c: In function ‘free_old_xmit_skbs’: > drivers/net/virtio_net.c:1346:25: error: ‘use_napi’ undeclared (first use in > this function); did you mean ‘used_math’? >napi_consume_skb(skb, use_napi); > ^~~~ > used_math > drivers/net/virtio_net.c:1346:25: note: each undeclared identifier is > reported only once for each function it appears in Yes my bad it was on top of other patches. I'm rebasing and will repost. -- MST ___ Virtualization mailing list Virtualization@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/virtualization
Re: [PATCH net-next] virtio_net: bulk free tx skbs
From: "Michael S. Tsirkin" Date: Mon, 14 Jan 2019 20:34:26 -0500 > Use napi_consume_skb() to get bulk free. Note that napi_consume_skb is > safe to call in a non-napi context as long as the napi_budget flag is > correct. > > Signed-off-by: Michael S. Tsirkin > --- > > My perf testing setup is down but it works fine on my devel box and > should be fairly uncontroversial. It would be uncontroversial if it compiled. drivers/net/virtio_net.c: In function ‘free_old_xmit_skbs’: drivers/net/virtio_net.c:1346:25: error: ‘use_napi’ undeclared (first use in this function); did you mean ‘used_math’? napi_consume_skb(skb, use_napi); ^~~~ used_math drivers/net/virtio_net.c:1346:25: note: each undeclared identifier is reported only once for each function it appears in ___ Virtualization mailing list Virtualization@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/virtualization
[PATCH net-next] virtio_net: bulk free tx skbs
Use napi_consume_skb() to get bulk free. Note that napi_consume_skb is safe to call in a non-napi context as long as the napi_budget flag is correct. Signed-off-by: Michael S. Tsirkin --- My perf testing setup is down but it works fine on my devel box and should be fairly uncontroversial. drivers/net/virtio_net.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/virtio_net.c b/drivers/net/virtio_net.c index 023725086046..d76dcc68cbb6 100644 --- a/drivers/net/virtio_net.c +++ b/drivers/net/virtio_net.c @@ -1343,7 +1343,7 @@ static void free_old_xmit_skbs(struct send_queue *sq) bytes += skb->len; packets++; - dev_consume_skb_any(skb); + napi_consume_skb(skb, use_napi); } /* Avoid overhead when no packets have been processed -- MST ___ Virtualization mailing list Virtualization@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/virtualization
