Re: [PATCHv2 01/14] virtio: event index interface

2011-05-20 Thread Rusty Russell
On Fri, 20 May 2011 02:10:17 +0300, "Michael S. Tsirkin"  
wrote:
> Define a new feature bit for the guest and host to utilize
> an event index (like Xen) instead if a flag bit to enable/disable
> interrupts and kicks.

Applied.

Thanks,
Rusty.
___
Virtualization mailing list
Virtualization@lists.linux-foundation.org
https://lists.linux-foundation.org/mailman/listinfo/virtualization


[PATCHv2 01/14] virtio: event index interface

2011-05-19 Thread Michael S. Tsirkin
Define a new feature bit for the guest and host to utilize
an event index (like Xen) instead if a flag bit to enable/disable
interrupts and kicks.

Signed-off-by: Michael S. Tsirkin 
---
 include/linux/virtio_ring.h |   15 ++-
 1 files changed, 14 insertions(+), 1 deletions(-)

diff --git a/include/linux/virtio_ring.h b/include/linux/virtio_ring.h
index e4d144b..70b0b39 100644
--- a/include/linux/virtio_ring.h
+++ b/include/linux/virtio_ring.h
@@ -29,6 +29,12 @@
 /* We support indirect buffer descriptors */
 #define VIRTIO_RING_F_INDIRECT_DESC28
 
+/* The Guest publishes the used index for which it expects an interrupt
+ * at the end of the avail ring. Host should ignore the avail->flags field. */
+/* The Host publishes the avail index for which it expects a kick
+ * at the end of the used ring. Guest should ignore the used->flags field. */
+#define VIRTIO_RING_F_EVENT_IDX29
+
 /* Virtio ring descriptors: 16 bytes.  These can chain together via "next". */
 struct vring_desc {
/* Address (guest-physical). */
@@ -83,6 +89,7 @@ struct vring {
  * __u16 avail_flags;
  * __u16 avail_idx;
  * __u16 available[num];
+ * __u16 used_event_idx;
  *
  * // Padding to the next align boundary.
  * char pad[];
@@ -91,8 +98,14 @@ struct vring {
  * __u16 used_flags;
  * __u16 used_idx;
  * struct vring_used_elem used[num];
+ * __u16 avail_event_idx;
  * };
  */
+/* We publish the used event index at the end of the available ring, and vice
+ * versa. They are at the end for backwards compatibility. */
+#define vring_used_event(vr) ((vr)->avail->ring[(vr)->num])
+#define vring_avail_event(vr) (*(__u16 *)&(vr)->used->ring[(vr)->num])
+
 static inline void vring_init(struct vring *vr, unsigned int num, void *p,
  unsigned long align)
 {
@@ -107,7 +120,7 @@ static inline unsigned vring_size(unsigned int num, 
unsigned long align)
 {
return ((sizeof(struct vring_desc) * num + sizeof(__u16) * (2 + num)
 + align - 1) & ~(align - 1))
-   + sizeof(__u16) * 2 + sizeof(struct vring_used_elem) * num;
+   + sizeof(__u16) * 3 + sizeof(struct vring_used_elem) * num;
 }
 
 #ifdef __KERNEL__
-- 
1.7.5.53.gc233e

___
Virtualization mailing list
Virtualization@lists.linux-foundation.org
https://lists.linux-foundation.org/mailman/listinfo/virtualization