Re: [patch v2] virtio: console: cleanup an error message
Dan Carpenter writes:
> The PTR_ERR(NULL) here is not useful.
>
> Signed-off-by: Dan Carpenter
> ---
> v2: completely different
Applied.
Thanks,
Rusty.
> diff --git a/drivers/char/virtio_console.c b/drivers/char/virtio_console.c
> index 1b456fe..4cf46d8 100644
> --- a/drivers/char/virtio_console.c
> +++ b/drivers/char/virtio_console.c
> @@ -2215,10 +2215,8 @@ static int __init init(void)
> }
>
> pdrvdata.debugfs_dir = debugfs_create_dir("virtio-ports", NULL);
> - if (!pdrvdata.debugfs_dir) {
> - pr_warning("Error %ld creating debugfs dir for virtio-ports\n",
> -PTR_ERR(pdrvdata.debugfs_dir));
> - }
> + if (!pdrvdata.debugfs_dir)
> + pr_warning("Error creating debugfs dir for virtio-ports\n");
> INIT_LIST_HEAD(&pdrvdata.consoles);
> INIT_LIST_HEAD(&pdrvdata.portdevs);
>
> ___
> Virtualization mailing list
> Virtualization@lists.linux-foundation.org
> https://lists.linuxfoundation.org/mailman/listinfo/virtualization
___
Virtualization mailing list
Virtualization@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/virtualization
Re: [patch v2] virtio: console: cleanup an error message
On Mon, Jul 29, 2013 at 04:35:38PM +0300, Dan Carpenter wrote:
> On Mon, Jul 29, 2013 at 06:12:31AM -0700, Greg Kroah-Hartman wrote:
> > On Mon, Jul 29, 2013 at 12:41:31PM +0530, Amit Shah wrote:
> > > On (Mon) 22 Jul 2013 [23:41:00], Dan Carpenter wrote:
> > > > The PTR_ERR(NULL) here is not useful.
> > > >
> > > > Signed-off-by: Dan Carpenter
> > > > ---
> > > > v2: completely different
> > > >
> > > > diff --git a/drivers/char/virtio_console.c
> > > > b/drivers/char/virtio_console.c
> > > > index 1b456fe..4cf46d8 100644
> > > > --- a/drivers/char/virtio_console.c
> > > > +++ b/drivers/char/virtio_console.c
> > > > @@ -2215,10 +2215,8 @@ static int __init init(void)
> > > > }
> > > >
> > > > pdrvdata.debugfs_dir = debugfs_create_dir("virtio-ports", NULL);
> > > > - if (!pdrvdata.debugfs_dir) {
> > > > - pr_warning("Error %ld creating debugfs dir for
> > > > virtio-ports\n",
> > > > - PTR_ERR(pdrvdata.debugfs_dir));
> > > > - }
> > > > + if (!pdrvdata.debugfs_dir)
> > > > + pr_warning("Error creating debugfs dir for
> > > > virtio-ports\n");
> > >
> > > When debugfs is enabled and creating the dir fails, we'll print this
> > > warning message.
> > >
> > > When debugfs is disabled, we'll get an error return, and not print any
> > > message.
> >
> > Not true, you will still print the message if debugfs is disabled, as
> > .debugfs_dir will not be NULL.
> >
> > Why even print anything at all? It's debugfs, you shouldn't really care
> > that much about it :)
> >
>
> Yes yes. That's what this code does. It only checks for NULL. The
> debugfs was a little confusing at first but I get it now.
Ugh, you are right, that's what I get for writing email before my
morning coffee...
___
Virtualization mailing list
Virtualization@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/virtualization
Re: [patch v2] virtio: console: cleanup an error message
On Mon, Jul 29, 2013 at 06:12:31AM -0700, Greg Kroah-Hartman wrote:
> On Mon, Jul 29, 2013 at 12:41:31PM +0530, Amit Shah wrote:
> > On (Mon) 22 Jul 2013 [23:41:00], Dan Carpenter wrote:
> > > The PTR_ERR(NULL) here is not useful.
> > >
> > > Signed-off-by: Dan Carpenter
> > > ---
> > > v2: completely different
> > >
> > > diff --git a/drivers/char/virtio_console.c b/drivers/char/virtio_console.c
> > > index 1b456fe..4cf46d8 100644
> > > --- a/drivers/char/virtio_console.c
> > > +++ b/drivers/char/virtio_console.c
> > > @@ -2215,10 +2215,8 @@ static int __init init(void)
> > > }
> > >
> > > pdrvdata.debugfs_dir = debugfs_create_dir("virtio-ports", NULL);
> > > - if (!pdrvdata.debugfs_dir) {
> > > - pr_warning("Error %ld creating debugfs dir for virtio-ports\n",
> > > -PTR_ERR(pdrvdata.debugfs_dir));
> > > - }
> > > + if (!pdrvdata.debugfs_dir)
> > > + pr_warning("Error creating debugfs dir for virtio-ports\n");
> >
> > When debugfs is enabled and creating the dir fails, we'll print this
> > warning message.
> >
> > When debugfs is disabled, we'll get an error return, and not print any
> > message.
>
> Not true, you will still print the message if debugfs is disabled, as
> .debugfs_dir will not be NULL.
>
> Why even print anything at all? It's debugfs, you shouldn't really care
> that much about it :)
>
Yes yes. That's what this code does. It only checks for NULL. The
debugfs was a little confusing at first but I get it now.
regards,
dan carpenter
___
Virtualization mailing list
Virtualization@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/virtualization
Re: [patch v2] virtio: console: cleanup an error message
On Mon, Jul 29, 2013 at 12:41:31PM +0530, Amit Shah wrote:
> On (Mon) 22 Jul 2013 [23:41:00], Dan Carpenter wrote:
> > The PTR_ERR(NULL) here is not useful.
> >
> > Signed-off-by: Dan Carpenter
> > ---
> > v2: completely different
> >
> > diff --git a/drivers/char/virtio_console.c b/drivers/char/virtio_console.c
> > index 1b456fe..4cf46d8 100644
> > --- a/drivers/char/virtio_console.c
> > +++ b/drivers/char/virtio_console.c
> > @@ -2215,10 +2215,8 @@ static int __init init(void)
> > }
> >
> > pdrvdata.debugfs_dir = debugfs_create_dir("virtio-ports", NULL);
> > - if (!pdrvdata.debugfs_dir) {
> > - pr_warning("Error %ld creating debugfs dir for virtio-ports\n",
> > - PTR_ERR(pdrvdata.debugfs_dir));
> > - }
> > + if (!pdrvdata.debugfs_dir)
> > + pr_warning("Error creating debugfs dir for virtio-ports\n");
>
> When debugfs is enabled and creating the dir fails, we'll print this
> warning message.
>
> When debugfs is disabled, we'll get an error return, and not print any
> message.
Not true, you will still print the message if debugfs is disabled, as
.debugfs_dir will not be NULL.
Why even print anything at all? It's debugfs, you shouldn't really care
that much about it :)
thanks,
greg k-h
___
Virtualization mailing list
Virtualization@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/virtualization
Re: [patch v2] virtio: console: cleanup an error message
On (Mon) 22 Jul 2013 [23:41:00], Dan Carpenter wrote:
> The PTR_ERR(NULL) here is not useful.
>
> Signed-off-by: Dan Carpenter
> ---
> v2: completely different
>
> diff --git a/drivers/char/virtio_console.c b/drivers/char/virtio_console.c
> index 1b456fe..4cf46d8 100644
> --- a/drivers/char/virtio_console.c
> +++ b/drivers/char/virtio_console.c
> @@ -2215,10 +2215,8 @@ static int __init init(void)
> }
>
> pdrvdata.debugfs_dir = debugfs_create_dir("virtio-ports", NULL);
> - if (!pdrvdata.debugfs_dir) {
> - pr_warning("Error %ld creating debugfs dir for virtio-ports\n",
> -PTR_ERR(pdrvdata.debugfs_dir));
> - }
> + if (!pdrvdata.debugfs_dir)
> + pr_warning("Error creating debugfs dir for virtio-ports\n");
When debugfs is enabled and creating the dir fails, we'll print this
warning message.
When debugfs is disabled, we'll get an error return, and not print any
message.
Seems OK to me.
Reviewed-by: Amit Shah
Rusty, please pick this up.
Amit
___
Virtualization mailing list
Virtualization@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/virtualization
Re: [patch v2] virtio: console: cleanup an error message
On Mon, Jul 22, 2013 at 11:41:00PM +0300, Dan Carpenter wrote: > The PTR_ERR(NULL) here is not useful. > > Signed-off-by: Dan Carpenter > --- > v2: completely different > > diff --git a/drivers/char/virtio_console.c b/drivers/char/virtio_console.c > index 1b456fe..4cf46d8 100644 > --- a/drivers/char/virtio_console.c > +++ b/drivers/char/virtio_console.c Rusty handles virtio stuff, please cc: him on these. thanks, greg k-h ___ Virtualization mailing list Virtualization@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/virtualization
[patch v2] virtio: console: cleanup an error message
The PTR_ERR(NULL) here is not useful.
Signed-off-by: Dan Carpenter
---
v2: completely different
diff --git a/drivers/char/virtio_console.c b/drivers/char/virtio_console.c
index 1b456fe..4cf46d8 100644
--- a/drivers/char/virtio_console.c
+++ b/drivers/char/virtio_console.c
@@ -2215,10 +2215,8 @@ static int __init init(void)
}
pdrvdata.debugfs_dir = debugfs_create_dir("virtio-ports", NULL);
- if (!pdrvdata.debugfs_dir) {
- pr_warning("Error %ld creating debugfs dir for virtio-ports\n",
- PTR_ERR(pdrvdata.debugfs_dir));
- }
+ if (!pdrvdata.debugfs_dir)
+ pr_warning("Error creating debugfs dir for virtio-ports\n");
INIT_LIST_HEAD(&pdrvdata.consoles);
INIT_LIST_HEAD(&pdrvdata.portdevs);
___
Virtualization mailing list
Virtualization@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/virtualization
