Re: Large Patch Series in Email (was Re: [PATCH 0000/0117] Staging: hv: Driver cleanup)
On Sat, 16 Jul 2011 00:07:39 +0100 Alan Cox a...@lxorguk.ukuu.org.uk wrote: Do not send more than 15 patches at once to the vger mailing lists!!! and, accordingly, I went to the trouble of setting up a GitHub account to host a repo from which I could issue *one* single PULL request email; I get a little miffed every time my inbox gets blasted with hundreds of patches when others don't do similarly. The problem with dumping stuff that needs review into a git tree is it's a lot of hassle to review so the advice is kind of outdated in such cases. It's good advice for things like big new subsystems perhaps but not for review. As is always the case social norms evolve faster than the people who feel compelled to attempt to document them. There are lots of web archives of the list and it's also not hard to set up mail tools to shuffle long emails into a folder so there are plenty of ways to manage and read the lists without being part of it. And someone should probably updating the CodingStyle document to reflect reality 8) Alan And while at it, maybe add some tipps on how to keep patchseries small... (people have probably more / better suggestions, please): - 'submit early, submit often' instead of time based submittal (like... oh I hacked 24/7 this week and now is friday, let's see how many patches I got...) - Putting controversial stuff at the end (so at least uncontroversial stuff can be applied) - try to split patchseries into stuff that can be applied independent of one another. - ... Regards, Flo ___ Virtualization mailing list Virtualization@lists.linux-foundation.org https://lists.linux-foundation.org/mailman/listinfo/virtualization
RE: Large Patch Series in Email (was Re: [PATCH 0000/0117] Staging: hv: Driver cleanup)
-Original Message- From: Michael Witten [mailto:mfwit...@gmail.com] Sent: Friday, July 15, 2011 2:26 PM To: KY Srinivasan Cc: Greg Kroah-Hartman; linux-ker...@vger.kernel.org; de...@linuxdriverproject.org; virtualizat...@lists.osdl.org Subject: Large Patch Series in Email (was Re: [PATCH /0117] Staging: hv: Driver cleanup) On Fri, 15 Jul 2011 10:47:04 -0700, K. Y. Srinivasan wrote: Subject: [PATCH /0117] Staging: hv: Driver cleanup Now, admittedly, I'm a nobody. You and I have something in common! I am sorry for flooding your mailbox. In the past Greg had indicated that he could handle large patch-sets and so, I sent out this large patch-set. Perhaps I should not have included the vger mailing list. Regards, K. Y ___ Virtualization mailing list Virtualization@lists.linux-foundation.org https://lists.linux-foundation.org/mailman/listinfo/virtualization
Large Patch Series in Email (was Re: [PATCH 0000/0117] Staging: hv: Driver cleanup)
On Fri, 15 Jul 2011 10:47:04 -0700, K. Y. Srinivasan wrote: Subject: [PATCH /0117] Staging: hv: Driver cleanup Now, admittedly, I'm a nobody. However, when I had a patch series of considerable size, I noted that Documentation/SubmittingPatches has stated the following since 2006: If you cannot condense your patch set into a smaller set of patches, then only post say 15 or so at a time and wait for review and integration. ... Do not send more than 15 patches at once to the vger mailing lists!!! and, accordingly, I went to the trouble of setting up a GitHub account to host a repo from which I could issue *one* single PULL request email; I get a little miffed every time my inbox gets blasted with hundreds of patches when others don't do similarly. Surely Microsoft can host a public repo for you (and anybody else, for that matter). Sincerely, Michael Witten ___ Virtualization mailing list Virtualization@lists.linux-foundation.org https://lists.linux-foundation.org/mailman/listinfo/virtualization
Re: Large Patch Series in Email (was Re: [PATCH 0000/0117] Staging: hv: Driver cleanup)
On Fri, Jul 15, 2011 at 06:25:55PM -, Michael Witten wrote: Do not send more than 15 patches at once to the vger mailing lists!!! If you're using mutt just type ESC-t ; d to delete the entire thread. Don't be a whinge bucket. regards, dan carpenter ___ Virtualization mailing list Virtualization@lists.linux-foundation.org https://lists.linux-foundation.org/mailman/listinfo/virtualization
Re: Large Patch Series in Email (was Re: [PATCH 0000/0117] Staging: hv: Driver cleanup)
Do not send more than 15 patches at once to the vger mailing lists!!! and, accordingly, I went to the trouble of setting up a GitHub account to host a repo from which I could issue *one* single PULL request email; I get a little miffed every time my inbox gets blasted with hundreds of patches when others don't do similarly. The problem with dumping stuff that needs review into a git tree is it's a lot of hassle to review so the advice is kind of outdated in such cases. It's good advice for things like big new subsystems perhaps but not for review. As is always the case social norms evolve faster than the people who feel compelled to attempt to document them. There are lots of web archives of the list and it's also not hard to set up mail tools to shuffle long emails into a folder so there are plenty of ways to manage and read the lists without being part of it. And someone should probably updating the CodingStyle document to reflect reality 8) Alan ___ Virtualization mailing list Virtualization@lists.linux-foundation.org https://lists.linux-foundation.org/mailman/listinfo/virtualization
Re: Large Patch Series in Email
From: Michael Witten mfwit...@gmail.com Date: Fri, 15 Jul 2011 22:55:29 - On Sat, 16 Jul 2011 00:09:03 +0300, Dan Carpenter wrote: On Fri, Jul 15, 2011 at 06:25:55PM -, Michael Witten wrote: Do not send more than 15 patches at once to the vger mailing lists!!! ... Don't be a whinge bucket. Or be respectful of bandwidth, differing email environments, and the official guidelines for submitting patches, which I will quote again: If you cannot condense your patch set into a smaller set of patches, then only post say 15 or so at a time and wait for review and integration. ... Do not send more than 15 patches at once to the vger mailing lists!!! Indeed, it really sucks when people send huge patch sets, do not do it. If the official SubmittingPatches document isn't convincing enough, then maybe me (the vger postmaster) saying it will. ___ Virtualization mailing list Virtualization@lists.linux-foundation.org https://lists.linux-foundation.org/mailman/listinfo/virtualization
Re: Large Patch Series in Email (was Re: [PATCH 0000/0117] Staging: hv: Driver cleanup)
On Sat, 16 Jul 2011 00:09:03 +0300, Dan Carpenter wrote: On Fri, Jul 15, 2011 at 06:25:55PM -, Michael Witten wrote: Do not send more than 15 patches at once to the vger mailing lists!!! ... Don't be a whinge bucket. Or be respectful of bandwidth, differing email environments, and the official guidelines for submitting patches, which I will quote again: If you cannot condense your patch set into a smaller set of patches, then only post say 15 or so at a time and wait for review and integration. ... Do not send more than 15 patches at once to the vger mailing lists!!! Sincerely, Michael Witten ___ Virtualization mailing list Virtualization@lists.linux-foundation.org https://lists.linux-foundation.org/mailman/listinfo/virtualization
