Re: [PATCH V3 0/2] [BUGFIX] virtio/console: Fix two bugs of splice_write

2013-07-22 Thread Rusty Russell
Amit Shah  writes:
> On (Mon) 22 Jul 2013 [13:00:43], Yoshihiro YUNOMAE wrote:
>> Hi,
>> 
>> This patch set fixes two bugs of splice_write in the virtio-console driver.
>> 
>> [BUG1] Although pipe->nrbufs is empty, the driver tries to do splice_write.
>>=> This induces oops in sg_init_table().
>> 
>> [BUG2] No lock for competition of splice_write.
>>=> This induces oops in splice_from_pipe_feed() by bug of any user
>>   application.
>> 
>> These reports are written in each patch.
>> 
>> Changes in V2:
>> - Fix a locking problem for error
>> 
>> Changes in V3:
>> - Add Reviewed-by lines and stable@ line in sign-off area
>
> Thank you!
>
> Rusty, please pick this up.

Both applied, thankyou.

Cheers,
Rusty.
___
Virtualization mailing list
Virtualization@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/virtualization


Re: [PATCH V3 0/2] [BUGFIX] virtio/console: Fix two bugs of splice_write

2013-07-21 Thread Amit Shah
On (Mon) 22 Jul 2013 [13:00:43], Yoshihiro YUNOMAE wrote:
> Hi,
> 
> This patch set fixes two bugs of splice_write in the virtio-console driver.
> 
> [BUG1] Although pipe->nrbufs is empty, the driver tries to do splice_write.
>=> This induces oops in sg_init_table().
> 
> [BUG2] No lock for competition of splice_write.
>=> This induces oops in splice_from_pipe_feed() by bug of any user
>   application.
> 
> These reports are written in each patch.
> 
> Changes in V2:
> - Fix a locking problem for error
> 
> Changes in V3:
> - Add Reviewed-by lines and stable@ line in sign-off area

Thank you!

Rusty, please pick this up.

Amit
___
Virtualization mailing list
Virtualization@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/virtualization