Re: [RFC PATCH v3 19/19] smp, x86: kill SMP single function call interrupt

2013-12-15 Thread Jiang Liu
Hi Sebastian,
Thanks for your review.
The patch applies to the mainstream kernel, so seems there's difference
between tip and the mainstream kernel. I will try to find the
difference.
And there's another patch for Xen, but I found the mail tile is
wrong:( Please refer to:
http://www.kernelhub.org/?msg=373208p=2

Should I merge the patch for xen with the patch for native x86?
Is there any dependency between them?

Thanks!
Gerry

On 12/12/2013 06:10 AM, Sebastian Andrzej Siewior wrote:
 On 05.12.13, Jiang Liu wrote:
 
 I like this in general however
 
 diff --git a/arch/x86/xen/smp.c b/arch/x86/xen/smp.c
 index 7cf1689..f241792 100644
 --- a/arch/x86/xen/smp.c
 +++ b/arch/x86/xen/smp.c
 @@ -560,7 +560,6 @@ static inline int xen_map_vector(int vector)
  xen_vector = XEN_RESCHEDULE_VECTOR;
  break;
  case CALL_FUNCTION_VECTOR:
 -case CALL_FUNCTION_SINGLE_VECTOR:
  xen_vector = XEN_CALL_FUNCTION_VECTOR;
  break;
  case IRQ_WORK_VECTOR:
 
 This chunk does not apply again tip's master branch, the code looks
 different. You need to also kill XEN_CALL_FUNCTION_SINGLE_VECTOR which
 is either part of a different patch or against a different tree. I
 haven't seen a note in 0/19 or this patch description so I'm confused
 here :)
 
 Sebastian
 

___
Virtualization mailing list
Virtualization@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/virtualization


Re: [RFC PATCH v3 19/19] smp, x86: kill SMP single function call interrupt

2013-12-11 Thread Sebastian Andrzej Siewior
On 05.12.13, Jiang Liu wrote:

I like this in general however

 diff --git a/arch/x86/xen/smp.c b/arch/x86/xen/smp.c
 index 7cf1689..f241792 100644
 --- a/arch/x86/xen/smp.c
 +++ b/arch/x86/xen/smp.c
 @@ -560,7 +560,6 @@ static inline int xen_map_vector(int vector)
   xen_vector = XEN_RESCHEDULE_VECTOR;
   break;
   case CALL_FUNCTION_VECTOR:
 - case CALL_FUNCTION_SINGLE_VECTOR:
   xen_vector = XEN_CALL_FUNCTION_VECTOR;
   break;
   case IRQ_WORK_VECTOR:

This chunk does not apply again tip's master branch, the code looks
different. You need to also kill XEN_CALL_FUNCTION_SINGLE_VECTOR which
is either part of a different patch or against a different tree. I
haven't seen a note in 0/19 or this patch description so I'm confused
here :)

Sebastian
___
Virtualization mailing list
Virtualization@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/virtualization