Re: [net-next RFC V4 PATCH 0/4] Multiqueue virtio-net

2012-06-26 Thread Jason Wang

On 06/26/2012 01:49 AM, Sridhar Samudrala wrote:

On 6/25/2012 2:16 AM, Jason Wang wrote:

Hello All:

This series is an update version of multiqueue virtio-net driver 
based on
Krishna Kumar's work to let virtio-net use multiple rx/tx queues to 
do the

packets reception and transmission. Please review and comments.

Test Environment:
- Intel(R) Xeon(R) CPU E5620 @ 2.40GHz, 8 cores 2 numa nodes
- Two directed connected 82599

Test Summary:

- Highlights: huge improvements on TCP_RR test
- Lowlights: regression on small packet transmission, higher cpu 
utilization

  than single queue, need further optimization

Does this also scale with increased number of VMs?



Hi Sridhar:

Good suggestions, I didn't measure them. I would run test and post them.

Thanks


Thanks
Sridhar


Analysis of the performance result:

- I count the number of packets sending/receiving during the test, and
   multiqueue show much more ability in terms of packets per second.

- For the tx regression, multiqueue send about 1-2 times of more packets
   compared to single queue, and the packets size were much smaller 
than single
   queue does. I suspect tcp does less batching in multiqueue, so I 
hack the

   tcp_write_xmit() to forece more batching, multiqueue works as well as
   singlequeue for both small transmission and throughput

- I didn't pack the accelerate RFS with virtio-net in this sereis as 
it still

   need further shaping, for the one that interested in this please see:
   http://www.mail-archive.com/kvm@vger.kernel.org/msg64111.html




--
To unsubscribe from this list: send the line unsubscribe netdev in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html


___
Virtualization mailing list
Virtualization@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/virtualization


Re: [net-next RFC V4 PATCH 0/4] Multiqueue virtio-net

2012-06-26 Thread Jason Wang

On 06/26/2012 02:01 AM, Shirley Ma wrote:

Hello Jason,

Good work. Do you have local guest to guest results?

Thanks
Shirley

Hi Shirley:

I would run tests to measure the performance and post here.

Thanks
___
Virtualization mailing list
Virtualization@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/virtualization


Re: [net-next RFC V4 PATCH 0/4] Multiqueue virtio-net

2012-06-25 Thread Michael S. Tsirkin
On Mon, Jun 25, 2012 at 05:16:48PM +0800, Jason Wang wrote:
 Hello All:
 
 This series is an update version of multiqueue virtio-net driver based on
 Krishna Kumar's work to let virtio-net use multiple rx/tx queues to do the
 packets reception and transmission. Please review and comments.
 
 Test Environment:
 - Intel(R) Xeon(R) CPU E5620 @ 2.40GHz, 8 cores 2 numa nodes
 - Two directed connected 82599
 
 Test Summary:
 
 - Highlights: huge improvements on TCP_RR test
 - Lowlights: regression on small packet transmission, higher cpu utilization
  than single queue, need further optimization

Didn't review yet, reacting this this paragraph:

To avoid regressions, it seems reasonable to make
the device use a single queue by default for now.
Add a way to switch multiqueue on/off using ethtool.

This way guest admin can tune the device for the
workload manually until we manage to imlement some
self-tuning heuristics.

-- 
MST
___
Virtualization mailing list
Virtualization@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/virtualization


Re: [net-next RFC V4 PATCH 0/4] Multiqueue virtio-net

2012-06-25 Thread John Fastabend

On 6/25/2012 3:07 AM, Michael S. Tsirkin wrote:

On Mon, Jun 25, 2012 at 05:16:48PM +0800, Jason Wang wrote:

Hello All:

This series is an update version of multiqueue virtio-net driver based on
Krishna Kumar's work to let virtio-net use multiple rx/tx queues to do the
packets reception and transmission. Please review and comments.

Test Environment:
- Intel(R) Xeon(R) CPU E5620 @ 2.40GHz, 8 cores 2 numa nodes
- Two directed connected 82599

Test Summary:

- Highlights: huge improvements on TCP_RR test
- Lowlights: regression on small packet transmission, higher cpu utilization
  than single queue, need further optimization


Didn't review yet, reacting this this paragraph:

To avoid regressions, it seems reasonable to make
the device use a single queue by default for now.
Add a way to switch multiqueue on/off using ethtool.

This way guest admin can tune the device for the
workload manually until we manage to imlement some
self-tuning heuristics.



Ethtool already has this switch 'ethtool -L' can be
used to set the number tx/rx channels. So you would
likely just need to add a set_channels hook.

.John
___
Virtualization mailing list
Virtualization@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/virtualization


Re: [net-next RFC V4 PATCH 0/4] Multiqueue virtio-net

2012-06-25 Thread Sridhar Samudrala

On 6/25/2012 2:16 AM, Jason Wang wrote:

Hello All:

This series is an update version of multiqueue virtio-net driver based on
Krishna Kumar's work to let virtio-net use multiple rx/tx queues to do the
packets reception and transmission. Please review and comments.

Test Environment:
- Intel(R) Xeon(R) CPU E5620 @ 2.40GHz, 8 cores 2 numa nodes
- Two directed connected 82599

Test Summary:

- Highlights: huge improvements on TCP_RR test
- Lowlights: regression on small packet transmission, higher cpu utilization
  than single queue, need further optimization

Does this also scale with increased number of VMs?

Thanks
Sridhar


Analysis of the performance result:

- I count the number of packets sending/receiving during the test, and
   multiqueue show much more ability in terms of packets per second.

- For the tx regression, multiqueue send about 1-2 times of more packets
   compared to single queue, and the packets size were much smaller than single
   queue does. I suspect tcp does less batching in multiqueue, so I hack the
   tcp_write_xmit() to forece more batching, multiqueue works as well as
   singlequeue for both small transmission and throughput

- I didn't pack the accelerate RFS with virtio-net in this sereis as it still
   need further shaping, for the one that interested in this please see:
   http://www.mail-archive.com/kvm@vger.kernel.org/msg64111.html




___
Virtualization mailing list
Virtualization@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/virtualization


Re: [net-next RFC V4 PATCH 0/4] Multiqueue virtio-net

2012-06-25 Thread Shirley Ma
Hello Jason,

Good work. Do you have local guest to guest results?

Thanks
Shirley

___
Virtualization mailing list
Virtualization@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/virtualization