Re: linux-next: Tree for Feb 13 (virtio_console)
On Thu, Feb 14, 2013 at 4:23 PM, Stephen Rothwell s...@canb.auug.org.au wrote: Hi Greg, On Thu, 14 Feb 2013 16:02:29 -0800 Greg KH g...@kroah.com wrote: On Fri, Feb 15, 2013 at 10:55:19AM +1100, Stephen Rothwell wrote: Also, has someone checked to see if any of the CONFIG_ symbols that had a dependency on TTY added are selected anywhere else? Joe did all of that I think. Joe? OK, good. I tried to find all of them, but I can't guarantee they're all fixed : ). I tried to search out the features that used the tty driver (using two initialization functions), and tried enabling all features while disabling TTY on my x86 64 bit machine. In addition to stubbing out functions that the kernel's initialization required. Any other suggestions for finding problems proactively are appreciated. - Joe ___ Virtualization mailing list Virtualization@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/virtualization
Re: linux-next: Tree for Feb 13 (virtio_console)
On 02/13/13 19:00, Rusty Russell wrote: Randy Dunlap rdun...@infradead.org writes: On 02/13/13 00:35, Stephen Rothwell wrote: Hi all, Changes since 20130212: on i386: drivers/built-in.o: In function `in_intr': virtio_console.c:(.text+0x2dd31): undefined reference to `hvc_poll' virtio_console.c:(.text+0x2dd41): undefined reference to `hvc_kick' drivers/built-in.o: In function `resize_console': virtio_console.c:(.text+0x2e26f): undefined reference to `__hvc_resize' drivers/built-in.o: In function `unplug_port': virtio_console.c:(.text+0x2e572): undefined reference to `hvc_remove' drivers/built-in.o: In function `init_port_console': (.text+0x2fe59): undefined reference to `hvc_alloc' drivers/built-in.o: In function `virtio_cons_early_init': (.init.text+0x16d1): undefined reference to `hvc_instantiate' Full randconfig file is attached. This looks like an impossible config. CONFIG_VIRTIO_CONSOLE=y, but CONFIG_HVC_DRIVER isn't set. From drivers/char/Kconfig: config VIRTIO_CONSOLE tristate Virtio console depends on VIRTIO select HVC_DRIVER ??? OK. It's probably yet another stinking problem with kvmtool and randconfig. Running *config reports: warning: (KVMTOOL_TEST_ENABLE LGUEST_GUEST) selects VIRTIO_CONSOLE which has unmet direct dependencies (VIRTIO TTY) I'll look a bit more... thanks, -- ~Randy ___ Virtualization mailing list Virtualization@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/virtualization
Re: linux-next: Tree for Feb 13 (virtio_console)
On 02/14/13 10:45, Randy Dunlap wrote: On 02/13/13 19:00, Rusty Russell wrote: Randy Dunlap rdun...@infradead.org writes: On 02/13/13 00:35, Stephen Rothwell wrote: Hi all, Changes since 20130212: on i386: drivers/built-in.o: In function `in_intr': virtio_console.c:(.text+0x2dd31): undefined reference to `hvc_poll' virtio_console.c:(.text+0x2dd41): undefined reference to `hvc_kick' drivers/built-in.o: In function `resize_console': virtio_console.c:(.text+0x2e26f): undefined reference to `__hvc_resize' drivers/built-in.o: In function `unplug_port': virtio_console.c:(.text+0x2e572): undefined reference to `hvc_remove' drivers/built-in.o: In function `init_port_console': (.text+0x2fe59): undefined reference to `hvc_alloc' drivers/built-in.o: In function `virtio_cons_early_init': (.init.text+0x16d1): undefined reference to `hvc_instantiate' Full randconfig file is attached. This looks like an impossible config. CONFIG_VIRTIO_CONSOLE=y, but CONFIG_HVC_DRIVER isn't set. From drivers/char/Kconfig: config VIRTIO_CONSOLE tristate Virtio console depends on VIRTIO select HVC_DRIVER ??? OK. It's probably yet another stinking problem with kvmtool and randconfig. Running *config reports: warning: (KVMTOOL_TEST_ENABLE LGUEST_GUEST) selects VIRTIO_CONSOLE which has unmet direct dependencies (VIRTIO TTY) I'll look a bit more... Nope, that's not it. Stephen's comments were much closer. The patch below fixes the kconfig warning and the build errors. --- From: Randy Dunlap rdun...@infradead.org Fix kconfig warning for LGUEST_GUEST config by selecting TTY: warning: (KVMTOOL_TEST_ENABLE LGUEST_GUEST) selects VIRTIO_CONSOLE which has unmet direct dependencies (VIRTIO TTY) Signed-off-by: Randy Dunlap rdun...@infradead.org --- arch/x86/lguest/Kconfig |1 + 1 file changed, 1 insertion(+) --- linux-next-20130213.orig/arch/x86/lguest/Kconfig +++ linux-next-20130213/arch/x86/lguest/Kconfig @@ -2,6 +2,7 @@ config LGUEST_GUEST bool Lguest guest support select PARAVIRT depends on X86_32 + select TTY select VIRTUALIZATION select VIRTIO select VIRTIO_CONSOLE ___ Virtualization mailing list Virtualization@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/virtualization
Re: linux-next: Tree for Feb 13 (virtio_console)
Hi Greg, The patch below is needed in the tty tree (which introduced CONFIG_TTY). Also, has someone checked to see if any of the CONFIG_ symbols that had a dependency on TTY added are selected anywhere else? On Thu, 14 Feb 2013 10:55:06 -0800 Randy Dunlap rdun...@infradead.org wrote: On 02/14/13 10:45, Randy Dunlap wrote: On 02/13/13 19:00, Rusty Russell wrote: Randy Dunlap rdun...@infradead.org writes: On 02/13/13 00:35, Stephen Rothwell wrote: Hi all, Changes since 20130212: on i386: drivers/built-in.o: In function `in_intr': virtio_console.c:(.text+0x2dd31): undefined reference to `hvc_poll' virtio_console.c:(.text+0x2dd41): undefined reference to `hvc_kick' drivers/built-in.o: In function `resize_console': virtio_console.c:(.text+0x2e26f): undefined reference to `__hvc_resize' drivers/built-in.o: In function `unplug_port': virtio_console.c:(.text+0x2e572): undefined reference to `hvc_remove' drivers/built-in.o: In function `init_port_console': (.text+0x2fe59): undefined reference to `hvc_alloc' drivers/built-in.o: In function `virtio_cons_early_init': (.init.text+0x16d1): undefined reference to `hvc_instantiate' Full randconfig file is attached. This looks like an impossible config. CONFIG_VIRTIO_CONSOLE=y, but CONFIG_HVC_DRIVER isn't set. From drivers/char/Kconfig: config VIRTIO_CONSOLE tristate Virtio console depends on VIRTIO select HVC_DRIVER ??? OK. It's probably yet another stinking problem with kvmtool and randconfig. Running *config reports: warning: (KVMTOOL_TEST_ENABLE LGUEST_GUEST) selects VIRTIO_CONSOLE which has unmet direct dependencies (VIRTIO TTY) I'll look a bit more... Nope, that's not it. Stephen's comments were much closer. The patch below fixes the kconfig warning and the build errors. --- From: Randy Dunlap rdun...@infradead.org Fix kconfig warning for LGUEST_GUEST config by selecting TTY: warning: (KVMTOOL_TEST_ENABLE LGUEST_GUEST) selects VIRTIO_CONSOLE which has unmet direct dependencies (VIRTIO TTY) Signed-off-by: Randy Dunlap rdun...@infradead.org --- arch/x86/lguest/Kconfig |1 + 1 file changed, 1 insertion(+) --- linux-next-20130213.orig/arch/x86/lguest/Kconfig +++ linux-next-20130213/arch/x86/lguest/Kconfig @@ -2,6 +2,7 @@ config LGUEST_GUEST bool Lguest guest support select PARAVIRT depends on X86_32 + select TTY select VIRTUALIZATION select VIRTIO select VIRTIO_CONSOLE -- Cheers, Stephen Rothwells...@canb.auug.org.au pgpPROvEqZqPS.pgp Description: PGP signature ___ Virtualization mailing list Virtualization@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/virtualization
Re: linux-next: Tree for Feb 13 (virtio_console)
On Fri, Feb 15, 2013 at 10:55:19AM +1100, Stephen Rothwell wrote: Hi Greg, The patch below is needed in the tty tree (which introduced CONFIG_TTY). Ok, now done. Also, has someone checked to see if any of the CONFIG_ symbols that had a dependency on TTY added are selected anywhere else? Joe did all of that I think. Joe? ___ Virtualization mailing list Virtualization@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/virtualization
Re: linux-next: Tree for Feb 13 (virtio_console)
Hi Greg, On Thu, 14 Feb 2013 16:02:29 -0800 Greg KH g...@kroah.com wrote: On Fri, Feb 15, 2013 at 10:55:19AM +1100, Stephen Rothwell wrote: The patch below is needed in the tty tree (which introduced CONFIG_TTY). Ok, now done. Thanks. Also, has someone checked to see if any of the CONFIG_ symbols that had a dependency on TTY added are selected anywhere else? Joe did all of that I think. Joe? OK, good. -- Cheers, Stephen Rothwells...@canb.auug.org.au pgpY1jB0BZw11.pgp Description: PGP signature ___ Virtualization mailing list Virtualization@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/virtualization
Re: linux-next: Tree for Feb 13 (virtio_console)
Randy Dunlap rdun...@infradead.org writes: On 02/13/13 00:35, Stephen Rothwell wrote: Hi all, Changes since 20130212: on i386: drivers/built-in.o: In function `in_intr': virtio_console.c:(.text+0x2dd31): undefined reference to `hvc_poll' virtio_console.c:(.text+0x2dd41): undefined reference to `hvc_kick' drivers/built-in.o: In function `resize_console': virtio_console.c:(.text+0x2e26f): undefined reference to `__hvc_resize' drivers/built-in.o: In function `unplug_port': virtio_console.c:(.text+0x2e572): undefined reference to `hvc_remove' drivers/built-in.o: In function `init_port_console': (.text+0x2fe59): undefined reference to `hvc_alloc' drivers/built-in.o: In function `virtio_cons_early_init': (.init.text+0x16d1): undefined reference to `hvc_instantiate' Full randconfig file is attached. This looks like an impossible config. CONFIG_VIRTIO_CONSOLE=y, but CONFIG_HVC_DRIVER isn't set. From drivers/char/Kconfig: config VIRTIO_CONSOLE tristate Virtio console depends on VIRTIO select HVC_DRIVER ??? Cheers, Rusty. ___ Virtualization mailing list Virtualization@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/virtualization
Re: linux-next: Tree for Feb 13 (virtio_console)
Hi Rusty, On Thu, 14 Feb 2013 13:30:37 +1030 Rusty Russell ru...@rustcorp.com.au wrote: This looks like an impossible config. CONFIG_VIRTIO_CONSOLE=y, but CONFIG_HVC_DRIVER isn't set. From drivers/char/Kconfig: config VIRTIO_CONSOLE tristate Virtio console depends on VIRTIO This also has TTY in -next (not actually relevant) select HVC_DRIVER Its weird, but since CONFIG_TTY is not set (see the config), the HVC_DRIVER symbol is not even visible, so I suspect that the above select does nothing :-( But also, I can't see how VIRTIO_CONSOLE could be set in the first place since TTY is not set. (cc'ing some more people) (this is a randconfig that has TTY=n, HVC_DRIVER=n, but VIRTIO_CONSOLE=y) -- Cheers, Stephen Rothwells...@canb.auug.org.au pgpTRtlXluTPP.pgp Description: PGP signature ___ Virtualization mailing list Virtualization@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/virtualization
