[vlc-commits] [Git][videolan/vlc][master] 10 commits: qml/AnimatedBackground: animate border
Jean-Baptiste Kempf pushed to branch master at VideoLAN / VLC
Commits:
87275e07 by Prince Gupta at 2021-06-24T22:08:45+05:30
qml/AnimatedBackground: animate border
- - - - -
58b94d7e by Prince Gupta at 2021-06-24T22:08:45+05:30
qml/BannerTabButton: use AnimatedBackground
- - - - -
0e534d74 by Prince Gupta at 2021-06-24T22:29:54+05:30
qml/IconToolButton: use AnimatedBackground
- - - - -
d140b635 by Prince Gupta at 2021-06-24T22:29:54+05:30
qml/SortControl: use AnimatedBackground
- - - - -
e7cd9618 by Prince Gupta at 2021-06-24T22:29:54+05:30
qml/TabButtonExt: use AnimatedBackground
- - - - -
9c9359df by Prince Gupta at 2021-06-24T22:29:54+05:30
qml/TextToolButton: use AnimatedBackground
- - - - -
47907745 by Prince Gupta at 2021-06-24T22:29:54+05:30
qml/PlayerMenuItem: use AnimatedBackground
- - - - -
0cdf8bdf by Prince Gupta at 2021-06-24T22:29:54+05:30
qml/ArtworkInfo: use AnimatedBackground
- - - - -
f598c6ee by Prince Gupta at 2021-06-24T22:29:54+05:30
qml: remove BackgroundFocus
- - - - -
fb9b8af9 by Prince Gupta at 2021-06-24T22:29:54+05:30
qml: remove BackgroundHover
- - - - -
14 changed files:
- modules/gui/qt/Makefile.am
- modules/gui/qt/player/qml/ControlButtons.qml
- modules/gui/qt/player/qml/PlaybackSpeed.qml
- modules/gui/qt/player/qml/PlayerMenuItem.qml
- modules/gui/qt/vlc.qrc
- modules/gui/qt/widgets/qml/AnimatedBackground.qml
- − modules/gui/qt/widgets/qml/BackgroundFocus.qml
- − modules/gui/qt/widgets/qml/BackgroundHover.qml
- modules/gui/qt/widgets/qml/BannerTabButton.qml
- modules/gui/qt/widgets/qml/GridItem.qml
- modules/gui/qt/widgets/qml/IconToolButton.qml
- modules/gui/qt/widgets/qml/SortControl.qml
- modules/gui/qt/widgets/qml/TabButtonExt.qml
- modules/gui/qt/widgets/qml/TextToolButton.qml
Changes:
=
modules/gui/qt/Makefile.am
=
@@ -751,8 +751,6 @@ libqt_plugin_la_QML = \
gui/qt/util/qml/Helpers.js \
gui/qt/util/qml/KeyHelper.js \
gui/qt/util/qml/SelectableDelegateModel.qml \
- gui/qt/widgets/qml/BackgroundFocus.qml \
- gui/qt/widgets/qml/BackgroundHover.qml \
gui/qt/widgets/qml/BannerTabButton.qml \
gui/qt/widgets/qml/BusyIndicatorExt.qml \
gui/qt/widgets/qml/CaptionLabel.qml \
=
modules/gui/qt/player/qml/ControlButtons.qml
=
@@ -807,7 +807,7 @@ Item{
Component {
id: artworkInfoDelegate
-Widgets.BackgroundHover {
+Widgets.AnimatedBackground {
id: artworkInfoItem
property bool paintOnly: false
@@ -1016,7 +1016,7 @@ Item{
anchors.centerIn: parent
font.pixelSize: VLCStyle.fontSize_normal
text: !playbackSpeedButton.paintOnly ?
i18n.qtr("%1x").arg(+player.rate.toFixed(2)) : i18n.qtr("1x")
-color: playbackSpeedButton.background.foregroundColor //
IconToolButton.background is a BackgroundHover
+color: playbackSpeedButton.background.foregroundColor //
IconToolButton.background is a AnimatedBackground
}
}
}
=
modules/gui/qt/player/qml/PlaybackSpeed.qml
=
@@ -151,7 +151,7 @@ Popup {
anchors.centerIn: parent
font.pixelSize: VLCStyle.fontSize_normal
text: i18n.qtr("1x")
-color: resetButton.background.foregroundColor //
IconToolButton.background is a BackgroundHover
+color: resetButton.background.foregroundColor //
IconToolButton.background is a AnimatedBackground
}
}
=
modules/gui/qt/player/qml/PlayerMenuItem.qml
=
@@ -104,9 +104,11 @@ T.MenuItem {
}
-background: Widgets.BackgroundHover {
+background: Widgets.AnimatedBackground {
implicitHeight: VLCStyle.fontHeight_normal
-active: control.highlighted
+
+backgroundColor: control.highlighted ? VLCStyle.colors.buttonHover
+ :
VLCStyle.colors.setColorAlpha(VLCStyle.colors.buttonHover, 0)
}
//hack around QTBUG-79115
=
modules/gui/qt/vlc.qrc
=
@@ -190,8 +190,6 @@
maininterface/qml/MiniPlayerBottomMargin.qml
-widgets/qml/BackgroundFocus.qml
-widgets/qml/BackgroundHover.qml
widgets/qml/BannerTabButton.qml
widgets/qml/BusyIndicatorExt.qml
widgets/qml/AnimatedBackground.qml
=
modules/gui/qt/widgets/qml/AnimatedBackground.qml
=
@@ -43,23 +43,42 @@ Rectangle {
return brightness > .6 ? "black" : "white"
}
+property color activeBorderColor:
[vlc-commits] [Git][videolan/vlc][master] qml/IconToolButton: Improve focus rectangle visibility
Jean-Baptiste Kempf pushed to branch master at VideoLAN / VLC
Commits:
7d83226e by Benjamin Arnaud at 2021-06-24T15:31:58+00:00
qml/IconToolButton: Improve focus rectangle visibility
And refactor color settings.
- - - - -
6 changed files:
- modules/gui/qt/player/qml/ButtonsLayout.qml
- modules/gui/qt/player/qml/Player.qml
- modules/gui/qt/player/qml/TopBar.qml
- modules/gui/qt/player/qml/VolumeWidget.qml
- modules/gui/qt/style/VLCColors.qml
- modules/gui/qt/widgets/qml/IconToolButton.qml
Changes:
=
modules/gui/qt/player/qml/ButtonsLayout.qml
=
@@ -108,6 +108,8 @@ Widgets.NavigableFocusScope {
return
VLCStyle.colors.setColorAlpha(colors.playerBg, 0.8); })
if (!!buttonloader.item.borderColor)
buttonloader.item.borderColor =
Qt.binding(function() { return colors.playerBorder; })
+if (!!buttonloader.item.colorFocus)
+buttonloader.item.colorFocus =
Qt.binding(function() { return colors.bgFocus; })
}
if (index > 0)
=
modules/gui/qt/player/qml/Player.qml
=
@@ -465,6 +465,7 @@ Widgets.NavigableFocusScope {
onClicked: player.jumpBwd()
text: i18n.qtr("Step back")
color: rootPlayer.colors.playerFg
+colorFocus: rootPlayer.colors.bgFocus
}
Widgets.IconToolButton {
@@ -473,6 +474,7 @@ Widgets.NavigableFocusScope {
onClicked: player.toggleVisualization()
text: i18n.qtr("Visualization")
color: rootPlayer.colors.playerFg
+colorFocus: rootPlayer.colors.bgFocus
}
Widgets.IconToolButton{
@@ -481,6 +483,7 @@ Widgets.NavigableFocusScope {
onClicked: player.jumpFwd()
text: i18n.qtr("Step forward")
color: rootPlayer.colors.playerFg
+colorFocus: rootPlayer.colors.bgFocus
}
}
}
=
modules/gui/qt/player/qml/TopBar.qml
=
@@ -147,6 +147,7 @@ Widgets.NavigableFocusScope{
iconText: VLCIcons.topbar_previous
text: i18n.qtr("Back")
color: topFocusScope.colors.playerFg
+colorFocus: topFocusScope.colors.bgFocus
focus: true
KeyNavigation.right: menuSelector
onClicked: {
@@ -253,6 +254,7 @@ Widgets.NavigableFocusScope{
iconText: VLCIcons.ellipsis
text: i18n.qtr("Menu")
color: rootPlayer.colors.playerFg
+colorFocus: rootPlayer.colors.bgFocus
property bool acceptFocus: true
onClicked: contextMenu.popup(this.mapToGlobal(0, height))
@@ -278,6 +280,7 @@ Widgets.NavigableFocusScope{
iconText: VLCIcons.playlist
text: i18n.qtr("Playlist")
color: rootPlayer.colors.playerFg
+colorFocus: rootPlayer.colors.bgFocus
focus: false
property bool acceptFocus: true
=
modules/gui/qt/player/qml/VolumeWidget.qml
=
@@ -68,6 +68,7 @@ FocusScope{
VLCIcons.volume_high
text: i18n.qtr("Mute")
color: widgetfscope.color
+colorFocus: colors.bgFocus
onClicked: player.muted = !player.muted
KeyNavigation.right: volControl
=
modules/gui/qt/style/VLCColors.qml
=
@@ -176,6 +176,7 @@ Item {
bgHoverText: text
bgHoverInactive: "#3daee9"
bgHoverTextInactive: text
+bgFocus: "black"
button: "#eff0f1";
buttonText: "#232627";
@@ -210,6 +211,7 @@ Item {
bgHoverText: text
bgHoverInactive: "#3daee9"
bgHoverTextInactive: text
+bgFocus: "white"
button: "#31363b"
buttonText: "#eff0f1"
buttonBorder: "#575b5f"
=
modules/gui/qt/widgets/qml/IconToolButton.qml
=
@@ -32,6 +32,7 @@ ToolButton {
property alias color: backgroundHover.foregroundColor
property color colorDisabled: VLCStyle.colors.textInactive
property color colorOverlay: "transparent"
+property color colorFocus: VLCStyle.colors.bgFocus
property string textOverlay: ""
property bool
[vlc-commits] [Git][videolan/vlc][master] macosx: Fix tiny bugs in volume control
Jean-Baptiste Kempf pushed to branch master at VideoLAN / VLC Commits: 98838a77 by Samuel Bassaly at 2021-06-24T14:52:26+00:00 macosx: Fix tiny bugs in volume control Fix a problem in the parsing string used for the volume control tooltip. The old string formatted a float as an int, leading to printing wrong values. Additionally, set the default value of the volume on startup to 1 (the correct value), instead of 0. Clean the LibraryWindow xib from 3 old variables, that were removed from the class, but not the xib. - - - - - 3 changed files: - modules/gui/macosx/UI/VLCLibraryWindow.xib - modules/gui/macosx/playlist/VLCPlayerController.m - modules/gui/macosx/windows/mainwindow/VLCMainWindowControlsBar.m Changes: = modules/gui/macosx/UI/VLCLibraryWindow.xib = @@ -1,8 +1,8 @@ - + - + @@ -17,24 +17,24 @@ - - - + + + - + - - + + - - + + - + @@ -42,7 +42,7 @@ - + @@ -50,16 +50,16 @@ - + - + - + - + @@ -67,7 +67,6 @@ - @@ -83,7 +82,7 @@ - + @@ -121,10 +120,10 @@ - + - + @@ -134,7 +133,7 @@ - +
[vlc-commits] [Git][videolan/vlc][master] rtp: fix invalid check
Thomas Guillem pushed to branch master at VideoLAN / VLC
Commits:
b6d0ebc9 by Thomas Guillem at 2021-06-24T13:05:44+00:00
rtp: fix invalid check
This caused the rtp access module to always fail.
Regression from ced9254b63271c36bddd15c01adabb88d3a3f1bb
- - - - -
1 changed file:
- modules/access/rtp/rtp.c
Changes:
=
modules/access/rtp/rtp.c
=
@@ -417,7 +417,7 @@ static int OpenURL(vlc_object_t *obj)
free (tmp);
p_sys->rtp_sock = (co ? vlc_dccp_CreateFD : vlc_datagram_CreateFD)(fd);
-if (p_sys->rtcp_sock == NULL) {
+if (p_sys->rtp_sock == NULL) {
if (rtcp_fd != -1)
net_Close(rtcp_fd);
return VLC_EGENERIC;
View it on GitLab:
https://code.videolan.org/videolan/vlc/-/commit/b6d0ebc9af53280ca05380280560d8096e3b6d14
--
View it on GitLab:
https://code.videolan.org/videolan/vlc/-/commit/b6d0ebc9af53280ca05380280560d8096e3b6d14
You're receiving this email because of your account on code.videolan.org.
___
vlc-commits mailing list
vlc-commits@videolan.org
https://mailman.videolan.org/listinfo/vlc-commits
[vlc-commits] [Git][videolan/vlc][master] directx_va: only call profile readers if we don't have one
Steve Lhomme pushed to branch master at VideoLAN / VLC
Commits:
a69b492a by Steve Lhomme at 2021-06-24T09:10:10+00:00
directx_va: only call profile readers if we dont have one
Thats how MediaCodec does it. These readers can be wrong so rely on lavc
and container values instead.
Fixes #25850
- - - - -
1 changed file:
- modules/codec/avcodec/directx_va.c
Changes:
=
modules/codec/avcodec/directx_va.c
=
@@ -348,13 +348,13 @@ static bool profile_supported(const directx_va_mode_t
*mode, const es_format_t *
return true;
int profile = fmt->i_profile >= 0 ? fmt->i_profile : avctx->profile;
-if (mode->codec == AV_CODEC_ID_H264)
+if (mode->codec == AV_CODEC_ID_H264 && profile == -1)
{
uint8_t h264_profile;
if ( h264_get_profile_level(fmt, _profile, NULL, NULL) )
profile = h264_profile;
}
-if (mode->codec == AV_CODEC_ID_HEVC)
+if (mode->codec == AV_CODEC_ID_HEVC && profile == -1)
{
uint8_t hevc_profile;
if (hevc_get_profile_level(fmt, _profile, NULL, NULL) )
View it on GitLab:
https://code.videolan.org/videolan/vlc/-/commit/a69b492a6272c84b9c2efa912ad0b1dc612a2b83
--
View it on GitLab:
https://code.videolan.org/videolan/vlc/-/commit/a69b492a6272c84b9c2efa912ad0b1dc612a2b83
You're receiving this email because of your account on code.videolan.org.
___
vlc-commits mailing list
vlc-commits@videolan.org
https://mailman.videolan.org/listinfo/vlc-commits
[vlc-commits] [Git][videolan/vlc][master] modules: inline module_exists()
Steve Lhomme pushed to branch master at VideoLAN / VLC
Commits:
ab58ea1b by Lyndon Brown at 2021-06-24T08:08:04+00:00
modules: inline module_exists()
- - - - -
3 changed files:
- include/vlc_modules.h
- src/libvlccore.sym
- src/modules/modules.c
Changes:
=
include/vlc_modules.h
=
@@ -124,15 +124,6 @@ static inline module_t *module_need_var(vlc_object_t *obj,
const char *cap,
VLC_API void module_unneed( vlc_object_t *, module_t * );
#define module_unneed(a,b) module_unneed(VLC_OBJECT(a),b)
-/**
- * Checks if a module exists.
- *
- * \param name name of the module
- * \retval true if the module exists
- * \retval false if the module does not exist (in the running installation)
- */
-VLC_API bool module_exists(const char *) VLC_USED;
-
/**
* Get a pointer to a module_t given it's name.
*
@@ -141,6 +132,18 @@ VLC_API bool module_exists(const char *) VLC_USED;
*/
VLC_API module_t *module_find(const char *name) VLC_USED;
+/**
+ * Checks if a module exists.
+ *
+ * \param name name of the module
+ * \retval true if the module exists
+ * \retval false if the module does not exist (in the running installation)
+ */
+VLC_USED static inline bool module_exists(const char * name)
+{
+return module_find(name) != NULL;
+}
+
/**
* Gets the table of module configuration items.
*
=
src/libvlccore.sym
=
@@ -252,7 +252,6 @@ vlc_uri_fixup
vlc_tick_now
module_config_free
module_config_get
-module_exists
module_find
module_get_capability
module_get_help
=
src/modules/modules.c
=
@@ -329,11 +329,6 @@ module_t *module_find (const char *name)
return NULL;
}
-bool module_exists (const char * psz_name)
-{
-return module_find (psz_name) != NULL;
-}
-
module_config_t *module_config_get( const module_t *module, unsigned *restrict
psize )
{
const vlc_plugin_t *plugin = module->plugin;
View it on GitLab:
https://code.videolan.org/videolan/vlc/-/commit/ab58ea1ba5d8a9f8eac353db23138d49ecf48846
--
View it on GitLab:
https://code.videolan.org/videolan/vlc/-/commit/ab58ea1ba5d8a9f8eac353db23138d49ecf48846
You're receiving this email because of your account on code.videolan.org.
___
vlc-commits mailing list
vlc-commits@videolan.org
https://mailman.videolan.org/listinfo/vlc-commits
