[vlc-commits] [Git][videolan/vlc][master] 2 commits: macosx: Fix valid album string check for length in playlist table cell view
Jean-Baptiste Kempf pushed to branch master at VideoLAN / VLC
Commits:
83a1b518 by Claudio Cambra at 2024-05-11T19:57:49+00:00
macosx: Fix valid album string check for length in playlist table cell view
Signed-off-by: Claudio Cambra develo...@claudiocambra.com
- - - - -
f3693fe7 by Claudio Cambra at 2024-05-11T19:57:49+00:00
macosx: Set default value for song detail string in playlist table cell view
Signed-off-by: Claudio Cambra develo...@claudiocambra.com
- - - - -
1 changed file:
- modules/gui/macosx/playlist/VLCPlaylistTableCellView.m
Changes:
=
modules/gui/macosx/playlist/VLCPlaylistTableCellView.m
=
@@ -84,9 +84,9 @@
}];
const BOOL validArtistString = item.artistName && item.artistName.length >
0;
-const BOOL validAlbumString = item.albumName && item.albumName > 0;
+const BOOL validAlbumString = item.albumName && item.albumName.length > 0;
-NSString *songDetailString;
+NSString *songDetailString = @"";
if (validArtistString && validAlbumString) {
songDetailString = [NSString stringWithFormat:@"%@ · %@",
item.artistName, item.albumName];
View it on GitLab:
https://code.videolan.org/videolan/vlc/-/compare/bebcc89c3835222e6e879ad955222951a18cbef5...f3693fe723041082b997cf0eb685e230c9ac90f0
--
View it on GitLab:
https://code.videolan.org/videolan/vlc/-/compare/bebcc89c3835222e6e879ad955222951a18cbef5...f3693fe723041082b997cf0eb685e230c9ac90f0
You're receiving this email because of your account on code.videolan.org.
VideoLAN code repository instance___
vlc-commits mailing list
vlc-commits@videolan.org
https://mailman.videolan.org/listinfo/vlc-commits
[vlc-commits] [Git][videolan/vlc][master] macosx: Add elide to audio group header view title
Jean-Baptiste Kempf pushed to branch master at VideoLAN / VLC Commits: bebcc89c by Claudio Cambra at 2024-05-11T16:17:57+00:00 macosx: Add elide to audio group header view title Signed-off-by: Claudio Cambra develo...@claudiocambra.com - - - - - 1 changed file: - modules/gui/macosx/UI/VLCLibraryAudioGroupHeaderView.xib Changes: = modules/gui/macosx/UI/VLCLibraryAudioGroupHeaderView.xib = @@ -23,7 +23,7 @@ - + View it on GitLab: https://code.videolan.org/videolan/vlc/-/commit/bebcc89c3835222e6e879ad955222951a18cbef5 -- View it on GitLab: https://code.videolan.org/videolan/vlc/-/commit/bebcc89c3835222e6e879ad955222951a18cbef5 You're receiving this email because of your account on code.videolan.org. VideoLAN code repository instance___ vlc-commits mailing list vlc-commits@videolan.org https://mailman.videolan.org/listinfo/vlc-commits
[vlc-commits] [Git][videolan/vlc][3.0.x] http: allow short response byte range
Jean-Baptiste Kempf pushed to branch 3.0.x at VideoLAN / VLC
Commits:
d9b0f2b6 by Rémi Denis-Courmont at 2024-05-10T18:03:51+03:00
http: allow short response byte range
RFC9110 specifies that a client must handle a shorter response range
than requested in all circumstanges. Previously, RFC7233 only required
that behaviour for multipart ranges, which VLC did not use.
This matches the newer specification: VLC will try to resume from the
last received offset not only on unexpected error, but also on short
response.
Fixes #28627.
(cherry picked from commit 90dc0a023f6ceee591f6464367efae65f2ccf6e7)
- - - - -
1 changed file:
- modules/access/http/file.c
Changes:
=
modules/access/http/file.c
=
@@ -235,20 +235,21 @@ block_t *vlc_http_file_read(struct vlc_http_resource *res)
block_t *block = vlc_http_res_read(res);
if (block == vlc_http_error)
-{ /* Automatically reconnect on error if server supports seek */
-if (res->response != NULL
- && vlc_http_msg_can_seek(res->response)
- && file->offset < vlc_http_msg_get_file_size(res->response)
- && vlc_http_file_seek(res, file->offset) == 0)
-block = vlc_http_res_read(res);
+block = NULL;
+
+/* Automatically resume on short response or error if possible */
+if (block == NULL && res->response != NULL
+ && vlc_http_msg_can_seek(res->response)
+ && file->offset < vlc_http_msg_get_file_size(res->response)
+ && vlc_http_file_seek(res, file->offset) == 0)
+{
+block = vlc_http_res_read(res);
if (block == vlc_http_error)
-return NULL;
+block = NULL; /* Non-recovered error */
}
-if (block == NULL)
-return NULL; /* End of stream */
-
-file->offset += block->i_buffer;
+if (block != NULL)
+file->offset += block->i_buffer;
return block;
}
View it on GitLab:
https://code.videolan.org/videolan/vlc/-/commit/d9b0f2b638fa78cec95ab5f39e855ab65dc3e83b
--
View it on GitLab:
https://code.videolan.org/videolan/vlc/-/commit/d9b0f2b638fa78cec95ab5f39e855ab65dc3e83b
You're receiving this email because of your account on code.videolan.org.
VideoLAN code repository instance___
vlc-commits mailing list
vlc-commits@videolan.org
https://mailman.videolan.org/listinfo/vlc-commits
[vlc-commits] [Git][videolan/vlc][master] macosx: Do not show horizontal scroller on audio grouping table view
Jean-Baptiste Kempf pushed to branch master at VideoLAN / VLC Commits: 1fa42f74 by Claudio Cambra at 2024-05-11T14:47:33+00:00 macosx: Do not show horizontal scroller on audio grouping table view Signed-off-by: Claudio Cambra develo...@claudiocambra.com - - - - - 1 changed file: - modules/gui/macosx/UI/VLCLibraryWindow.xib Changes: = modules/gui/macosx/UI/VLCLibraryWindow.xib = @@ -927,7 +927,7 @@ - + View it on GitLab: https://code.videolan.org/videolan/vlc/-/commit/1fa42f744e75fc7b67578e407f34624c088cbc14 -- View it on GitLab: https://code.videolan.org/videolan/vlc/-/commit/1fa42f744e75fc7b67578e407f34624c088cbc14 You're receiving this email because of your account on code.videolan.org. VideoLAN code repository instance___ vlc-commits mailing list vlc-commits@videolan.org https://mailman.videolan.org/listinfo/vlc-commits
[vlc-commits] [Git][videolan/vlc][master] qml: fix grouping in video views
Jean-Baptiste Kempf pushed to branch master at VideoLAN / VLC
Commits:
04ba6eb3 by Prince Gupta at 2024-05-11T11:49:06+00:00
qml: fix grouping in video views
fixes a typo
- - - - -
1 changed file:
- modules/gui/qt/medialibrary/qml/VideoAllSubDisplay.qml
Changes:
=
modules/gui/qt/medialibrary/qml/VideoAllSubDisplay.qml
=
@@ -37,7 +37,7 @@ VideoAll {
property SortMenuVideo sortMenu: SortMenuVideo {
ctx: MainCtx
-onGrouping: (groupping) => { MainCtx.grouping = grouping }
+onGrouping: (grouping) => { MainCtx.grouping = grouping }
}
// Private
View it on GitLab:
https://code.videolan.org/videolan/vlc/-/commit/04ba6eb336081c0930725c91237ab688483ac4a7
--
View it on GitLab:
https://code.videolan.org/videolan/vlc/-/commit/04ba6eb336081c0930725c91237ab688483ac4a7
You're receiving this email because of your account on code.videolan.org.
VideoLAN code repository instance___
vlc-commits mailing list
vlc-commits@videolan.org
https://mailman.videolan.org/listinfo/vlc-commits
[vlc-commits] [Git][videolan/vlc][master] libvlc: add API to set/toggle teletext transparency
Jean-Baptiste Kempf pushed to branch master at VideoLAN / VLC
Commits:
11569530 by Fabian Huber at 2024-05-11T07:27:32+00:00
libvlc: add API to set/toggle teletext transparency
- - - - -
3 changed files:
- include/vlc/libvlc_media_player.h
- lib/libvlc.sym
- lib/video.c
Changes:
=
include/vlc/libvlc_media_player.h
=
@@ -2153,6 +2153,25 @@ LIBVLC_API int libvlc_video_get_teletext(
libvlc_media_player_t *p_mi );
*/
LIBVLC_API void libvlc_video_set_teletext( libvlc_media_player_t *p_mi, int
i_page );
+/**
+ * Set teletext background transparency.
+ *
+ * \param p_mi the media player
+ * \param transparent whether background should be transparent.
+ * \version LibVLC 4.0.0 or later
+ */
+LIBVLC_API void libvlc_video_set_teletext_transparency( libvlc_media_player_t
*p_mi, bool transparent );
+
+/**
+ * Get teletext background transparency.
+ *
+ * \param p_mi the media player
+ * \retval true teletext has transparent background
+ * \retval false teletext has opaque background
+ * \version LibVLC 4.0.0 or later
+ */
+LIBVLC_API bool libvlc_video_get_teletext_transparency( libvlc_media_player_t
*p_mi );
+
/**
* Take a snapshot of the current video window.
*
=
lib/libvlc.sym
=
@@ -244,6 +244,7 @@ libvlc_video_get_scale
libvlc_video_get_spu_delay
libvlc_video_get_spu_text_scale
libvlc_video_get_teletext
+libvlc_video_get_teletext_transparency
libvlc_video_set_adjust_float
libvlc_video_set_adjust_int
libvlc_video_set_aspect_ratio
@@ -267,6 +268,7 @@ libvlc_video_set_scale
libvlc_video_set_spu_delay
libvlc_video_set_spu_text_scale
libvlc_video_set_teletext
+libvlc_video_set_teletext_transparency
libvlc_video_take_snapshot
libvlc_video_new_viewpoint
libvlc_video_update_viewpoint
=
lib/video.c
=
@@ -446,6 +446,28 @@ void libvlc_video_set_teletext( libvlc_media_player_t
*p_mi, int i_page )
vlc_player_Unlock(player);
}
+void libvlc_video_set_teletext_transparency( libvlc_media_player_t *p_mi, bool
transparent )
+{
+vlc_player_t *player = p_mi->player;
+vlc_player_Lock(player);
+
+vlc_player_SetTeletextTransparency(player, transparent);
+
+vlc_player_Unlock(player);
+}
+
+bool libvlc_video_get_teletext_transparency( libvlc_media_player_t *p_mi )
+{
+vlc_player_t *player = p_mi->player;
+vlc_player_Lock(player);
+
+bool transparent = vlc_player_IsTeletextTransparent(player);
+
+vlc_player_Unlock(player);
+
+return transparent;
+}
+
/**
* libvlc_video_set_deinterlace : enable/disable/auto deinterlace and filter
*/
View it on GitLab:
https://code.videolan.org/videolan/vlc/-/commit/115695305e6ba715f2e8e4d61da9327bdf4c5e91
--
View it on GitLab:
https://code.videolan.org/videolan/vlc/-/commit/115695305e6ba715f2e8e4d61da9327bdf4c5e91
You're receiving this email because of your account on code.videolan.org.
VideoLAN code repository instance___
vlc-commits mailing list
vlc-commits@videolan.org
https://mailman.videolan.org/listinfo/vlc-commits
