[vlc-commits] [Git][videolan/vlc][master] 3 commits: macosx: Limit trailing edge of hero view stack view
Jean-Baptiste Kempf pushed to branch master at VideoLAN / VLC Commits: a85531c4 by Claudio Cambra at 2024-05-12T14:28:22+00:00 macosx: Limit trailing edge of hero view stack view Signed-off-by: Claudio Cambra- - - - - 8d1c820b by Claudio Cambra at 2024-05-12T14:28:22+00:00 macosx: Lower compression resistance priority of stack view components Prevents the child views of the stack view resizing the stack view past the size of the super view Signed-off-by: Claudio Cambra - - - - - 7f94bd85 by Claudio Cambra at 2024-05-12T14:28:22+00:00 macosx: Limit detail string for hero view to one line Signed-off-by: Claudio Cambra - - - - - 1 changed file: - modules/gui/macosx/UI/VLCLibraryHeroView.xib Changes: = modules/gui/macosx/UI/VLCLibraryHeroView.xib = @@ -29,7 +29,7 @@ - + @@ -40,19 +40,19 @@ - + - + - - + + @@ -86,6 +86,7 @@ + View it on GitLab: https://code.videolan.org/videolan/vlc/-/compare/928e8fea7d1ed8c0917da12d32d960cab55e40a9...7f94bd8563c1f212b2389b679c26e8b54a35391a -- View it on GitLab: https://code.videolan.org/videolan/vlc/-/compare/928e8fea7d1ed8c0917da12d32d960cab55e40a9...7f94bd8563c1f212b2389b679c26e8b54a35391a You're receiving this email because of your account on code.videolan.org. VideoLAN code repository instance___ vlc-commits mailing list vlc-commits@videolan.org https://mailman.videolan.org/listinfo/vlc-commits
[vlc-commits] [Git][videolan/vlc][master] 2 commits: macosx: Avoid crashing upon clicking collection view item when receiving nil index path
Jean-Baptiste Kempf pushed to branch master at VideoLAN / VLC Commits: f54dc525 by Claudio Cambra at 2024-05-12T13:19:00+00:00 macosx: Avoid crashing upon clicking collection view item when receiving nil index path Signed-off-by: Claudio Cambra- - - - - 928e8fea by Claudio Cambra at 2024-05-12T13:19:00+00:00 macosx: Log when receiving nil index path on mouse down of collection view item Signed-off-by: Claudio Cambra - - - - - 1 changed file: - modules/gui/macosx/library/VLCLibraryCollectionViewItem.m Changes: = modules/gui/macosx/library/VLCLibraryCollectionViewItem.m = @@ -297,6 +297,11 @@ const CGFloat VLCLibraryCollectionViewItemMaximumDisplayedProgress = 0.95; [self.collectionView.dataSource conformsToProtocol:@protocol(VLCLibraryCollectionViewDataSource)]) { NSObject * const dataSource = (NSObject *)self.collectionView.dataSource; NSIndexPath * const indexPath = [dataSource indexPathForLibraryItem:self.representedItem.item]; +if (indexPath == nil) { +NSLog(@"Received nil indexPath for item %@!", self.representedItem.item.displayString); +return; +} + NSSet * const indexPathSet = [NSSet setWithObject:indexPath]; [self.collectionView deselectItemsAtIndexPaths:indexPathSet]; View it on GitLab: https://code.videolan.org/videolan/vlc/-/compare/f3693fe723041082b997cf0eb685e230c9ac90f0...928e8fea7d1ed8c0917da12d32d960cab55e40a9 -- View it on GitLab: https://code.videolan.org/videolan/vlc/-/compare/f3693fe723041082b997cf0eb685e230c9ac90f0...928e8fea7d1ed8c0917da12d32d960cab55e40a9 You're receiving this email because of your account on code.videolan.org. VideoLAN code repository instance___ vlc-commits mailing list vlc-commits@videolan.org https://mailman.videolan.org/listinfo/vlc-commits