[vlc-commits] [Git][videolan/vlc][master] libvlccore: Add missing vlc_player_GetAtoBLoop to libvlccore.sym

[Steve Lhomme (@robUx4)]

Steve Lhomme pushed to branch master at VideoLAN / VLC


Commits:
5bd5a7ed by Claudio Cambra at 2024-06-23T05:13:42+00:00
libvlccore: Add missing vlc_player_GetAtoBLoop to libvlccore.sym

Signed-off-by: Claudio Cambra 

- - - - -


1 changed file:

- src/libvlccore.sym


Changes:

=
src/libvlccore.sym
=
@@ -855,6 +855,7 @@ vlc_player_CondWait
 vlc_player_DisplayPosition
 vlc_player_DecrementRate
 vlc_player_Delete
+vlc_player_GetAtoBLoop
 vlc_player_GetCapabilities
 vlc_player_GetCategoryDelay
 vlc_player_GetCategoryLanguage



View it on GitLab: 
https://code.videolan.org/videolan/vlc/-/commit/5bd5a7ed2d58018376fe07f515daf4d89934f755

-- 
This project does not include diff previews in email notifications.
View it on GitLab: 
https://code.videolan.org/videolan/vlc/-/commit/5bd5a7ed2d58018376fe07f515daf4d89934f755
You're receiving this email because of your account on code.videolan.org.


VideoLAN code repository instance___
vlc-commits mailing list
vlc-commits@videolan.org
https://mailman.videolan.org/listinfo/vlc-commits

[vlc-commits] [Git][videolan/vlc][master] qml: fix double click in video view

[Jean-Baptiste Kempf (@jbk)]

Jean-Baptiste Kempf pushed to branch master at VideoLAN / VLC


Commits:
78ea1cf9 by Prince Gupta at 2024-06-22T21:41:50+00:00
qml: fix double click in video view

- - - - -


1 changed file:

- modules/gui/qt/medialibrary/qml/VideoGridDisplay.qml


Changes:

=
modules/gui/qt/medialibrary/qml/VideoGridDisplay.qml
=
@@ -108,7 +108,7 @@ MainInterface.MainGridView {
 
 onItemClicked: (modifier) => { gridView.leftClickOnItem(modifier, 
index) }
 
-onItemDoubleClicked: model => gridView.itemDoubleClicked(model)
+onItemDoubleClicked: gridView.itemDoubleClicked(model)
 
 onContextMenuButtonClicked: (_, globalMousePos) => {
 gridView.rightClickOnItem(index);



View it on GitLab: 
https://code.videolan.org/videolan/vlc/-/commit/78ea1cf9708518d10efa704f8706ae4efed165cd

-- 
This project does not include diff previews in email notifications.
View it on GitLab: 
https://code.videolan.org/videolan/vlc/-/commit/78ea1cf9708518d10efa704f8706ae4efed165cd
You're receiving this email because of your account on code.videolan.org.


VideoLAN code repository instance___
vlc-commits mailing list
vlc-commits@videolan.org
https://mailman.videolan.org/listinfo/vlc-commits

[vlc-commits] [Git][videolan/vlc][3.0.x] vlc_common: remove warnings on VLC_OBJECT

[@fkuehne]

Felix Paul Kühne pushed to branch 3.0.x at VideoLAN / VLC


Commits:
ac310b4b by Alexandre Janniaux at 2024-06-22T14:25:44+00:00
vlc_common: remove warnings on VLC_OBJECT

Fix an infinite amount of warnings on Darwin:

../../include/vlc_variables.h:563:5: warning: due to lvalue conversion of 
the controlling expression, association of type 'const struct 
vlc_common_members' will never be selected because it is qualified 
[-Wunreachable-code-generic-assoc]
var_Create( p_obj, psz_name, VLC_VAR_STRING | VLC_VAR_DOINHERIT
^
../../include/vlc_variables.h:122:39: note: expanded from macro 
'var_Create'
#define var_Create(a,b,c) var_Create( VLC_OBJECT(a), b, c )
  ^
../../include/vlc_common.h:481:15: note: expanded from macro 
'VLC_OBJECT'
const struct vlc_common_members: (const vlc_object_t 
*)(&(x)->obj) \

- - - - -


1 changed file:

- include/vlc_common.h


Changes:

=
include/vlc_common.h
=
@@ -477,8 +477,8 @@ struct vlc_common_members
 #if !defined(__cplusplus)
 # define VLC_OBJECT(x) \
 _Generic((x)->obj, \
-struct vlc_common_members: (vlc_object_t *)(&(x)->obj), \
-const struct vlc_common_members: (const vlc_object_t *)(&(x)->obj) \
+vlc_object_t: (vlc_object_t *)(&(x)->obj), \
+struct vlc_common_members: (vlc_object_t *)(x) \
 )
 #else
 # define VLC_OBJECT( x ) ((vlc_object_t *)&(x)->obj)



View it on GitLab: 
https://code.videolan.org/videolan/vlc/-/commit/ac310b4b193bd86b741308393aa8d8833a1075ae

-- 
This project does not include diff previews in email notifications.
View it on GitLab: 
https://code.videolan.org/videolan/vlc/-/commit/ac310b4b193bd86b741308393aa8d8833a1075ae
You're receiving this email because of your account on code.videolan.org.


VideoLAN code repository instance___
vlc-commits mailing list
vlc-commits@videolan.org
https://mailman.videolan.org/listinfo/vlc-commits

[vlc-commits] [Git][videolan/vlc][master] aout: rework reset before aout->stop

[@fkuehne]

Felix Paul Kühne pushed to branch master at VideoLAN / VLC


Commits:
ef75cfe7 by Thomas Guillem at 2024-06-22T14:25:55+00:00
aout: rework reset before aout->stop

An asynchronous timing report would fail/assert after a stream_Reset().

This issue was hidden since, most of the time, vlc_aout_stream_Flush()
is called before vlc_aout_stream_Delete() but there are some rare case
where vlc_aout_stream_Delete() is called without a flush.

- - - - -


2 changed files:

- src/audio_output/dec.c
- src/audio_output/filters.c


Changes:

=
src/audio_output/dec.c
=
@@ -331,11 +331,14 @@ void vlc_aout_stream_Delete (vlc_aout_stream *stream)
 
 if (stream->mixer_format.i_format)
 {
-stream_Reset(stream);
 vlc_audio_meter_Reset(&owner->meter, NULL);
 if (stream->filters)
 aout_FiltersDelete (aout, stream->filters);
 aout_OutputDelete (aout);
+
+vlc_clock_Lock(stream->sync.clock);
+vlc_clock_Reset(stream->sync.clock);
+vlc_clock_Unlock(stream->sync.clock);
 }
 if (stream->volume != NULL)
 aout_volume_Delete(stream->volume);


=
src/audio_output/filters.c
=
@@ -144,7 +144,12 @@ static void aout_FiltersPipelineDestroy(struct aout_filter 
*tab, unsigned n)
 if (tab[i].vout != NULL)
 vout_Close(tab[i].vout);
 if (tab[i].clock != NULL)
+{
+vlc_clock_Lock(tab[i].clock);
+vlc_clock_Reset(tab[i].clock);
+vlc_clock_Unlock(tab[i].clock);
 vlc_clock_Delete(tab[i].clock);
+}
 }
 }
 



View it on GitLab: 
https://code.videolan.org/videolan/vlc/-/commit/ef75cfe77765de7ac401729f7dd79e746a1a8d78

-- 
This project does not include diff previews in email notifications.
View it on GitLab: 
https://code.videolan.org/videolan/vlc/-/commit/ef75cfe77765de7ac401729f7dd79e746a1a8d78
You're receiving this email because of your account on code.videolan.org.


VideoLAN code repository instance___
vlc-commits mailing list
vlc-commits@videolan.org
https://mailman.videolan.org/listinfo/vlc-commits

[vlc-commits] [Git][videolan/vlc][master] 4 commits: src: Cargo.toml: fix warnings on workspace

[Steve Lhomme (@robUx4)]

Steve Lhomme pushed to branch master at VideoLAN / VLC


Commits:
7e6f5783 by Alexandre Janniaux at 2024-06-22T07:48:04+00:00
src: Cargo.toml: fix warnings on workspace

Since we'll be using edition = "2021", and we have a virtual
workspace[^1], we need to specify the manifest resolver[^2].

Otherwise, cargo emits the following warning:

warning: virtual workspace defaulting to `resolver = "1"` despite 
one or more workspace members being on edition 2021 which implies `resolver = 
"2"`
note: to keep the current resolver, specify `workspace.resolver = 
"1"` in the workspace root's manifest
note: to use the edition 2021 resolver, specify `workspace.resolver = 
"2"` in the workspace root's manifest
note: for more details see 
https://doc.rust-lang.org/cargo/reference/resolver.html#resolver-versions

See release note[^3] for details on how this resolver changes the way
features are selected for packages inside the workspace.

[^1]: 
https://doc.rust-lang.org/cargo/reference/workspaces.html#virtual-workspace
[^2]: 
https://doc.rust-lang.org/edition-guide/rust-2021/default-cargo-resolver.html
[^3]: 
https://blog.rust-lang.org/2021/03/25/Rust-1.51.0.html#cargos-new-feature-resolver

- - - - -
7afc811f by Alexandre Janniaux at 2024-06-22T07:48:04+00:00
buildsystem: cargo-test: add cargo test driver

Cargo can output the test results as JSON when running with unstable
options. This script provides an automake test driver[^1] to run the
tests and gather the results in the automake test suite.

[^1]: 
https://www.gnu.org/software/automake/manual/html_node/Overview-of-Custom-Test-Drivers-Support.html

- - - - -
a29952aa by Alexandre Janniaux at 2024-06-22T07:48:04+00:00
src: Makefile.am: initialize TEST_EXTENSIONS

TEST_EXTENSIONS might be setup from different makefiles included, so it
must be defined first.

- - - - -
97e8fd1e by Alexandre Janniaux at 2024-06-22T07:48:04+00:00
src: rust: add Makefile.am for tests

Tests are sufficiently integrated into the automake test suite, and only
a few features are missing:

 - Handling skipping and xfailing for rust tests.
 - Reporting tests by category (lib, doctest, etc) and being able to
   disable a category, there's currently not enough test to justify
   this right now.
 - Handling the incremental building of tests, which currently seems to
   be triggered everytime.

- - - - -


5 changed files:

- Makefile.am
- + buildsystem/cargo-test.py
- src/Makefile.am
- src/rust/Cargo.toml
- + src/rust/Makefile.am


Changes:

=
Makefile.am
=
@@ -10,6 +10,7 @@ SUBDIRS = compat po share src modules lib doc bin test
 DIST_SUBDIRS = m4 $(SUBDIRS)
 
 EXTRA_DIST = \
+   buildsystem/cargo-test.py \
buildsystem/check_qml_module.py \
extras/include/x86/x86inc.asm \
extras/include/x86/x86util.asm \


=
buildsystem/cargo-test.py
=
@@ -0,0 +1,93 @@
+#!/usr/bin/python3
+# SPDX-License-Identifier: LGPL-2.1-or-later
+# Copyright (C) 2024 Alexandre Janniaux 
+#
+# Helper script to implement a cargo-based automake test driver.
+# See modules/Makefile.am and included Makefile for usage.
+
+import os, sys
+import argparse
+
+parser = argparse.ArgumentParser(
+prog='cargo-test',
+description='Automake test driver for cargo-based tests')
+
+parser.add_argument('--test-name')
+parser.add_argument('--log-file')
+parser.add_argument('--trs-file')
+parser.add_argument('--color-tests')
+parser.add_argument('--expect-failure')
+parser.add_argument('--enable-hard-errors')
+parser.add_argument('--working-directory', default=os.getcwd())
+
+args = []
+other_args = None
+for arg in sys.argv[1:]:
+if other_args is not None:
+other_args.append(arg)
+continue
+if arg == "--":
+other_args = []
+continue
+args.append(arg)
+args = parser.parse_args(args)
+
+test_name = args.test_name
+if test_name.endswith('.cargo'):
+test_name = test_name[:-len('.cargo')]
+
+# TODO: handle also additional parameter to select sub-tests
+# test_name = "::".join(args.test_name.split('.')[1:-1])
+
+import subprocess, os
+cmd = ['cargo', 'test', 
+   '--offline', '--locked',
+   '--color', 'always' if args.color_tests == 'yes' else 'never',
+   '--package', test_name,
+   '--',
+   '-Z', 'unstable-options',
+   '--format=json', '--show-output']
+
+out = subprocess.run(
+cmd,
+cwd=args.working_directory,
+capture_output=True,
+text=True,
+close_fds=False, # Necessary for jobserver
+env=os.environ | {
+'DYLD_LIBRARY_PATH': os.environ['top_builddir'] + '/src/.libs',
+'LD_LIBRARY_PATH': os.environ['top_builddir'] + '/src/.libs',
+}
+)
+
+sys.stderr.write(str(out.stderr))
+
+import json
+log_file = open(args.log_file, 'wt')
+trs_file = open(args.trs_file, 'wt')
+for line in out.stdout.splitlines():
+meta = json.loads(line)