[vlc-commits] Qt: extensioninfo dialog: remove unused member
vlc/vlc-2.0 | branch: master | Francois Cartegnie | Fri Mar 2 16:38:37 2012 +0100| [ea52eae0eb4a0d1fb219ea193fe66d1f56d7] | committer: Jean-Baptiste Kempf Qt: extensioninfo dialog: remove unused member (cherry picked from commit 8290233b46cd5e4edcd83d6a5795cda6814f06a7) Signed-off-by: Jean-Baptiste Kempf > http://git.videolan.org/gitweb.cgi/vlc/vlc-2.0.git/?a=commit;h=ea52eae0eb4a0d1fb219ea193fe66d1f56d7 --- modules/gui/qt4/dialogs/plugins.cpp | 12 +++- modules/gui/qt4/dialogs/plugins.hpp |4 2 files changed, 3 insertions(+), 13 deletions(-) diff --git a/modules/gui/qt4/dialogs/plugins.cpp b/modules/gui/qt4/dialogs/plugins.cpp index 180827d..ce7f137 100644 --- a/modules/gui/qt4/dialogs/plugins.cpp +++ b/modules/gui/qt4/dialogs/plugins.cpp @@ -187,8 +187,8 @@ bool PluginTreeItem::operator< ( const QTreeWidgetItem & other ) const } /* Extensions tab */ -ExtensionTab::ExtensionTab( intf_thread_t *p_intf ) -: QVLCFrame( p_intf ) +ExtensionTab::ExtensionTab( intf_thread_t *p_intf_ ) +: QVLCFrame( p_intf_ ) { // Layout QVBoxLayout *layout = new QVBoxLayout( this ); @@ -489,8 +489,7 @@ QSize ExtensionItemDelegate::sizeHint( const QStyleOptionViewItem &option, ExtensionInfoDialog::ExtensionInfoDialog( const ExtensionCopy& extension, intf_thread_t *p_intf, QWidget *parent ) - : QVLCDialog( parent, p_intf ), - extension( new ExtensionCopy( extension ) ) + : QVLCDialog( parent, p_intf ) { // Let's be a modal dialog setWindowModality( Qt::WindowModal ); @@ -578,11 +577,6 @@ ExtensionInfoDialog::ExtensionInfoDialog( const ExtensionCopy& extension, setMinimumSize( 450, 350 ); } -ExtensionInfoDialog::~ExtensionInfoDialog() -{ -delete extension; -} - static QPixmap *loadPixmapFromData( char *data, int size ) { if( !data || size <= 0 ) diff --git a/modules/gui/qt4/dialogs/plugins.hpp b/modules/gui/qt4/dialogs/plugins.hpp index 20ba740..e2ae1d2 100644 --- a/modules/gui/qt4/dialogs/plugins.hpp +++ b/modules/gui/qt4/dialogs/plugins.hpp @@ -162,10 +162,6 @@ class ExtensionInfoDialog : public QVLCDialog public: ExtensionInfoDialog( const ExtensionCopy& extension, intf_thread_t *p_intf, QWidget *parent ); -virtual ~ExtensionInfoDialog(); - -private: -ExtensionCopy *extension; }; #endif ___ vlc-commits mailing list vlc-commits@videolan.org http://mailman.videolan.org/listinfo/vlc-commits
[vlc-commits] Qt: extensioninfo dialog: remove unused member
vlc | branch: master | Francois Cartegnie | Fri Mar 2 16:38:37 2012 +0100| [8290233b46cd5e4edcd83d6a5795cda6814f06a7] | committer: Francois Cartegnie Qt: extensioninfo dialog: remove unused member > http://git.videolan.org/gitweb.cgi/vlc.git/?a=commit;h=8290233b46cd5e4edcd83d6a5795cda6814f06a7 --- modules/gui/qt4/dialogs/plugins.cpp | 12 +++- modules/gui/qt4/dialogs/plugins.hpp |4 2 files changed, 3 insertions(+), 13 deletions(-) diff --git a/modules/gui/qt4/dialogs/plugins.cpp b/modules/gui/qt4/dialogs/plugins.cpp index 6e32c16..1fcae46 100644 --- a/modules/gui/qt4/dialogs/plugins.cpp +++ b/modules/gui/qt4/dialogs/plugins.cpp @@ -187,8 +187,8 @@ bool PluginTreeItem::operator< ( const QTreeWidgetItem & other ) const } /* Extensions tab */ -ExtensionTab::ExtensionTab( intf_thread_t *p_intf ) -: QVLCFrame( p_intf ) +ExtensionTab::ExtensionTab( intf_thread_t *p_intf_ ) +: QVLCFrame( p_intf_ ) { // Layout QVBoxLayout *layout = new QVBoxLayout( this ); @@ -491,8 +491,7 @@ QSize ExtensionItemDelegate::sizeHint( const QStyleOptionViewItem &option, ExtensionInfoDialog::ExtensionInfoDialog( const ExtensionCopy& extension, intf_thread_t *p_intf, QWidget *parent ) - : QVLCDialog( parent, p_intf ), - extension( new ExtensionCopy( extension ) ) + : QVLCDialog( parent, p_intf ) { // Let's be a modal dialog setWindowModality( Qt::WindowModal ); @@ -576,11 +575,6 @@ ExtensionInfoDialog::ExtensionInfoDialog( const ExtensionCopy& extension, setMinimumSize( 450, 350 ); } -ExtensionInfoDialog::~ExtensionInfoDialog() -{ -delete extension; -} - static QPixmap *loadPixmapFromData( char *data, int size ) { if( !data || size <= 0 ) diff --git a/modules/gui/qt4/dialogs/plugins.hpp b/modules/gui/qt4/dialogs/plugins.hpp index 5494b44..0058c67 100644 --- a/modules/gui/qt4/dialogs/plugins.hpp +++ b/modules/gui/qt4/dialogs/plugins.hpp @@ -163,10 +163,6 @@ class ExtensionInfoDialog : public QVLCDialog public: ExtensionInfoDialog( const ExtensionCopy& extension, intf_thread_t *p_intf, QWidget *parent ); -virtual ~ExtensionInfoDialog(); - -private: -ExtensionCopy *extension; }; #endif ___ vlc-commits mailing list vlc-commits@videolan.org http://mailman.videolan.org/listinfo/vlc-commits