[vlc-commits] qt: Fix memory leak

2017-02-14 Thread Hugo Beauzée-Luyssen
vlc | branch: master | Hugo Beauzée-Luyssen  | Tue Feb 14 
15:02:25 2017 +0100| [9078750d7912e66fb91ed97f55e6462753ff2332] | committer: 
Jean-Baptiste Kempf

qt: Fix memory leak

CID #1402725

> http://git.videolan.org/gitweb.cgi/vlc.git/?a=commit;h=9078750d7912e66fb91ed97f55e6462753ff2332
---

 modules/gui/qt/components/simple_preferences.cpp | 6 +-
 1 file changed, 5 insertions(+), 1 deletion(-)

diff --git a/modules/gui/qt/components/simple_preferences.cpp 
b/modules/gui/qt/components/simple_preferences.cpp
index f216653..e9c0133 100644
--- a/modules/gui/qt/components/simple_preferences.cpp
+++ b/modules/gui/qt/components/simple_preferences.cpp
@@ -1230,7 +1230,10 @@ bool SPrefsPanel::addType( const char * psz_ext, 
QTreeWidgetItem* current,
 const char* psz_VLC = "VLC";
 current = new QTreeWidgetItem( parent, QStringList( psz_ext ) );
 
-if( strstr( qvReg->ReadRegistry( psz_ext, "", "" ), psz_VLC ) )
+char* psz_reg = qvReg->ReadRegistry( psz_ext, "", "" );
+if( psz_reg == NULL )
+return false;
+if( strstr( psz_reg, psz_VLC ) )
 {
 current->setCheckState( 0, Qt::Checked );
 b_temp = true;
@@ -1240,6 +1243,7 @@ bool SPrefsPanel::addType( const char * psz_ext, 
QTreeWidgetItem* current,
 current->setCheckState( 0, Qt::Unchecked );
 b_temp = false;
 }
+free( psz_reg );
 listAsso.append( current );
 return b_temp;
 }

___
vlc-commits mailing list
vlc-commits@videolan.org
https://mailman.videolan.org/listinfo/vlc-commits


[vlc-commits] qt: Fix memory leak

2017-02-14 Thread Hugo Beauzée-Luyssen
vlc | branch: master | Hugo Beauzée-Luyssen  | Tue Feb 14 
15:02:25 2017 +0100| [7496c5d3d1e1d2e958deb7989a8315e7c5795ba8] | committer: 
Hugo Beauzée-Luyssen

qt: Fix memory leak

CID #1402725

> http://git.videolan.org/gitweb.cgi/vlc.git/?a=commit;h=7496c5d3d1e1d2e958deb7989a8315e7c5795ba8
---

 modules/gui/qt/components/simple_preferences.cpp | 6 +-
 1 file changed, 5 insertions(+), 1 deletion(-)

diff --git a/modules/gui/qt/components/simple_preferences.cpp 
b/modules/gui/qt/components/simple_preferences.cpp
index f216653..e9c0133 100644
--- a/modules/gui/qt/components/simple_preferences.cpp
+++ b/modules/gui/qt/components/simple_preferences.cpp
@@ -1230,7 +1230,10 @@ bool SPrefsPanel::addType( const char * psz_ext, 
QTreeWidgetItem* current,
 const char* psz_VLC = "VLC";
 current = new QTreeWidgetItem( parent, QStringList( psz_ext ) );
 
-if( strstr( qvReg->ReadRegistry( psz_ext, "", "" ), psz_VLC ) )
+char* psz_reg = qvReg->ReadRegistry( psz_ext, "", "" );
+if( psz_reg == NULL )
+return false;
+if( strstr( psz_reg, psz_VLC ) )
 {
 current->setCheckState( 0, Qt::Checked );
 b_temp = true;
@@ -1240,6 +1243,7 @@ bool SPrefsPanel::addType( const char * psz_ext, 
QTreeWidgetItem* current,
 current->setCheckState( 0, Qt::Unchecked );
 b_temp = false;
 }
+free( psz_reg );
 listAsso.append( current );
 return b_temp;
 }

___
vlc-commits mailing list
vlc-commits@videolan.org
https://mailman.videolan.org/listinfo/vlc-commits


[vlc-commits] Qt: fix memory leak

2015-10-21 Thread Hannes Domani
vlc/vlc-2.2 | branch: master | Hannes Domani  | Tue Jul  7 
19:22:00 2015 +0200| [81987901b362617968bff4423b9034cb55448877] | committer: 
Jean-Baptiste Kempf

Qt: fix memory leak

Signed-off-by: Jean-Baptiste Kempf 
(cherry picked from commit c5a36efc2bbcae2adc9016eda9a4530527de2e56)
Signed-off-by: Jean-Baptiste Kempf 

> http://git.videolan.org/gitweb.cgi/vlc/vlc-2.2.git/?a=commit;h=81987901b362617968bff4423b9034cb55448877
---

 modules/gui/qt4/dialogs/toolbar.cpp |2 ++
 1 file changed, 2 insertions(+)

diff --git a/modules/gui/qt4/dialogs/toolbar.cpp 
b/modules/gui/qt4/dialogs/toolbar.cpp
index c1e667a..4a8d48a 100644
--- a/modules/gui/qt4/dialogs/toolbar.cpp
+++ b/modules/gui/qt4/dialogs/toolbar.cpp
@@ -888,6 +888,8 @@ bool DroppingController::eventFilter( QObject *obj, QEvent 
*event )
 /* Start the effective drag */
 drag->exec(Qt::CopyAction | Qt::MoveAction, Qt::MoveAction);
 b_draging = false;
+
+delete dI;
 }
 return true;
 

___
vlc-commits mailing list
vlc-commits@videolan.org
https://mailman.videolan.org/listinfo/vlc-commits


[vlc-commits] Qt: fix memory leak

2015-10-21 Thread Hannes Domani
vlc/vlc-2.2 | branch: master | Hannes Domani  | Fri Jul  3 
14:34:41 2015 +0200| [8a7acb1e7424a0be03e01cde7ceaab6dc486c7c6] | committer: 
Jean-Baptiste Kempf

Qt: fix memory leak

Signed-off-by: Jean-Baptiste Kempf 
(cherry picked from commit 98f1ae98a639f465b756fa881f873e9892e38964)
Signed-off-by: Jean-Baptiste Kempf 

> http://git.videolan.org/gitweb.cgi/vlc/vlc-2.2.git/?a=commit;h=8a7acb1e7424a0be03e01cde7ceaab6dc486c7c6
---

 modules/gui/qt4/dialogs/open.cpp |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/modules/gui/qt4/dialogs/open.cpp b/modules/gui/qt4/dialogs/open.cpp
index 56ea980..500e1e4 100644
--- a/modules/gui/qt4/dialogs/open.cpp
+++ b/modules/gui/qt4/dialogs/open.cpp
@@ -111,7 +111,7 @@ OpenDialog::OpenDialog( QWidget *parent,
 selectButton = new QPushButton( qtr( "" ) );
 
 /* Menu for the Play button */
-QMenu * openButtonMenu = new QMenu( "Open" );
+QMenu * openButtonMenu = new QMenu( "Open", playButton );
 openButtonMenu->addAction( qtr( "" ), this, SLOT( enqueue() ),
 QKeySequence( "Alt+E" ) );
 openButtonMenu->addAction( qtr( "" ), this, SLOT( play() ),

___
vlc-commits mailing list
vlc-commits@videolan.org
https://mailman.videolan.org/listinfo/vlc-commits


[vlc-commits] Qt: fix memory leak

2015-10-21 Thread Hannes Domani
vlc/vlc-2.2 | branch: master | Hannes Domani  | Thu Aug 27 
16:18:24 2015 +0200| [03a2fd67c15a8a5c5e1686752a298416f7e32d37] | committer: 
Jean-Baptiste Kempf

Qt: fix memory leak

Signed-off-by: Jean-Baptiste Kempf 
(cherry picked from commit 5a04c819b287918876c1b9f0f68753003ed8faa1)
Signed-off-by: Jean-Baptiste Kempf 

> http://git.videolan.org/gitweb.cgi/vlc/vlc-2.2.git/?a=commit;h=03a2fd67c15a8a5c5e1686752a298416f7e32d37
---

 modules/gui/qt4/components/preferences_widgets.cpp |2 ++
 1 file changed, 2 insertions(+)

diff --git a/modules/gui/qt4/components/preferences_widgets.cpp 
b/modules/gui/qt4/components/preferences_widgets.cpp
index 8da328c..6cfb4bd 100644
--- a/modules/gui/qt4/components/preferences_widgets.cpp
+++ b/modules/gui/qt4/components/preferences_widgets.cpp
@@ -623,6 +623,8 @@ void ModuleListConfigControl::fillGrid( QGridLayout *l, int 
line )
 
 ModuleListConfigControl::~ModuleListConfigControl()
 {
+foreach ( checkBoxListItem *it, modules )
+free( it->psz_module );
 qDeleteAll( modules );
 modules.clear();
 delete groupBox;

___
vlc-commits mailing list
vlc-commits@videolan.org
https://mailman.videolan.org/listinfo/vlc-commits


[vlc-commits] Qt: fix memory leak

2015-10-21 Thread Hannes Domani
vlc/vlc-2.2 | branch: master | Hannes Domani  | Fri Jul  3 
14:34:01 2015 +0200| [d1c15289b977e8507f4105a4aa76cfdaa827f379] | committer: 
Jean-Baptiste Kempf

Qt: fix memory leak

Signed-off-by: Rémi Denis-Courmont 
(cherry picked from commit 1637cd913030e5fccf5f5aad37ad0dc22588f8e3)
Signed-off-by: Jean-Baptiste Kempf 

> http://git.videolan.org/gitweb.cgi/vlc/vlc-2.2.git/?a=commit;h=d1c15289b977e8507f4105a4aa76cfdaa827f379
---

 modules/gui/qt4/components/preferences_widgets.cpp |1 +
 1 file changed, 1 insertion(+)

diff --git a/modules/gui/qt4/components/preferences_widgets.cpp 
b/modules/gui/qt4/components/preferences_widgets.cpp
index da724dc..a79621b 100644
--- a/modules/gui/qt4/components/preferences_widgets.cpp
+++ b/modules/gui/qt4/components/preferences_widgets.cpp
@@ -504,6 +504,7 @@ void setfillVLCConfigCombo( const char *configname, 
intf_thread_t *p_intf,
 free( texts[i] );
 }
 free( texts );
+free( values );
 }
 
 if( p_config->psz_longtext != NULL )

___
vlc-commits mailing list
vlc-commits@videolan.org
https://mailman.videolan.org/listinfo/vlc-commits


[vlc-commits] Qt: fix memory leak

2015-08-27 Thread Hannes Domani
vlc | branch: master | Hannes Domani ssb...@yahoo.de | Thu Aug 27 16:18:24 
2015 +0200| [5a04c819b287918876c1b9f0f68753003ed8faa1] | committer: 
Jean-Baptiste Kempf

Qt: fix memory leak

Signed-off-by: Jean-Baptiste Kempf j...@videolan.org

 http://git.videolan.org/gitweb.cgi/vlc.git/?a=commit;h=5a04c819b287918876c1b9f0f68753003ed8faa1
---

 modules/gui/qt4/components/preferences_widgets.cpp |2 ++
 1 file changed, 2 insertions(+)

diff --git a/modules/gui/qt4/components/preferences_widgets.cpp 
b/modules/gui/qt4/components/preferences_widgets.cpp
index c3a9c54..6d72387 100644
--- a/modules/gui/qt4/components/preferences_widgets.cpp
+++ b/modules/gui/qt4/components/preferences_widgets.cpp
@@ -623,6 +623,8 @@ void ModuleListConfigControl::fillGrid( QGridLayout *l, int 
line )
 
 ModuleListConfigControl::~ModuleListConfigControl()
 {
+foreach ( checkBoxListItem *it, modules )
+free( it-psz_module );
 qDeleteAll( modules );
 modules.clear();
 delete groupBox;

___
vlc-commits mailing list
vlc-commits@videolan.org
https://mailman.videolan.org/listinfo/vlc-commits


[vlc-commits] Qt: fix memory leak

2015-07-15 Thread Hannes Domani
vlc | branch: master | Hannes Domani ssb...@yahoo.de | Tue Jul  7 19:22:00 
2015 +0200| [c5a36efc2bbcae2adc9016eda9a4530527de2e56] | committer: 
Jean-Baptiste Kempf

Qt: fix memory leak

Signed-off-by: Jean-Baptiste Kempf j...@videolan.org

 http://git.videolan.org/gitweb.cgi/vlc.git/?a=commit;h=c5a36efc2bbcae2adc9016eda9a4530527de2e56
---

 modules/gui/qt4/dialogs/toolbar.cpp |2 ++
 1 file changed, 2 insertions(+)

diff --git a/modules/gui/qt4/dialogs/toolbar.cpp 
b/modules/gui/qt4/dialogs/toolbar.cpp
index c1e667a..4a8d48a 100644
--- a/modules/gui/qt4/dialogs/toolbar.cpp
+++ b/modules/gui/qt4/dialogs/toolbar.cpp
@@ -888,6 +888,8 @@ bool DroppingController::eventFilter( QObject *obj, QEvent 
*event )
 /* Start the effective drag */
 drag-exec(Qt::CopyAction | Qt::MoveAction, Qt::MoveAction);
 b_draging = false;
+
+delete dI;
 }
 return true;
 

___
vlc-commits mailing list
vlc-commits@videolan.org
https://mailman.videolan.org/listinfo/vlc-commits


[vlc-commits] Qt: fix memory leak

2015-07-06 Thread Hannes Domani
vlc | branch: master | Hannes Domani ssb...@yahoo.de | Fri Jul  3 14:34:41 
2015 +0200| [98f1ae98a639f465b756fa881f873e9892e38964] | committer: 
Jean-Baptiste Kempf

Qt: fix memory leak

Signed-off-by: Jean-Baptiste Kempf j...@videolan.org

 http://git.videolan.org/gitweb.cgi/vlc.git/?a=commit;h=98f1ae98a639f465b756fa881f873e9892e38964
---

 modules/gui/qt4/dialogs/open.cpp |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/modules/gui/qt4/dialogs/open.cpp b/modules/gui/qt4/dialogs/open.cpp
index d080dac..224cfa5 100644
--- a/modules/gui/qt4/dialogs/open.cpp
+++ b/modules/gui/qt4/dialogs/open.cpp
@@ -111,7 +111,7 @@ OpenDialog::OpenDialog( QWidget *parent,
 selectButton = new QPushButton( qtr( Select ) );
 
 /* Menu for the Play button */
-QMenu * openButtonMenu = new QMenu( Open );
+QMenu * openButtonMenu = new QMenu( Open, playButton );
 openButtonMenu-addAction( qtr( Enqueue ), this, SLOT( enqueue() ),
 QKeySequence( Alt+E ) );
 openButtonMenu-addAction( qtr( Play ), this, SLOT( play() ),

___
vlc-commits mailing list
vlc-commits@videolan.org
https://mailman.videolan.org/listinfo/vlc-commits


[vlc-commits] Qt: fix memory leak

2015-07-03 Thread Hannes Domani
vlc | branch: master | Hannes Domani ssb...@yahoo.de | Fri Jul  3 14:34:01 
2015 +0200| [1637cd913030e5fccf5f5aad37ad0dc22588f8e3] | committer: Rémi 
Denis-Courmont

Qt: fix memory leak

Signed-off-by: Rémi Denis-Courmont r...@remlab.net

 http://git.videolan.org/gitweb.cgi/vlc.git/?a=commit;h=1637cd913030e5fccf5f5aad37ad0dc22588f8e3
---

 modules/gui/qt4/components/preferences_widgets.cpp |1 +
 1 file changed, 1 insertion(+)

diff --git a/modules/gui/qt4/components/preferences_widgets.cpp 
b/modules/gui/qt4/components/preferences_widgets.cpp
index 39465f2..bc6b6cc 100644
--- a/modules/gui/qt4/components/preferences_widgets.cpp
+++ b/modules/gui/qt4/components/preferences_widgets.cpp
@@ -504,6 +504,7 @@ void setfillVLCConfigCombo( const char *configname, 
intf_thread_t *p_intf,
 free( texts[i] );
 }
 free( texts );
+free( values );
 }
 
 if( p_config-psz_longtext != NULL )

___
vlc-commits mailing list
vlc-commits@videolan.org
https://mailman.videolan.org/listinfo/vlc-commits