Re: [vpp-dev] Missing session.api.h file

2017-03-03 Thread Dave Barach (dbarach)
Oh, no need to bisect or otherwise screw around. I found the problem.

Too many routines called “vat_api_hookup” floating around, resulting in 
repeated calls to the version in api_format.c. I caught the dpdk plugin doing 
it, and I think there’s at least one more.

I’ll fix it in the morning. I’m too sleepy to do it accurately right now.

Thanks… Dave

From: Jon Loeliger [mailto:j...@netgate.com]
Sent: Friday, March 3, 2017 10:43 PM
To: Dave Barach (dbarach) 
Cc: Florin Coras ; vpp-dev 
Subject: Re: [vpp-dev] Missing session.api.h file

On Fri, Mar 3, 2017 at 9:20 PM, Dave Barach (dbarach) 
> wrote:
BUG: multiple registrations of 
'vl_api_sw_interface_tag_add_del_reply_t_handler' means pretty much what it 
says. Two places in the code are registering handlers for that specific 
message. Last registrant wins.

I found and fixed 30 of these when I first added the check. Most were 
relatively benign - duplicate but identical routines left around after the 
vpe.api break-up. I found one which was not benign, code working only by 
accident.

Yeah, I figured as much.  My mystery is that I didn't change any of my
code except for pulling new VPP from upstream.   I think.


I’ve started a build of master/latest to see what I see...

 I'll try to bisect it or something, but it may be Monday before I get to it.

Thanks… Dave

Thanks,
jdl

___
vpp-dev mailing list
vpp-dev@lists.fd.io
https://lists.fd.io/mailman/listinfo/vpp-dev

Re: [vpp-dev] Missing session.api.h file

2017-03-03 Thread Dave Barach (dbarach)
BUG: multiple registrations of 
'vl_api_sw_interface_tag_add_del_reply_t_handler' means pretty much what it 
says. Two places in the code are registering handlers for that specific 
message. Last registrant wins.

I found and fixed 30 of these when I first added the check. Most were 
relatively benign - duplicate but identical routines left around after the 
vpe.api break-up. I found one which was not benign, code working only by 
accident.

I’ve started a build of master/latest to see what I see...

Thanks… Dave

From: vpp-dev-boun...@lists.fd.io [mailto:vpp-dev-boun...@lists.fd.io] On 
Behalf Of Jon Loeliger
Sent: Friday, March 3, 2017 10:07 PM
To: Florin Coras 
Cc: vpp-dev 
Subject: Re: [vpp-dev] Missing session.api.h file

On Fri, Mar 3, 2017 at 7:11 PM, Jon Loeliger 
> wrote:
On Fri, Mar 3, 2017 at 6:54 PM, Florin Coras 
> wrote:
Hi Jon,

Apologies about that. Alexander was kind enough to provide a quick solution 
here [1]. Will merge as soon as it passes verify.

Florin


Awesome!  Thank you!

jdl

That seems to have worked!

Thank you!


So, a different question now  Did something change about the
order or intended correct inclusion of the API message files?
That might be vague, sorry...

I'm now seeing these messages on VPP startup.

/usr/bin/vpp[2599]: vl_msg_api_config:672: BUG: multiple registrations of 
'vl_api_sw_interface_tag_add_del_reply_t_handler'

It all seems to be working so far, but am I somehow managing
to call in an API registration for each message twice now?
Like, did the include files somehow end up doubled up or something?

Yeah, I don't know either yet...

jdl


___
vpp-dev mailing list
vpp-dev@lists.fd.io
https://lists.fd.io/mailman/listinfo/vpp-dev

Re: [vpp-dev] Missing session.api.h file

2017-03-03 Thread Jon Loeliger
On Fri, Mar 3, 2017 at 7:11 PM, Jon Loeliger  wrote:

> On Fri, Mar 3, 2017 at 6:54 PM, Florin Coras 
> wrote:
>
>> Hi Jon,
>>
>> Apologies about that. Alexander was kind enough to provide a quick
>> solution here [1]. Will merge as soon as it passes verify.
>>
>> Florin
>>
>
>
> Awesome!  Thank you!
>
> jdl
>

That seems to have worked!

Thank you!


So, a different question now  Did something change about the
order or intended correct inclusion of the API message files?
That might be vague, sorry...

I'm now seeing these messages on VPP startup.

/usr/bin/vpp[2599]: vl_msg_api_config:672: BUG: multiple registrations of
'vl_api_sw_interface_tag_add_del_reply_t_handler'

It all seems to be working so far, but am I somehow managing
to call in an API registration for each message twice now?
Like, did the include files somehow end up doubled up or something?

Yeah, I don't know either yet...

jdl
___
vpp-dev mailing list
vpp-dev@lists.fd.io
https://lists.fd.io/mailman/listinfo/vpp-dev

Re: [vpp-dev] Missing session.api.h file

2017-03-03 Thread Jon Loeliger
On Fri, Mar 3, 2017 at 6:54 PM, Florin Coras  wrote:

> Hi Jon,
>
> Apologies about that. Alexander was kind enough to provide a quick
> solution here [1]. Will merge as soon as it passes verify.
>
> Florin
>


Awesome!  Thank you!

jdl
___
vpp-dev mailing list
vpp-dev@lists.fd.io
https://lists.fd.io/mailman/listinfo/vpp-dev

Re: [vpp-dev] Missing session.api.h file

2017-03-03 Thread Florin Coras
Hi Jon, 

Apologies about that. Alexander was kind enough to provide a quick solution 
here [1]. Will merge as soon as it passes verify.

Florin

[1] https://gerrit.fd.io/r/#/c/5621/ 

> On Mar 3, 2017, at 4:38 PM, Jon Loeliger  wrote:
> 
> VPP-ers,
> 
> I've just build RPM packages out of the current top-of-tree VPP at
> commit c83c3b7f117b981b677f646a0e30f44ec70de239.
> 
> After a yum install, a file in /usr/include/ references session.api.h:
> 
> $ grep -r session.api.h /usr/include/
> /usr/include/vnet/vnet_all_api_h.h:#include 
> 
> Yet it is not installed:
> 
> $ find /usr/include -name session\*
> /usr/include/vnet/session
> /usr/include/vnet/session/session.h
> 
> In fact, if you look in the RPM build staging directory, it is missing
> there as well:
> 
> $ find  build-root/install-vpp-native/vpp/include/ -name session\*
> build-root/install-vpp-native/vpp/include/vnet/session
> build-root/install-vpp-native/vpp/include/vnet/session/session.h
> 
> Thanks,
> jdl
> 
> ___
> vpp-dev mailing list
> vpp-dev@lists.fd.io
> https://lists.fd.io/mailman/listinfo/vpp-dev

___
vpp-dev mailing list
vpp-dev@lists.fd.io
https://lists.fd.io/mailman/listinfo/vpp-dev

[vpp-dev] Missing session.api.h file

2017-03-03 Thread Jon Loeliger
VPP-ers,

I've just build RPM packages out of the current top-of-tree VPP at
commit c83c3b7f117b981b677f646a0e30f44ec70de239.

After a yum install, a file in /usr/include/ references session.api.h:

$ grep -r session.api.h /usr/include/
/usr/include/vnet/vnet_all_api_h.h:#include 

Yet it is not installed:

$ find /usr/include -name session\*
/usr/include/vnet/session
/usr/include/vnet/session/session.h

In fact, if you look in the RPM build staging directory, it is missing
there as well:

$ find  build-root/install-vpp-native/vpp/include/ -name session\*
build-root/install-vpp-native/vpp/include/vnet/session
build-root/install-vpp-native/vpp/include/vnet/session/session.h

Thanks,
jdl
___
vpp-dev mailing list
vpp-dev@lists.fd.io
https://lists.fd.io/mailman/listinfo/vpp-dev

Re: [vpp-dev] dpdk sw crypto- build error

2017-03-03 Thread Billy McFall
Like the original email on this thread, I am trying to build latest vpp
with vpp_uses_dpdk_cryptodev_sw = yes option to enable vpp sw crypto. The
difference is I am running on Fedora 25. I attempted to followed the
suggestions in this email chain:
* I updated /build-data/platforms/vpp.mk with
 "-Wl,--whole-archive,-l:libIPSec_MB.a,--no-whole-archive" and copied
libIPSec_MB.a into /usr/lib/.
* I set link_all_deplibs to yes
in vpp/build-root/build-vpp-native/dpdk/isa-l_crypto-master/aclocal.m4
after running 'make bootstrap', which set it in
vpp/build-root/build-vpp-native/vpp/libtool.

If anyone has instructions on how to update libtool from source, I will
attempt that.


Below is the error I am seeing:

make[3]: Entering directory
'/home/bmcfall/dev/2017_03_03_VPP_Master/vpp/build-root/build-vpp-native/vpp'
  CCLD libvppinfra.la
/usr/bin/ld:
/home/bmcfall/dev/2017_03_03_VPP_Master/vpp/build-root/install-vpp-native/dpdk/lib/libIPSec_MB.a(aes128_cntr_by4_sse.o):
relocation R_X86_64_PC32 against symbol `byteswap_const' can not be used
when making a shared object; recompile with -fPIC
/usr/bin/ld: final link failed: Bad value
collect2: error: ld returned 1 exit status
Makefile:4564: recipe for target 'libvppinfra.la' failed
make[3]: *** [libvppinfra.la] Error 1


I am also seeing a lot of warnings when the dpdk/crypto is being built
(this is just a snippet, I am seeing a lot more):

make[4]: Entering directory
'/home/bmcfall/dev/2017_03_03_VPP_Master/vpp/build-root/build-vpp-native/dpdk/isa-l_crypto-master'
Building isa-l_crypto.h
make --no-print-directory all-am
  CC   md5_mb/md5_ctx_sse.lo
  CC   md5_mb/md5_ctx_avx.lo
  CC   md5_mb/md5_ctx_avx2.lo
  CC   md5_mb/md5_mb_mgr_init_sse.lo
  CC   md5_mb/md5_mb_mgr_init_avx2.lo
  CC   md5_mb/md5_mb_mgr_init_avx512.lo
  MKTMPmd5_mb/md5_mb_mgr_submit_sse.s
  CCAS md5_mb/md5_mb_mgr_submit_sse.lo
md5_mb/md5_mb_mgr_submit_sse.s:151: warning: absolute address can not be
RIP-relative
  MKTMPmd5_mb/md5_mb_mgr_submit_avx.s
  CCAS md5_mb/md5_mb_mgr_submit_avx.lo
md5_mb/md5_mb_mgr_submit_avx.s:150: warning: absolute address can not be
RIP-relative
  MKTMPmd5_mb/md5_mb_mgr_submit_avx2.s
  CCAS md5_mb/md5_mb_mgr_submit_avx2.lo
md5_mb/md5_mb_mgr_submit_avx2.s:159: warning: absolute address can not be
RIP-relative
  MKTMPmd5_mb/md5_mb_mgr_flush_sse.s
  CCAS md5_mb/md5_mb_mgr_flush_sse.lo
md5_mb/md5_mb_mgr_flush_sse.s:119: warning: absolute address can not be
RIP-relative
md5_mb/md5_mb_mgr_flush_sse.s:121: warning: absolute address can not be
RIP-relative
md5_mb/md5_mb_mgr_flush_sse.s:123: warning: absolute address can not be
RIP-relative
md5_mb/md5_mb_mgr_flush_sse.s:125: warning: absolute address can not be
RIP-relative
md5_mb/md5_mb_mgr_flush_sse.s:127: warning: absolute address can not be
RIP-relative
md5_mb/md5_mb_mgr_flush_sse.s:129: warning: absolute address can not be
RIP-relative
md5_mb/md5_mb_mgr_flush_sse.s:131: warning: absolute address can not be
RIP-relative
md5_mb/md5_mb_mgr_flush_sse.s:164: warning: absolute address can not be
RIP-relative
  MKTMPmd5_mb/md5_mb_mgr_flush_avx.s
  CCAS md5_mb/md5_mb_mgr_flush_avx.lo
md5_mb/md5_mb_mgr_flush_avx.s:119: warning: absolute address can not be
RIP-relative
md5_mb/md5_mb_mgr_flush_avx.s:121: warning: absolute address can not be
RIP-relative
md5_mb/md5_mb_mgr_flush_avx.s:123: warning: absolute address can not be
RIP-relative
md5_mb/md5_mb_mgr_flush_avx.s:125: warning: absolute address can not be
RIP-relative
md5_mb/md5_mb_mgr_flush_avx.s:127: warning: absolute address can not be
RIP-relative
md5_mb/md5_mb_mgr_flush_avx.s:129: warning: absolute address can not be
RIP-relative
md5_mb/md5_mb_mgr_flush_avx.s:131: warning: absolute address can not be
RIP-relative
md5_mb/md5_mb_mgr_flush_avx.s:163: warning: absolute address can not be
RIP-relative
:
  CCAS md5_mb/md5_mb_x4x2_sse.lo
md5_mb/md5_mb_x4x2_sse.s:361: warning: absolute address can not be
RIP-relative
md5_mb/md5_mb_x4x2_sse.s:539: warning: absolute address can not be
RIP-relative
md5_mb/md5_mb_x4x2_sse.s:162: ... from macro `MD5_STEP1' defined here
md5_mb/md5_mb_x4x2_sse.s:120: ... from macro `MAGIC_I' defined here
md5_mb/md5_mb_x4x2_sse.s:539: warning: absolute address can not be
RIP-relative
md5_mb/md5_mb_x4x2_sse.s:164: ... from macro `MD5_STEP1' defined here
md5_mb/md5_mb_x4x2_sse.s:120: ... from macro `MAGIC_I' defined here
md5_mb/md5_mb_x4x2_sse.s:540: warning: absolute address can not be
RIP-relative
md5_mb/md5_mb_x4x2_sse.s:162: ... from macro `MD5_STEP1' defined here
md5_mb/md5_mb_x4x2_sse.s:120: ... from macro `MAGIC_I' defined here
:

Any suggestions would be greatly appreciated,
Billy McFall

On Fri, Feb 24, 2017 at 7:03 AM, yusuf khan  wrote:

> Hi All,
>
> As Radu suggested, after updating libtool from source it works fine.
>
> Thanks a lot everyone.
>
> Br
> Yusuf
>
> On 24-Feb-2017 1:49 PM, "Chen, Zhaoyan"  wrote:
>
>> Met the same issue.
>>