Re: [vpp-dev] 'pool_elt_at_index' Relative Addressing Cause a Mistake

2018-01-04 Thread Dave Barach (dbarach) 
All of the pool_get(mypool, new_elt) variants are capable of expanding - and 
hence moving - mypool, leading to dangling references to free memory if you’re 
not careful. Here’s the usual coding pattern:

old_elt = pool_elt_at_index (mypool, index);

/* use old-elt */

pool_get (mypool, new_elt);

/* old-elt now INVALID, but index (or p[0]) is still fine */

old_elt = pool_elt_at_index (mypool, index);



Thanks… Dave

From: vpp-dev-boun...@lists.fd.io [mailto:vpp-dev-boun...@lists.fd.io] On 
Behalf Of ???
Sent: Thursday, January 4, 2018 1:22 AM
To: vpp-dev 
Subject: [vpp-dev] 'pool_elt_at_index' Relative Addressing Cause a Mistake


Hi guys,

I'm testing ikev2. When I initiate a sa succeed(pr1), then add the other one 
(pr2), the sa->pr1->name is rewritten.

After viewing I find the 'pool_elt_at_index' is relative addressing . And the 
'pool_base' may change when use the pointer we preserved before.

eg:'pool_elt_at_index (km->profiles, p[0]);'

How can we solve the problem?

Thanks,
Xyxue

___
vpp-dev mailing list
vpp-dev@lists.fd.io
https://lists.fd.io/mailman/listinfo/vpp-dev

Re: [vpp-dev] 'vlib_buffer_alloc' alloc an uninitialized memory

2018-01-04 Thread Dave Barach (dbarach) 
Nothing wrong here AFAICT.

vnet_buffer(b)->sw_if_index[VLIB_RX] = 2, which is plausible. “show int” to 
confirm.

vnet_buffer(b)->sw_if_index[VLIB_TX] = 0x == ~0 == 4294967295 => use 
the interface’s FIB index in ip[46]_lookup.

 sw_if_index = {2, 4294967295},


From: vpp-dev-boun...@lists.fd.io [mailto:vpp-dev-boun...@lists.fd.io] On 
Behalf Of ???
Sent: Thursday, January 4, 2018 1:51 AM
To: vpp-dev 
Subject: [vpp-dev] 'vlib_buffer_alloc' alloc an uninitialized memory


Hi guys,

I'm testing ikev2. In the function 'ikev2_rekey_child_sa_internal',:
bi0 = ikev2_get_new_ike_header_buff (vm, &ike0);
//The following is the debug code
 vlib_buffer_t *b0;
 b0 = vlib_get_buffer (vm, bi0);

   (gdb) p *(vnet_buffer_opaque_t *)(b0->opaque)
$1 = {
  sw_if_index = {2, 4294967295},//The rest of the value is correct
  l2_hdr_offset = 0,
  l3_hdr_offset = 0,
  l4_hdr_offset = 0,


  The wrong may cause an error in 'ip4_lookup_inline '.
  BTW, the problem doesn't happen every time.

Thanks,
Xyxue

___
vpp-dev mailing list
vpp-dev@lists.fd.io
https://lists.fd.io/mailman/listinfo/vpp-dev

[vpp-dev] VPP 18.01 RC1 milestone is complete!

2018-01-04 Thread Dave Wallace 

Folks,

The VPP 18.01 RC1 milestone is complete. The VPP 18.01 release 
branch(stable/1801) has been created, along with the associated nexus 
and packagecloud repo's.


 * vpp master branch is now open for all patches slated for VPP 18.04
   (and beyond).
 * vpp stable/1801 is open for bug fix patches only.

Per the standard process, all bug fixes to the stable branch should 
follow the best practices:


 * All bug fixes must be double-committed to the release throttle as
   well as to the master branch
 o Commit first to the release throttle, then "git cherry-pick"
   into master
 o Manual merges may be required, depending on the degree of
   divergence between throttle and master
 * All bug fixes need to have a Jira ticket
 o Please put Jira IDs into the commit messages.
 o Please use the same Jira ID for both the stable branch and master.

Note: I downloaded and installed the Ubuntu packages for stable/1801 & 
master following the directions on this wiki page: 
https://wiki.fd.io/view/VPP/Installing_VPP_binaries_from_packages


Please let me know if there are any issues downloading/installing the 
centos7 artifacts.

-daw-

ps. Thanks to Florin Coras and Ed Warnicke for their assistance.
___
vpp-dev mailing list
vpp-dev@lists.fd.io
https://lists.fd.io/mailman/listinfo/vpp-dev

[vpp-dev] VPP 18.01 Release Milestone RC2 is Wed 1/10/2018

2018-01-04 Thread Dave Wallace 

Folks,

Just a reminder of VPP 18.01 Release Milestones:

https://wiki.fd.io/view/Projects/vpp/Release_Plans/Release_Plan_18.01#Release_Milestones

VPP 18.01 RC2 is next Wednesday January 10, 2018.

Per the standard process, all bug fixes to the stable branch should 
follow the best practices:


 * All bug fixes must be double-committed to the release throttle as
   well as to the master branch
 o Commit first to the release throttle, then "git cherry-pick"
   into master
 o Manual merges may be required, depending on the degree of
   divergence between throttle and master
 * All bug fixes need to have a Jira ticket
 o Please put Jira IDs into the commit messages.
 o Please use the same Jira ID for both the stable branch and master.

Thanks,
-daw-

___
vpp-dev mailing list
vpp-dev@lists.fd.io
https://lists.fd.io/mailman/listinfo/vpp-dev

Re: [vpp-dev] [tsc] [nsh_sfc-dev] Stepping down as NSH_SFC PTL

2018-01-04 Thread George Zhao 
Hi Danny,
Thanks for your contributions.

I will let Ed correct me if I am wrong, I don’t think PTL need TSC approval,  
but an email thread from project committers voted +1 for Honghui Ni as new PTL.

BR,
George

From: tsc-boun...@lists.fd.io [mailto:tsc-boun...@lists.fd.io] On Behalf Of 
a...@yunify.org
Sent: Friday, January 05, 2018 9:06 AM
To: Zhou, Danny; t...@lists.fd.io; nsh_sfc-...@lists.fd.io
Cc: vpp-dev@lists.fd.io
Subject: Re: [tsc] [nsh_sfc-dev] Stepping down as NSH_SFC PTL

+1

Thanks for all your hard work!

Ash

Ash Young
M: 408-628-7223


On Wed, Jan 3, 2018 at 8:32 PM -0600, "Zhou, Danny" 
mailto:danny.z...@intel.com>> wrote:
Hi TSC,
I've been taking the NSH_SFC PTL role 1 year ago. It has been a pleasure, but 
also a burden as there are some personal reasons make me cannot focus on 
NSH_SFC anymore, so I am stepping down as NSH_SFC PTL with immediate effect. 
Additionally, I would like to nominate Hongjun Ni, who is the most active 
NSH_SFC maintainer in 2017, as new NSH_SFC PTL for his excellent contribution 
as below:

•  Upstreamed 42 patches totally cover Ingress Classifier, SFF, Egress 
Classifier, NSH-Proxy, NSH-aware NAT, MD-Type2, NSH over Ethernet and NSH TTL.

•  Published four NSH_SFC Releases: 17.01, 17.04, 17.07 and 17.10.

NSH_SFC maintainers,

Pls vote for Hongjun Ni by directly replying this email.

-Danny
___
vpp-dev mailing list
vpp-dev@lists.fd.io
https://lists.fd.io/mailman/listinfo/vpp-dev

Re: [vpp-dev] [tsc] [nsh_sfc-dev] Stepping down as NSH_SFC PTL

2018-01-04 Thread Zhou, Danny 
You are right George and Ash.  The process, as pointed by Ed to me before, is 
at https://fd.io/governance/technical-community-charter/#tcc323.

Below are current committers of NSH_SFC project who are eligible to vote.

[cid:image003.jpg@01D38616.1DC41AB0]

From: George Zhao [mailto:george.y.z...@huawei.com]
Sent: Friday, January 5, 2018 9:52 AM
To: a...@yunify.org; Zhou, Danny ; t...@lists.fd.io; 
nsh_sfc-...@lists.fd.io
Cc: vpp-dev@lists.fd.io
Subject: RE: [tsc] [nsh_sfc-dev] Stepping down as NSH_SFC PTL

Hi Danny,
Thanks for your contributions.

I will let Ed correct me if I am wrong, I don’t think PTL need TSC approval,  
but an email thread from project committers voted +1 for Honghui Ni as new PTL.

BR,
George

From: tsc-boun...@lists.fd.io 
[mailto:tsc-boun...@lists.fd.io] On Behalf Of 
a...@yunify.org
Sent: Friday, January 05, 2018 9:06 AM
To: Zhou, Danny; t...@lists.fd.io; 
nsh_sfc-...@lists.fd.io
Cc: vpp-dev@lists.fd.io
Subject: Re: [tsc] [nsh_sfc-dev] Stepping down as NSH_SFC PTL

+1

Thanks for all your hard work!

Ash

Ash Young
M: 408-628-7223

On Wed, Jan 3, 2018 at 8:32 PM -0600, "Zhou, Danny" 
mailto:danny.z...@intel.com>> wrote:
Hi TSC,
I've been taking the NSH_SFC PTL role 1 year ago. It has been a pleasure, but 
also a burden as there are some personal reasons make me cannot focus on 
NSH_SFC anymore, so I am stepping down as NSH_SFC PTL with immediate effect. 
Additionally, I would like to nominate Hongjun Ni, who is the most active 
NSH_SFC maintainer in 2017, as new NSH_SFC PTL for his excellent contribution 
as below:

•  Upstreamed 42 patches totally cover Ingress Classifier, SFF, Egress 
Classifier, NSH-Proxy, NSH-aware NAT, MD-Type2, NSH over Ethernet and NSH TTL.

•  Published four NSH_SFC Releases: 17.01, 17.04, 17.07 and 17.10.

NSH_SFC maintainers,

Pls vote for Hongjun Ni by directly replying this email.

-Danny
___
vpp-dev mailing list
vpp-dev@lists.fd.io
https://lists.fd.io/mailman/listinfo/vpp-dev

Re: [vpp-dev] [nsh_sfc-dev] Stepping down as NSH_SFC PTL

2018-01-04 Thread Zhou, Danny 
+1 for Hongjun

From: a...@yunify.org [mailto:a...@yunify.org]
Sent: Friday, January 5, 2018 9:06 AM
To: Zhou, Danny ; t...@lists.fd.io; 
nsh_sfc-...@lists.fd.io
Cc: vpp-dev@lists.fd.io
Subject: Re: [nsh_sfc-dev] Stepping down as NSH_SFC PTL

+1

Thanks for all your hard work!

Ash

Ash Young
M: 408-628-7223


On Wed, Jan 3, 2018 at 8:32 PM -0600, "Zhou, Danny" 
mailto:danny.z...@intel.com>> wrote:
Hi TSC,
I've been taking the NSH_SFC PTL role 1 year ago. It has been a pleasure, but 
also a burden as there are some personal reasons make me cannot focus on 
NSH_SFC anymore, so I am stepping down as NSH_SFC PTL with immediate effect. 
Additionally, I would like to nominate Hongjun Ni, who is the most active 
NSH_SFC maintainer in 2017, as new NSH_SFC PTL for his excellent contribution 
as below:

l  Upstreamed 42 patches totally cover Ingress Classifier, SFF, Egress 
Classifier, NSH-Proxy, NSH-aware NAT, MD-Type2, NSH over Ethernet and NSH TTL.

l  Published four NSH_SFC Releases: 17.01, 17.04, 17.07 and 17.10.

NSH_SFC maintainers,

Pls vote for Hongjun Ni by directly replying this email.

-Danny
___
vpp-dev mailing list
vpp-dev@lists.fd.io
https://lists.fd.io/mailman/listinfo/vpp-dev

Re: [vpp-dev] [nsh_sfc-dev] Stepping down as NSH_SFC PTL

2018-01-04 Thread Wan, Qun 
+1 for Hongjun

Best Regards,
Anna

From: vpp-dev-boun...@lists.fd.io [mailto:vpp-dev-boun...@lists.fd.io] On 
Behalf Of Zhou, Danny
Sent: Friday, January 5, 2018 11:14 AM
To: a...@yunify.org; t...@lists.fd.io; nsh_sfc-...@lists.fd.io
Cc: vpp-dev@lists.fd.io
Subject: Re: [vpp-dev] [nsh_sfc-dev] Stepping down as NSH_SFC PTL

+1 for Hongjun

From: a...@yunify.org [mailto:a...@yunify.org]
Sent: Friday, January 5, 2018 9:06 AM
To: Zhou, Danny mailto:danny.z...@intel.com>>; 
t...@lists.fd.io; 
nsh_sfc-...@lists.fd.io
Cc: vpp-dev@lists.fd.io
Subject: Re: [nsh_sfc-dev] Stepping down as NSH_SFC PTL

+1

Thanks for all your hard work!

Ash

Ash Young
M: 408-628-7223

On Wed, Jan 3, 2018 at 8:32 PM -0600, "Zhou, Danny" 
mailto:danny.z...@intel.com>> wrote:
Hi TSC,
I've been taking the NSH_SFC PTL role 1 year ago. It has been a pleasure, but 
also a burden as there are some personal reasons make me cannot focus on 
NSH_SFC anymore, so I am stepping down as NSH_SFC PTL with immediate effect. 
Additionally, I would like to nominate Hongjun Ni, who is the most active 
NSH_SFC maintainer in 2017, as new NSH_SFC PTL for his excellent contribution 
as below:

l  Upstreamed 42 patches totally cover Ingress Classifier, SFF, Egress 
Classifier, NSH-Proxy, NSH-aware NAT, MD-Type2, NSH over Ethernet and NSH TTL.

l  Published four NSH_SFC Releases: 17.01, 17.04, 17.07 and 17.10.

NSH_SFC maintainers,

Pls vote for Hongjun Ni by directly replying this email.

-Danny
___
vpp-dev mailing list
vpp-dev@lists.fd.io
https://lists.fd.io/mailman/listinfo/vpp-dev

Re: [vpp-dev] The performance problem of NAT plugin

2018-01-04 Thread Matus Fabian -X (matfabia - PANTHEON TECHNOLOGIES at Cisco) 
I tested ARP with stable/1801 and it works fine
23:20:10.885539 ARP, Request who-has 3.3.3.5 tell 3.3.3.1, length 28
23:20:10.885769 ARP, Reply 3.3.3.5 is-at 08:00:27:c9:ea:36 (oui Unknown), 
length 46

Matus

From: 李洪亮 [mailto:lihongli...@360.cn]
Sent: Friday, December 22, 2017 4:36 PM
To: Matus Fabian -X (matfabia - PANTHEON TECHNOLOGIES at Cisco) 

Cc: vpp-dev@lists.fd.io
Subject: Re: The performance problem of NAT plugin

I find that when I use NAT , the ARP is abnormal;

AS, I use the 3.3.3.5 as the NAT pool address: nat44 add address  3.3.3.5

On target NIC(3.3.3.1), the tcpdump can capture the ARP request without reply:

23:21:57.783994 ARP, Request who-has 3.3.3.5 tell 3.3.3.1, length 28





___
vpp-dev mailing list
vpp-dev@lists.fd.io
https://lists.fd.io/mailman/listinfo/vpp-dev