Re: [vpp-dev] GTPu

[Kingwel Xie]

Hi,

My colleague Liu Anhua has done the patch:

https://gerrit.fd.io/r/#/c/13134/

Couldn’t add Chengqiang as reviewer, gerrit says he/she can not be identified.

Regards,
Kingwel

From: Ni, Hongjun 
Sent: Friday, June 08, 2018 5:54 PM
To: Edward Warnicke ; Kingwel Xie 
; vpp-dev@lists.fd.io
Cc: Yao, Chengqiang 
Subject: RE: [vpp-dev] GTPu

Thanks Kingwei for your effort on improving GTPU plugin.

Please submit some patches and add 
chengqiang@intel.com as one of reviewers.

Thanks,
Hongjun

From: vpp-dev@lists.fd.io 
[mailto:vpp-dev@lists.fd.io] On Behalf Of Edward Warnicke
Sent: Friday, June 8, 2018 10:18 AM
To: Kingwel Xie mailto:kingwel@ericsson.com>>; 
vpp-dev@lists.fd.io
Subject: Re: [vpp-dev] GTPu

Please do push a patch :)

Ed


On June 8, 2018 at 4:16:19 AM, Kingwel Xie 
(kingwel@ericsson.com) wrote:
Hi all,

We are working on improving gtpu plugin, to make it better comply with 3GPP 
standard.

Here is the brief of what we have done:


  1.  Path management – gtpu-process was added
  2.  Error indication
  3.  Bi-direction TEID
  4.  Some bug fixes

I’m thinking of pushing up-stream the improvement. We can make the patch soon. 
Any comments?

Regards,
Kingwel


-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.

View/Reply Online (#9649): https://lists.fd.io/g/vpp-dev/message/9649
Mute This Topic: https://lists.fd.io/mt/21792620/21656
Group Owner: vpp-dev+ow...@lists.fd.io
Unsubscribe: https://lists.fd.io/g/vpp-dev/unsub  [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [vpp-dev] Verify consistently failing

[Ed Kern via Lists.Fd.Io]

I think what Ed meant to do is to speedup verify job without realizing
that test framework does a local install of vpp_papi package which is
part of the source tree.

this is correct.


So having cached virtualenv is a bad idea as
we see already.

dont agree…caching internal bits is certainly bad….I just didnt pick out in the 
rash
of 16 other packages getting installed that papi was getting compiled from the 
tree
as opposed to from local src.
The whole reason that patch and my cache exists is NOT for speed it was for
reliability. (and also not abusing dep code holders (GitHub,pypy,dpdk etc)).  I 
tracked
hundreds of failures where intermittent loss of ability to pull dep packages 
caused
entire build/verification failures.
That number has effectively dropped to zero.


I also wonder whether the caching script watches
changes in test/Makefile/PYTHON_DEPENDS and whether adding or changing
a dependency would pass a verify job.

With every verify run install-dep is run (with ubuntu16 test-dep is also run) 
this would/will
pick up any change


Ed, thoughts? I would suggest not to cache virtualenv at all.


For now im going to continue to cache but after doing so will nuke:
rm -f /var/cache/vpp/python/papi-install.done
rm -f 
/var/cache/vpp/python/virtualenv/lib/python2.7/site-packages/vpp_papi-*-py2.7.egg

the papi-install.done is nastier then I thought.  Even if ole had rev’d the 
papi package test-dep
would have not properly run do to the presence of that file.

On spot testing this will byte-compile with every test-dep on every verify run.
Ive rebuilt the cache image with these changes so we will see the results.  
(things should
already be passing, the only noticeable change will be the byte-compile of papi 
on
each and every test-dep)

Ed



Thanks,
Klement


On Tue, 2018-06-19 at 08:55 +0200, Ole Troan wrote:
Seems like my patch https://gerrit.fd.io/r/#/c/13013/
broke the verification job. I provided a fix, but for some strange
reason it seems like the verifiy build is stuck with the broken
version of the vpp_papi package.
This problem seems to persist even after I reverted 13013 with https:
//gerrit.fd.io/r/#/c/13104/

This is not reproducible locally (since make test uses the correct
python package from the build directory there).
Anyone knows how to reproduce the verify setup (or have an idea of
what's going on?)

Cheers,
Ole








-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.

View/Reply Online (#9648): https://lists.fd.io/g/vpp-dev/message/9648
Mute This Topic: https://lists.fd.io/mt/22427622/21656
Group Owner: vpp-dev+ow...@lists.fd.io
Unsubscribe: https://lists.fd.io/g/vpp-dev/unsub  [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [vpp-dev] vpp project patch verification broken

[Ole Troan]

Hi Ed,

> On 19 Jun 2018, at 17:24, Ed Kern (ejk)  wrote:
> 
> 
> 
>> On Jun 19, 2018, at 7:33 AM, Ole Troan  wrote:
>> 
>> Dave, et al,
>> 
>> Yes, all these are indications of the verify job running a different (and 
>> cached) version of the Python VPP package than the one in build tree.
> 
> yup it certainly is...
> 
>> That stopped working as soon as I changed the in-tree one (and the caching 
>> system picking up and apparently being stuck with a broken version of it). 
>> The fix is of course to always use the in-tree one.
> question for you…did you rev the version number for vpp_papi from 1.4 with 
> your changes?  (because if you rev’d and it still stuck with the old thats a 
> larger problem)

I at least tried to rev it later, if not in first rev of patch. 
Reverting the patch also changed the version number of course. Which didn’t get 
it unstuck. 

> 
> I put that patch in as you have already seen for the python_deps because on 
> at least four different occasions we had builds going bad intermittently 
> because make test-sep pulls over sixteen (yes 16) different packages.
> This was bad and it was breaking things.
> So yes every three days I rebuild the cache (for make install-dep and make 
> test-dep)  I build them into the base build image.
> Any new requirements in-between runs of the cache (additions either of 
> packages or version changes) are still picked up with each and every run 
> (make install-dep and make test-dep are still run with each verify) 

Good!
We could rev vpp_papi on every change, but at least in principle we might not 
want that. 
Since the vpp_papi is in the repo there is certainly an expectation that we can 
rev and develop that just like any other in-repo code. 

I think it’s perfectly fine that the dependencies are in the cache, as long as 
they get updated whenever there is change in requirement. But I don’t think 
vpp_papi should be. (At least not behave as if it was.)

> 
>>  So that local verify behavior matches jenkins one. 
> 
> Well this may not be true for dpdk (since those packages are not built every 
> time)  it should be true for anything else.  Id need to see your gerrit
> to try and parse out why it verified and then failed post merge.

Thanks 
> 
> 
> 
>> But we need someone with access to the verify build. While we’re at it, 
>> would be great to have that documented and accessible...
>> 
> 
> separate conversation (but its one im more than happy to have) on what you 
> would have liked to have access to or documented to make this
> problem faster or easier for you to track down and correct.
> 
> 
> Im now going to poke into removing papi after test-dep so that we dont lose 
> the benefits of having the external deps cached but forcing the build of what 
> should
> be built each and every time.  In this case the vpp-papi.

Yep. Thanks 

Cheers 
Ole
> 
> Ed
> 
> 
> 
> 
>> Cheers 
>> Ole
>> 
>> On 19 Jun 2018, at 15:21, Dave Barach via Lists.Fd.Io 
>>  wrote:
>> 
>>> See, for example, https://gerrit.fd.io/r/#/c/13061. 
>>>
>>> This failure is almost certainly unrelated to the patch. We need to fix 
>>> this 90 seconds ago.
>>>
>>> Thanks... Dave
>>>
>>>
>>> 13:02:17 
>>> ==
>>> 13:02:17 ERROR: IP ACL test
>>> 13:02:17 
>>> --
>>> 13:02:17 Traceback (most recent call last):
>>> 13:02:17   File 
>>> "/w/workspace/vpp-verify-master-ubuntu1604/test/test_classifier.py", line 
>>> 310, in test_acl_ip
>>> 13:02:17 self.create_classify_table('ip', 
>>> self.build_ip_mask(src_ip=''))
>>> 13:02:17   File 
>>> "/w/workspace/vpp-verify-master-ubuntu1604/test/test_classifier.py", line 
>>> 244, in create_classify_table
>>> 13:02:17 current_data_offset=data_offset)
>>> 13:02:17   File 
>>> "/w/workspace/vpp-verify-master-ubuntu1604/test/vpp_papi_provider.py", line 
>>> 2206, in classify_add_del_table
>>> 13:02:17 'mask': mask})
>>> 13:02:17   File 
>>> "/w/workspace/vpp-verify-master-ubuntu1604/test/vpp_papi_provider.py", line 
>>> 160, in api
>>> 13:02:17 reply = api_fn(**api_args)
>>> 13:02:17   File "build/bdist.linux-x86_64/egg/vpp_papi/vpp_papi.py", line 
>>> 104, in __call__
>>> 13:02:17 return self._func(**kwargs)
>>> 13:02:17   File "build/bdist.linux-x86_64/egg/vpp_papi/vpp_papi.py", line 
>>> 398, in f
>>> 13:02:17 return self._call_vpp(i, msg, multipart, **kwargs)
>>> 13:02:17   File "build/bdist.linux-x86_64/egg/vpp_papi/vpp_papi.py", line 
>>> 591, in _call_vpp
>>> 13:02:17 b = msg.pack(kwargs)
>>> 13:02:17   File "build/bdist.linux-x86_64/egg/vpp_papi/vpp_serializer.py", 
>>> line 320, in pack
>>> 13:02:17 b += self.packers[i].pack(data[a], kwargs)
>>> 13:02:17   File "build/bdist.linux-x86_64/egg/vpp_papi/vpp_serializer.py", 
>>> line 171, in pack
>>> 13:02:17 b += self.packer.pack(e)
>>> 13:02:17   File 

Re: [vpp-dev] How to disable assert in VPP

[Damjan Marion]

ASSERT will not cause crash in production image, as it is excluded from 
production builds.
However if ASSERT condition was met than it is good probability that VPP will 
crash shortly after or start to misbehave.

> On 19 Jun 2018, at 04:28, chetan bhasin  wrote:
> 
> Actually assert is fine if we are doing QA testing but if we deploy build at 
> customer site we don't expect there would be a crash, even in error 
> condition,  error code should be return and that code needs to be handled 
> properly. 
> 
> Thanks, 
> Chetan Bhasin 
> 
> On Tue, Jun 19, 2018, 14:32 Ray Kinsella  > wrote:
> Ok - there something we are  missing here.
> Why would you want to do this?
> 
> Ray K
> 
> On 15/06/2018 10:11, chetan bhasin wrote:
> > Hi ,
> > 
> > For deployment , we want to replace assert with error log. Is there a 
> > way in VPP to do that?
> > 
> > Thanks,
> > Chetan
> > 
> 
> 
> 
> 


-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.

View/Reply Online (#9646): https://lists.fd.io/g/vpp-dev/message/9646
Mute This Topic: https://lists.fd.io/mt/22293940/21656
Group Owner: vpp-dev+ow...@lists.fd.io
Unsubscribe: https://lists.fd.io/g/vpp-dev/unsub  [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [vpp-dev] vpp project patch verification broken

[Ed Kern via Lists.Fd.Io]

On Jun 19, 2018, at 7:33 AM, Ole Troan 
mailto:otr...@employees.org>> wrote:

Dave, et al,

Yes, all these are indications of the verify job running a different (and 
cached) version of the Python VPP package than the one in build tree.

yup it certainly is...

That stopped working as soon as I changed the in-tree one (and the caching 
system picking up and apparently being stuck with a broken version of it). The 
fix is of course to always use the in-tree one.
question for you…did you rev the version number for vpp_papi from 1.4 with your 
changes?  (because if you rev’d and it still stuck with the old thats a larger 
problem)

I put that patch in as you have already seen for the python_deps because on at 
least four different occasions we had builds going bad intermittently because 
make test-sep pulls over sixteen (yes 16) different packages.
This was bad and it was breaking things.
So yes every three days I rebuild the cache (for make install-dep and make 
test-dep)  I build them into the base build image.
Any new requirements in-between runs of the cache (additions either of packages 
or version changes) are still picked up with each and every run (make 
install-dep and make test-dep are still run with each verify)

 So that local verify behavior matches jenkins one.

Well this may not be true for dpdk (since those packages are not built every 
time)  it should be true for anything else.  Id need to see your gerrit
to try and parse out why it verified and then failed post merge.



But we need someone with access to the verify build. While we’re at it, would 
be great to have that documented and accessible...


separate conversation (but its one im more than happy to have) on what you 
would have liked to have access to or documented to make this
problem faster or easier for you to track down and correct.


Im now going to poke into removing papi after test-dep so that we dont lose the 
benefits of having the external deps cached but forcing the build of what should
be built each and every time.  In this case the vpp-papi.

Ed




Cheers
Ole

On 19 Jun 2018, at 15:21, Dave Barach via Lists.Fd.Io 
mailto:dbarach=cisco@lists.fd.io>> wrote:

See, for example, https://gerrit.fd.io/r/#/c/13061.

This failure is almost certainly unrelated to the patch. We need to fix this 90 
seconds ago.

Thanks... Dave


13:02:17 
==
13:02:17 ERROR: IP ACL test
13:02:17 
--
13:02:17 Traceback (most recent call last):
13:02:17   File 
"/w/workspace/vpp-verify-master-ubuntu1604/test/test_classifier.py", line 310, 
in test_acl_ip
13:02:17 self.create_classify_table('ip', 
self.build_ip_mask(src_ip=''))
13:02:17   File 
"/w/workspace/vpp-verify-master-ubuntu1604/test/test_classifier.py", line 244, 
in create_classify_table
13:02:17 current_data_offset=data_offset)
13:02:17   File 
"/w/workspace/vpp-verify-master-ubuntu1604/test/vpp_papi_provider.py", line 
2206, in classify_add_del_table
13:02:17 'mask': mask})
13:02:17   File 
"/w/workspace/vpp-verify-master-ubuntu1604/test/vpp_papi_provider.py", line 
160, in api
13:02:17 reply = api_fn(**api_args)
13:02:17   File "build/bdist.linux-x86_64/egg/vpp_papi/vpp_papi.py", line 104, 
in __call__
13:02:17 return self._func(**kwargs)
13:02:17   File "build/bdist.linux-x86_64/egg/vpp_papi/vpp_papi.py", line 398, 
in f
13:02:17 return self._call_vpp(i, msg, multipart, **kwargs)
13:02:17   File "build/bdist.linux-x86_64/egg/vpp_papi/vpp_papi.py", line 591, 
in _call_vpp
13:02:17 b = msg.pack(kwargs)
13:02:17   File "build/bdist.linux-x86_64/egg/vpp_papi/vpp_serializer.py", line 
320, in pack
13:02:17 b += self.packers[i].pack(data[a], kwargs)
13:02:17   File "build/bdist.linux-x86_64/egg/vpp_papi/vpp_serializer.py", line 
171, in pack
13:02:17 b += self.packer.pack(e)
13:02:17   File "build/bdist.linux-x86_64/egg/vpp_papi/vpp_serializer.py", line 
51, in pack
13:02:17 return self.packer.pack(data)
13:02:17 error: cannot convert argument to integer
13:02:17
13:02:17 
==
13:02:17 ERROR: Output IP ACL test
13:02:17 
--
13:02:17 Traceback (most recent call last):
13:02:17   File 
"/w/workspace/vpp-verify-master-ubuntu1604/test/test_classifier.py", line 340, 
in test_acl_ip_out
13:02:17 data_offset=0)
13:02:17   File 
"/w/workspace/vpp-verify-master-ubuntu1604/test/test_classifier.py", line 244, 
in create_classify_table
13:02:17 current_data_offset=data_offset)
13:02:17   File 
"/w/workspace/vpp-verify-master-ubuntu1604/test/vpp_papi_provider.py", line 
2206, in classify_add_del_table
13:02:17 'mask': mask})
13:02:17   File 
"/w/workspace/vpp-verify-master-ubuntu1604/test/vpp_papi_provider.py", line 
160, in api
13:02:17 

Re: [vpp-dev] vpp project patch verification broken

[Ole Troan]

Dave, et al,

Yes, all these are indications of the verify job running a different (and 
cached) version of the Python VPP package than the one in build tree.
That stopped working as soon as I changed the in-tree one (and the caching 
system picking up and apparently being stuck with a broken version of it). The 
fix is of course to always use the in-tree one. So that local verify behavior 
matches jenkins one. 

But we need someone with access to the verify build. While we’re at it, would 
be great to have that documented and accessible...

Cheers 
Ole

> On 19 Jun 2018, at 15:21, Dave Barach via Lists.Fd.Io 
>  wrote:
> 
> See, for example, https://gerrit.fd.io/r/#/c/13061.
>
> This failure is almost certainly unrelated to the patch. We need to fix this 
> 90 seconds ago.
>
> Thanks... Dave
>
>
> 13:02:17 
> ==
> 13:02:17 ERROR: IP ACL test
> 13:02:17 
> --
> 13:02:17 Traceback (most recent call last):
> 13:02:17   File 
> "/w/workspace/vpp-verify-master-ubuntu1604/test/test_classifier.py", line 
> 310, in test_acl_ip
> 13:02:17 self.create_classify_table('ip', 
> self.build_ip_mask(src_ip=''))
> 13:02:17   File 
> "/w/workspace/vpp-verify-master-ubuntu1604/test/test_classifier.py", line 
> 244, in create_classify_table
> 13:02:17 current_data_offset=data_offset)
> 13:02:17   File 
> "/w/workspace/vpp-verify-master-ubuntu1604/test/vpp_papi_provider.py", line 
> 2206, in classify_add_del_table
> 13:02:17 'mask': mask})
> 13:02:17   File 
> "/w/workspace/vpp-verify-master-ubuntu1604/test/vpp_papi_provider.py", line 
> 160, in api
> 13:02:17 reply = api_fn(**api_args)
> 13:02:17   File "build/bdist.linux-x86_64/egg/vpp_papi/vpp_papi.py", line 
> 104, in __call__
> 13:02:17 return self._func(**kwargs)
> 13:02:17   File "build/bdist.linux-x86_64/egg/vpp_papi/vpp_papi.py", line 
> 398, in f
> 13:02:17 return self._call_vpp(i, msg, multipart, **kwargs)
> 13:02:17   File "build/bdist.linux-x86_64/egg/vpp_papi/vpp_papi.py", line 
> 591, in _call_vpp
> 13:02:17 b = msg.pack(kwargs)
> 13:02:17   File "build/bdist.linux-x86_64/egg/vpp_papi/vpp_serializer.py", 
> line 320, in pack
> 13:02:17 b += self.packers[i].pack(data[a], kwargs)
> 13:02:17   File "build/bdist.linux-x86_64/egg/vpp_papi/vpp_serializer.py", 
> line 171, in pack
> 13:02:17 b += self.packer.pack(e)
> 13:02:17   File "build/bdist.linux-x86_64/egg/vpp_papi/vpp_serializer.py", 
> line 51, in pack
> 13:02:17 return self.packer.pack(data)
> 13:02:17 error: cannot convert argument to integer
> 13:02:17
> 13:02:17 
> ==
> 13:02:17 ERROR: Output IP ACL test
> 13:02:17 
> --
> 13:02:17 Traceback (most recent call last):
> 13:02:17   File 
> "/w/workspace/vpp-verify-master-ubuntu1604/test/test_classifier.py", line 
> 340, in test_acl_ip_out
> 13:02:17 data_offset=0)
> 13:02:17   File 
> "/w/workspace/vpp-verify-master-ubuntu1604/test/test_classifier.py", line 
> 244, in create_classify_table
> 13:02:17 current_data_offset=data_offset)
> 13:02:17   File 
> "/w/workspace/vpp-verify-master-ubuntu1604/test/vpp_papi_provider.py", line 
> 2206, in classify_add_del_table
> 13:02:17 'mask': mask})
> 13:02:17   File 
> "/w/workspace/vpp-verify-master-ubuntu1604/test/vpp_papi_provider.py", line 
> 160, in api
> 13:02:17 reply = api_fn(**api_args)
> 13:02:17   File "build/bdist.linux-x86_64/egg/vpp_papi/vpp_papi.py", line 
> 104, in __call__
> 13:02:17 return self._func(**kwargs)
> 13:02:17   File "build/bdist.linux-x86_64/egg/vpp_papi/vpp_papi.py", line 
> 398, in f
> 13:02:17 return self._call_vpp(i, msg, multipart, **kwargs)
> 13:02:17   File "build/bdist.linux-x86_64/egg/vpp_papi/vpp_papi.py", line 
> 591, in _call_vpp
> 13:02:17 b = msg.pack(kwargs)
> 13:02:17   File "build/bdist.linux-x86_64/egg/vpp_papi/vpp_serializer.py", 
> line 320, in pack
> 13:02:17 b += self.packers[i].pack(data[a], kwargs)
> 13:02:17   File "build/bdist.linux-x86_64/egg/vpp_papi/vpp_serializer.py", 
> line 171, in pack
> 13:02:17 b += self.packer.pack(e)
> 13:02:17   File "build/bdist.linux-x86_64/egg/vpp_papi/vpp_serializer.py", 
> line 51, in pack
> 13:02:17 return self.packer.pack(data)
> 13:02:17 error: cannot convert argument to integer
> 13:02:17
> 

-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.

View/Reply Online (#9644): https://lists.fd.io/g/vpp-dev/message/9644
Mute This Topic: https://lists.fd.io/mt/22432813/21656
Group Owner: vpp-dev+ow...@lists.fd.io
Unsubscribe: https://lists.fd.io/g/vpp-dev/unsub  [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-

[vpp-dev] vpp project patch verification broken

[Dave Barach via Lists.Fd.Io]

See, for example, https://gerrit.fd.io/r/#/c/13061.

This failure is almost certainly unrelated to the patch. We need to fix this 90 
seconds ago.

Thanks... Dave


13:02:17 
==
13:02:17 ERROR: IP ACL test
13:02:17 
--
13:02:17 Traceback (most recent call last):
13:02:17   File 
"/w/workspace/vpp-verify-master-ubuntu1604/test/test_classifier.py", line 310, 
in test_acl_ip
13:02:17 self.create_classify_table('ip', 
self.build_ip_mask(src_ip=''))
13:02:17   File 
"/w/workspace/vpp-verify-master-ubuntu1604/test/test_classifier.py", line 244, 
in create_classify_table
13:02:17 current_data_offset=data_offset)
13:02:17   File 
"/w/workspace/vpp-verify-master-ubuntu1604/test/vpp_papi_provider.py", line 
2206, in classify_add_del_table
13:02:17 'mask': mask})
13:02:17   File 
"/w/workspace/vpp-verify-master-ubuntu1604/test/vpp_papi_provider.py", line 
160, in api
13:02:17 reply = api_fn(**api_args)
13:02:17   File "build/bdist.linux-x86_64/egg/vpp_papi/vpp_papi.py", line 104, 
in __call__
13:02:17 return self._func(**kwargs)
13:02:17   File "build/bdist.linux-x86_64/egg/vpp_papi/vpp_papi.py", line 398, 
in f
13:02:17 return self._call_vpp(i, msg, multipart, **kwargs)
13:02:17   File "build/bdist.linux-x86_64/egg/vpp_papi/vpp_papi.py", line 591, 
in _call_vpp
13:02:17 b = msg.pack(kwargs)
13:02:17   File "build/bdist.linux-x86_64/egg/vpp_papi/vpp_serializer.py", line 
320, in pack
13:02:17 b += self.packers[i].pack(data[a], kwargs)
13:02:17   File "build/bdist.linux-x86_64/egg/vpp_papi/vpp_serializer.py", line 
171, in pack
13:02:17 b += self.packer.pack(e)
13:02:17   File "build/bdist.linux-x86_64/egg/vpp_papi/vpp_serializer.py", line 
51, in pack
13:02:17 return self.packer.pack(data)
13:02:17 error: cannot convert argument to integer
13:02:17
13:02:17 
==
13:02:17 ERROR: Output IP ACL test
13:02:17 
--
13:02:17 Traceback (most recent call last):
13:02:17   File 
"/w/workspace/vpp-verify-master-ubuntu1604/test/test_classifier.py", line 340, 
in test_acl_ip_out
13:02:17 data_offset=0)
13:02:17   File 
"/w/workspace/vpp-verify-master-ubuntu1604/test/test_classifier.py", line 244, 
in create_classify_table
13:02:17 current_data_offset=data_offset)
13:02:17   File 
"/w/workspace/vpp-verify-master-ubuntu1604/test/vpp_papi_provider.py", line 
2206, in classify_add_del_table
13:02:17 'mask': mask})
13:02:17   File 
"/w/workspace/vpp-verify-master-ubuntu1604/test/vpp_papi_provider.py", line 
160, in api
13:02:17 reply = api_fn(**api_args)
13:02:17   File "build/bdist.linux-x86_64/egg/vpp_papi/vpp_papi.py", line 104, 
in __call__
13:02:17 return self._func(**kwargs)
13:02:17   File "build/bdist.linux-x86_64/egg/vpp_papi/vpp_papi.py", line 398, 
in f
13:02:17 return self._call_vpp(i, msg, multipart, **kwargs)
13:02:17   File "build/bdist.linux-x86_64/egg/vpp_papi/vpp_papi.py", line 591, 
in _call_vpp
13:02:17 b = msg.pack(kwargs)
13:02:17   File "build/bdist.linux-x86_64/egg/vpp_papi/vpp_serializer.py", line 
320, in pack
13:02:17 b += self.packers[i].pack(data[a], kwargs)
13:02:17   File "build/bdist.linux-x86_64/egg/vpp_papi/vpp_serializer.py", line 
171, in pack
13:02:17 b += self.packer.pack(e)
13:02:17   File "build/bdist.linux-x86_64/egg/vpp_papi/vpp_serializer.py", line 
51, in pack
13:02:17 return self.packer.pack(data)
13:02:17 error: cannot convert argument to integer
13:02:17

-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.

View/Reply Online (#9643): https://lists.fd.io/g/vpp-dev/message/9643
Mute This Topic: https://lists.fd.io/mt/22432813/21656
Group Owner: vpp-dev+ow...@lists.fd.io
Unsubscribe: https://lists.fd.io/g/vpp-dev/unsub  [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [vpp-dev] How to disable assert in VPP

[chetan bhasin]

Actually assert is fine if we are doing QA testing but if we deploy build
at customer site we don't expect there would be a crash, even in error
condition,  error code should be return and that code needs to be handled
properly.

Thanks,
Chetan Bhasin

On Tue, Jun 19, 2018, 14:32 Ray Kinsella  wrote:

> Ok - there something we are  missing here.
> Why would you want to do this?
>
> Ray K
>
> On 15/06/2018 10:11, chetan bhasin wrote:
> > Hi ,
> >
> > For deployment , we want to replace assert with error log. Is there a
> > way in VPP to do that?
> >
> > Thanks,
> > Chetan
> >
>
> 
>
>

-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.

View/Reply Online (#9642): https://lists.fd.io/g/vpp-dev/message/9642
Mute This Topic: https://lists.fd.io/mt/22293940/21656
Group Owner: vpp-dev+ow...@lists.fd.io
Unsubscribe: https://lists.fd.io/g/vpp-dev/unsub  [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [vpp-dev] Verify consistently failing

[Klement Sekera via Lists.Fd.Io]

Hi,

I created a debugging patch set https://gerrit.fd.io/r/#/c/13122/ which
hints that there is something fishy going on with the python
virtualenv.

Per https://jenkins.fd.io/job/vpp-verify-master-ubuntu1604/12067/consol
e: 

10:21:46 make -C test TEST_DIR=/w/workspace/vpp-verify-master-
ubuntu1604/test VPP_TEST_BUILD_DIR=/w/workspace/vpp-verify-master-
ubuntu1604/build-root/build-vpp-native VPP_TEST_BIN=/w/workspace/vpp-
verify-master-ubuntu1604/build-root/install-vpp-native/vpp/bin/vpp
VPP_TEST_PLUGIN_PATH=/w/workspace/vpp-verify-master-ubuntu1604/build-
root/install-vpp-native/vpp/lib/vpp_plugins:/w/workspace/vpp-verify-
master-ubuntu1604/build-root/install-vpp-native/vpp/lib64/vpp_plugins
VPP_TEST_INSTALL_PATH=/w/workspace/vpp-verify-master-ubuntu1604/build-
root/install-vpp-native/ LD_LIBRARY_PATH=/w/workspace/vpp-verify-
master-ubuntu1604/build-root/install-vpp-
native/vpp/lib/:/w/workspace/vpp-verify-master-ubuntu1604/build-
root/install-vpp-native/vpp/lib64/ EXTENDED_TESTS= PYTHON= OS_ID=ubuntu
CACHE_OUTPUT= test
10:21:46 make[2]: Entering directory '/w/workspace/vpp-verify-master-
ubuntu1604/test'
10:21:46 echo "vpp python prefix is /var/cache/vpp/python"
10:21:46 vpp python prefix is /var/cache/vpp/python

Looking at the possible causes of this in the main Makefile we get:

56ccc23f (Ed Kern   2018-04-02 16:42:48 -0600 351)
export VPP_PYTHON_PREFIX ?= $(BR)/python

commit 56ccc23fbc6244190140bd7eb57bfa75f2312c62
Author: Ed Kern 
Date:   Mon Apr 2 16:42:48 2018 -0600

Makefile: Alter VPP_PYTHON_PREFIX for preloading deps

Allow setting of VPP_PYTHON_PREFIX to alternate location
so the python prereqs can be installed into base image
Also added test-dep trigger to isolate dependency install
from actual test run

Change-Id: Ia80f5dbf71bc24eb46cd6586bcadd474ef822704
Signed-off-by: Ed Kern 

I think what Ed meant to do is to speedup verify job without realizing
that test framework does a local install of vpp_papi package which is
part of the source tree. So having cached virtualenv is a bad idea as
we see already. I also wonder whether the caching script watches
changes in test/Makefile/PYTHON_DEPENDS and whether adding or changing
a dependency would pass a verify job.

Ed, thoughts? I would suggest not to cache virtualenv at all.

Thanks,
Klement


On Tue, 2018-06-19 at 08:55 +0200, Ole Troan wrote:
> Seems like my patch https://gerrit.fd.io/r/#/c/13013/
> broke the verification job. I provided a fix, but for some strange
> reason it seems like the verifiy build is stuck with the broken
> version of the vpp_papi package.
> This problem seems to persist even after I reverted 13013 with https:
> //gerrit.fd.io/r/#/c/13104/
> 
> This is not reproducible locally (since make test uses the correct
> python package from the build directory there).
> Anyone knows how to reproduce the verify setup (or have an idea of
> what's going on?)
> 
> Cheers,
> Ole
> 
> 
> 
> 

-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.

View/Reply Online (#9641): https://lists.fd.io/g/vpp-dev/message/9641
Mute This Topic: https://lists.fd.io/mt/22427622/21656
Group Owner: vpp-dev+ow...@lists.fd.io
Unsubscribe: https://lists.fd.io/g/vpp-dev/unsub  [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [vpp-dev] How to disable assert in VPP

[Ray Kinsella]

Ok - there something we are  missing here.
Why would you want to do this?

Ray K

On 15/06/2018 10:11, chetan bhasin wrote:

Hi ,

For deployment , we want to replace assert with error log. Is there a 
way in VPP to do that?


Thanks,
Chetan



-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.

View/Reply Online (#9640): https://lists.fd.io/g/vpp-dev/message/9640
Mute This Topic: https://lists.fd.io/mt/22293940/21656
Group Owner: vpp-dev+ow...@lists.fd.io
Unsubscribe: https://lists.fd.io/g/vpp-dev/unsub  [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-

[vpp-dev] Verify consistently failing

[Ole Troan]

Seems like my patch https://gerrit.fd.io/r/#/c/13013/
broke the verification job. I provided a fix, but for some strange reason it 
seems like the verifiy build is stuck with the broken version of the vpp_papi 
package.
This problem seems to persist even after I reverted 13013 with 
https://gerrit.fd.io/r/#/c/13104/

This is not reproducible locally (since make test uses the correct python 
package from the build directory there).
Anyone knows how to reproduce the verify setup (or have an idea of what's going 
on?)

Cheers,
Ole


-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.

View/Reply Online (#9639): https://lists.fd.io/g/vpp-dev/message/9639
Mute This Topic: https://lists.fd.io/mt/22427622/21656
Group Owner: vpp-dev+ow...@lists.fd.io
Unsubscribe: https://lists.fd.io/g/vpp-dev/unsub  [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-



signature.asc
Description: Message signed with OpenPGP