[vpp-dev] pmalloc: clib_pmalloc_create_shared_arena
Hi dear Damjan, I'm looking at the DPDK IPSec code, and occasionally I got a strange behavior of the memory pools created by dpdk_pool_create. After some time hard debugging, I think there might be a potential overrun issue in clib_pmalloc_create_shared_arena. This is the modified code: return pm->base + ((uword) pp->index << pm->def_log2_page_sz); pp->index is u32, it would wrap after 4 times creation when the page size is 1G. The overlapped va leads to very unexpected result. A patch was created for correction: https://gerrit.fd.io/r/15847 Please take a look at it. Appreciate your comments. Regards, Kingwel -=-=-=-=-=-=-=-=-=-=-=- Links: You receive all messages sent to this group. View/Reply Online (#11189): https://lists.fd.io/g/vpp-dev/message/11189 Mute This Topic: https://lists.fd.io/mt/28070034/21656 Group Owner: vpp-dev+ow...@lists.fd.io Unsubscribe: https://lists.fd.io/g/vpp-dev/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
Re: [vpp-dev] New Committer Nomination: Andrew Yourtchenko
+1 of course. Cheers Ole > On 8 Nov 2018, at 16:01, John Lo (loj) via Lists.Fd.Io > wrote: > > +1 > > -Original Message- > From: vpp-dev@lists.fd.io On Behalf Of Dave Barach via > Lists.Fd.Io > Sent: Thursday, November 08, 2018 7:14 AM > To: vpp-dev@lists.fd.io > Cc: vpp-dev@lists.fd.io > Subject: [vpp-dev] New Committer Nomination: Andrew Yourtchenko > > In view of significant code contributions to the vpp project - see below - > I'm pleased to nominate Andrew Yourtchenko as a vpp project committer. I have > high confidence that he'll be a major asset to the project in a committer > role. > > Andrew has contributed 181 merged patches, including significant new feature > work in the ACL plugin. Example: https://gerrit.fd.io/r/#/c/13162 > > Committers, please vote (+1, 0, -1) on vpp-dev@ We'll need a recorded > vote so that the TSC will approve Andrew's nomination. > > Thanks... Dave > > -=-=-=-=-=-=-=-=-=-=-=- > Links: You receive all messages sent to this group. > > View/Reply Online (#11169): https://lists.fd.io/g/vpp-dev/message/11169 > Mute This Topic: https://lists.fd.io/mt/28035544/675193 > Group Owner: vpp-dev+ow...@lists.fd.io > Unsubscribe: https://lists.fd.io/g/vpp-dev/unsub [otr...@employees.org] > -=-=-=-=-=-=-=-=-=-=-=- -=-=-=-=-=-=-=-=-=-=-=- Links: You receive all messages sent to this group. View/Reply Online (#11188): https://lists.fd.io/g/vpp-dev/message/11188 Mute This Topic: https://lists.fd.io/mt/28035544/21656 Group Owner: vpp-dev+ow...@lists.fd.io Unsubscribe: https://lists.fd.io/g/vpp-dev/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
Re: [vpp-dev] [tsc] Project Proposal for Sweetcomb
Congratulations! Ed On Thu, Nov 8, 2018 at 9:32 PM Ni, Hongjun wrote: > Hi all, > > > > Sweetcomb project has been approved by FD.io TSC. > > And project creation has been completed. > > Thank you all for your great help to make this happen! > > > > Below is the project resource: > > > > Committers group: fdio-gerrit-sweetcomb-committers Invites sent to the > initial committers: > https://wiki.fd.io/view/Project_Proposals/Sweetcomb#Initial_Committers > > JIRA: https://jira.fd.io/projects/SWEET/issues > > Jenkins: https://jenkins.fd.io/view/sweetcomb/ > > Gerrit: https://gerrit.fd.io/r/#/admin/projects/sweetcomb > > Groups.io: https://lists.fd.io/g/sweetcomb-dev > > GitHub Replication: https://github.com/FDio/sweetcomb > > > > We also have submitted initial code for IPR Review. > > https://gerrit.fd.io/r/#/c/15835/ Initial code checkin for Sweetcomb > project > > > > The initial code is contributed by HuachenTel, and we help to refactor it. > > If you have any concern, please raise it in project mail list: > sweetcomb-...@lists.fd.io > > > > Thank you again, > > Hongjun > > > > *From:* t...@lists.fd.io [mailto:t...@lists.fd.io] *On Behalf Of *Ni, > Hongjun > *Sent:* Thursday, November 8, 2018 10:57 PM > *To:* Ni, Hongjun ; Edward Warnicke < > hagb...@gmail.com> > *Cc:* t...@lists.fd.io; vpp-dev@lists.fd.io; Wang, Drenfong < > drenfong.w...@intel.com>; ??? ; > chen...@huachentel.com; lizhuo...@cmhi.chinamobile.com; ??? < > lihf...@chinaunicom.cn>; zhijl@chinatelecom.cn; changlin...@nxp.com; > Wang Tianyi ; davidfgao(?? ; > lixin...@huachentel.com; jingqing@alibaba-inc.com; gu.ji...@zte.com.cn; > Jerome Tollet (jtollet) > *Subject:* Re: [vpp-dev] [tsc] Project Proposal for Sweetcomb > > > > Hi TSC members, > > > > Our Initial code has been refactored and gone through internal legal > review. > > > > How can we submit the code to the fd.io Foundation for IPR Review? > > > > Thanks, > > Hongjun > > > > *From:* vpp-dev@lists.fd.io [mailto:vpp-dev@lists.fd.io > ] *On Behalf Of *Ni, Hongjun > *Sent:* Thursday, November 8, 2018 12:04 PM > *To:* Ni, Hongjun ; Edward Warnicke < > hagb...@gmail.com> > *Cc:* t...@lists.fd.io; vpp-dev@lists.fd.io; Wang, Drenfong < > drenfong.w...@intel.com>; ??? ; > chen...@huachentel.com; lizhuo...@cmhi.chinamobile.com; ??? < > lihf...@chinaunicom.cn>; zhijl@chinatelecom.cn; changlin...@nxp.com; > Wang Tianyi ; davidfgao(?? ; > lixin...@huachentel.com; jingqing@alibaba-inc.com; gu.ji...@zte.com.cn; > Jerome Tollet (jtollet) > *Subject:* Re: [vpp-dev] [tsc] Project Proposal for Sweetcomb > > > > > > Welcome Cisco to join Sweetcomb project! > > > > https://wiki.fd.io/view/Project_Proposals/Sweetcomb > > > > Thanks a lot, > > Hongjun > > > > *From:* t...@lists.fd.io [mailto:t...@lists.fd.io ] *On > Behalf Of *Ni, Hongjun > *Sent:* Thursday, November 1, 2018 8:40 AM > *To:* Ni, Hongjun ; Edward Warnicke < > hagb...@gmail.com> > *Cc:* t...@lists.fd.io; vpp-dev@lists.fd.io; Wang, Drenfong < > drenfong.w...@intel.com>; ??? ; > chen...@huachentel.com; lizhuo...@cmhi.chinamobile.com; ??? < > lihf...@chinaunicom.cn>; zhijl@chinatelecom.cn; changlin...@nxp.com; > Wang Tianyi ; davidfgao(?? ; > lixin...@huachentel.com; jingqing@alibaba-inc.com; gu.ji...@zte.com.cn > *Subject:* Re: [vpp-dev] [tsc] Project Proposal for Sweetcomb > > > > > > Welcome ZTE to join! > > > > Thanks, > > Hongjun > > > > *From:* vpp-dev@lists.fd.io [mailto:vpp-dev@lists.fd.io > ] *On Behalf Of *Ni, Hongjun > *Sent:* Thursday, October 25, 2018 9:22 AM > *To:* Edward Warnicke > *Cc:* t...@lists.fd.io; vpp-dev@lists.fd.io; Wang, Drenfong < > drenfong.w...@intel.com>; ??? ; > chen...@huachentel.com; lizhuo...@cmhi.chinamobile.com; ??? < > lihf...@chinaunicom.cn>; zhijl@chinatelecom.cn; changlin...@nxp.com; > Wang Tianyi ; davidfgao(?? ; > lixin...@huachentel.com; jingqing@alibaba-inc.com > *Subject:* Re: [vpp-dev] [tsc] Project Proposal for Sweetcomb > > > > Hi all, > > > > Some guys are asking for the original code in private. > > Here is our answer: > > > > We are working on reworking the original code, and doing internal legal > review. > > When it is done, we will submit the code to FD.io community for IPR > review in one or two weeks. > > > > Thanks a lot, > > Hongjun > > > > *From:* vpp-dev@lists.fd.io [mailto:vpp-dev@lists.fd.io > ] *On Behalf Of *Edward Warnicke > *Sent:* Tuesday, October 23, 2018 9:47 PM > *To:* Ni, Hongjun > *Cc:* t...@lists.fd.io; vpp-dev@lists.fd.io; Wang, Drenfong < > drenfong.w...@intel.com>; ??? ; > chen...@huachentel.com; lizhuo...@cmhi.chinamobile.com; ??? < > lihf...@chinaunicom.cn>; zhijl@chinatelecom.cn; changlin...@nxp.com; > Wang Tianyi ; davidfgao(?? ; > lixin...@huachentel.com; jingqing@alibaba-inc.com > *Subject:* Re: [vpp-dev] [tsc] Project Proposal for Sweetcomb > > > > I look forward to it :) > > > > Ed > > > > On Tue, Oct 23, 2018 at 8:42 AM Ni, Hongjun wrote: > > Hi Ed, > > > > OK. I or some project proposer will join the
Re: [vpp-dev] fragment error in ip4_input.h
That makes sense. Thank you for your reply. Best regards yongong | blanks...@163.com | On 11/9/2018 17:10，Ole Troan wrote： On 9 Nov 2018, at 15:42, blankspot wrote: hi, vpp dev I am doing some fragment test using vpp 18.07. IP4 Packet with offset 8 is dropped with trace error: 00:20:04:661292: error-drop ip4-input: ip4 fragment offset == 1 I find the comment in ip4_input.h: /* Drop fragmentation offset 1 packets. */ Does someone know why? Because it’s a tiny fragment attack? Cheers Ole Best regards, yonggong | blanks...@163.com | 签名由网易邮箱大师定制 -=-=-=-=-=-=-=-=-=-=-=- Links: You receive all messages sent to this group. View/Reply Online (#11183): https://lists.fd.io/g/vpp-dev/message/11183 Mute This Topic: https://lists.fd.io/mt/28046882/675193 Group Owner: vpp-dev+ow...@lists.fd.io Unsubscribe: https://lists.fd.io/g/vpp-dev/unsub [otr...@employees.org] -=-=-=-=-=-=-=-=-=-=-=- -=-=-=-=-=-=-=-=-=-=-=- Links: You receive all messages sent to this group. View/Reply Online (#11186): https://lists.fd.io/g/vpp-dev/message/11186 Mute This Topic: https://lists.fd.io/mt/28046882/21656 Group Owner: vpp-dev+ow...@lists.fd.io Unsubscribe: https://lists.fd.io/g/vpp-dev/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
Re: [vpp-dev] fragment error in ip4_input.h
> On 9 Nov 2018, at 15:42, blankspot wrote: > > hi, vpp dev > > I am doing some fragment test using vpp 18.07. IP4 Packet with offset 8 is > dropped with trace error: > > 00:20:04:661292: error-drop > ip4-input: ip4 fragment offset == 1 > > I find the comment in ip4_input.h: /* Drop fragmentation offset 1 packets. */ > > Does someone know why? Because it’s a tiny fragment attack? Cheers Ole > > Best regards, > > yonggong > > blanks...@163.com > > 签名由 网易邮箱大师 定制 > -=-=-=-=-=-=-=-=-=-=-=- > Links: You receive all messages sent to this group. > > View/Reply Online (#11183): https://lists.fd.io/g/vpp-dev/message/11183 > Mute This Topic: https://lists.fd.io/mt/28046882/675193 > Group Owner: vpp-dev+ow...@lists.fd.io > Unsubscribe: https://lists.fd.io/g/vpp-dev/unsub [otr...@employees.org] > -=-=-=-=-=-=-=-=-=-=-=- -=-=-=-=-=-=-=-=-=-=-=- Links: You receive all messages sent to this group. View/Reply Online (#11185): https://lists.fd.io/g/vpp-dev/message/11185 Mute This Topic: https://lists.fd.io/mt/28046882/21656 Group Owner: vpp-dev+ow...@lists.fd.io Unsubscribe: https://lists.fd.io/g/vpp-dev/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
Re: [vpp-dev] #vpp sctp echo test crash
Florin, Your patch addresses the TCP issue.Now back to SCTP... ;( Cheers,Marco On Thu, 2018-11-08 at 14:02 -0800, Florin Coras wrote: > Hm, I suspect in case of TCP it may be an overlap between unit tests and the > throughput test. I’ve separated them here. Can you try it out with 500M > locally? It works fine on my box, but maybe it has to do with the hardware it > runs on. > > Thanks, > Florin > > [1] https://gerrit.fd.io/r/#/c/15833/ > > On Nov 8, 2018, at 1:29 PM, Marco Varlese wrote: > > > > It finishes with errors (stating 3 tests failed). Same behavior as seen with > > SCTP so I'm now guessing that's rather an issue with the test code (either > > client or server) or with the session layer (doubt that since VCL works)?? > > > > Thoughts? > > Marco Varlese > > > > On Nov 8, 2018 22:06, Florin Coras wrote: > > > Hi Marco, > > > So echo test with 500MB does finish and reports throughput after 15s but > > > with warnings of the type “clients stuck”? > > > > > > Note that we also have tests that run iperf3 for about 5s and those > > > exchange GB of data probably. > > > > > > Florin > > > > > > > On Nov 8, 2018, at 12:55 PM, Marco Varlese wrote: > > > > > > Well, folks there's something strange here... > > > I was trying to understand what's going on with SCTP and (because I > > > couldn't see the light) I decided to give TCP a try. > > > I hence modified test_tcp.py to have 500 mbytes to send and the test > > > fails. Similarly to what happens for SCTP. I did try to increase the test- > > > timeout but without much success... > > > Interestingly, for both TCP and SCTP, with a test-timeout of 30 seconds > > > the test completes (with errors) after round 12-15 secs... > > > On Thu, 2018-11-08 at 08:21 -0800, Florin Coras wrote: > > > > Hi guys, > > > > I unfortunately missed this. Yes, the fifo size provided is the number > > > > of kB and yes you should be able to do 4MB (fifo-size 4096) or even > > > > higher. > > > > > > > > The “stuck clients” warning is just a notification, the test can still > > > > finish. To make sure you give the test enough time, add “test-timeout > > > > ” to the list of parameters. > > > > > > > > Florin > > > > > > > > > On Nov 8, 2018, at 5:46 AM, Yao, Chengqiang > > > > > wrote: > > > > > > > > > > Hi Macro, Seems the max workable fifo-size in test_sctp.py is 16. With > > > > > fifo-size in test_sctp.py set to 16, the throughput is only 4Gbps (VPP > > > > > is under release mode), I think the real number should be more than > > > > > this if we can increase both fifo-size and mbytes in test_sctp.py. -=-=-=-=-=-=-=-=-=-=-=- Links: You receive all messages sent to this group. View/Reply Online (#11184): https://lists.fd.io/g/vpp-dev/message/11184 Mute This Topic: https://lists.fd.io/mt/28023358/21656 Mute #vpp: https://lists.fd.io/mk?hashtag=vpp=1480452 Group Owner: vpp-dev+ow...@lists.fd.io Unsubscribe: https://lists.fd.io/g/vpp-dev/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
[vpp-dev] fragment error in ip4_input.h
hi, vpp dev I am doing some fragment test using vpp 18.07. IP4 Packet with offset 8 is dropped with trace error: 00:20:04:661292: error-drop ip4-input: ip4 fragment offset == 1 I find the comment in ip4_input.h: /* Drop fragmentation offset 1 packets. */ Does someone know why? Best regards, yonggong | blanks...@163.com | 签名由网易邮箱大师定制-=-=-=-=-=-=-=-=-=-=-=- Links: You receive all messages sent to this group. View/Reply Online (#11183): https://lists.fd.io/g/vpp-dev/message/11183 Mute This Topic: https://lists.fd.io/mt/28046882/21656 Group Owner: vpp-dev+ow...@lists.fd.io Unsubscribe: https://lists.fd.io/g/vpp-dev/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
Re: [vpp-dev] PPPoE plugin documentation/support
Yes, that seems to be the problem. The control plane interface is dropping the replies with error "L3 MAC MISMATCH". How do I set the interface to l2? Using the command " set interface l2 bridge 1" is not working, as it starts to drop the PADI packets also. After using the above mentioned command: Packet 1 01:11:18:827637: vhost-user-input VirtualEthernet0/0/0 queue 0 virtio flags: INDIRECT Indirect descriptor virtio_net_hdr first_desc_len 12 flags 0x00 gso_type 0 num_buff 0 01:11:18:827641: ethernet-input PPPOE_DISCOVERY: 52:54:00:cc:3a:0e -> ff:ff:ff:ff:ff:ff 01:11:18:827643: l2-input l2-input: sw_if_index 3 dst ff:ff:ff:ff:ff:ff src 52:54:00:cc:3a:0e 01:11:18:827644: l2-learn l2-learn: sw_if_index 3 dst ff:ff:ff:ff:ff:ff src 52:54:00:cc:3a:0e bd_index 1 01:11:18:827646: error-drop l2-flood: L2 replication complete Regards, Alp Arslan -Original Message- From: vpp-dev@lists.fd.io [mailto:vpp-dev@lists.fd.io] On Behalf Of Ni, Hongjun Sent: Thursday, November 8, 2018 5:18 PM To: alp.ars...@xflowresearch.com; vpp-dev@lists.fd.io Subject: Re: [vpp-dev] PPPoE plugin documentation/support Hi alp arslan, It works in my server. Below is my configuration: vpp# set int state TenGigabitEthernet5/0/0 up vpp# set int ip table TenGigabitEthernet5/0/0 0 vpp# set int ip address TenGigabitEthernet5/0/0 100.1.1.3/32 vpp# vpp# set int state TenGigabitEthernet5/0/1 up vpp# set int ip table TenGigabitEthernet5/0/1 0 vpp# set int ip address TenGigabitEthernet5/0/1 100.1.1.200/32 vpp# ip route add 100.1.1.100/24 via 100.1.1.4 TenGigabitEthernet5/0/1 vpp# set ip arp TenGigabitEthernet5/0/1 100.1.1.100 ..0001 vpp# vpp# create pppoe cp cp-if-index 2 vpp# vpp# trace add dpdk-input 10 //Then you sent PADI packet: vpp# vpp# sh trace --- Start of thread 0 vpp_main --- Packet 1 00:00:49:834924: dpdk-input TenGigabitEthernet5/0/0 rx queue 0 buffer 0xa4e03: current data 0, length 60, free-list 0, clone-count 0, totlen-nifb 0, trace 0x0 ext-hdr-valid l4-cksum-computed l4-cksum-correct l2-hdr-offset 0 PKT MBUF: port 0, nb_segs 1, pkt_len 60 buf_len 2176, data_len 60, ol_flags 0x180, data_off 128, phys_addr 0x6dd38140 packet_type 0x1 l2_len 0 l3_len 0 outer_l2_len 0 outer_l3_len 0 rss 0x0 fdir.hi 0x0 fdir.lo 0x0 Packet Offload Flags PKT_RX_IP_CKSUM_GOOD (0x0080) IP cksum of RX pkt. is valid PKT_RX_L4_CKSUM_GOOD (0x0100) L4 cksum of RX pkt. is valid Packet Types RTE_PTYPE_L2_ETHER (0x0001) Ethernet packet PPPOE_DISCOVERY: 00:11:01:00:00:01 -> ff:ff:ff:ff:ff:ff 00:00:49:834959: ethernet-input PPPOE_DISCOVERY: 00:11:01:00:00:01 -> ff:ff:ff:ff:ff:ff 00:00:49:834978: pppoe-cp-dispatch PPPoE dispatch from sw_if_index -1 next 1 error 0 pppoe_code 0x9 ppp_proto 0x101 00:00:49:835469: TenGigabitEthernet5/0/1-output TenGigabitEthernet5/0/1 PPPOE_DISCOVERY: 00:11:01:00:00:01 -> ff:ff:ff:ff:ff:ff 00:00:49:835473: TenGigabitEthernet5/0/1-tx TenGigabitEthernet5/0/1 tx queue 0 buffer 0xa4e03: current data 0, length 60, free-list 0, clone-count 0, totlen-nifb 0, trace 0x0 ext-hdr-valid l4-cksum-computed l4-cksum-correct l2-hdr-offset 0 l3-hdr-offset 14 PKT MBUF: port 0, nb_segs 1, pkt_len 60 buf_len 2176, data_len 60, ol_flags 0x180, data_off 128, phys_addr 0x6dd38140 packet_type 0x1 l2_len 0 l3_len 0 outer_l2_len 0 outer_l3_len 0 rss 0x0 fdir.hi 0x0 fdir.lo 0x0 Packet Offload Flags PKT_RX_IP_CKSUM_GOOD (0x0080) IP cksum of RX pkt. is valid PKT_RX_L4_CKSUM_GOOD (0x0100) L4 cksum of RX pkt. is valid Packet Types RTE_PTYPE_L2_ETHER (0x0001) Ethernet packet PPPOE_DISCOVERY: 00:11:01:00:00:01 -> ff:ff:ff:ff:ff:ff vpp# vpp# vpp# sh pppoe session No pppoe sessions configured... vpp# vpp# sh pppoe fib no pppoe fib entries vpp# vpp# //Then you need to configure pppoe session: vpp# create pppoe session client-ip 100.1.1.2 session-id 1 client-mac 00:11:01:00:00:01 pppoe_session0 vpp# sh pppoe fib Mac-Address session_id sw_if_index session_index 00:11:01:00:00:01 1 1 0 1 pppoe fib entries vpp# vpp# sh pppoe session [0] sw-if-index 3 client-ip 100.1.1.2 session-id 1 encap-if-index 1 decap-fib-index 0 local-mac 90:e2:ba:48:7a:80 client-mac 00:11:01:00:00:01 //For l3 mac mismatch, maybe you need to set your control interface to l2 mode. Thanks, Hongjun -Original Message- From: alp.ars...@xflowresearch.com [mailto:alp.ars...@xflowresearch.com] Sent: Thursday, November 8, 2018 6:38 PM To: Ni, Hongjun ; vpp-dev@lists.fd.io Subject: RE: [vpp-dev] PPPoE plugin documentation/support Still waiting on this. Can anyone help me on this one? -Original Message- From: Muhammad Alp Arslan (alp.ars...@xflowresearch.com) [mailto:alp.ars...@xflowresearch.com] Sent: Friday, November 2, 2018 4:07 PM To: 'Ni, Hongjun'; 'vpp-dev@lists.fd.io' Subject:
