Re: [vpp-dev] About lock-free operation in policer

2019-01-14 Thread Kingwel Xie
Simply because most CLI commands and API handlers are marked as not is_mp_safe, 
hence they are actually protected by vlib_worker_thread_barrier_sync.

So to speak, node functions are temporally stopped and waiting when CLI/API is 
being executed.

You should take a look at: vlib_worker_thread_barrier_sync/ 
vlib_worker_thread_barrier_release

Regards,
Kingwel

From: vpp-dev@lists.fd.io  On Behalf Of blankspot
Sent: Tuesday, January 15, 2019 3:00 PM
To: vpp-dev 
Subject: [vpp-dev] About lock-free operation in policer

hi all,

I have a question about policer classify.
The code of bind/unbind a policer with interface is:

  if (is_add)
pcm->classify_table_index_by_sw_if_index[ti][sw_if_index] = pct[ti];
  else
pcm->classify_table_index_by_sw_if_index[ti][sw_if_index] = ~0;

and the code checking the value in "ip4-policer-classify" node is:

table_index0 =
pcm->classify_table_index_by_sw_if_index[tid][sw_if_index0];

There is no lock protecting the table index.

The function of policer is ok in multi-thread vpp, but I don't know why it is 
lock-free.
Can any one help?

Thanks.

yonggong
-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.

View/Reply Online (#11919): https://lists.fd.io/g/vpp-dev/message/11919
Mute This Topic: https://lists.fd.io/mt/2915/21656
Group Owner: vpp-dev+ow...@lists.fd.io
Unsubscribe: https://lists.fd.io/g/vpp-dev/unsub  [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-


[vpp-dev] VNET classifier table/session

2019-01-14 Thread Harish Patil
Hi,

Can you please provide few examples (with right syntax and little
explanation) on to how to use VNET classify table and classify session in
relatively older VPP releases.

 "classify table [miss-next|l2-miss_next|acl-miss-next ]"
 "\n mask  buckets  [skip ] [match ] [del]",


"classify session [hit-next|l2-hit-next|acl-hit-next ]"
   "\n table-index  match [hex] [l2] [l3 ip4] [opaque-index ]",
Thanks,

Harish
-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.

View/Reply Online (#11918): https://lists.fd.io/g/vpp-dev/message/11918
Mute This Topic: https://lists.fd.io/mt/29122272/21656
Group Owner: vpp-dev+ow...@lists.fd.io
Unsubscribe: https://lists.fd.io/g/vpp-dev/unsub  [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-


[vpp-dev] About lock-free operation in policer

2019-01-14 Thread blankspot
hi all,


I have a question about policer classify.
The code of bind/unbind a policer with interface is:  


  if (is_add)
pcm->classify_table_index_by_sw_if_index[ti][sw_if_index] = pct[ti];
  else
pcm->classify_table_index_by_sw_if_index[ti][sw_if_index] = ~0;


and the code checking the value in "ip4-policer-classify" node is: 


table_index0 =
pcm->classify_table_index_by_sw_if_index[tid][sw_if_index0];


There is no lock protecting the table index.


The function of policer is ok in multi-thread vpp, but I don't know why it is 
lock-free.
Can any one help?


Thanks.


yonggong  -=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.

View/Reply Online (#11917): https://lists.fd.io/g/vpp-dev/message/11917
Mute This Topic: https://lists.fd.io/mt/2915/21656
Group Owner: vpp-dev+ow...@lists.fd.io
Unsubscribe: https://lists.fd.io/g/vpp-dev/unsub  [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-


[vpp-dev] GoVPP

2019-01-14 Thread Abeeha Aqeel
Hi,

I have been trying to implement a simple VPP management application which uses 
the go bindings generated by GoVPP. The simple-client given in GoVPP works fine 
but I’ve been trying to add additional functionalities to it. 

I followed a sample go program from 
https://www.marosmars.com/blog/managing-vpp-go-edition blog but when I build 
the program it gives me the following errors: 



My operating system is Centos 7 and I have installed VPP 19.01,  go1.11.4 and 
GoVPP.
I was wondering if anyone could help me with this problem. 
Thanks in advance!

Regards,
Abeeha Aqeel

-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.

View/Reply Online (#11916): https://lists.fd.io/g/vpp-dev/message/11916
Mute This Topic: https://lists.fd.io/mt/29122154/21656
Group Owner: vpp-dev+ow...@lists.fd.io
Unsubscribe: https://lists.fd.io/g/vpp-dev/unsub  [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-


Re: [vpp-dev] Issues running vpp #vpp

2019-01-14 Thread Ray Kinsella
VPP isn't running for some reason, hence you can't connect to it.

Ray K

On 14/01/2019 16:08, Abdul Hadi wrote:
> Hi All,
> 
> I suddenly have this problem of not being able to run vpp. Tried both
> building and installing myself and using also vagrant as well. Both
> scenarios end up with the same error which is
> clib_socket_init: connect (fd 3, '/run/vpp/cli.sock'): No such file or
> directory
> 
> Can any one help? if there is anything new that i am not aware of?
> 
> i am following everything at
> https://wiki.fd.io/view/VPP/Pulling,_Building,_Running,_Hacking_and_Pushing_VPP_Code#Subsequent_Builds.27
> 
> Thanks in advance!
> Hadi
> 
> -=-=-=-=-=-=-=-=-=-=-=-
> Links: You receive all messages sent to this group.
> 
> View/Reply Online (#11912): https://lists.fd.io/g/vpp-dev/message/11912
> Mute This Topic: https://lists.fd.io/mt/29080648/675355
> Mute #vpp: https://lists.fd.io/mk?hashtag=vpp=1480675
> Group Owner: vpp-dev+ow...@lists.fd.io
> Unsubscribe: https://lists.fd.io/g/vpp-dev/unsub  [m...@ashroe.eu]
> -=-=-=-=-=-=-=-=-=-=-=-
> 



signature.asc
Description: OpenPGP digital signature
-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.

View/Reply Online (#11915): https://lists.fd.io/g/vpp-dev/message/11915
Mute This Topic: https://lists.fd.io/mt/29080648/21656
Mute #vpp: https://lists.fd.io/mk?hashtag=vpp=1480452
Group Owner: vpp-dev+ow...@lists.fd.io
Unsubscribe: https://lists.fd.io/g/vpp-dev/unsub  [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-


[vpp-dev] Reminder: VPP Release 19.01 RC1 date is this Wednesday 16th January 2019

2019-01-14 Thread Andrew Yourtchenko
Hi all,

A reminder that the RC1 branch [1] is this Wednesday 16th January at 18:00 UTC.

We’re still accepting low-risk patches on master ahead of the branch.

[1] https://wiki.fd.io/view/Projects/vpp/Release_Plans/Release_Plan_19.01

--a
-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.

View/Reply Online (#11914): https://lists.fd.io/g/vpp-dev/message/11914
Mute This Topic: https://lists.fd.io/mt/29081899/21656
Group Owner: vpp-dev+ow...@lists.fd.io
Unsubscribe: https://lists.fd.io/g/vpp-dev/unsub  [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-


Re: [vpp-dev] Issues running vpp #vpp

2019-01-14 Thread Paul Vinciguerra
You probably need to either run VPP as root or specify an alternate file 
location that your user can write to in your config. 
cli-listen /run/vpp/cli.sock
-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.

View/Reply Online (#11913): https://lists.fd.io/g/vpp-dev/message/11913
Mute This Topic: https://lists.fd.io/mt/29080648/21656
Mute #vpp: https://lists.fd.io/mk?hashtag=vpp=1480452
Group Owner: vpp-dev+ow...@lists.fd.io
Unsubscribe: https://lists.fd.io/g/vpp-dev/unsub  [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-


[vpp-dev] Issues running vpp #vpp

2019-01-14 Thread Abdul Hadi
Hi All,

I suddenly have this problem of not being able to run vpp. Tried both building 
and installing myself and using also vagrant as well. Both scenarios end up 
with the same error which is
clib_socket_init: connect (fd 3, '/run/vpp/cli.sock'): No such file or directory

Can any one help? if there is anything new that i am not aware of?

i am following everything at 
https://wiki.fd.io/view/VPP/Pulling,_Building,_Running,_Hacking_and_Pushing_VPP_Code#Subsequent_Builds.27

Thanks in advance!
Hadi
-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.

View/Reply Online (#11912): https://lists.fd.io/g/vpp-dev/message/11912
Mute This Topic: https://lists.fd.io/mt/29080648/21656
Mute #vpp: https://lists.fd.io/mk?hashtag=vpp=1480452
Group Owner: vpp-dev+ow...@lists.fd.io
Unsubscribe: https://lists.fd.io/g/vpp-dev/unsub  [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-


Re: [vpp-dev] Using prefetch and buffer_enqueue

2019-01-14 Thread Damjan Marion via Lists.Fd.Io


> On 10 Jan 2019, at 07:15, Raj  wrote:
> 
> On Wed, Jan 9, 2019 at 4:18 PM Damjan Marion  wrote:
>>> On 9 Jan 2019, at 09:53, Raj  wrote:
>>> 1.   static_always_inline void
>>>  vlib_buffer_enqueue_to_next (vlib_main_t * vm, vlib_node_runtime_t * node,
>>>   u32 * buffers, u16 * nexts, uword count)
>>> 
>> 
>> This function simply gets array of buffer indices and array of next indices,
>> and enqueues those buffers to be processed by those next nodes...
> 
> Is this function only used in the case of feature arc, where some
> packets satisfies certain criteria and moves to a different node?
> Basically from where do we get the array of next indices?

No, it can be used without feature arcs.

> 
> Also in the code certain macros CLIB_HAVE_VEC128, CLIB_HAVE_VEC256 and
> CLIB_HAVE_VEC512 are defined. I could not figure out what these do.

They don't do anything, they are just set or not set depending on availability 
of
vector instructions on the target cpu.


> 
>>> type can be either LOAD or STORE. What is the purpose of these two 
>>> operations?
>> On x86, there was only load prefetch for a long time, recently store 
>> prefetch is introduced
>> with Skylake microarchitecture. You can find explanation here:
> 
> Based on code walkthrough, one thing I have observed is where ever
> .function is defined, static binding happens. In other nodes, dynamic
> binding based on the macro VLIB_NODE_FN happens.

yep

> So If I understand
> correctly, we have to use STORE in the latter case. But we can use
> LOAD as well. There is no hard and fast rule. Please correct me if I'm
> wrong.

It is good practice to pick the one which you really need. i.e. if you want to 
prefetch for 
store, just use STORE, if store is not available compiler will do LOAD 
instead...

-- 
Damjan

-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.

View/Reply Online (#11911): https://lists.fd.io/g/vpp-dev/message/11911
Mute This Topic: https://lists.fd.io/mt/28982509/21656
Group Owner: vpp-dev+ow...@lists.fd.io
Unsubscribe: https://lists.fd.io/g/vpp-dev/unsub  [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-


Re: [SUSPECTED SPAM] [vpp-dev] IPFIX Nat Logging

2019-01-14 Thread emma sdi
Dear Ole,

No I don't see any things on the wire. Ipfix logging doesn't work in flowprobe 
and nat mode for me . my vpp version is stable18.10 

Warm Regards,
-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.

View/Reply Online (#11910): https://lists.fd.io/g/vpp-dev/message/11910
Mute This Topic: https://lists.fd.io/mt/28911869/21656
Group Owner: vpp-dev+ow...@lists.fd.io
Unsubscribe: https://lists.fd.io/g/vpp-dev/unsub  [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-